)]}'
{"templates/inspector_dnsmasq_http.erb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"68ba85bf586792b79ce0dba4cdaff83f8ef12138","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003c% if s[\u0027classless_static_routes\u0027] -%\u003e"},{"line_number":23,"context_line":"\u003c%- @_routes \u003d [] -%\u003e"},{"line_number":24,"context_line":"\u003c%- s[\u0027classless_static_routes\u0027].each do |route| -%\u003e"},{"line_number":25,"context_line":"\u003c%- @_routes \u003c\u003c route[\u0027destination\u0027] + \u0027,\u0027 + route[\u0027nexthop\u0027] -%\u003e"},{"line_number":26,"context_line":"\u003c% end -%\u003e"},{"line_number":27,"context_line":"\u003c% if s[\u0027tag\u0027] -%\u003e"},{"line_number":28,"context_line":"dhcp-option\u003dtag:\u003c%\u003d s[\u0027tag\u0027] -%\u003e,option:classless-static-route,\u003c%\u003d @_routes.join(\u0027,\u0027) -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"5fc1f717_8d192623","line":25,"updated":"2019-03-13 09:40:01.000000000","message":"I\u0027d prefer we do this logic in puppet, not here","commit_id":"c192ee40ac7c9244ef98b70d9f16cf86aad69779"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e9637df8f3db101636a61257536cf9019029ad82","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003c% if s[\u0027classless_static_routes\u0027] -%\u003e"},{"line_number":23,"context_line":"\u003c%- @_routes \u003d [] -%\u003e"},{"line_number":24,"context_line":"\u003c%- s[\u0027classless_static_routes\u0027].each do |route| -%\u003e"},{"line_number":25,"context_line":"\u003c%- @_routes \u003c\u003c route[\u0027destination\u0027] + \u0027,\u0027 + route[\u0027nexthop\u0027] -%\u003e"},{"line_number":26,"context_line":"\u003c% end -%\u003e"},{"line_number":27,"context_line":"\u003c% if s[\u0027tag\u0027] -%\u003e"},{"line_number":28,"context_line":"dhcp-option\u003dtag:\u003c%\u003d s[\u0027tag\u0027] -%\u003e,option:classless-static-route,\u003c%\u003d @_routes.join(\u0027,\u0027) -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"5fc1f717_fe43b26a","line":25,"in_reply_to":"5fc1f717_8d192623","updated":"2019-03-13 12:32:07.000000000","message":"The classless_static_routes are data is packed per subnet in $dnsmasq_ip_subnets array. We currently do not do any processing on $dnsmasq_ip_subnets in puppet, we do it all here sarting at L7 with \u003c% @dnsmasq_ip_subnets.each do |s| -%\u003e.\n\nWith all the puppet limitations, no re-assigning a variable these three lines of code would become quite a complex thing?","commit_id":"c192ee40ac7c9244ef98b70d9f16cf86aad69779"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d94f48b7a5056903ca571b0329aabb86a4cbd6cd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003c% if s[\u0027classless_static_routes\u0027] -%\u003e"},{"line_number":23,"context_line":"\u003c%- @_routes \u003d [] -%\u003e"},{"line_number":24,"context_line":"\u003c%- s[\u0027classless_static_routes\u0027].each do |route| -%\u003e"},{"line_number":25,"context_line":"\u003c%- @_routes \u003c\u003c route[\u0027destination\u0027] + \u0027,\u0027 + route[\u0027nexthop\u0027] -%\u003e"},{"line_number":26,"context_line":"\u003c% end -%\u003e"},{"line_number":27,"context_line":"\u003c% if s[\u0027tag\u0027] -%\u003e"},{"line_number":28,"context_line":"dhcp-option\u003dtag:\u003c%\u003d s[\u0027tag\u0027] -%\u003e,option:classless-static-route,\u003c%\u003d @_routes.join(\u0027,\u0027) -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"5fc1f717_d920504b","line":25,"in_reply_to":"5fc1f717_fe43b26a","updated":"2019-03-13 12:54:38.000000000","message":"Oh yeah. Puppet.","commit_id":"c192ee40ac7c9244ef98b70d9f16cf86aad69779"}],"templates/inspector_dnsmasq_tftp.erb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"68ba85bf586792b79ce0dba4cdaff83f8ef12138","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003c% if s[\u0027classless_static_routes\u0027] -%\u003e"},{"line_number":23,"context_line":"\u003c%- @_routes \u003d [] -%\u003e"},{"line_number":24,"context_line":"\u003c%- s[\u0027classless_static_routes\u0027].each do |route| -%\u003e"},{"line_number":25,"context_line":"\u003c%- @_routes \u003c\u003c route[\u0027destination\u0027] + \u0027,\u0027 + route[\u0027nexthop\u0027] -%\u003e"},{"line_number":26,"context_line":"\u003c% end -%\u003e"},{"line_number":27,"context_line":"\u003c% if s[\u0027tag\u0027] -%\u003e"},{"line_number":28,"context_line":"dhcp-option\u003dtag:\u003c%\u003d s[\u0027tag\u0027] -%\u003e,option:classless-static-route,\u003c%\u003d @_routes.join(\u0027,\u0027) -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"5fc1f717_ad1662f0","line":25,"updated":"2019-03-13 09:40:01.000000000","message":"ditto","commit_id":"c192ee40ac7c9244ef98b70d9f16cf86aad69779"}]}
