)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ce67ceccdd549f999c6d803143d52d36fd4a26fc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"a mechanism for serving it by default."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change makes this possible by setting the puppet parameter"},{"line_number":16,"context_line":"$::ironic::pxe::common::ipxe_name_base to ipxe-snponly."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3a0e85ce6d83001833c829f484baf181a677a5d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_f896a894","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":38},"updated":"2020-04-21 05:13:43.000000000","message":"It will actually be ironic::pxe::ipxe_name_base","commit_id":"f2189f234040c2f3046706ca11c8f5e24eb9f8a7"}],"manifests/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a9e8c094966e7b288de65bacf33d545aa89b2cf","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  })"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  file { \"${tftp_root_real}/undionly.kpxe\":"},{"line_number":175,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":176,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":177,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":178,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_7383db57","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":23},"updated":"2020-04-21 06:42:58.000000000","message":"Can we also replace this by file, so that these 2 file creations are consistent ?","commit_id":"0723e659e5b4814ad4a042c251d2faed273a10fa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"417a489d18de5b24d7962198872358197f2df47f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  })"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  file { \"${tftp_root_real}/undionly.kpxe\":"},{"line_number":175,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":176,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":177,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":178,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_dbb114e4","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":23},"in_reply_to":"1f493fa4_7383db57","updated":"2020-04-21 21:48:01.000000000","message":"Done","commit_id":"0723e659e5b4814ad4a042c251d2faed273a10fa"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e36ad234078db68f194c25c6ddabcc33105df43f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  })"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  file { \"${tftp_root_real}/undionly.kpxe\":"},{"line_number":175,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":176,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":177,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":178,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_8eee3e86","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":23},"in_reply_to":"1f493fa4_7383db57","updated":"2020-04-21 08:45:08.000000000","message":"I think we should copy both ipxe-snponly-${arch}.efi and ipxe-${arch}.efi to the tftp_root and control which one to use with the \u0027[pxe]/uefi_pxe_bootfile_name\u0027 option in ironic.conf?","commit_id":"0723e659e5b4814ad4a042c251d2faed273a10fa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0e405f2b0484302c2faa8eeaa0feded27378e247","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  })"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  file { \"${tftp_root_real}/undionly.kpxe\":"},{"line_number":175,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":176,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":177,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":178,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_bb26c8b6","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":23},"in_reply_to":"1f493fa4_8eee3e86","updated":"2020-04-21 21:16:26.000000000","message":"\u003e I think we should copy both ipxe-snponly-${arch}.efi and\n \u003e ipxe-${arch}.efi to the tftp_root and control which one to use with\n \u003e the \u0027[pxe]/uefi_pxe_bootfile_name\u0027 option in ironic.conf?\n\nThat would work for ironic, but not for ironic-inspector which appears to have no support for special uefi behaviours. The inspector dnsmasq is hardcoded to tftp load \u0027ipxe\u0027, so if we went down this path there would need to be a whole new mechanism to allow different images to load.\n\nI think this would be a good idea in the long term, but right now I\u0027m looking for a solution which can be backported to Queens","commit_id":"0723e659e5b4814ad4a042c251d2faed273a10fa"}]}