)]}'
{"manifests/conductor.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"387b341279d790fbe3a730485b4820dd92b08ff0","unresolved":true,"context_lines":[{"line_number":254,"context_line":"  $rescue_kernel                       \u003d $::os_service_default,"},{"line_number":255,"context_line":"  $rescue_ramdisk                      \u003d $::os_service_default,"},{"line_number":256,"context_line":"  $allow_provisioning_in_maintenance   \u003d $::os_service_default,"},{"line_number":257,"context_line":"  $image_convert_memory_limit          \u003d 2048,"},{"line_number":258,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":259,"context_line":"  $max_time_interval                   \u003d undef,"},{"line_number":260,"context_line":"  $api_url                             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"cb0bf84a_e95d9251","line":257,"range":{"start_line":257,"start_character":41,"end_line":257,"end_character":45},"updated":"2021-01-29 12:17:09.000000000","message":"I think $::os_service_default is better . (And I guess you intended that according to unit test cases? )","commit_id":"4039fb2ece4aa42a83a00fff91ed725c4ab09cb2"}],"releasenotes/notes/enable_memory_limit_configuration-de66152b812dbc94.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"387b341279d790fbe3a730485b4820dd92b08ff0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds ability to set ``image_convert_memory_limit`` parameter"},{"line_number":5,"context_line":"    to influence the ``[disk_utils]image_convert_memory_limit``"},{"line_number":6,"context_line":"    parameter for conductor configuration. This paramter"},{"line_number":7,"context_line":"    is used to control how much memory the ``qemu-img`` utility"},{"line_number":8,"context_line":"    is allowed to consume, and in some cases may need to be"},{"line_number":9,"context_line":"    increased. This value defaults to ``2048`` which is twice"},{"line_number":10,"context_line":"    the default limit, as increased memory pressure may prevent"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"61e15fb8_1b638cbc","line":7,"updated":"2021-01-29 12:17:09.000000000","message":"Since puppet-ironic doesn\u0027t implement the feature but provides an interface to set its parameter, it\u0027s better to avoid mentioning the implementation in detail, IMO.","commit_id":"4039fb2ece4aa42a83a00fff91ed725c4ab09cb2"}],"spec/classes/ironic_conductor_spec.rb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02606d9159d4c636db77500f54972ba14c1a653c","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        is_expected.to contain_ironic_config(\u0027conductor/rescue_kernel\u0027).with_value(p[:rescue_kernel])"},{"line_number":151,"context_line":"        is_expected.to contain_ironic_config(\u0027conductor/rescue_ramdisk\u0027).with_value(p[:rescue_ramdisk])"},{"line_number":152,"context_line":"        is_expected.to contain_ironic_config(\u0027conductor/allow_provisioning_in_maintenance\u0027).with_value(p[:allow_provisioning_in_maintenance])"},{"line_number":153,"context_line":"        is_expected.to contain_ironic_config(\u0027disk_utils/image_convert_memory_limit\u0027).with_value(2048)"},{"line_number":154,"context_line":"      end"},{"line_number":155,"context_line":"    end"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dc3a10d5_f3937f90","line":153,"updated":"2020-12-10 13:41:57.000000000","message":"nit: use p[:image_convert_memory_limit]","commit_id":"39e3b14fcc4623932db76553eff4f2af19addc29"}]}