)]}'
{"manifests/drivers/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5451a671b452a1225cfefd81b2386c907199e77","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  # Configure ironic.conf"},{"line_number":129,"context_line":"  ironic_config {"},{"line_number":130,"context_line":"    \u0027pxe/ipxe_enabled\u0027: value              \u003d\u003e $ipxe_enabled;"},{"line_number":131,"context_line":"    \u0027pxe/pxe_append_params\u0027: value         \u003d\u003e $pxe_append_params;"},{"line_number":132,"context_line":"    \u0027pxe/pxe_bootfile_name\u0027: value         \u003d\u003e $pxe_bootfile_name_real;"},{"line_number":133,"context_line":"    \u0027pxe/pxe_config_template\u0027: value       \u003d\u003e $pxe_config_template_real;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6470b99a_3d095512","side":"PARENT","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":60},"updated":"2021-05-05 15:06:04.000000000","message":"How about adding the following logic to purge the parameter.\n\nironic_config {\n  \u0027pxe/ipxe_enabled\u0027: ensure \u003d\u003e absent;\n}\n\nThis helps us to clean up the parameter during update.\nPlease add a note to remove that cleanup implementation during Y release.","commit_id":"ada04652a7c96212747873ea51373f270f45f469"}],"spec/classes/ironic_drivers_pxe_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5451a671b452a1225cfefd81b2386c907199e77","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      it \u0027detects correct boot parameters\u0027 do"},{"line_number":64,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/pxe_append_params\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/pxe_bootfile_name\u0027).with_value(\u0027undionly.kpxe\u0027)"},{"line_number":66,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/pxe_config_template\u0027).with_value(\u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":67,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/tftp_server\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":68,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/tftp_root\u0027).with_value(p[:tftp_root])"},{"line_number":69,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/images_path\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"01909d71_feb5b1a9","side":"PARENT","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":133},"updated":"2021-05-05 15:06:04.000000000","message":"I think this test case is still useful to validate these options.","commit_id":"ada04652a7c96212747873ea51373f270f45f469"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d237613b7e81a66acea39b237bd4c67d4d844940","unresolved":true,"context_lines":[{"line_number":53,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/ipxe_enabled\u0027).with_value(false)"},{"line_number":54,"context_line":"    end"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    context \u0027when overriding only ipxe_enabled\u0027 do"},{"line_number":57,"context_line":"      before do"},{"line_number":58,"context_line":"        params.merge!("},{"line_number":59,"context_line":"          :ipxe_enabled             \u003d\u003e true,"},{"line_number":60,"context_line":"        )"},{"line_number":61,"context_line":"      end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      it \u0027detects correct boot parameters\u0027 do"},{"line_number":64,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/pxe_append_params\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"e6134e82_66f92911","side":"PARENT","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":9},"updated":"2021-05-06 11:57:34.000000000","message":"We still need this.","commit_id":"ada04652a7c96212747873ea51373f270f45f469"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e10f326745f34861fc51d2657b0b66c65221f6cf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/ipxe_enabled\u0027).with_value(false)"},{"line_number":54,"context_line":"    end"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    context \u0027when overriding only ipxe_enabled\u0027 do"},{"line_number":57,"context_line":"      before do"},{"line_number":58,"context_line":"        params.merge!("},{"line_number":59,"context_line":"          :ipxe_enabled             \u003d\u003e true,"},{"line_number":60,"context_line":"        )"},{"line_number":61,"context_line":"      end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      it \u0027detects correct boot parameters\u0027 do"},{"line_number":64,"context_line":"        is_expected.to contain_ironic_config(\u0027pxe/pxe_append_params\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"0a122383_92129484","side":"PARENT","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":9},"in_reply_to":"e6134e82_66f92911","updated":"2021-05-10 15:02:30.000000000","message":"Done","commit_id":"ada04652a7c96212747873ea51373f270f45f469"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d237613b7e81a66acea39b237bd4c67d4d844940","unresolved":true,"context_lines":[{"line_number":101,"context_line":"          :uefi_pxe_bootfile_name    \u003d\u003e \u0027bootx64.efi\u0027,"},{"line_number":102,"context_line":"          :uefi_pxe_config_template  \u003d\u003e \u0027foo-uefi\u0027,"},{"line_number":103,"context_line":"          :ipxe_timeout              \u003d\u003e \u002760\u0027,"},{"line_number":104,"context_line":"          :ipxe_enabled              \u003d\u003e true,"},{"line_number":105,"context_line":"          :pxe_bootfile_name         \u003d\u003e \u0027bootx64\u0027,"},{"line_number":106,"context_line":"          :boot_retry_timeout        \u003d\u003e 600,"},{"line_number":107,"context_line":"          :boot_retry_check_interval \u003d\u003e 120,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"d8206ef4_1d7e7ac5","side":"PARENT","line":104,"range":{"start_line":104,"start_character":10,"end_line":104,"end_character":45},"updated":"2021-05-06 11:57:34.000000000","message":"I think we should keep this to ensure that ipxe_enabled \u003d\u003e true doesn\u0027t conflict with the other settings","commit_id":"ada04652a7c96212747873ea51373f270f45f469"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e10f326745f34861fc51d2657b0b66c65221f6cf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"          :uefi_pxe_bootfile_name    \u003d\u003e \u0027bootx64.efi\u0027,"},{"line_number":102,"context_line":"          :uefi_pxe_config_template  \u003d\u003e \u0027foo-uefi\u0027,"},{"line_number":103,"context_line":"          :ipxe_timeout              \u003d\u003e \u002760\u0027,"},{"line_number":104,"context_line":"          :ipxe_enabled              \u003d\u003e true,"},{"line_number":105,"context_line":"          :pxe_bootfile_name         \u003d\u003e \u0027bootx64\u0027,"},{"line_number":106,"context_line":"          :boot_retry_timeout        \u003d\u003e 600,"},{"line_number":107,"context_line":"          :boot_retry_check_interval \u003d\u003e 120,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"50fbb802_73b5836e","side":"PARENT","line":104,"range":{"start_line":104,"start_character":10,"end_line":104,"end_character":45},"in_reply_to":"d8206ef4_1d7e7ac5","updated":"2021-05-10 15:02:30.000000000","message":"Done","commit_id":"ada04652a7c96212747873ea51373f270f45f469"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d237613b7e81a66acea39b237bd4c67d4d844940","unresolved":true,"context_lines":[{"line_number":50,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/instance_master_path\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":51,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_bootfile_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":52,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_config_template\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    it \u0027detects correct boot parameters\u0027 do"},{"line_number":56,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/pxe_append_params\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"87eaead7_3061952b","line":53,"updated":"2021-05-06 11:57:34.000000000","message":"How about adding a test case like;\n\nis_expected.to contain_ironic_config(\u0027pxe/ipxe_enabled\u0027).with_ensure(\u0027absent\u0027)","commit_id":"67c987a5f4c47c911eddc3a5a42576bde35b7f38"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e10f326745f34861fc51d2657b0b66c65221f6cf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/instance_master_path\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":51,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_bootfile_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":52,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_config_template\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    it \u0027detects correct boot parameters\u0027 do"},{"line_number":56,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/pxe_append_params\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"b39e610a_edf23914","line":53,"in_reply_to":"87eaead7_3061952b","updated":"2021-05-10 15:02:30.000000000","message":"Done","commit_id":"67c987a5f4c47c911eddc3a5a42576bde35b7f38"}]}