)]}'
{"manifests/drivers/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"42799dc1b097501eff04b5d33507394743577cf7","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#   (optional) The IP version that will be used for PXE booting."},{"line_number":106,"context_line":"#   Defaults to $::os_service_default."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"class ironic::drivers::pxe ("},{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7442cb2a_ea490a96","line":108,"updated":"2021-06-23 23:51:39.000000000","message":"Please do not remove the parameter but deprecate it.　The parameter should be left for one cycle to keep interface compatibility.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"672fb5685a7b68d87cb948f8815d0b0ba797c15a","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#   (optional) The IP version that will be used for PXE booting."},{"line_number":106,"context_line":"#   Defaults to $::os_service_default."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"class ironic::drivers::pxe ("},{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"df958b89_2475c0b7","line":108,"in_reply_to":"7442cb2a_ea490a96","updated":"2021-06-24 15:38:00.000000000","message":"Do you mean keep the parameter, but have it do nothing?\n\nI ask because https://review.opendev.org/c/openstack/ironic/+/698352 landed quite some time ago, so the parameter has no effect in ironic itself. And to have it actually still impact the behavior of the manifest would actually be harmful for anyone using the manifest as it would result in an inoperable configuration if they tried to enable it.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e7569619d1f6429b15f37614cd1e334013ea6494","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#   (optional) The IP version that will be used for PXE booting."},{"line_number":106,"context_line":"#   Defaults to $::os_service_default."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"class ironic::drivers::pxe ("},{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"cd824736_e7546e5e","line":108,"in_reply_to":"aa2f4115_e97a4c32","updated":"2021-06-24 16:44:01.000000000","message":"For parameter deprecation please check https://review.opendev.org/c/openstack/puppet-nova/+/779888 .\nBecause this manifest doesn\u0027t have deprecated parameters now please add \"DEPRECATED PARAMETERS\" line in parameter description and parameter definition.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e099dcfaa6c214b9e4dd86d0a5b1fcc2585da7e9","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#   (optional) The IP version that will be used for PXE booting."},{"line_number":106,"context_line":"#   Defaults to $::os_service_default."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"class ironic::drivers::pxe ("},{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"a4c4aaab_2c9c4774","line":108,"in_reply_to":"cd824736_e7546e5e","updated":"2021-06-24 17:04:32.000000000","message":"Much appreciated, thanks!","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ca7ee15df1e3c02c4a1fadb232b8aaf5da03c2cf","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#   (optional) The IP version that will be used for PXE booting."},{"line_number":106,"context_line":"#   Defaults to $::os_service_default."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"class ironic::drivers::pxe ("},{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f2520781_a49e842b","line":108,"in_reply_to":"df958b89_2475c0b7","updated":"2021-06-24 15:53:24.000000000","message":"Yes. That is my expectation. Keep the parameter but deprecate it. Change default to undef and if the parameter is not undef then show warning.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"520a1e30d1577a13063f17971c11fd0e6c8f817d","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#   (optional) The IP version that will be used for PXE booting."},{"line_number":106,"context_line":"#   Defaults to $::os_service_default."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"class ironic::drivers::pxe ("},{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"aa2f4115_e97a4c32","line":108,"in_reply_to":"f2520781_a49e842b","updated":"2021-06-24 15:59:10.000000000","message":"Do you have any pointers to that by chance. I  last wrote puppet manifests like a decade ago.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee27f21a1e19a2ddce8485065d34250b7a421a05","unresolved":true,"context_lines":[{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"},{"line_number":112,"context_line":"  $ipxe_bootfile_name        \u003d undef,"},{"line_number":113,"context_line":"  $ipxe_config_template      \u003d undef,"},{"line_number":114,"context_line":"  $tftp_server               \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $tftp_root                 \u003d \u0027/tftpboot\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e47c0212_b1c58ec0","line":112,"range":{"start_line":112,"start_character":31,"end_line":112,"end_character":36},"updated":"2021-06-24 14:39:55.000000000","message":"Please use $::os_service_default instead. Undef results in a empty value set.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ca7ee15df1e3c02c4a1fadb232b8aaf5da03c2cf","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"},{"line_number":112,"context_line":"  $ipxe_bootfile_name        \u003d undef,"},{"line_number":113,"context_line":"  $ipxe_config_template      \u003d undef,"},{"line_number":114,"context_line":"  $tftp_server               \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $tftp_root                 \u003d \u0027/tftpboot\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fd0ccab8_c8814ec1","line":112,"range":{"start_line":112,"start_character":31,"end_line":112,"end_character":36},"in_reply_to":"e47c0212_b1c58ec0","updated":"2021-06-24 15:53:24.000000000","message":"Sorry please ignore this. This should be undef to work with the pick later.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eee6203db5fbdb4ec72eda94b38795ce4d2d5e48","unresolved":true,"context_lines":[{"line_number":109,"context_line":"  $pxe_append_params         \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $pxe_bootfile_name         \u003d undef,"},{"line_number":111,"context_line":"  $pxe_config_template       \u003d undef,"},{"line_number":112,"context_line":"  $ipxe_bootfile_name        \u003d undef,"},{"line_number":113,"context_line":"  $ipxe_config_template      \u003d undef,"},{"line_number":114,"context_line":"  $tftp_server               \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $tftp_root                 \u003d \u0027/tftpboot\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"206b040c_4643853a","line":112,"range":{"start_line":112,"start_character":31,"end_line":112,"end_character":36},"in_reply_to":"e47c0212_b1c58ec0","updated":"2021-06-24 15:56:36.000000000","message":"ack, the service default is correct so we don\u0027t need to override it anywhere.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee27f21a1e19a2ddce8485065d34250b7a421a05","unresolved":true,"context_lines":[{"line_number":130,"context_line":"  include ironic::pxe::common"},{"line_number":131,"context_line":"  $tftp_root_real    \u003d pick($::ironic::pxe::common::tftp_root, $tftp_root)"},{"line_number":132,"context_line":"  $ipxe_timeout_real \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e0aa3142_cc06b407","line":133,"updated":"2021-06-24 14:39:55.000000000","message":"off-topic. I don\u0027t see any benefit to use pick instead of defining these defaults. Maybe we can fix that point separately.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eee6203db5fbdb4ec72eda94b38795ce4d2d5e48","unresolved":true,"context_lines":[{"line_number":131,"context_line":"  $tftp_root_real    \u003d pick($::ironic::pxe::common::tftp_root, $tftp_root)"},{"line_number":132,"context_line":"  $ipxe_timeout_real \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"217a81ab_0a106bb6","line":134,"updated":"2021-06-24 15:56:36.000000000","message":"this is also the default, so not needed.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e7569619d1f6429b15f37614cd1e334013ea6494","unresolved":true,"context_lines":[{"line_number":131,"context_line":"  $tftp_root_real    \u003d pick($::ironic::pxe::common::tftp_root, $tftp_root)"},{"line_number":132,"context_line":"  $ipxe_timeout_real \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"68711f45_c19c9d91","line":134,"in_reply_to":"217a81ab_0a106bb6","updated":"2021-06-24 16:44:01.000000000","message":"Ah, thanks for checking. My suggestion is to fix this in new parameters and now and leave existing parameters. and consider fixing the existing items later.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"808cb262faaf80f79d93b45e3a0ce635dd2f30b7","unresolved":true,"context_lines":[{"line_number":131,"context_line":"  $tftp_root_real    \u003d pick($::ironic::pxe::common::tftp_root, $tftp_root)"},{"line_number":132,"context_line":"  $ipxe_timeout_real \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"c4c9165e_1e356930","line":134,"in_reply_to":"4f531746_2b64d732","updated":"2021-06-24 17:13:32.000000000","message":"It seems my brain has stopped working in midnight... I now understand the usage of undef was intentional to support ipxe_enabled, which is deprecated by this patch so now I agree doing that cleanup about defaults in this. Anyway once you update the patch with cleanup I\u0027ll have another look.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e099dcfaa6c214b9e4dd86d0a5b1fcc2585da7e9","unresolved":true,"context_lines":[{"line_number":131,"context_line":"  $tftp_root_real    \u003d pick($::ironic::pxe::common::tftp_root, $tftp_root)"},{"line_number":132,"context_line":"  $ipxe_timeout_real \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"4f531746_2b64d732","line":134,"in_reply_to":"68711f45_c19c9d91","updated":"2021-06-24 17:04:32.000000000","message":"I\u0027m basically operating negative time capacity, so I\u0027m going ahead and just doing a general cleanup since this has diverge significantly and I\u0027ll note everything in the release note as it all kind of cascades out of ipxe_enabled going away.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eee6203db5fbdb4ec72eda94b38795ce4d2d5e48","unresolved":true,"context_lines":[{"line_number":132,"context_line":"  $ipxe_timeout_real \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"238a517e_a44e0371","line":135,"updated":"2021-06-24 15:56:36.000000000","message":"So it turns out this is the default, might as well remove this as well and just allow the default to be used and if someone has an override..","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eee6203db5fbdb4ec72eda94b38795ce4d2d5e48","unresolved":true,"context_lines":[{"line_number":133,"context_line":"  $ipxe_bootfile_name_real \u003d pick($ipxe_bootfile_name, \u0027undionly.kpxe\u0027)"},{"line_number":134,"context_line":"  $ipxe_config_template_real \u003d pick($ipxe_config_template, \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027)"},{"line_number":135,"context_line":"  $pxe_bootfile_name_real \u003d pick($pxe_bootfile_name, \u0027pxelinux.0\u0027)"},{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# TODO set configuration"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"cee7fe57_9de44de7","line":136,"updated":"2021-06-24 15:56:36.000000000","message":"this too, is the default, so not needed.\n\nI guess it was only present because of ipxe_enabled which has no effect anymore and keeping that behavior would do the wrong things.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee27f21a1e19a2ddce8485065d34250b7a421a05","unresolved":true,"context_lines":[{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# TODO set configuration"},{"line_number":140,"context_line":"  # Configure ironic.conf"},{"line_number":141,"context_line":"  ironic_config {"},{"line_number":142,"context_line":"    \u0027pxe/pxe_append_params\u0027: value         \u003d\u003e $pxe_append_params;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6bbf9b1b_337b5481","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":24},"updated":"2021-06-24 14:39:55.000000000","message":"Can we remove this TODO now ?","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"672fb5685a7b68d87cb948f8815d0b0ba797c15a","unresolved":true,"context_lines":[{"line_number":136,"context_line":"  $pxe_config_template_real \u003d pick($pxe_config_template, \u0027$pybasedir/drivers/modules/pxe_config.template\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# TODO set configuration"},{"line_number":140,"context_line":"  # Configure ironic.conf"},{"line_number":141,"context_line":"  ironic_config {"},{"line_number":142,"context_line":"    \u0027pxe/pxe_append_params\u0027: value         \u003d\u003e $pxe_append_params;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"aa3370a9_3301e51c","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":24},"in_reply_to":"6bbf9b1b_337b5481","updated":"2021-06-24 15:38:00.000000000","message":"Oh yes, meant to remove it when I was adding the other defaults.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"}],"manifests/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"42799dc1b097501eff04b5d33507394743577cf7","unresolved":true,"context_lines":[{"line_number":190,"context_line":"    source  \u003d\u003e \"${::ironic::params::ipxe_rom_dir}/${ipxe_name_base}${arch}.efi\","},{"line_number":191,"context_line":"    backup  \u003d\u003e false,"},{"line_number":192,"context_line":"    require \u003d\u003e Anchor[\u0027ironic-inspector::install::end\u0027],"},{"line_number":193,"context_line":"  }"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  include apache"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e06e4ed9_16e27990","line":193,"range":{"start_line":193,"start_character":2,"end_line":193,"end_character":3},"updated":"2021-06-23 23:51:39.000000000","message":"(I\u0027m still learning the context of this change, but) Can we add a cleanup to remove ipxe.efi if we need this switch ?","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"672fb5685a7b68d87cb948f8815d0b0ba797c15a","unresolved":true,"context_lines":[{"line_number":190,"context_line":"    source  \u003d\u003e \"${::ironic::params::ipxe_rom_dir}/${ipxe_name_base}${arch}.efi\","},{"line_number":191,"context_line":"    backup  \u003d\u003e false,"},{"line_number":192,"context_line":"    require \u003d\u003e Anchor[\u0027ironic-inspector::install::end\u0027],"},{"line_number":193,"context_line":"  }"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  include apache"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8c00b27d_4b3cbc67","line":193,"range":{"start_line":193,"start_character":2,"end_line":193,"end_character":3},"in_reply_to":"e06e4ed9_16e27990","updated":"2021-06-24 15:38:00.000000000","message":"Some operators *do* end up needing ipxe.efi, but it is exceedingly rare where as what is really needed is snponly.efi. I guess where I\u0027m going with this, while removal may be tidy, it may result in sudden unintended consequences if the operator has explicitly had to place it themselves, depending on how the manifest is used.","commit_id":"222c137a714584f9085f33bcabefebd88d0986a7"}],"releasenotes/notes/pxe-cleanup-692c78cad322893d.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b000e4ed1f5777f4d32a671c243156674ae1e8c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    ``[pxe]uefi_ipxe_bootfile_name`` to be explicitly set using the"},{"line_number":10,"context_line":"    ``ironic::drivers::pxe::uefi_ipxe_bootfile_name`` manifest parameter,"},{"line_number":11,"context_line":"    however this value is defaulted to ``snponly.efi`` which is anticipated"},{"line_number":12,"context_line":"    to become the default in Ironic sometime in the Xena development cycle."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The Ironic project has in elevated support for ``ipxe`` to a top level"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a625fa6e_7be4874a","line":12,"updated":"2021-07-01 13:45:45.000000000","message":"Mmmm? :) I don\u0027t disagree, just haven\u0027t heard about it.","commit_id":"3864e15998b5b1eec7d2b1b4911add9bb899fdb8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"69893cf927cedc1e41e507ff9b7dcfbf0dfc488d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    ``[pxe]uefi_ipxe_bootfile_name`` to be explicitly set using the"},{"line_number":10,"context_line":"    ``ironic::drivers::pxe::uefi_ipxe_bootfile_name`` manifest parameter,"},{"line_number":11,"context_line":"    however this value is defaulted to ``snponly.efi`` which is anticipated"},{"line_number":12,"context_line":"    to become the default in Ironic sometime in the Xena development cycle."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The Ironic project has in elevated support for ``ipxe`` to a top level"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5101ef1f_0d72aed6","line":12,"in_reply_to":"a625fa6e_7be4874a","updated":"2021-07-01 14:01:45.000000000","message":"It already merged. Ultimately the old default setting we had was contrary to what operators had to place on disk to make it work because ipxe.efi doesn\u0027t have snp networking nor does it really carry the same drivers as undionly.kpxe, and even then those drivers wouldn\u0027t work in uefi mode anyway. Ultimately it meant mean we\u0027re in conflict and complicating operator\u0027s lives.","commit_id":"3864e15998b5b1eec7d2b1b4911add9bb899fdb8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b000e4ed1f5777f4d32a671c243156674ae1e8c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    to become the default in Ironic sometime in the Xena development cycle."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The Ironic project has in elevated support for ``ipxe`` to a top level"},{"line_number":16,"context_line":"    node boot_interface, and removed support for it\u0027s ``[pxe]ipxe_enabled``"},{"line_number":17,"context_line":"    option as this is settable per node. Removal of this option has allowed"},{"line_number":18,"context_line":"    for the manifest to be cleaned up."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3713e4d5_b071260d","line":15,"updated":"2021-07-01 13:45:45.000000000","message":"nit: s/in // ?","commit_id":"3864e15998b5b1eec7d2b1b4911add9bb899fdb8"}]}