)]}'
{"manifests/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a3482d6d1935a51ca4ceff9b36871f474a7e5bb","unresolved":true,"context_lines":[{"line_number":66,"context_line":"  $syslinux_files \u003d $::ironic::params::syslinux_files,"},{"line_number":67,"context_line":"  $tftp_bind_host \u003d undef,"},{"line_number":68,"context_line":"  $enable_ppc64le \u003d false,"},{"line_number":69,"context_line":"  $ipxe_name_base \u003d \u0027ipxe-snponly\u0027,"},{"line_number":70,"context_line":") inherits ::ironic::params {"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  include ironic::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a21ea21_86af3b09","line":69,"range":{"start_line":69,"start_character":21,"end_line":69,"end_character":33},"updated":"2021-07-22 15:56:24.000000000","message":"We should not change this in Wallaby.","commit_id":"e7afd30d31947d320b13ba231f11f2cefcf7d397"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09e6c88959239cb3f7556efa631ba40b76fbb848","unresolved":true,"context_lines":[{"line_number":73,"context_line":"  $tftp_bind_host          \u003d undef,"},{"line_number":74,"context_line":"  $enable_ppc64le          \u003d false,"},{"line_number":75,"context_line":"  $ipxe_name_base          \u003d \u0027ipxe\u0027,"},{"line_number":76,"context_line":"  $uefi_ipxe_bootfile_name \u003d \u0027ipxe.efi\u0027"},{"line_number":77,"context_line":") inherits ::ironic::params {"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ironic::deps"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"e3324828_af059cbe","line":76,"updated":"2021-07-27 21:34:48.000000000","message":"Truthfully, this setting to ipxe.efi makes me uncomfortable, but it being something that can be overriden at least provide an escape hatch for when it doesn\u0027t work.","commit_id":"7cc374a063c84d56a5d971776e46a6157636f552"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f3558f10fbe6ba111dab8c526f7c099a92405901","unresolved":true,"context_lines":[{"line_number":73,"context_line":"  $tftp_bind_host          \u003d undef,"},{"line_number":74,"context_line":"  $enable_ppc64le          \u003d false,"},{"line_number":75,"context_line":"  $ipxe_name_base          \u003d \u0027ipxe\u0027,"},{"line_number":76,"context_line":"  $uefi_ipxe_bootfile_name \u003d \u0027ipxe.efi\u0027"},{"line_number":77,"context_line":") inherits ::ironic::params {"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ironic::deps"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"20551084_25abd14c","line":76,"in_reply_to":"56c91bc7_fb7d2024","updated":"2021-07-29 17:15:49.000000000","message":"Yeah, we only changed the default because we found almost everyone was overriding it anyway. It should be fine in the grand scheme of things and should be able to be accounted for as updated patches make it through build pipelines.","commit_id":"7cc374a063c84d56a5d971776e46a6157636f552"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e4d59879fbad9481d036e2bfc85bf395568cf278","unresolved":true,"context_lines":[{"line_number":73,"context_line":"  $tftp_bind_host          \u003d undef,"},{"line_number":74,"context_line":"  $enable_ppc64le          \u003d false,"},{"line_number":75,"context_line":"  $ipxe_name_base          \u003d \u0027ipxe\u0027,"},{"line_number":76,"context_line":"  $uefi_ipxe_bootfile_name \u003d \u0027ipxe.efi\u0027"},{"line_number":77,"context_line":") inherits ::ironic::params {"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ironic::deps"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"56c91bc7_fb7d2024","line":76,"in_reply_to":"e3324828_af059cbe","updated":"2021-07-27 22:56:11.000000000","message":"We can override this by setting puppet parameters, hieradata and etc.\n\nAs I documented in the commit message, ironic still points to ipxe.efi by default in wallaby and older. I understand your concern but from perspective of configuration management tool, IMO we should not override default in services in general.","commit_id":"7cc374a063c84d56a5d971776e46a6157636f552"}]}