)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbe73e6d105db1e5c0bb96b72ffabed1affc032b","unresolved":true,"context_lines":[{"line_number":374,"context_line":"      require \u003d\u003e Anchor[\u0027ironic-inspector::config::begin\u0027],"},{"line_number":375,"context_line":"    }"},{"line_number":376,"context_line":"  }"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  # NOTE(TheJulia): No exclusively required for http preferred cases"},{"line_number":379,"context_line":"  # but this doesn\u0027t hurt anything to have present."},{"line_number":380,"context_line":"  file { \"${tftp_root_real}/pxelinux.cfg/default\":"},{"line_number":381,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":382,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":383,"context_line":"    owner   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":384,"context_line":"    group   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":385,"context_line":"    content \u003d\u003e template(\u0027ironic/inspector_pxelinux_cfg.erb\u0027),"},{"line_number":386,"context_line":"    require \u003d\u003e Anchor[\u0027ironic-inspector::config::begin\u0027],"},{"line_number":387,"context_line":"  }"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"  if $enable_ppc64le {"},{"line_number":390,"context_line":"    file { \"${tftp_root_real}/ppc64le/default\":"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3062da50_5cf6cf25","line":387,"range":{"start_line":377,"start_character":0,"end_line":387,"end_character":3},"updated":"2021-08-05 13:43:42.000000000","message":"I\u0027d prefer keeping the current implementation and enabling this only when pxe_transfer_protocol is tftp.\nThis minimizes change during minor update, and is a better approach for backport candidate IMO.","commit_id":"555dc695a1ac143bae5649c49364ca71f40897f0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bda8c3dec069c71c1ff529cdf172e75ab069fbab","unresolved":true,"context_lines":[{"line_number":374,"context_line":"      require \u003d\u003e Anchor[\u0027ironic-inspector::config::begin\u0027],"},{"line_number":375,"context_line":"    }"},{"line_number":376,"context_line":"  }"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  # NOTE(TheJulia): No exclusively required for http preferred cases"},{"line_number":379,"context_line":"  # but this doesn\u0027t hurt anything to have present."},{"line_number":380,"context_line":"  file { \"${tftp_root_real}/pxelinux.cfg/default\":"},{"line_number":381,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":382,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":383,"context_line":"    owner   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":384,"context_line":"    group   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":385,"context_line":"    content \u003d\u003e template(\u0027ironic/inspector_pxelinux_cfg.erb\u0027),"},{"line_number":386,"context_line":"    require \u003d\u003e Anchor[\u0027ironic-inspector::config::begin\u0027],"},{"line_number":387,"context_line":"  }"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"  if $enable_ppc64le {"},{"line_number":390,"context_line":"    file { \"${tftp_root_real}/ppc64le/default\":"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"18a873d7_62adfa06","line":387,"range":{"start_line":377,"start_character":0,"end_line":387,"end_character":3},"in_reply_to":"3062da50_5cf6cf25","updated":"2021-08-05 14:32:22.000000000","message":"For inspection, this is likely fine.\n\nThe key delineation, and likely where changing this exposes a bug is the tftproot is shared and without a default file present we could have instances where deploys may fail if someone sets the boot interface to pxe and has to chain load through syslinux. Ultimately, what is set *is* just a preference, and the system admin can state \"I want pxe\" which uses tftp. or \"I want ipxe\" which prefers http. Ultimately not placing it is just techncial debt and additional cases where bugs may be exposed.","commit_id":"555dc695a1ac143bae5649c49364ca71f40897f0"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbe73e6d105db1e5c0bb96b72ffabed1affc032b","unresolved":true,"context_lines":[{"line_number":296,"context_line":"      end"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"      it \u0027should contain file /tftpboot/pxelinux.cfg/default\u0027 do"},{"line_number":299,"context_line":"        is_expected.to contain_file(\u0027/tftpboot/pxelinux.cfg/default\u0027).with("},{"line_number":300,"context_line":"          \u0027owner\u0027   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":301,"context_line":"          \u0027group\u0027   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":302,"context_line":"          \u0027seltype\u0027 \u003d\u003e \u0027tftpdir_t\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3ff58573_4a8ea33c","line":299,"range":{"start_line":299,"start_character":37,"end_line":299,"end_character":67},"updated":"2021-08-05 13:43:42.000000000","message":"tftp_root is overridden in this test case (see L228) and that is why this is failing now.","commit_id":"555dc695a1ac143bae5649c49364ca71f40897f0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bda8c3dec069c71c1ff529cdf172e75ab069fbab","unresolved":true,"context_lines":[{"line_number":296,"context_line":"      end"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"      it \u0027should contain file /tftpboot/pxelinux.cfg/default\u0027 do"},{"line_number":299,"context_line":"        is_expected.to contain_file(\u0027/tftpboot/pxelinux.cfg/default\u0027).with("},{"line_number":300,"context_line":"          \u0027owner\u0027   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":301,"context_line":"          \u0027group\u0027   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":302,"context_line":"          \u0027seltype\u0027 \u003d\u003e \u0027tftpdir_t\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"daae960b_136727f6","line":299,"range":{"start_line":299,"start_character":37,"end_line":299,"end_character":67},"in_reply_to":"3ff58573_4a8ea33c","updated":"2021-08-05 14:32:22.000000000","message":"Ahh, didn\u0027t catch that. Thanks!","commit_id":"555dc695a1ac143bae5649c49364ca71f40897f0"}]}