)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cc808f06a0bd02a389f2b0ab391ebbe21c029da0","unresolved":true,"context_lines":[{"line_number":15,"context_line":"allow disabling sequential addressing to improve"},{"line_number":16,"context_line":"interoperability with DHCPv6 clients in UEFI firmware."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1941908"},{"line_number":19,"context_line":"Change-Id: Iad32434790a1744249b284937c6b67e9b58a235f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9062b336_84f66979","line":18,"updated":"2021-08-27 17:04:06.000000000","message":"should be Closes-Bug","commit_id":"751ba404b5393bd4a275a96f6dcf9ce9f2de650f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"76a98cbffdc046d8afadf759d235bb2113f80dd8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"allow disabling sequential addressing to improve"},{"line_number":16,"context_line":"interoperability with DHCPv6 clients in UEFI firmware."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1941908"},{"line_number":19,"context_line":"Change-Id: Iad32434790a1744249b284937c6b67e9b58a235f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"50bdcdb6_da3362bd","line":18,"in_reply_to":"9062b336_84f66979","updated":"2021-08-27 17:58:29.000000000","message":"Done","commit_id":"751ba404b5393bd4a275a96f6dcf9ce9f2de650f"}],"manifests/inspector.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cc808f06a0bd02a389f2b0ab391ebbe21c029da0","unresolved":true,"context_lines":[{"line_number":176,"context_line":"#   Example: {\u002710.10.10.0/24\u0027 \u003d\u003e \u0027physnet_a\u0027, \u00272001:db8::/64\u0027 \u003d\u003e \u0027physnet_b\u0027}"},{"line_number":177,"context_line":"#   Defaults to {}"},{"line_number":178,"context_line":"#"},{"line_number":179,"context_line":"# [*dnsmasq_dhcp_sequential_ip*]"},{"line_number":180,"context_line":"#   (optional) When true enable the \u0027dhcp-sequential-ip\u0027 option for dnsmasq."},{"line_number":181,"context_line":"#   Defaults to true"},{"line_number":182,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0abe8c1b_f9a8b5d1","line":179,"updated":"2021-08-27 17:04:06.000000000","message":"nit: Can we add this parameter just after dnsmasq_dhcp_hostsdir to put dnsmasq parameters in one place as possible?","commit_id":"751ba404b5393bd4a275a96f6dcf9ce9f2de650f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"76a98cbffdc046d8afadf759d235bb2113f80dd8","unresolved":false,"context_lines":[{"line_number":176,"context_line":"#   Example: {\u002710.10.10.0/24\u0027 \u003d\u003e \u0027physnet_a\u0027, \u00272001:db8::/64\u0027 \u003d\u003e \u0027physnet_b\u0027}"},{"line_number":177,"context_line":"#   Defaults to {}"},{"line_number":178,"context_line":"#"},{"line_number":179,"context_line":"# [*dnsmasq_dhcp_sequential_ip*]"},{"line_number":180,"context_line":"#   (optional) When true enable the \u0027dhcp-sequential-ip\u0027 option for dnsmasq."},{"line_number":181,"context_line":"#   Defaults to true"},{"line_number":182,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"447a5aeb_6438c17f","line":179,"in_reply_to":"0abe8c1b_f9a8b5d1","updated":"2021-08-27 17:58:29.000000000","message":"Done\n\nI also moved it in the class header below.","commit_id":"751ba404b5393bd4a275a96f6dcf9ce9f2de650f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4caff9132db57c263202f2546cb94dcc1e371892","unresolved":true,"context_lines":[{"line_number":104,"context_line":"#   filter."},{"line_number":105,"context_line":"#   Defaults to undef"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*dnsmasq_dhcp_sequential_ip*]"},{"line_number":108,"context_line":"#   (optional) When true enable the \u0027dhcp-sequential-ip\u0027 option for dnsmasq."},{"line_number":109,"context_line":"#   Defaults to true"},{"line_number":110,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"de77e864_6fb03a01","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":30},"updated":"2021-08-27 23:53:30.000000000","message":"This parameter is used before \"dnsmasq_dhcp_hostsdir\" in current erb templates so it\u0027s better we follow that order here.\nSorry I missed this when I made my previous comment.","commit_id":"124504d8d57dce8019969e0da7b3224735b5eddb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6e5ff44d71846231a015d2cc3f2563295df39a7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#   filter."},{"line_number":105,"context_line":"#   Defaults to undef"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*dnsmasq_dhcp_sequential_ip*]"},{"line_number":108,"context_line":"#   (optional) When true enable the \u0027dhcp-sequential-ip\u0027 option for dnsmasq."},{"line_number":109,"context_line":"#   Defaults to true"},{"line_number":110,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"e68ced42_bdfe9309","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":30},"in_reply_to":"de77e864_6fb03a01","updated":"2021-08-27 23:55:11.000000000","message":"Done","commit_id":"124504d8d57dce8019969e0da7b3224735b5eddb"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9d367077ca57e19abed27999c85d68d415391caf","unresolved":true,"context_lines":[{"line_number":194,"context_line":"        /dhcp-option\u003dtag:subnet3,option:router,2001:4888:a03:313a:c0:fe0:0:c000/"},{"line_number":195,"context_line":"      )"},{"line_number":196,"context_line":"      is_expected.to contain_file(\u0027/etc/ironic-inspector/dnsmasq.conf\u0027).with_content("},{"line_number":197,"context_line":"            /dhcp-sequential-ip/"},{"line_number":198,"context_line":"      )"},{"line_number":199,"context_line":"    end"},{"line_number":200,"context_line":"    it \u0027should contain file /tftpboot/pxelinux.cfg/default\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"08443c58_ce7698dc","line":197,"updated":"2021-08-27 17:07:20.000000000","message":"this line is over indented.","commit_id":"751ba404b5393bd4a275a96f6dcf9ce9f2de650f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"76a98cbffdc046d8afadf759d235bb2113f80dd8","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        /dhcp-option\u003dtag:subnet3,option:router,2001:4888:a03:313a:c0:fe0:0:c000/"},{"line_number":195,"context_line":"      )"},{"line_number":196,"context_line":"      is_expected.to contain_file(\u0027/etc/ironic-inspector/dnsmasq.conf\u0027).with_content("},{"line_number":197,"context_line":"            /dhcp-sequential-ip/"},{"line_number":198,"context_line":"      )"},{"line_number":199,"context_line":"    end"},{"line_number":200,"context_line":"    it \u0027should contain file /tftpboot/pxelinux.cfg/default\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5665b2dc_75e992b8","line":197,"in_reply_to":"08443c58_ce7698dc","updated":"2021-08-27 17:58:29.000000000","message":"Done","commit_id":"751ba404b5393bd4a275a96f6dcf9ce9f2de650f"}],"templates/inspector_dnsmasq_http.erb":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b212930aa150f894eee145403ebfe483400bb79","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003c% end -%\u003e"},{"line_number":39,"context_line":"\u003c% end -%\u003e"},{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip -%\u003e"},{"line_number":42,"context_line":"dhcp-sequential-ip"},{"line_number":43,"context_line":"\u003c% end -%\u003e"},{"line_number":44,"context_line":"dhcp-match\u003dipxe,175"},{"line_number":45,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":46,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"}],"source_content_type":"application/x-erb","patch_set":5,"id":"80598151_7f3675ed","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":10},"updated":"2021-09-07 21:15:09.000000000","message":"Apparently my comment never posted through, my apologies.\n\nI\u0027m not a fan of adding more configuration options to puppet-ironic in the name of making everything which may be a slight behavior change of a back-end service we use maintain behavior. The important aspect is the overall contract for the end user. \"Able to deploy\" being that end contract.\n\nGranted, the continued use of the option *does* mean a in-depth analysis of logs might take an extra 20 minutes when that comes up, but operators shouldn\u0027t realistically have to identify they have to change their configuration to handle the outlier when what they are worried about is things \"just working\".\n\nI guess, ultimately, I\u0027d prefer we go on a path of removing options wherever possible which don\u0027t bring operational value other than meaning the first 20 minutes of a log analysis is slightly more organized until it is no longer sequential as some leases are being retained.","commit_id":"4f67b341eef9f0a84afefdbe63133c3449d2e1eb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8628e5d95741654559ad37023a8b50a50ffe556d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip -%\u003e"},{"line_number":42,"context_line":"dhcp-sequential-ip"},{"line_number":43,"context_line":"\u003c% end -%\u003e"},{"line_number":44,"context_line":"dhcp-match\u003dipxe,175"},{"line_number":45,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":46,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"}],"source_content_type":"application/x-erb","patch_set":5,"id":"15c49f3e_e6016c52","line":43,"updated":"2021-09-09 16:09:43.000000000","message":"config options are cheap. And if it\u0027s ever needed to turn off for some unforeseen future case it\u0027s better to have it with default enable not not have it at all.  Unfortunately with openstack and it\u0027s thousands of configuration options this is just something we have to deal with.  There are many times where we can\u0027t see when an end user might want to disable this (because we don\u0027t know all the use cases) and not having the option ends up with manual hacks and idempotency problems.  That being said if we don\u0027t think this should bother to be set, just remove it.","commit_id":"4f67b341eef9f0a84afefdbe63133c3449d2e1eb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d1e9e9ed0c06c96c255bebf58ddd9619b9a45fe0","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003c% end -%\u003e"},{"line_number":39,"context_line":"\u003c% end -%\u003e"},{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip -%\u003e"},{"line_number":42,"context_line":"dhcp-sequential-ip"},{"line_number":43,"context_line":"\u003c% end -%\u003e"},{"line_number":44,"context_line":"dhcp-match\u003dipxe,175"},{"line_number":45,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":46,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"}],"source_content_type":"application/x-erb","patch_set":5,"id":"48fc4579_d9196bc3","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":10},"in_reply_to":"5e72504a_94850b16","updated":"2021-09-09 03:59:28.000000000","message":"I agree that adding this option doesn\u0027t give much benefit.\n\nOne concern with just removing the option is that the change would not agree with what we care during backport \"in case you\u0027ll backport this\". We generally avoid making the forceful change in parameters in stable branches unless the previous configuration is completely broken, to avoid changing behavior and restarting services during update as much as possible.\n\nHowever adding a redundant parameter doesn\u0027t make much sense here and this configuration affects only the tiny dnsmasq service so I don\u0027t expect big disruption cased by restarting the service.\n\nSo I\u0027m good as long as the change is properly documented in a release note.","commit_id":"4f67b341eef9f0a84afefdbe63133c3449d2e1eb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"074e9618bd869a3fd45ca02aa67503ccb4db4d21","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003c% end -%\u003e"},{"line_number":39,"context_line":"\u003c% end -%\u003e"},{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip -%\u003e"},{"line_number":42,"context_line":"dhcp-sequential-ip"},{"line_number":43,"context_line":"\u003c% end -%\u003e"},{"line_number":44,"context_line":"dhcp-match\u003dipxe,175"},{"line_number":45,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":46,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"}],"source_content_type":"application/x-erb","patch_set":5,"id":"5e72504a_94850b16","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":10},"in_reply_to":"80598151_7f3675ed","updated":"2021-09-08 11:44:57.000000000","message":"Right, I agree with Julia. This option does not really bring value.\nIf there are no objections I will update this change to remove \u0027dhcp-sequential-ip\u0027 from inspector dnsmasq configuration instead of making it optional.","commit_id":"4f67b341eef9f0a84afefdbe63133c3449d2e1eb"}],"templates/inspector_dnsmasq_tftp.erb":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3bc7f1feac019e6379fc08b692d3fe3ada08e942","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003c% end -%\u003e"},{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":42,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip -%\u003e"},{"line_number":43,"context_line":"dhcp-sequential-ip"},{"line_number":44,"context_line":"\u003c% end -%\u003e"},{"line_number":45,"context_line":"\u003c% if @dnsmasq_dhcp_hostsdir %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"2265e771_090b7362","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":35},"updated":"2021-08-27 18:01:07.000000000","message":"I think this linebreak removal should be removed.","commit_id":"580a00a55e5eae9deb1fd88556d6ae46c961d078"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e63c0db2119857d0bd502069af337ef6d3732f08","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003c% end -%\u003e"},{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":42,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip %\u003e"},{"line_number":43,"context_line":"dhcp-sequential-ip"},{"line_number":44,"context_line":"\u003c% end %\u003e"},{"line_number":45,"context_line":"\u003c% if @dnsmasq_dhcp_hostsdir %\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"1c7c03aa_ff350c61","line":42,"range":{"start_line":42,"start_character":33,"end_line":42,"end_character":36},"updated":"2021-08-27 23:44:50.000000000","message":"Not you should not remove \u0027-\u0027. Because of the removal now this change results in blank lines around dhcp-sequential-ip\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_103/806430/3/check/tripleo-puppet-ci-centos-8-undercloud-containers/1032ab5/logs/undercloud/var/lib/config-data/puppet-generated/ironic_inspector/etc/ironic-inspector/dnsmasq.conf\n\n\nvs\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_740/806422/3/check/tripleo-puppet-ci-centos-8-undercloud-containers/74017c9/logs/undercloud/var/lib/config-data/puppet-generated/ironic_inspector/etc/ironic-inspector/dnsmasq.conf\n\n(From https://zuul.opendev.org/t/openstack/build/74017c90ee7f4dfbaa762a2977d1bff2 )","commit_id":"1580ce5d4b385b17ad0df453d97aacbd86b79738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6e5ff44d71846231a015d2cc3f2563295df39a7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003c% end -%\u003e"},{"line_number":40,"context_line":"\u003c% end -%\u003e"},{"line_number":41,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":42,"context_line":"\u003c% if @dnsmasq_dhcp_sequential_ip %\u003e"},{"line_number":43,"context_line":"dhcp-sequential-ip"},{"line_number":44,"context_line":"\u003c% end %\u003e"},{"line_number":45,"context_line":"\u003c% if @dnsmasq_dhcp_hostsdir %\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"76efac15_33cb4535","line":42,"range":{"start_line":42,"start_character":33,"end_line":42,"end_character":36},"in_reply_to":"1c7c03aa_ff350c61","updated":"2021-08-27 23:55:11.000000000","message":"Done","commit_id":"1580ce5d4b385b17ad0df453d97aacbd86b79738"}]}