)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6f4c02c62c53dace2ab02c954d07f5c55a0f2b4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"78aeb6e6_935f1974","updated":"2021-12-23 00:29:46.000000000","message":"I\u0027ve added a warning message to help users notice the deprecation.","commit_id":"634ddb82a90100849ef1a7698881c4415de61742"}],"manifests/inspector.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e691a1d7595ad7c7392484b4cc0fe2bfe2444803","unresolved":true,"context_lines":[{"line_number":409,"context_line":"      seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":410,"context_line":"      owner   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":411,"context_line":"      group   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":412,"context_line":"      require \u003d\u003e Anchor[\u0027ironic::install::end\u0027],"},{"line_number":413,"context_line":"      tag     \u003d\u003e \u0027ironic-tftp-file\u0027,"},{"line_number":414,"context_line":"    }"},{"line_number":415,"context_line":"    file { \"${tftp_root_real}/ppc64le/default\":"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"eb772ac7_ae8ccedf","line":412,"range":{"start_line":412,"start_character":25,"end_line":412,"end_character":45},"updated":"2021-12-21 00:55:28.000000000","message":"we should use an anchor for ironic-inspector.","commit_id":"f117d5b3ea0b1911f3083ddc4b4695a9fd8f1404"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e691a1d7595ad7c7392484b4cc0fe2bfe2444803","unresolved":true,"context_lines":[{"line_number":410,"context_line":"      owner   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":411,"context_line":"      group   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":412,"context_line":"      require \u003d\u003e Anchor[\u0027ironic::install::end\u0027],"},{"line_number":413,"context_line":"      tag     \u003d\u003e \u0027ironic-tftp-file\u0027,"},{"line_number":414,"context_line":"    }"},{"line_number":415,"context_line":"    file { \"${tftp_root_real}/ppc64le/default\":"},{"line_number":416,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da16fefc_e342ac42","line":413,"range":{"start_line":413,"start_character":18,"end_line":413,"end_character":34},"updated":"2021-12-21 00:55:28.000000000","message":"we can remove this. Looking at the implementation in puppet, the parent directory is automatically required so this was just redundant.","commit_id":"f117d5b3ea0b1911f3083ddc4b4695a9fd8f1404"}],"manifests/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e691a1d7595ad7c7392484b4cc0fe2bfe2444803","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  $syslinux_path           \u003d $::ironic::params::syslinux_path,"},{"line_number":79,"context_line":"  $syslinux_files          \u003d $::ironic::params::syslinux_files,"},{"line_number":80,"context_line":"  $tftp_bind_host          \u003d undef,"},{"line_number":81,"context_line":"  $enable_ppc64le          \u003d undef,"},{"line_number":82,"context_line":"  $ipxe_name_base          \u003d \u0027ipxe-snponly\u0027,"},{"line_number":83,"context_line":"  $uefi_ipxe_bootfile_name \u003d \u0027snponly.efi\u0027,"},{"line_number":84,"context_line":"  $tftp_use_xinetd         \u003d $::ironic::params::xinetd_available"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d51cdfc8_9072e4fc","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":35},"updated":"2021-12-21 00:55:28.000000000","message":"Please move this to the bottom line. Also insert \"DEPRECATED PARAMETERS\" line. See manifests/neutron.pp to find an example.\n\nAlso, please add a logic to show warning message when enable_ppc64le !\u003d undef. This helps users to notice the deprecation.","commit_id":"f117d5b3ea0b1911f3083ddc4b4695a9fd8f1404"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e691a1d7595ad7c7392484b4cc0fe2bfe2444803","unresolved":true,"context_lines":[{"line_number":345,"context_line":"    context \u0027when enabling ppc64le support\u0027 do"},{"line_number":346,"context_line":"      let :pre_condition do"},{"line_number":347,"context_line":"         \"class { \u0027ironic::inspector::authtoken\u0027: password       \u003d\u003e \u0027password\u0027, }"},{"line_number":348,"context_line":"          class { \u0027ironic::inspector\u0027:                  enable_ppc64le \u003d\u003e true, }\""},{"line_number":349,"context_line":"      end"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"      before do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"408947fe_32fa4a7c","line":348,"range":{"start_line":348,"start_character":10,"end_line":348,"end_character":81},"updated":"2021-12-21 00:55:28.000000000","message":"you don\u0027t need this because ironic::inspector is the test target.","commit_id":"f117d5b3ea0b1911f3083ddc4b4695a9fd8f1404"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e691a1d7595ad7c7392484b4cc0fe2bfe2444803","unresolved":true,"context_lines":[{"line_number":385,"context_line":"    context \u0027when enabling ppc64le support with http default transport\u0027 do"},{"line_number":386,"context_line":"      let :pre_condition do"},{"line_number":387,"context_line":"         \"class { \u0027ironic::inspector::authtoken\u0027: password       \u003d\u003e \u0027password\u0027, }"},{"line_number":388,"context_line":"          class { \u0027ironic::inspector\u0027:                  enable_ppc64le \u003d\u003e true, }\""},{"line_number":389,"context_line":"      end"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"      before do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"61e104b5_7008c4d3","line":388,"range":{"start_line":388,"start_character":10,"end_line":388,"end_character":81},"updated":"2021-12-21 00:55:28.000000000","message":"ditto","commit_id":"f117d5b3ea0b1911f3083ddc4b4695a9fd8f1404"}]}
