)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"440f4de5c419e02b597159b6e31eb95e69c559b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"838c06ae_d8632567","updated":"2022-05-20 05:43:16.000000000","message":"Leaving a few too-early feedback before we get results by CI.\n\nThis change introduces a new parameter and relatively important change in functionality. Do you mind creating a release note ?\n\nFinally, if you intend to backport this to stable branch, I think creating a bug (a short one can be enough) to explain the problem would be helpful.","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cd9cbf1666ea71a1ef62cf271857d9bdded39116","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a4046884_f5cd70bb","in_reply_to":"838c06ae_d8632567","updated":"2022-05-23 22:28:09.000000000","message":"\u003e This change introduces a new parameter and relatively important change in functionality. Do you mind creating a release note ?\n\nDone\n\n\u003e Finally, if you intend to backport this to stable branch, I think creating a bug (a short one can be enough) to explain the problem would be helpful.\n\nDone","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ce6493f500a878d6d11650c31fc8f0f20f0308e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"183af433_2272db05","in_reply_to":"a4046884_f5cd70bb","updated":"2022-06-10 08:20:13.000000000","message":"Done","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c1a42db5b95b7814c519fd3c853a869c843a6767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"459f8048_abbbab2c","updated":"2022-05-24 05:00:19.000000000","message":"c8s litmus job is failing because of the following error\n\nError: /Stage[main]/Ironic::Pxe/File[/tftpboot/grubx64.efi]: Could not evaluate: Could not retrieve information from environment production source(s) file:///boot/efi/EFI/centos/grubx64.efi","commit_id":"1c23d36ea8828244d8461b84dc693b144d45ba89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d11406385e755f3439ad5ffa52ea63b0a7542687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"137e585a_71ec81c5","updated":"2022-06-01 09:40:40.000000000","message":"2022-05-24 03:07:56.128328 | centos-8-stream |        \u001b[1;31mError: /Stage[main]/Ironic::Pxe/File[/tftpboot/grubx64.efi]: Could not evaluate: Could not retrieve information from environment production source(s) file:///boot/efi/EFI/centos/grubx64.efi\n...\n2022-05-24 03:07:56.129891 | centos-8-stream |        \u001b[mNotice: /Stage[main]/Ironic::Pxe/Package[grub_efi]/ensure: created\u001b[0m\n2022-05-24 03:07:56.129903 | centos-8-stream |        \u001b[mNotice: /Stage[main]/Ironic::Pxe/Package[shim]/ensure: created\u001b[0m\n","commit_id":"c075a245ae8c0e5a9bf0da13c72670b556f6f3c8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"62df77777377db93a4aff2c9ad64e5ec669dde08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"81807eaa_7efcc5e3","updated":"2022-06-01 10:56:38.000000000","message":"Litmus job passed https://review.opendev.org/c/openstack/puppet-ironic/+/844174","commit_id":"c075a245ae8c0e5a9bf0da13c72670b556f6f3c8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ce6493f500a878d6d11650c31fc8f0f20f0308e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"119cfdbc_07017f5a","updated":"2022-06-10 08:20:13.000000000","message":"We are still waiting for https://review.opendev.org/c/openstack/tripleo-common/+/844147 to make tripleo undercloud job pass with this change.","commit_id":"c0574a9675aa50261d628238791e97daec30b94e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d794ae54db3c35ecd3e3d71a13194e727ac8093b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"cf982a8b_915035f6","updated":"2022-06-25 02:51:16.000000000","message":"Updated the patch to disable diff logging.","commit_id":"4863a485cd7405f6bca9011a9694dd385d170049"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f91b096702f99b66cd74780c5c85e031d9481aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8cb3bf24_e5156ed7","updated":"2022-06-28 03:01:46.000000000","message":"recheck","commit_id":"4863a485cd7405f6bca9011a9694dd385d170049"}],"manifests/drivers/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"440f4de5c419e02b597159b6e31eb95e69c559b1","unresolved":true,"context_lines":[{"line_number":74,"context_line":"#   (optional) Template file for PXE configuration for UEFI boot loader."},{"line_number":75,"context_line":"#   Defaults to $::os_service_default."},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# [*uefi_pxe_bootfile_name*]"},{"line_number":78,"context_line":"#   (optional) Bootfile DHCP parameter for UEFI boot mode for the"},{"line_number":79,"context_line":"#   pxe boot interface. No separate configuration template is required"},{"line_number":80,"context_line":"#   when using ipxe."},{"line_number":81,"context_line":"#   Defaults to bootx64.efi, which will be the signed shim that loads"},{"line_number":82,"context_line":"#   grub for a network boot."},{"line_number":83,"context_line":"#"},{"line_number":84,"context_line":"# [*uefi_ipxe_bootfile_name*]"},{"line_number":85,"context_line":"#   (optional) Bootfile DHCP parameter for UEFI boot mode for the"},{"line_number":86,"context_line":"#   ipxe boot interface. No separate configuration template is required"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"faec99a6_0a13ec95","line":83,"range":{"start_line":77,"start_character":0,"end_line":83,"end_character":1},"updated":"2022-05-20 05:43:16.000000000","message":"I don\u0027t see any benefit with this change. The new order is not consistent with the parameter definition and usage.","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cd9cbf1666ea71a1ef62cf271857d9bdded39116","unresolved":false,"context_lines":[{"line_number":74,"context_line":"#   (optional) Template file for PXE configuration for UEFI boot loader."},{"line_number":75,"context_line":"#   Defaults to $::os_service_default."},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# [*uefi_pxe_bootfile_name*]"},{"line_number":78,"context_line":"#   (optional) Bootfile DHCP parameter for UEFI boot mode for the"},{"line_number":79,"context_line":"#   pxe boot interface. No separate configuration template is required"},{"line_number":80,"context_line":"#   when using ipxe."},{"line_number":81,"context_line":"#   Defaults to bootx64.efi, which will be the signed shim that loads"},{"line_number":82,"context_line":"#   grub for a network boot."},{"line_number":83,"context_line":"#"},{"line_number":84,"context_line":"# [*uefi_ipxe_bootfile_name*]"},{"line_number":85,"context_line":"#   (optional) Bootfile DHCP parameter for UEFI boot mode for the"},{"line_number":86,"context_line":"#   ipxe boot interface. No separate configuration template is required"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"2716611a_dfbf760a","line":83,"range":{"start_line":77,"start_character":0,"end_line":83,"end_character":1},"in_reply_to":"faec99a6_0a13ec95","updated":"2022-05-23 22:28:09.000000000","message":"Done","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d11406385e755f3439ad5ffa52ea63b0a7542687","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      $syslinux_package          \u003d \u0027syslinux-tftpboot\u0027"},{"line_number":67,"context_line":"      $syslinux_path             \u003d \u0027/tftpboot\u0027"},{"line_number":68,"context_line":"      $syslinux_files            \u003d [\u0027pxelinux.0\u0027, \u0027chain.c32\u0027, \u0027ldlinux.c32\u0027]"},{"line_number":69,"context_line":"      $grub_efi_package          \u003d \u0027grub2-efi-x64\u0027"},{"line_number":70,"context_line":"      $grub_efi_file             \u003d \u0027/boot/efi/EFI/centos/grubx64.efi\u0027"},{"line_number":71,"context_line":"      $shim_package              \u003d \u0027shim\u0027"},{"line_number":72,"context_line":"      $shim_file                 \u003d \u0027/boot/efi/EFI/centos/shimx64.efi\u0027"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"8e2a9d24_1ffffce6","line":69,"range":{"start_line":69,"start_character":36,"end_line":69,"end_character":49},"updated":"2022-06-01 09:40:40.000000000","message":"Looking at the logs in litmus, it seems only grub2-efi-ia32 is installed. As we expect xgrub64.efi , I think we should use more specific package name.","commit_id":"c075a245ae8c0e5a9bf0da13c72670b556f6f3c8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"62df77777377db93a4aff2c9ad64e5ec669dde08","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      $syslinux_package          \u003d \u0027syslinux-tftpboot\u0027"},{"line_number":67,"context_line":"      $syslinux_path             \u003d \u0027/tftpboot\u0027"},{"line_number":68,"context_line":"      $syslinux_files            \u003d [\u0027pxelinux.0\u0027, \u0027chain.c32\u0027, \u0027ldlinux.c32\u0027]"},{"line_number":69,"context_line":"      $grub_efi_package          \u003d \u0027grub2-efi-x64\u0027"},{"line_number":70,"context_line":"      $grub_efi_file             \u003d \u0027/boot/efi/EFI/centos/grubx64.efi\u0027"},{"line_number":71,"context_line":"      $shim_package              \u003d \u0027shim\u0027"},{"line_number":72,"context_line":"      $shim_file                 \u003d \u0027/boot/efi/EFI/centos/shimx64.efi\u0027"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"2701f481_e6ee006e","line":69,"range":{"start_line":69,"start_character":36,"end_line":69,"end_character":49},"in_reply_to":"8e2a9d24_1ffffce6","updated":"2022-06-01 10:56:38.000000000","message":"Done","commit_id":"c075a245ae8c0e5a9bf0da13c72670b556f6f3c8"}],"manifests/pxe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"da5a415fc261425d392c18b0b993606e5d1b694c","unresolved":true,"context_lines":[{"line_number":101,"context_line":"  $http_root_real \u003d pick($::ironic::pxe::common::http_root, $http_root)"},{"line_number":102,"context_line":"  $http_port_real \u003d pick($::ironic::pxe::common::http_port, $http_port)"},{"line_number":103,"context_line":"  $uefi_ipxe_bootfile_name_real \u003d pick($::ironic::pxe::common::uefi_ipxe_bootfile_name, $uefi_ipxe_bootfile_name)"},{"line_number":104,"context_line":"  $uefi_pxe_bootfile_name_real \u003d pick($::ironic::pxe::common::uefi_pxe_bootfile_name, $uefi_pxe_bootfile_name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  if $::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":107,"context_line":"    $arch \u003d \"-${::os[\u0027architecture\u0027]}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"86eddbd9_eed53413","line":104,"range":{"start_line":104,"start_character":87,"end_line":104,"end_character":109},"updated":"2022-05-20 02:56:08.000000000","message":"this parameter does not exist.","commit_id":"e21ada5b7839b1ad1c266647500b855e38bec03b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"440f4de5c419e02b597159b6e31eb95e69c559b1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $http_root_real \u003d pick($::ironic::pxe::common::http_root, $http_root)"},{"line_number":102,"context_line":"  $http_port_real \u003d pick($::ironic::pxe::common::http_port, $http_port)"},{"line_number":103,"context_line":"  $uefi_ipxe_bootfile_name_real \u003d pick($::ironic::pxe::common::uefi_ipxe_bootfile_name, $uefi_ipxe_bootfile_name)"},{"line_number":104,"context_line":"  $uefi_pxe_bootfile_name_real \u003d pick($::ironic::pxe::common::uefi_pxe_bootfile_name, $uefi_pxe_bootfile_name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  if $::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":107,"context_line":"    $arch \u003d \"-${::os[\u0027architecture\u0027]}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"93ab33bf_a7c48a8c","line":104,"range":{"start_line":104,"start_character":87,"end_line":104,"end_character":109},"in_reply_to":"487da6c5_c2924775","updated":"2022-05-20 05:43:16.000000000","message":"Done","commit_id":"e21ada5b7839b1ad1c266647500b855e38bec03b"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"be25f731a8774d29d3a95d13eb01f6e9b8214caa","unresolved":true,"context_lines":[{"line_number":101,"context_line":"  $http_root_real \u003d pick($::ironic::pxe::common::http_root, $http_root)"},{"line_number":102,"context_line":"  $http_port_real \u003d pick($::ironic::pxe::common::http_port, $http_port)"},{"line_number":103,"context_line":"  $uefi_ipxe_bootfile_name_real \u003d pick($::ironic::pxe::common::uefi_ipxe_bootfile_name, $uefi_ipxe_bootfile_name)"},{"line_number":104,"context_line":"  $uefi_pxe_bootfile_name_real \u003d pick($::ironic::pxe::common::uefi_pxe_bootfile_name, $uefi_pxe_bootfile_name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  if $::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":107,"context_line":"    $arch \u003d \"-${::os[\u0027architecture\u0027]}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"487da6c5_c2924775","line":104,"range":{"start_line":104,"start_character":87,"end_line":104,"end_character":109},"in_reply_to":"86eddbd9_eed53413","updated":"2022-05-20 05:08:27.000000000","message":"Jobs are much more green now, this change is ready for review I think","commit_id":"e21ada5b7839b1ad1c266647500b855e38bec03b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"440f4de5c419e02b597159b6e31eb95e69c559b1","unresolved":true,"context_lines":[{"line_number":64,"context_line":"#   should be consistent with the uefi_pxe_bootfile_name parameter in pxe"},{"line_number":65,"context_line":"#   driver."},{"line_number":66,"context_line":"#   Defaults to \u0027bootx64.efi\u0027"},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*tftp_use_xinetd*]"},{"line_number":70,"context_line":"#   (optional) Override wheter to use xinetd instead of dnsmasq as the tftp"},{"line_number":71,"context_line":"#   service facilitator."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"f99c44f2_f93c61db","line":68,"range":{"start_line":67,"start_character":1,"end_line":68,"end_character":1},"updated":"2022-05-20 05:43:16.000000000","message":"One line can be removed.","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cd9cbf1666ea71a1ef62cf271857d9bdded39116","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   should be consistent with the uefi_pxe_bootfile_name parameter in pxe"},{"line_number":65,"context_line":"#   driver."},{"line_number":66,"context_line":"#   Defaults to \u0027bootx64.efi\u0027"},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*tftp_use_xinetd*]"},{"line_number":70,"context_line":"#   (optional) Override wheter to use xinetd instead of dnsmasq as the tftp"},{"line_number":71,"context_line":"#   service facilitator."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"eb5bfd6f_9c97785b","line":68,"range":{"start_line":67,"start_character":1,"end_line":68,"end_character":1},"in_reply_to":"f99c44f2_f93c61db","updated":"2022-05-23 22:28:09.000000000","message":"Done","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78e9a510fda3391f1497463c06752af7dd2654e6","unresolved":true,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  ensure_resource( \u0027package\u0027, \u0027shim_efi\u0027, {"},{"line_number":286,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":287,"context_line":"    name   \u003d\u003e $::ironic::params::shim_efi_package,"},{"line_number":288,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-support-package\u0027],"},{"line_number":289,"context_line":"  })"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"29addc43_7e753cdc","line":287,"range":{"start_line":287,"start_character":33,"end_line":287,"end_character":49},"updated":"2022-05-24 02:21:51.000000000","message":"this should be shim_package","commit_id":"56a23e0ae2af6583a433b6b58538d0d4037f3b3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"62df77777377db93a4aff2c9ad64e5ec669dde08","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  ensure_resource( \u0027package\u0027, \u0027shim_efi\u0027, {"},{"line_number":286,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":287,"context_line":"    name   \u003d\u003e $::ironic::params::shim_efi_package,"},{"line_number":288,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-support-package\u0027],"},{"line_number":289,"context_line":"  })"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"f6343b52_469034d7","line":287,"range":{"start_line":287,"start_character":33,"end_line":287,"end_character":49},"in_reply_to":"29addc43_7e753cdc","updated":"2022-06-01 10:56:38.000000000","message":"Done","commit_id":"56a23e0ae2af6583a433b6b58538d0d4037f3b3e"}],"manifests/pxe/common.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"440f4de5c419e02b597159b6e31eb95e69c559b1","unresolved":true,"context_lines":[{"line_number":51,"context_line":"  $http_port               \u003d undef,"},{"line_number":52,"context_line":"  $ipxe_timeout            \u003d undef,"},{"line_number":53,"context_line":"  $uefi_ipxe_bootfile_name \u003d undef,"},{"line_number":54,"context_line":"  $uefi_pxe_bootfile_name \u003d undef,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":"  include ironic::deps"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7dfb366b_b8f2f18e","line":54,"range":{"start_line":54,"start_character":26,"end_line":54,"end_character":27},"updated":"2022-05-20 05:43:16.000000000","message":"please align \u003d","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cd9cbf1666ea71a1ef62cf271857d9bdded39116","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  $http_port               \u003d undef,"},{"line_number":52,"context_line":"  $ipxe_timeout            \u003d undef,"},{"line_number":53,"context_line":"  $uefi_ipxe_bootfile_name \u003d undef,"},{"line_number":54,"context_line":"  $uefi_pxe_bootfile_name \u003d undef,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":"  include ironic::deps"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"64592002_968070cf","line":54,"range":{"start_line":54,"start_character":26,"end_line":54,"end_character":27},"in_reply_to":"7dfb366b_b8f2f18e","updated":"2022-05-23 22:28:09.000000000","message":"Done","commit_id":"2b112108dfc497bce617437c004decc7bdcd95aa"}]}