)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dd7914ff58bd7b03a91d39e3516149d7ba810bad","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Maryna Savchenko \u003cmaryna.savchenko@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-26 17:04:06 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add deploy_callback_timeout parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I30fef88b425c2729acf860d489e9fb6a493c5a4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"58665dca_4e5497e0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":27},"updated":"2022-07-26 15:17:14.000000000","message":"This adds a new parameter/feature so please add a release note file to explain it.\nYou can refer to a few examples below\n\nhttps://review.opendev.org/c/openstack/puppet-ironic/+/829740/3/releasenotes/notes/json_rpc-allowed_roles-7e2d5640363596f6.yaml\nhttps://review.opendev.org/c/openstack/puppet-ironic/+/850300/5/releasenotes/notes/conductor-heartbeat-d92790f3e6a59c4b.yaml\nhttps://review.opendev.org/c/openstack/puppet-ironic/+/828493/5/releasenotes/notes/glance-swift_account_prefix-07b78b6b433e7202.yaml","commit_id":"3fb9d93e54d3c40e3fd0b8d2ed607e63d7b38fb9"},{"author":{"_account_id":34320,"name":"Maryna Savchenko","email":"maryna.savchenko@cern.ch","username":"msavchen"},"change_message_id":"e1e39d3bb50e138839d2247fc722848e430b5f80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maryna Savchenko \u003cmaryna.savchenko@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-26 17:04:06 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add deploy_callback_timeout parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I30fef88b425c2729acf860d489e9fb6a493c5a4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"460e28fc_509ce7ca","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":27},"in_reply_to":"58665dca_4e5497e0","updated":"2022-07-27 12:17:01.000000000","message":"Done","commit_id":"3fb9d93e54d3c40e3fd0b8d2ed607e63d7b38fb9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dd7914ff58bd7b03a91d39e3516149d7ba810bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2c71e70_20fb2be1","updated":"2022-07-26 15:17:14.000000000","message":"Thanks for submitting this. We have not yet get CI result but I\u0027ll leave (too) early comment before I leave for the day. It\u0027d be nice you can address these.","commit_id":"3fb9d93e54d3c40e3fd0b8d2ed607e63d7b38fb9"},{"author":{"_account_id":34320,"name":"Maryna Savchenko","email":"maryna.savchenko@cern.ch","username":"msavchen"},"change_message_id":"e1e39d3bb50e138839d2247fc722848e430b5f80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1681a773_921aac1d","in_reply_to":"b2c71e70_20fb2be1","updated":"2022-07-27 12:17:01.000000000","message":"Thanks for the review, Takashi.\nShould be fixed now.","commit_id":"3fb9d93e54d3c40e3fd0b8d2ed607e63d7b38fb9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4059f345a5018fa57347e75ebd2c77b1b221846b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"136c12ec_85a5ea3f","updated":"2022-07-27 15:56:59.000000000","message":"Thank you, Maryna, for updating the patch. I\u0027ve fixed a trivial typo in the release note file. Now this looks good to me.","commit_id":"c49f2a401e467a26d3e94f32e68b6f75658a9c0f"}],"releasenotes/notes/conductor-deploy_callback_timeout-0f415dee2dd2c181.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"76b938bd1f8a707e1328163c21780f0487b68d42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``ironic::conductor::deploy_callback_timeout`` parameter have been added."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2a96d324_0a899470","line":4,"range":{"start_line":4,"start_character":69,"end_line":4,"end_character":73},"updated":"2022-07-27 15:56:01.000000000","message":"has","commit_id":"327d50a04df3006a96e4d8d249cc2f08b5ca8117"}],"spec/classes/ironic_conductor_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dd7914ff58bd7b03a91d39e3516149d7ba810bad","unresolved":true,"context_lines":[{"line_number":90,"context_line":"      is_expected.to contain_ironic_config(\u0027conductor/rescue_ramdisk\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":91,"context_line":"      is_expected.to contain_ironic_config(\u0027conductor/bootloader\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":92,"context_line":"      is_expected.to contain_ironic_config(\u0027DEFAULT/image_download_concurrency\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":93,"context_line":"    end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    context \u0027when overriding parameters\u0027 do"},{"line_number":96,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"84e525c1_88050b74","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":7},"updated":"2022-07-26 15:17:14.000000000","message":"Please also add a case to test the default value.","commit_id":"3fb9d93e54d3c40e3fd0b8d2ed607e63d7b38fb9"},{"author":{"_account_id":34320,"name":"Maryna Savchenko","email":"maryna.savchenko@cern.ch","username":"msavchen"},"change_message_id":"e1e39d3bb50e138839d2247fc722848e430b5f80","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      is_expected.to contain_ironic_config(\u0027conductor/rescue_ramdisk\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":91,"context_line":"      is_expected.to contain_ironic_config(\u0027conductor/bootloader\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":92,"context_line":"      is_expected.to contain_ironic_config(\u0027DEFAULT/image_download_concurrency\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":93,"context_line":"    end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    context \u0027when overriding parameters\u0027 do"},{"line_number":96,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5f544c16_f8334f4f","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":7},"in_reply_to":"84e525c1_88050b74","updated":"2022-07-27 12:17:01.000000000","message":"Done","commit_id":"3fb9d93e54d3c40e3fd0b8d2ed607e63d7b38fb9"}]}
