)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8a5573da90e94bb70eafaee4e9551e96ed113df6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d07c5d4_96ba431e","updated":"2022-09-05 13:47:21.000000000","message":"recheck","commit_id":"97b35f0be776f36d4df47e0eb5c77c9a7080da45"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"4fb1d2fcb42b86b7a221be53bb2f964d0157d123","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"426e7756_fef42450","updated":"2022-09-06 12:34:04.000000000","message":"Thanks Takashi!","commit_id":"da750df0de9d8dca8eeddf621cca897ac240315e"}],"manifests/pxe.pp":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"639f17da21350651e9262dc6769169b566d2f935","unresolved":true,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  File[\"${tftp_root_real}\"] -\u003e File\u003c| tag \u003d\u003d \u0027ironic-tftp-file\u0027 |\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  include apache"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  apache::vhost { \u0027ipxe_vhost\u0027:"},{"line_number":333,"context_line":"    priority \u003d\u003e 10,"},{"line_number":334,"context_line":"    options  \u003d\u003e [\u0027Indexes\u0027,\u0027FollowSymLinks\u0027],"},{"line_number":335,"context_line":"    docroot  \u003d\u003e $http_root_real,"},{"line_number":336,"context_line":"    port     \u003d\u003e $http_port_real,"},{"line_number":337,"context_line":"  }"},{"line_number":338,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f5c87f4f_53b1c926","line":337,"range":{"start_line":330,"start_character":1,"end_line":337,"end_character":3},"updated":"2022-09-06 11:40:02.000000000","message":"we probably want to use the manage_service here as well.","commit_id":"da750df0de9d8dca8eeddf621cca897ac240315e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5da89a0a8de5e517de94313cee07fa2f3df0d254","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  File[\"${tftp_root_real}\"] -\u003e File\u003c| tag \u003d\u003d \u0027ironic-tftp-file\u0027 |\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  include apache"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  apache::vhost { \u0027ipxe_vhost\u0027:"},{"line_number":333,"context_line":"    priority \u003d\u003e 10,"},{"line_number":334,"context_line":"    options  \u003d\u003e [\u0027Indexes\u0027,\u0027FollowSymLinks\u0027],"},{"line_number":335,"context_line":"    docroot  \u003d\u003e $http_root_real,"},{"line_number":336,"context_line":"    port     \u003d\u003e $http_port_real,"},{"line_number":337,"context_line":"  }"},{"line_number":338,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7701c470_865d18c2","line":337,"range":{"start_line":330,"start_character":1,"end_line":337,"end_character":3},"in_reply_to":"0da155b3_64fc2b88","updated":"2022-09-06 12:17:53.000000000","message":"Because disabling apache resources is different from the objective of this change, I created a separate commit to cover it.\n\nhttps://review.opendev.org/c/openstack/puppet-ironic/+/856046","commit_id":"da750df0de9d8dca8eeddf621cca897ac240315e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"400d9e36227800b218610ed731d27f863097993c","unresolved":true,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  File[\"${tftp_root_real}\"] -\u003e File\u003c| tag \u003d\u003d \u0027ironic-tftp-file\u0027 |\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  include apache"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  apache::vhost { \u0027ipxe_vhost\u0027:"},{"line_number":333,"context_line":"    priority \u003d\u003e 10,"},{"line_number":334,"context_line":"    options  \u003d\u003e [\u0027Indexes\u0027,\u0027FollowSymLinks\u0027],"},{"line_number":335,"context_line":"    docroot  \u003d\u003e $http_root_real,"},{"line_number":336,"context_line":"    port     \u003d\u003e $http_port_real,"},{"line_number":337,"context_line":"  }"},{"line_number":338,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"0da155b3_64fc2b88","line":337,"range":{"start_line":330,"start_character":1,"end_line":337,"end_character":3},"in_reply_to":"c3fed7c9_160e43c2","updated":"2022-09-06 11:47:30.000000000","message":"that would still create the vhost... now that you mention it, there\u0027s the \"configure_apache\" thing I\u0027ve pushed to puppet-tripleo.. Maybe something to leverage here as well?","commit_id":"da750df0de9d8dca8eeddf621cca897ac240315e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a8f401c1c66fe4b59a9cdd199b727f4cc876151","unresolved":true,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  File[\"${tftp_root_real}\"] -\u003e File\u003c| tag \u003d\u003d \u0027ironic-tftp-file\u0027 |\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  include apache"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  apache::vhost { \u0027ipxe_vhost\u0027:"},{"line_number":333,"context_line":"    priority \u003d\u003e 10,"},{"line_number":334,"context_line":"    options  \u003d\u003e [\u0027Indexes\u0027,\u0027FollowSymLinks\u0027],"},{"line_number":335,"context_line":"    docroot  \u003d\u003e $http_root_real,"},{"line_number":336,"context_line":"    port     \u003d\u003e $http_port_real,"},{"line_number":337,"context_line":"  }"},{"line_number":338,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c3fed7c9_160e43c2","line":337,"range":{"start_line":330,"start_character":1,"end_line":337,"end_character":3},"in_reply_to":"f5c87f4f_53b1c926","updated":"2022-09-06 11:43:34.000000000","message":"If we do not want to manage httpd service then puppetlabs-apache provides the apache::service_manage parameter.","commit_id":"da750df0de9d8dca8eeddf621cca897ac240315e"}]}