)]}'
{"lib/puppet/provider/keystone_tenant/aviator.rb":[{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"94c6c2a609950fcfe8c04c4ce9344d2db26b4a91","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def self.instances"},{"line_number":73,"context_line":"    []"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  def instances"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da9df570_7c8c1680","line":73,"updated":"2014-09-25 00:25:00.000000000","message":"Why is self.instances not populated? The cli keystone provider did. Is this a limitation of the aviator provider? Can in use the class-instance instances method?","commit_id":"acf1560056eaf0c27d09eb05b0bb2fdf1440c50b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f316f43d51fa89ddcec3d0caebd47f9559a9f334","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def self.instances"},{"line_number":73,"context_line":"    []"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  def instances"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da9df570_30646fe4","line":73,"in_reply_to":"da9df570_7c8c1680","updated":"2014-09-25 04:33:56.000000000","message":"There is a note about this issue in the commit message and it is an open question on how to resolve it. The problem is that there are new options for authenticating and some of them require an instance of the provider to be created. self.instances could be rewritten to try to use the methods that don\u0027t require a provider instance, but it would not work consistently. \n\nThere is an object method that has the functionality of self.instances (below), so the only problem is that `puppet resource` doesn\u0027t work. Otherwise I think the functionality is captured.\n\nI am open to suggestions on how to have authentication without creating a provider instance. Could a device provider be used to help with this?","commit_id":"acf1560056eaf0c27d09eb05b0bb2fdf1440c50b"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"94c6c2a609950fcfe8c04c4ce9344d2db26b4a91","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def sym_to_bool(sym)"},{"line_number":96,"context_line":"      sym \u003d\u003d :true ? true : false"},{"line_number":97,"context_line":"    end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da9df570_bc62feaa","line":97,"updated":"2014-09-25 00:25:00.000000000","message":"Indentation of this section.","commit_id":"acf1560056eaf0c27d09eb05b0bb2fdf1440c50b"}],"lib/puppet/type/keystone_tenant.rb":[{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"94c6c2a609950fcfe8c04c4ce9344d2db26b4a91","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  # we should not do anything until the keystone service is started"},{"line_number":34,"context_line":"  autorequire(:service) do"},{"line_number":35,"context_line":"    [\u0027keystone\u0027]"},{"line_number":36,"context_line":"  end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da9df570_3cf52ecb","side":"PARENT","line":35,"updated":"2014-09-25 00:25:00.000000000","message":"Do we no longer need to autorequire the service?","commit_id":"e0fc680b109497b3ba47e7a2371fcee507baf0b9"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f316f43d51fa89ddcec3d0caebd47f9559a9f334","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  # we should not do anything until the keystone service is started"},{"line_number":34,"context_line":"  autorequire(:service) do"},{"line_number":35,"context_line":"    [\u0027keystone\u0027]"},{"line_number":36,"context_line":"  end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da9df570_70e35733","side":"PARENT","line":35,"in_reply_to":"da9df570_3cf52ecb","updated":"2014-09-25 04:33:56.000000000","message":"This should only be making API calls, and the endpoints don\u0027t need to be on localhost, so there shouldn\u0027t be a strict need anymore for the service to be running on the same host that the type is running on.","commit_id":"e0fc680b109497b3ba47e7a2371fcee507baf0b9"}]}