)]}'
{"lib/puppet/provider/keystone_user_role/openstack.rb":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"c907fc8e13b5f2c86527996cd29bb5be725c4f63","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  def self.get_api_version_for_cmd"},{"line_number":16,"context_line":"    [\"--os-identity-api-version\", \"3\"]"},{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  def create"},{"line_number":20,"context_line":"    if resource[:roles]"},{"line_number":21,"context_line":"      resource[:roles].each do |role|"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3acd31a7_675ed577","line":18,"updated":"2015-05-04 03:45:21.000000000","message":"this two methods repeat in this three files:\n\nlib/puppet/provider/keystone_tenant/openstack.rb\nlib/puppet/provider/keystone_user/openstack.rb\nlib/puppet/provider/keystone_user_role/openstack.rb\n\ni think they should be on a more general place. Maybe KeystoneV3Util?","commit_id":"d1a47460bf9adad38d5cc1c2307d321bc82e507f"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"b36be2208853d5fbd914fc9814a912b27310581e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  def self.get_api_version_for_cmd"},{"line_number":16,"context_line":"    [\"--os-identity-api-version\", \"3\"]"},{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  def create"},{"line_number":20,"context_line":"    if resource[:roles]"},{"line_number":21,"context_line":"      resource[:roles].each do |role|"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3acd31a7_cfc9307a","line":18,"in_reply_to":"3acd31a7_675ed577","updated":"2015-05-04 16:51:05.000000000","message":"They are here because they override the setting in the superclass lib/puppet/provider/keystone.rb. By default, keystone.rb uses v2 - \"/v2.0/\" and and empty [] array for the api version. Subclasses that support v3 override the methods to provide the v3 arguments.\n\nI think once all of the keystone providers support v3, we can use v3 everywhere, and get rid of these methods.","commit_id":"d1a47460bf9adad38d5cc1c2307d321bc82e507f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2543b3393ab017ad02a6995bdf91cc1fe7d35e9f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    if resource[:roles]"},{"line_number":20,"context_line":"      props \u003d properties"},{"line_number":21,"context_line":"      resource[:roles].each do |role|"},{"line_number":22,"context_line":"        self.class.request(\u0027role\u0027, \u0027add\u0027, [role] + props)"},{"line_number":23,"context_line":"      end"},{"line_number":24,"context_line":"    end"},{"line_number":25,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":33,"id":"ba3cc151_b8f93b82","line":22,"updated":"2015-07-08 21:17:41.000000000","message":"I would prefer to remove the props \u003d properties and just use the properties method call here","commit_id":"23cbe99009e329c2fd60ffcdc5c5ea4b66121d46"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"99a6d5d9c19aabbb03b5088a6829337ab7dc9be1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    if resource[:roles]"},{"line_number":20,"context_line":"      props \u003d properties"},{"line_number":21,"context_line":"      resource[:roles].each do |role|"},{"line_number":22,"context_line":"        self.class.request(\u0027role\u0027, \u0027add\u0027, [role] + props)"},{"line_number":23,"context_line":"      end"},{"line_number":24,"context_line":"    end"},{"line_number":25,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":33,"id":"ba3cc151_652c6bac","line":22,"in_reply_to":"ba3cc151_b8f93b82","updated":"2015-07-08 22:09:20.000000000","message":"Done\n\nAnd elsewhere in destroy, and roles\u003d","commit_id":"23cbe99009e329c2fd60ffcdc5c5ea4b66121d46"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2543b3393ab017ad02a6995bdf91cc1fe7d35e9f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  private"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  def properties"},{"line_number":89,"context_line":"    debug(\"in properties\")"},{"line_number":90,"context_line":"    properties \u003d []"},{"line_number":91,"context_line":"    if get_project_id"},{"line_number":92,"context_line":"      properties \u003c\u003c \u0027--project\u0027 \u003c\u003c get_project_id"}],"source_content_type":"text/x-ruby","patch_set":33,"id":"ba3cc151_98d557e6","line":89,"updated":"2015-07-08 21:17:41.000000000","message":"This debug statement should be removed","commit_id":"23cbe99009e329c2fd60ffcdc5c5ea4b66121d46"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"99a6d5d9c19aabbb03b5088a6829337ab7dc9be1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  private"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  def properties"},{"line_number":89,"context_line":"    debug(\"in properties\")"},{"line_number":90,"context_line":"    properties \u003d []"},{"line_number":91,"context_line":"    if get_project_id"},{"line_number":92,"context_line":"      properties \u003c\u003c \u0027--project\u0027 \u003c\u003c get_project_id"}],"source_content_type":"text/x-ruby","patch_set":33,"id":"ba3cc151_a526f3cb","line":89,"in_reply_to":"ba3cc151_98d557e6","updated":"2015-07-08 22:09:20.000000000","message":"Done","commit_id":"23cbe99009e329c2fd60ffcdc5c5ea4b66121d46"}]}