)]}'
{"lib/puppet/provider/keystone.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"7a47b65db7b623a13f64c83d012ac5e4f82f889f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d KeystoneV3Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"},{"line_number":38,"context_line":"    if resource[:domain].nil? \u0026\u0026 domain.nil?"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_b528fc9a","line":35,"updated":"2015-06-11 08:03:47.000000000","message":"Is an instance method still needed after the bp/auth_restructure?","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"4d3d17d4c1de2e200da73ac23039ec344e11022f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d KeystoneV3Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"},{"line_number":38,"context_line":"    if resource[:domain].nil? \u0026\u0026 domain.nil?"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_9ff5fdcc","line":35,"in_reply_to":"3afb71cf_b528fc9a","updated":"2015-06-11 20:26:16.000000000","message":"It\u0027s not strictly needed, but it provides a convenience (i.e. saves code) for provider subclass instances because it uses resource[:name] and resource[:domain] directly.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"7a47b65db7b623a13f64c83d012ac5e4f82f889f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    domain_hash[default_domain_id]"},{"line_number":139,"context_line":"  end"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  def default_domain"},{"line_number":142,"context_line":"    self.class.default_domain"},{"line_number":143,"context_line":"  end"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_182ca797","line":141,"updated":"2015-06-11 08:03:47.000000000","message":"Same question here regarding the instance method in the context of bp/auth_restructure change.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"4d3d17d4c1de2e200da73ac23039ec344e11022f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    domain_hash[default_domain_id]"},{"line_number":139,"context_line":"  end"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  def default_domain"},{"line_number":142,"context_line":"    self.class.default_domain"},{"line_number":143,"context_line":"  end"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_bfe67914","line":141,"in_reply_to":"3afb71cf_182ca797","updated":"2015-06-11 20:26:16.000000000","message":"This can be removed.  Done.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"7a47b65db7b623a13f64c83d012ac5e4f82f889f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    @domain_hash"},{"line_number":150,"context_line":"  end"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  def domain_hash"},{"line_number":153,"context_line":"    self.domain_hash"},{"line_number":154,"context_line":"  end"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_d8216f9f","line":152,"updated":"2015-06-11 08:03:47.000000000","message":"Same question here regarding the instance method in the context of bp/auth_restructure change.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"4d3d17d4c1de2e200da73ac23039ec344e11022f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    @domain_hash"},{"line_number":150,"context_line":"  end"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  def domain_hash"},{"line_number":153,"context_line":"    self.domain_hash"},{"line_number":154,"context_line":"  end"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_3fb969ed","line":152,"in_reply_to":"3afb71cf_d8216f9f","updated":"2015-06-11 20:26:16.000000000","message":"This can be removed.  Done.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"7a47b65db7b623a13f64c83d012ac5e4f82f889f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    domain_hash[id]"},{"line_number":158,"context_line":"  end"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  def domain_name_from_id(id)"},{"line_number":161,"context_line":"    self.class.domain_name_from_id(id)"},{"line_number":162,"context_line":"  end"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_b83d93c5","line":160,"updated":"2015-06-11 08:03:47.000000000","message":"Same question here regarding the instance method in the context of bp/auth_restructure change.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"4d3d17d4c1de2e200da73ac23039ec344e11022f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    domain_hash[id]"},{"line_number":158,"context_line":"  end"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  def domain_name_from_id(id)"},{"line_number":161,"context_line":"    self.class.domain_name_from_id(id)"},{"line_number":162,"context_line":"  end"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_dfb7f5f3","line":160,"in_reply_to":"3afb71cf_b83d93c5","updated":"2015-06-11 20:26:16.000000000","message":"This can be removed.  Done.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"7a47b65db7b623a13f64c83d012ac5e4f82f889f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @default_domain_id"},{"line_number":172,"context_line":"  end"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  def default_domain_id"},{"line_number":175,"context_line":"    self.class.default_domain_id"},{"line_number":176,"context_line":"  end"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_983897d4","line":174,"updated":"2015-06-11 08:03:47.000000000","message":"Same question here regarding the instance method in the context of bp/auth_restructure change.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"4d3d17d4c1de2e200da73ac23039ec344e11022f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @default_domain_id"},{"line_number":172,"context_line":"  end"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  def default_domain_id"},{"line_number":175,"context_line":"    self.class.default_domain_id"},{"line_number":176,"context_line":"  end"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_5fc4255e","line":174,"in_reply_to":"3afb71cf_983897d4","updated":"2015-06-11 20:26:16.000000000","message":"This can be removed.  Done.","commit_id":"a0d5d487a48e99d8301fbdde58d9da3358a9b412"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"4f8defc1c30300d948fe57b3c3b3804046097986","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @admin_endpoint ||\u003d get_admin_endpoint"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_50a183a8","line":34,"updated":"2015-06-15 00:53:42.000000000","message":"You previously said:  \n\n\"It\u0027s not strictly needed, but it provides a convenience (i.e. saves code) for provider subclass instances because it uses resource[:name] and resource[:domain] directly.\"\n\nI see what you mean. Can we make is class method instead because there is no need unless you have a use case for calling it only from object instances?","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f216a3c8b83845ef26f0a807f317f68eb7df2cc4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @admin_endpoint ||\u003d get_admin_endpoint"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_583bc8eb","line":34,"in_reply_to":"fa32b979_50a183a8","updated":"2015-06-15 17:52:10.000000000","message":"Done","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"4f8defc1c30300d948fe57b3c3b3804046097986","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"},{"line_number":38,"context_line":"    if resource[:domain].nil? \u0026\u0026 domain.nil?"},{"line_number":39,"context_line":"      # if we can\u0027t get the domain in any other way, look up the default_domain"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_50d3c338","line":36,"updated":"2015-06-15 00:53:42.000000000","message":"I think using Puppet::Provider::Keystone name space would be safer.","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f216a3c8b83845ef26f0a807f317f68eb7df2cc4","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"},{"line_number":38,"context_line":"    if resource[:domain].nil? \u0026\u0026 domain.nil?"},{"line_number":39,"context_line":"      # if we can\u0027t get the domain in any other way, look up the default_domain"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_b8a694bf","line":36,"in_reply_to":"fa32b979_50d3c338","updated":"2015-06-15 17:52:10.000000000","message":"Do you mean, make split_domain a class method of Puppet::Provider::Keystone?  I thought about that originally, but I thought this code might be useful outside of puppet-keystone.\nDo you mean, create Puppet::Provider::Keystone::Util?  I tried that, but I have to require \u0027puppet/provider/keystone\u0027 in util.rb, and require \u0027puppet/provider/keystone/util\u0027 in keystone.rb - ruby doesn\u0027t like this.\nCan you please tell me exactly what you mean, or possibly, just do it?","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6e2af86972a6f40e0e66ea11e56d8990f221c63b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # instance method - relies on the resource :name and :domain"},{"line_number":35,"context_line":"  def name_and_domain(name\u003dresource[:name])"},{"line_number":36,"context_line":"    unused_name, domain \u003d Util.split_domain(name)"},{"line_number":37,"context_line":"    domlist \u003d [resource[:domain], domain]"},{"line_number":38,"context_line":"    if resource[:domain].nil? \u0026\u0026 domain.nil?"},{"line_number":39,"context_line":"      # if we can\u0027t get the domain in any other way, look up the default_domain"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_e63d4bbc","line":36,"in_reply_to":"fa32b979_b8a694bf","updated":"2015-06-16 01:14:41.000000000","message":"Yes I meant Puppet::Provider::Keystone::Util and you\u0027re right about the \u0027loop\u0027 dependency.\n\nIf it\u0027s really that generic then that could move higher in the lib tree, puppet or puppetX but so far that\u0027s sort of attached to keystone.","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"d6a42240a1216929713657917e69de0449430f39","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"class Puppet::Provider::Keystone \u003c Puppet::Provider::Openstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  extend  Puppet::Provider::Openstack::Auth"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  INI_FILENAME \u003d \u0027/etc/keystone/keystone.conf\u0027"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"fa32b979_4fa46ba5","line":9,"updated":"2015-06-15 17:53:00.000000000","message":"I removed this extra space","commit_id":"6d9a03549caa395c335d7af8d8a0d8a36bedba96"}],"lib/puppet/provider/keystone/util.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"4f8defc1c30300d948fe57b3c3b3804046097986","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Util"},{"line_number":2,"context_line":"  # Given a string, return an array consisting of:"},{"line_number":3,"context_line":"  # [something, domainname]"},{"line_number":4,"context_line":"  # where domainname is everything after the rightmost domain delimiter"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_10abfb8a","line":1,"updated":"2015-06-15 00:53:42.000000000","message":"A Namespace within the provider would be better","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f216a3c8b83845ef26f0a807f317f68eb7df2cc4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Util"},{"line_number":2,"context_line":"  # Given a string, return an array consisting of:"},{"line_number":3,"context_line":"  # [something, domainname]"},{"line_number":4,"context_line":"  # where domainname is everything after the rightmost domain delimiter"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_d89fd85d","line":1,"in_reply_to":"fa32b979_10abfb8a","updated":"2015-06-15 17:52:10.000000000","message":"Please tell me exactly what you mean and exactly how it should be done.","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6e2af86972a6f40e0e66ea11e56d8990f221c63b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Util"},{"line_number":2,"context_line":"  # Given a string, return an array consisting of:"},{"line_number":3,"context_line":"  # [something, domainname]"},{"line_number":4,"context_line":"  # where domainname is everything after the rightmost domain delimiter"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_a65e6310","line":1,"in_reply_to":"fa32b979_d89fd85d","updated":"2015-06-16 01:14:41.000000000","message":"Never mind, the only way to do that would be to reopen the classes and that\u0027s overkill.","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"4f8defc1c30300d948fe57b3c3b3804046097986","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  # name_with_domain \u003d \"foo::bar::baz::\" -\u003e [\"foo::bar\", \"baz\"]"},{"line_number":22,"context_line":"  # domain name only"},{"line_number":23,"context_line":"  # name_with_domain \u003d \"::foo\" -\u003e [nil, \"foo\"]"},{"line_number":24,"context_line":"  # name_with_domain \u003d \"::foo::\" -\u003e [nil, \"foo\"]"},{"line_number":25,"context_line":"  def Util.split_domain(name_with_domain)"},{"line_number":26,"context_line":"    if name_with_domain.nil?"},{"line_number":27,"context_line":"      return [nil, nil]"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_f0921757","line":24,"updated":"2015-06-15 00:53:42.000000000","message":"The comment is helpful but it would be great if we could make it more concise.","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"4f8defc1c30300d948fe57b3c3b3804046097986","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      [ary[2], nil] # no delimiter - entire string is in ary[2]"},{"line_number":33,"context_line":"    else # delimiter found"},{"line_number":34,"context_line":"      [ary[0].empty? ? nil : ary[0], ary[2].empty? ? nil : ary[2]]"},{"line_number":35,"context_line":"    end"},{"line_number":36,"context_line":"  end"},{"line_number":37,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa32b979_f079b730","line":35,"updated":"2015-06-15 00:53:42.000000000","message":"I think we could refactor this a little bit to make it even more concise.","commit_id":"eb8e05ebbc264c4fa61033f0a77035fa74c09663"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"d6a42240a1216929713657917e69de0449430f39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Util"},{"line_number":2,"context_line":"  # Splits the rightmost part of a string using \u0027::\u0027 as delimiter"},{"line_number":3,"context_line":"\t# Returns an array of both parts or nil if either is empty."},{"line_number":4,"context_line":"\t# An empty rightmost part is ignored and converted as \u0027string::\u0027 \u003d\u003e \u0027string\u0027"},{"line_number":5,"context_line":"\t#"},{"line_number":6,"context_line":"  # Examples:"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"fa32b979_789ecc57","line":3,"updated":"2015-06-15 17:53:00.000000000","message":"The convention is to use 2 spaces for indentation, and no tabs.  I reindented","commit_id":"6d9a03549caa395c335d7af8d8a0d8a36bedba96"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"5ea35b0b9f8f96042e2fb06deb336ef07c98df2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Util"},{"line_number":2,"context_line":"  # Splits the rightmost part of a string using \u0027::\u0027 as delimiter"},{"line_number":3,"context_line":"\t# Returns an array of both parts or nil if either is empty."},{"line_number":4,"context_line":"\t# An empty rightmost part is ignored and converted as \u0027string::\u0027 \u003d\u003e \u0027string\u0027"},{"line_number":5,"context_line":"\t#"},{"line_number":6,"context_line":"  # Examples:"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"fa32b979_86e8ff11","line":3,"in_reply_to":"fa32b979_789ecc57","updated":"2015-06-16 01:17:27.000000000","message":"I need to check what my editor did with identation.\nThanks!","commit_id":"6d9a03549caa395c335d7af8d8a0d8a36bedba96"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"efa44b1ce1f62786dfadb783c4caaacbba0d79ad","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\t  left, right \u003d right, nil if delimiter.empty?"},{"line_number":21,"context_line":"\t  left \u003d nil if left.empty?"},{"line_number":22,"context_line":"\tend"},{"line_number":23,"context_line":"\treturn [left, right]"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"fa32b979_8a7c13ed","line":23,"updated":"2015-06-18 00:49:19.000000000","message":"Please use spaces not tabs","commit_id":"fd20bc57af0b36246506c21e128ceaccde85132f"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"b1c6c5b90befe16ffdb1161fbd3fcd51db260cb2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\t  left, right \u003d right, nil if delimiter.empty?"},{"line_number":21,"context_line":"\t  left \u003d nil if left.empty?"},{"line_number":22,"context_line":"\tend"},{"line_number":23,"context_line":"\treturn [left, right]"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"fa32b979_089bf918","line":23,"in_reply_to":"fa32b979_8a7c13ed","updated":"2015-06-18 22:51:56.000000000","message":"Done","commit_id":"fd20bc57af0b36246506c21e128ceaccde85132f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"efa44b1ce1f62786dfadb783c4caaacbba0d79ad","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\tend"},{"line_number":23,"context_line":"\treturn [left, right]"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"fa32b979_0a2a43db","line":25,"updated":"2015-06-18 00:49:19.000000000","message":"Seems to me like this is small enough it could just live in lib/puppet/provider/keystone.rb","commit_id":"fd20bc57af0b36246506c21e128ceaccde85132f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8f3960309d3c8e0a89ac520327071c772f8ef3e1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\tend"},{"line_number":23,"context_line":"\treturn [left, right]"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"fa32b979_0de1fd2c","line":25,"in_reply_to":"fa32b979_0a2a43db","updated":"2015-06-18 01:08:32.000000000","message":"Never mind, I see it\u0027s used in types in other patches","commit_id":"fd20bc57af0b36246506c21e128ceaccde85132f"}]}