)]}'
{"manifests/init.pp":[{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"bdf293f7bb4c7d49ee8e979abf7b9ffc2dec180e","unresolved":false,"context_lines":[{"line_number":349,"context_line":"#"},{"line_number":350,"context_line":"# [*enable_fernet_setup*]"},{"line_number":351,"context_line":"#   (Optional) Setup keystone for fernet tokens. This is typically only"},{"line_number":352,"context_line":"#   run on a single node, then they keys replicated to the other nodes"},{"line_number":353,"context_line":"#   in a cluster. You would typically also pair this with a fernet token"},{"line_number":354,"context_line":"#   provider setting."},{"line_number":355,"context_line":"#   Defaults to false"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a016987_f0bf8d5e","line":352,"updated":"2015-05-26 02:07:14.000000000","message":"nit, should be: \"then the keys are replicated\"","commit_id":"d49f38df6b91dc3acf6949fd035e89a647f14a97"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"bdf293f7bb4c7d49ee8e979abf7b9ffc2dec180e","unresolved":false,"context_lines":[{"line_number":465,"context_line":"  $public_workers         \u003d max($::processorcount, 2),"},{"line_number":466,"context_line":"  $sync_db                \u003d true,"},{"line_number":467,"context_line":"  $enable_fernet_setup    \u003d false,"},{"line_number":468,"context_line":"  $key_repository         \u003d \u0027/etc/keystone/fernet-keys\u0027,"},{"line_number":469,"context_line":"  $max_active_keys        \u003d undef,"},{"line_number":470,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":471,"context_line":"  $mysql_module           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a016987_8371317a","line":468,"updated":"2015-05-26 02:07:14.000000000","message":"Wonder if we want to default this to undef, rather than hard coding the keystone default here.  (We talked about this idea during design summit, but you may have been gone during that time.)\n\nI realize that even if it\u0027s undef here, the default value has to be hard coded below for the keystone-manage fernet_setup exec.  So this kind of just trades one problem for another.\n\nI don\u0027t have a strong preference either way here, but wanted to call it out.","commit_id":"d49f38df6b91dc3acf6949fd035e89a647f14a97"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"bdf293f7bb4c7d49ee8e979abf7b9ffc2dec180e","unresolved":false,"context_lines":[{"line_number":903,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":904,"context_line":"      creates     \u003d\u003e \"${key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":907,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":908,"context_line":"    }"},{"line_number":909,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a016987_c33f2986","line":906,"updated":"2015-05-26 02:07:14.000000000","message":"Don\u0027t you want to subscribe to Keystone_config[\u0027fernet_tokens/key_repository\u0027] here, too?  I.e. if keystone package is already installed, and you are just deploying a change which is enabling fernet tokens.\n\nIn that case, ${key_repository}/0 would not exist.  I don\u0027t think that situation is enough to get a refreshonly exec to run when not specifically triggered by a dependent resource.  Right?","commit_id":"d49f38df6b91dc3acf6949fd035e89a647f14a97"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"1ba224e69f5c92f5eb096c45d02fb9cbef24b378","unresolved":false,"context_lines":[{"line_number":349,"context_line":"#"},{"line_number":350,"context_line":"# [*enable_fernet_setup*]"},{"line_number":351,"context_line":"#   (Optional) Setup keystone for fernet tokens. This is typically only"},{"line_number":352,"context_line":"#   run on a single node, then they keys are replicated to the other nodes"},{"line_number":353,"context_line":"#   in a cluster. You would typically also pair this with a fernet token"},{"line_number":354,"context_line":"#   provider setting."},{"line_number":355,"context_line":"#   Defaults to false"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a016987_4168d187","line":352,"updated":"2015-05-26 04:37:31.000000000","message":"nit: change \"then they keys\" to \"then the keys\"  :)","commit_id":"d0711f5e7edb55c50ecb101189e4300b911aa6ba"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"77a4ebc750487ba205a3df3b0f9230fbe582965d","unresolved":false,"context_lines":[{"line_number":894,"context_line":"  }"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"  # Fernet tokens support"},{"line_number":897,"context_line":"  if $enable_fernet_setup {"},{"line_number":898,"context_line":"    validate_string($key_repository)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    exec { \u0027keystone-manage fernet_setup\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a016987_0162d9ad","line":897,"updated":"2015-05-26 04:34:20.000000000","message":"Do you also need to set keystone_config[token/provider] \u003d keystone.token.providers.fernet.Provider to enable fernet?","commit_id":"d0711f5e7edb55c50ecb101189e4300b911aa6ba"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"1ba224e69f5c92f5eb096c45d02fb9cbef24b378","unresolved":false,"context_lines":[{"line_number":903,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":904,"context_line":"      creates     \u003d\u003e \"${key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e [Package[\u0027keystone\u0027], Keystone_config[\u0027fernet_tokens/key_repository\u0027]]"},{"line_number":907,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":908,"context_line":"    }"},{"line_number":909,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a016987_2104b5c4","line":906,"updated":"2015-05-26 04:37:31.000000000","message":"need trailing comma, i assume this is why gate tests failed","commit_id":"d0711f5e7edb55c50ecb101189e4300b911aa6ba"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"234c3e001ce7ba5f6a4d921347a0ef0a089eac7a","unresolved":false,"context_lines":[{"line_number":465,"context_line":"  $public_workers         \u003d max($::processorcount, 2),"},{"line_number":466,"context_line":"  $sync_db                \u003d true,"},{"line_number":467,"context_line":"  $enable_fernet_setup    \u003d false,"},{"line_number":468,"context_line":"  $key_repository         \u003d \u0027/etc/keystone/fernet-keys\u0027,"},{"line_number":469,"context_line":"  $max_active_keys        \u003d undef,"},{"line_number":470,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":471,"context_line":"  $mysql_module           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a016987_6703c177","line":468,"updated":"2015-05-26 19:49:08.000000000","message":"I suggest we prefix those parameters with fernet_tokens_ to avoid possible future conflict.","commit_id":"5359cd832a3b253b9e620b377b25da58a18f0bd0"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1d5832e8205dfba1e49f44dedca7c44bcb1c381d","unresolved":false,"context_lines":[{"line_number":919,"context_line":"  }"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"  if $fernet_max_active_keys {"},{"line_number":922,"context_line":"    validate_integer($fernet_max_active_keys)"},{"line_number":923,"context_line":"    keystone_config {"},{"line_number":924,"context_line":"        \u0027fernet_tokens/max_active_keys\u0027:   value \u003d\u003e $fernet_max_active_keys;"},{"line_number":925,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a016987_a545d843","line":922,"updated":"2015-05-28 18:00:30.000000000","message":"validate_integer() was only added to stdlib in 4.6.0. This module depends on stdlib \u003e\u003d4.0.0.\n\nWe could achieve the same thing with if ! is_integer() { fail() }, or we could bump the required stdlib version. I think it would be better to attempt to be as compatible as possible by using is_integer().","commit_id":"14d6fc979318b9bbe7aa5b639ad60648381bfac3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a9797412e95252b836092925070aa9e20f5cdba","unresolved":false,"context_lines":[{"line_number":904,"context_line":"      creates     \u003d\u003e \"${fernet_key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e [Package[\u0027keystone\u0027], Keystone_config[\u0027fernet_tokens/key_repository\u0027]],"},{"line_number":907,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":908,"context_line":"    }"},{"line_number":909,"context_line":"  }"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_724a48c7","line":907,"updated":"2015-06-07 14:23:15.000000000","message":"At the summit we said we stop managing users/groups with Puppet.","commit_id":"960142ed7660deb324f6a0e329e0c5e85a9d20c7"}]}