)]}'
{"manifests/resource/service_identity.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"08427a9e868d7119a451c20ef2e7fe0819ddd737","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  if $configure_user {"},{"line_number":128,"context_line":"    if $password {"},{"line_number":129,"context_line":"      ensure_resource(\u0027keystone_user\u0027, $auth_name, {"},{"line_number":130,"context_line":"        \u0027ensure\u0027                \u003d\u003e \u0027present\u0027,"},{"line_number":131,"context_line":"        \u0027enabled\u0027               \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa32b979_098cbf7d","line":128,"updated":"2015-06-17 08:45:12.000000000","message":"LGTM, but shouldn\u0027t the \u0027validatestring\u0027 do the same as well in a bit shorter way?","commit_id":"cb1156cd2dd27aee171ffdbc5719d45b56bb803f"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a3c665a1bbcce4536e5ca0c2c03cb4de67409132","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \u0027ignore_default_tenant\u0027 \u003d\u003e $ignore_default_tenant,"},{"line_number":136,"context_line":"      })"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      fail (\u0027When configuring an user, you need to set the password parameter.\u0027)"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_62bdafd6","line":138,"updated":"2015-07-07 02:22:45.000000000","message":"I don\u0027t think we should enforce this, I\u0027m okay with a warning though. Keystone itself does not enforce this and I\u0027ve created users before without passwords.","commit_id":"cb1156cd2dd27aee171ffdbc5719d45b56bb803f"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a3c665a1bbcce4536e5ca0c2c03cb4de67409132","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \u0027internal_url\u0027 \u003d\u003e $internal_url,"},{"line_number":171,"context_line":"      })"},{"line_number":172,"context_line":"    } else {"},{"line_number":173,"context_line":"      fail (\u0027When configuring an endpoint, you need to set the _url parameters.\u0027)"},{"line_number":174,"context_line":"    }"},{"line_number":175,"context_line":"  }"},{"line_number":176,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_82c8f375","line":173,"updated":"2015-07-07 02:22:45.000000000","message":"*_url maybe?\n\nAlso again Keystone does not enforce this so a warning makes more sense. It looks like only a public_url is required.","commit_id":"cb1156cd2dd27aee171ffdbc5719d45b56bb803f"}],"spec/defines/keystone_resource_service_identity_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9fb9b4f32e3b91b31ab87ce8ae441698676be81a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    context \u0027when trying to create an user without password\u0027 do"},{"line_number":66,"context_line":"      before :each do"},{"line_number":67,"context_line":"        params.merge!(:password \u003d\u003e false)"},{"line_number":68,"context_line":"      end"},{"line_number":69,"context_line":"      it_raises \u0027a Puppet::Error\u0027, /When configuring an user, you need to set the password parameter/"},{"line_number":70,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3afb71cf_e48ba4c1","line":67,"updated":"2015-06-10 04:55:03.000000000","message":"I think this should look like this instead:\n\n let :params do\n   required_params.delete(:password)\n   required_params\n end\n\nReturning required_params at the end makes this work the way it was supposed to before. Doing it this way makes the edits on lines 24 and 35-36 unnecessary I think.","commit_id":"b36e062b9de564b9b2bc8e6b749529cb9ff67aab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"307b920d2cf41b032c488c3b546b3c1979f5a21c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    context \u0027when trying to create an user without password\u0027 do"},{"line_number":66,"context_line":"      before :each do"},{"line_number":67,"context_line":"        params.merge!(:password \u003d\u003e false)"},{"line_number":68,"context_line":"      end"},{"line_number":69,"context_line":"      it_raises \u0027a Puppet::Error\u0027, /When configuring an user, you need to set the password parameter/"},{"line_number":70,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3afb71cf_d12e16fa","line":67,"in_reply_to":"3afb71cf_e48ba4c1","updated":"2015-06-10 12:26:56.000000000","message":"Done","commit_id":"b36e062b9de564b9b2bc8e6b749529cb9ff67aab"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9fb9b4f32e3b91b31ab87ce8ae441698676be81a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      before :each do"},{"line_number":67,"context_line":"        params.merge!(:password \u003d\u003e false)"},{"line_number":68,"context_line":"      end"},{"line_number":69,"context_line":"      it_raises \u0027a Puppet::Error\u0027, /When configuring an user, you need to set the password parameter/"},{"line_number":70,"context_line":"    end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    context \u0027when trying to create a service without service_type\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3afb71cf_24b41c80","line":69,"updated":"2015-06-10 04:55:03.000000000","message":"++","commit_id":"b36e062b9de564b9b2bc8e6b749529cb9ff67aab"}]}