)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"4896bb91e84b1cd9df951cec2d708005ddbeb799","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Kilo oslo.messaging added heartbeating support for RabbitMQ"},{"line_number":10,"context_line":"connections.  This patch adds support for this in Puppet modules"},{"line_number":11,"context_line":"by managing the oslo_messaging_rabbit/heartbeat_timeout_theshold"},{"line_number":12,"context_line":"and oslo_messaging_rabbit/heartbeat_rate settings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, update all rabbit-related parameters to move to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_36f4a985","line":11,"updated":"2015-06-23 03:21:03.000000000","message":"typo on last word","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"61dea217b2d655fb482841e0c2425b12076aaae3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Kilo oslo.messaging added heartbeating support for RabbitMQ"},{"line_number":10,"context_line":"connections.  This patch adds support for this in Puppet modules"},{"line_number":11,"context_line":"by managing the oslo_messaging_rabbit/heartbeat_timeout_theshold"},{"line_number":12,"context_line":"and oslo_messaging_rabbit/heartbeat_rate settings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, update all rabbit-related parameters to move to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_60c9d558","line":11,"in_reply_to":"fa32b979_36f4a985","updated":"2015-06-23 22:13:26.000000000","message":"Done","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"3c26d39b86726a1b26b8d48a8ec7a39e8cf4435e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Kilo oslo.messaging added heartbeating support for RabbitMQ"},{"line_number":10,"context_line":"connections.  This patch adds support for this in Puppet modules"},{"line_number":11,"context_line":"by managing the oslo_messaging_rabbit/heartbeat_timeout_theshold"},{"line_number":12,"context_line":"and oslo_messaging_rabbit/heartbeat_rate settings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, update all rabbit-related parameters to move to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_ecc5f78d","line":11,"in_reply_to":"fa32b979_36f4a985","updated":"2015-06-23 14:22:31.000000000","message":"I will fix.  Need to fix this on all other reviews, too, since it was a copy/paste.","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"}],"manifests/init.pp":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"4896bb91e84b1cd9df951cec2d708005ddbeb799","unresolved":false,"context_lines":[{"line_number":186,"context_line":"#   (optional) Number of seconds after which the RabbitMQ broker is considered"},{"line_number":187,"context_line":"#   down if the heartbeat keepalive fails.  Any value \u003e0 enables heartbeats."},{"line_number":188,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":189,"context_line":"#   Defaults to 0"},{"line_number":190,"context_line":"#"},{"line_number":191,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":192,"context_line":"#   (optional) How often during rabbit_heartbeat_timeout_threshold to check."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_16f96580","line":189,"updated":"2015-06-23 03:21:03.000000000","message":"keystone defaults to 60, so why pick 0 is that just so it\u0027s disabled? What happens when someone enables this without the pre-requisite modules?","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"3c26d39b86726a1b26b8d48a8ec7a39e8cf4435e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"#   (optional) Number of seconds after which the RabbitMQ broker is considered"},{"line_number":187,"context_line":"#   down if the heartbeat keepalive fails.  Any value \u003e0 enables heartbeats."},{"line_number":188,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":189,"context_line":"#   Defaults to 0"},{"line_number":190,"context_line":"#"},{"line_number":191,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":192,"context_line":"#   (optional) How often during rabbit_heartbeat_timeout_threshold to check."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_2ca8bf8b","line":189,"in_reply_to":"fa32b979_16f96580","updated":"2015-06-23 14:22:31.000000000","message":"I was going off the current default from oslo.messaging.  The default changed from 60 to 0 in oslo.messaging 1.11.0.  Requirements.txt for Keystone 2015.1.0 has oslo.messaging\u003e\u003d1.8.0 ... so not exactly sure the best way to deal with this.\n\nI would argue we should make the Puppet default 0, since that\u0027s what it \"should\" be going forward.  However, I see your point for people running oslo.messaging \u003e\u003d 1.8.0 but \u003c 1.11.0, they would end up getting this feature disabled when they had always been getting it automatically before.  Maybe we can talk about this on the meeting today.","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"4896bb91e84b1cd9df951cec2d708005ddbeb799","unresolved":false,"context_lines":[{"line_number":191,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":192,"context_line":"#   (optional) How often during rabbit_heartbeat_timeout_threshold to check."},{"line_number":193,"context_line":"#   the heartbeat on RabbitMQ connection."},{"line_number":194,"context_line":"#   Defaults to 2"},{"line_number":195,"context_line":"#"},{"line_number":196,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":197,"context_line":"#   (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_9604957e","line":194,"updated":"2015-06-23 03:21:03.000000000","message":"whats the unit here?","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"61dea217b2d655fb482841e0c2425b12076aaae3","unresolved":false,"context_lines":[{"line_number":191,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":192,"context_line":"#   (optional) How often during rabbit_heartbeat_timeout_threshold to check."},{"line_number":193,"context_line":"#   the heartbeat on RabbitMQ connection."},{"line_number":194,"context_line":"#   Defaults to 2"},{"line_number":195,"context_line":"#"},{"line_number":196,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":197,"context_line":"#   (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_c005417a","line":194,"in_reply_to":"fa32b979_9604957e","updated":"2015-06-23 22:13:26.000000000","message":"Done","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"3c26d39b86726a1b26b8d48a8ec7a39e8cf4435e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":192,"context_line":"#   (optional) How often during rabbit_heartbeat_timeout_threshold to check."},{"line_number":193,"context_line":"#   the heartbeat on RabbitMQ connection."},{"line_number":194,"context_line":"#   Defaults to 2"},{"line_number":195,"context_line":"#"},{"line_number":196,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":197,"context_line":"#   (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_8cbc6bbc","line":194,"in_reply_to":"fa32b979_9604957e","updated":"2015-06-23 14:22:31.000000000","message":"It\u0027s \"times per the rabbit_heartbeat_timeout_threshold period\", so there are no units.  I can probably rephrase this to make more sense (plus I have an extra period.)  IIRC this was just a copy/paste from the oslo.messaging config reference.","commit_id":"7e38fdc1381c1e1165941070b4a7b25b711caa87"}]}