)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d027214bce35ceff18544b31a0f833f72968248d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rakefile: get logs in jenkins workspace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If WORKSPACE environment variable is set (usually when running a job"},{"line_number":10,"context_line":"with Jenkins), copy the logs in the job workspace so at the end of the"},{"line_number":11,"context_line":"job, we can use the logs to debug functional testing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54550cbce7eb1eb0189e29481649aeb2525c8130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3a50d1a3_45e57935","line":10,"updated":"2015-07-29 15:16:29.000000000","message":"This copy won\u0027t happen automatically, another line in the beaker job will have to be added to run this task.","commit_id":"60a1ec9dfccc42ef829bf179d66ba568409ef6ec"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"93ff5b7a05ab176cc0baa6a91ddbdd67de7395b7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"need to make sure WORKSPACE is set (automatically done when running the"},{"line_number":14,"context_line":"job on a Jenkins node). This task will copy the Keystone logs in the workspace."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To run the task, you need to run `rake -T copy_logs` which is what"},{"line_number":17,"context_line":"OpenStack Infra is doing."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I54550cbce7eb1eb0189e29481649aeb2525c8130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3a50d1a3_83bdb9b2","line":16,"updated":"2015-07-29 15:53:09.000000000","message":"I don\u0027t think you need -T. From `rake --help`:\n\n -T, --tasks [PATTERN]            Display the tasks (matching optional PATTERN) with descriptions, then exit.","commit_id":"2016ec9ff395f67e4745fc37565cae09753dff6b"}],"Rakefile":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"a3ecb6b87aa4da0b69ec98eaf904b4615a0f5660","unresolved":false,"context_lines":[{"line_number":7,"context_line":"PuppetLint.configuration.send(\u0027disable_class_inherits_from_params_class\u0027)"},{"line_number":8,"context_line":"PuppetLint.configuration.send(\u0027disable_class_parameter_defaults\u0027)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if ENV[\u0027WORKSPACE\u0027]"},{"line_number":11,"context_line":"  desc \u0027Copy useful logs to Jenkins workspace\u0027"},{"line_number":12,"context_line":"  task :copy_logs do"},{"line_number":13,"context_line":"    ws_log_dir \u003d ENV[\u0027WORKSPACE\u0027] + \u0027/logs\u0027"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"3a50d1a3_854716bb","line":10,"updated":"2015-07-29 08:35:09.000000000","message":"Rather than conditionally defining the task based on an environment variable, it could be defined always and throw an error in the task body if the env variable is undefined. Not a blocker though. +1","commit_id":"60a1ec9dfccc42ef829bf179d66ba568409ef6ec"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d027214bce35ceff18544b31a0f833f72968248d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"PuppetLint.configuration.send(\u0027disable_class_inherits_from_params_class\u0027)"},{"line_number":8,"context_line":"PuppetLint.configuration.send(\u0027disable_class_parameter_defaults\u0027)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if ENV[\u0027WORKSPACE\u0027]"},{"line_number":11,"context_line":"  desc \u0027Copy useful logs to Jenkins workspace\u0027"},{"line_number":12,"context_line":"  task :copy_logs do"},{"line_number":13,"context_line":"    ws_log_dir \u003d ENV[\u0027WORKSPACE\u0027] + \u0027/logs\u0027"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"3a50d1a3_4549f95e","line":10,"in_reply_to":"3a50d1a3_854716bb","updated":"2015-07-29 15:16:29.000000000","message":"Agreed, this should be part of the task","commit_id":"60a1ec9dfccc42ef829bf179d66ba568409ef6ec"}],"spec/acceptance/basic_keystone_spec.rb":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e188ab69270087ca779a4c56a3e803a49dbbda21","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    end"},{"line_number":223,"context_line":"  end"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"  describe \u0027Copy configuration files \u0026 logs in Jenkins workspace\u0027 do"},{"line_number":226,"context_line":"    it \u0027copy keystone.conf and keystone logs\u0027 do"},{"line_number":227,"context_line":"      # Prepare logs directory if acceptance is running"},{"line_number":228,"context_line":"      unless ENV[\u0027WORKSPACE\u0027].empty?"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a41bdd9_042594bf","line":225,"updated":"2015-07-14 15:48:58.000000000","message":"Would it be better to have log uploads done by some script or a rake task than have it directly in the tests? The rake task or script could then be called from the CI job script:\n\nhttps://github.com/openstack-infra/project-config/blob/5ca30292d22328cc56d28462c586fd163bf4306a/jenkins/jobs/puppet-module-jobs.yaml#L54","commit_id":"d3f996ae04e1c9566947a8256db81aba7551bde9"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"9d26f954206156b263e5044bdab48bbac9334ba2","unresolved":false,"context_lines":[{"line_number":228,"context_line":"      unless ENV[\u0027WORKSPACE\u0027].empty?"},{"line_number":229,"context_line":"        workspace_dir \u003d ENV[\u0027WORKSPACE\u0027]"},{"line_number":230,"context_line":"        shell(\"mkdir -p #{workspace_dir}/logs\")"},{"line_number":231,"context_line":"        shell(\"cp /var/log/keystone/* #{workspace_dir}/logs\")"},{"line_number":232,"context_line":"      end"},{"line_number":233,"context_line":"    end"},{"line_number":234,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"9a41bdd9_1d77593b","line":231,"updated":"2015-07-13 17:58:20.000000000","message":"What about the following to keep the folder structure?  This way, we don\u0027t overwrite any dupe filenames.  Not an issue for a single copy, but thinking of moving forward\n\ncp --parents /var/log/keystone/* #{workspace_dir}/logs","commit_id":"d3f996ae04e1c9566947a8256db81aba7551bde9"}],"spec/acceptance/keystone_wsgi_apache_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3454757bb042f9b26068485a187d5e4acb691dd4","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        shell(\"cp /var/log/keystone/* #{workspace_dir}/logs_wsgi\")"},{"line_number":239,"context_line":"      end"},{"line_number":240,"context_line":"    end"},{"line_number":241,"context_line":"  end"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3a50d1a3_cc27df10","line":241,"updated":"2015-07-27 18:46:57.000000000","message":"Should we maybe copy /var/log/{apache2,httpd} for this one too?","commit_id":"00481c1492a1ac2391e7fb9c03757c3da3faa77a"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"52444ca8826dadbb588b90bbead3b5ec7460f604","unresolved":false,"context_lines":[{"line_number":240,"context_line":"      unless ENV[\u0027WORKSPACE\u0027].empty?"},{"line_number":241,"context_line":"        workspace_dir \u003d ENV[\u0027WORKSPACE\u0027]"},{"line_number":242,"context_line":"        shell(\"mkdir -p #{workspace_dir}/logs/wsgi\")"},{"line_number":243,"context_line":"        shell(\"cp /var/log/#{httpd_service}/* #{workspace_dir}/logs/wsgi\")"},{"line_number":244,"context_line":"      end"},{"line_number":245,"context_line":"    end"},{"line_number":246,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"3a50d1a3_8088b672","line":243,"updated":"2015-07-27 20:03:56.000000000","message":"There is also a /var/log/keystone/keystone.log (at least on RH platforms) even if using wsgi.","commit_id":"7cd569b60affe329f8726f79c858e6b0d77ade2b"}]}