)]}'
{"manifests/init.pp":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"36c6622b062b0fd3ae7b2ccf1f0285c67c835fb8","unresolved":false,"context_lines":[{"line_number":699,"context_line":"      \u0027token/cache_time\u0027:           value \u003d\u003e $token_cache_time;"},{"line_number":700,"context_line":"      \u0027revoke/caching\u0027:             value \u003d\u003e $revoke_caching;"},{"line_number":701,"context_line":"      \u0027revoke/cache_time\u0027:          value \u003d\u003e $revoke_cache_time;"},{"line_number":702,"context_line":"      # these both have to be set for some reason"},{"line_number":703,"context_line":"      \u0027memcache/servers\u0027:           value \u003d\u003e join($memcache_servers, \u0027,\u0027);"},{"line_number":704,"context_line":"      \u0027cache/memcache_servers\u0027:     value \u003d\u003e join($memcache_servers, \u0027,\u0027);"},{"line_number":705,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_f56445e6","line":702,"updated":"2015-07-24 08:27:55.000000000","message":"surely we can say something better than \"for some reason\" ?","commit_id":"743a85a12b0af8698418ec16b8cf3664d1df50ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e48caa28afbed557c6d71aef3ef5c731831788fa","unresolved":false,"context_lines":[{"line_number":700,"context_line":"      \u0027revoke/caching\u0027:             value \u003d\u003e $revoke_caching;"},{"line_number":701,"context_line":"      \u0027revoke/cache_time\u0027:          value \u003d\u003e $revoke_cache_time;"},{"line_number":702,"context_line":"      # these both have to be set for some reason"},{"line_number":703,"context_line":"      \u0027memcache/servers\u0027:           value \u003d\u003e join($memcache_servers, \u0027,\u0027);"},{"line_number":704,"context_line":"      \u0027cache/memcache_servers\u0027:     value \u003d\u003e join($memcache_servers, \u0027,\u0027);"},{"line_number":705,"context_line":"    }"},{"line_number":706,"context_line":"    if $cache_backend_argument {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_a1578358","line":703,"updated":"2015-07-29 19:43:50.000000000","message":"This one seems left from IceHouse http://docs.openstack.org/icehouse/config-reference/content/keystone-conf-changes-icehouse.html\n and probably is either deprecated by or \"enhanced\" by\nthe cache/memcache_servers (only for specific backends).\n\nI believe the latter one, so please update the comment.","commit_id":"743a85a12b0af8698418ec16b8cf3664d1df50ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0ef9b0fee32eee4ef4c8f2b776776d8eabe0f256","unresolved":false,"context_lines":[{"line_number":701,"context_line":"      \u0027revoke/cache_time\u0027:          value \u003d\u003e $revoke_cache_time;"},{"line_number":702,"context_line":"      # these both have to be set for some reason"},{"line_number":703,"context_line":"      \u0027memcache/servers\u0027:           value \u003d\u003e join($memcache_servers, \u0027,\u0027);"},{"line_number":704,"context_line":"      \u0027cache/memcache_servers\u0027:     value \u003d\u003e join($memcache_servers, \u0027,\u0027);"},{"line_number":705,"context_line":"    }"},{"line_number":706,"context_line":"    if $cache_backend_argument {"},{"line_number":707,"context_line":"      validate_array($cache_backend_argument)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_4198ff74","line":704,"updated":"2015-07-29 19:38:07.000000000","message":"Although this looks not related to the patch scope, according to http://docs.openstack.org/juno/config-reference/content/keystone-conf-changes-juno.html this only should be used with the dogpile.cache.memcache and keystone.cache.memcache_pool backends. And there is no mention for the [memcache] servers at all which makes the situation even more misterious.","commit_id":"743a85a12b0af8698418ec16b8cf3664d1df50ac"}]}