)]}'
{"manifests/roles/admin.pp":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"a653925ac8439caff7e5d300a24dcc61a3ba4322","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      keystone_domain { $admin_project_domain:"},{"line_number":109,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":110,"context_line":"        enabled \u003d\u003e true,"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":"  }"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_6db36c0b","line":111,"updated":"2015-07-24 20:46:45.000000000","message":"I think the code should look like this::\n\n  if $service_project_domain {\n    keystone_domain { $service_project_domain:\n      ensure  \u003d\u003e present,\n      enabled \u003d\u003e true,\n    }\n  }\n\n  if $admin_project_domain {\n    if $service_project_domain !\u003d $admin_project_domain {\n      keystone_domain { $admin_project_domain:\n        ensure  \u003d\u003e present,\n        enabled \u003d\u003e true,\n      }\n    }\n  }\n\n  if $admin_user_domain {\n    if $admin_project_domain !\u003d $admin_user_domain {\n      if $service_project_domain !\u003d $admin_user_domain {\n        keystone_domain { $admin_user_domain:\n          ensure  \u003d\u003e present,\n          enabled \u003d\u003e true,\n        }\n      }\n    }\n  }","commit_id":"6f41572770b63efc13918246b6add109b1872ae7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"77e44103493bde20f59fbdd331224c88567c7c0f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  if $admin_project_domain {"},{"line_number":103,"context_line":"    if $service_project_domain !\u003d $admin_project_domain {"},{"line_number":104,"context_line":"      keystone_domain { $admin_project_domain:"},{"line_number":105,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":106,"context_line":"        enabled \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_a30423c6","line":103,"updated":"2015-07-24 21:51:04.000000000","message":"Could these just be simplified (all three instances) by checking the existance of the keystone_domain in the catalog already?  For example:\n\n if !defined(Keystone_domain[$admin_project_domain]) { ... }","commit_id":"49132817dfbdb2017b6ce6717cbf2ea371d78693"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"34305b741e303a4ba447ef694b290298262458c8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  if $admin_project_domain {"},{"line_number":103,"context_line":"    if $service_project_domain !\u003d $admin_project_domain {"},{"line_number":104,"context_line":"      keystone_domain { $admin_project_domain:"},{"line_number":105,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":106,"context_line":"        enabled \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_c38ccf37","line":103,"in_reply_to":"3a50d1a3_a30423c6","updated":"2015-07-24 21:55:21.000000000","message":"Alternatively...\n\n  $domains \u003d delete_undef_values([ $admin_user_domain, $admin_project_domain, $service_project_domain])\n\n  keystone_domain { $domains:\n    ensure \u003d\u003e present,\n    enabled \u003d\u003e true,\n  }\n\nand do away with the if\u0027s all together.","commit_id":"49132817dfbdb2017b6ce6717cbf2ea371d78693"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fb3bc8624191e3a7bdae67400103e90eb1a37bbe","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  if $admin_project_domain {"},{"line_number":103,"context_line":"    if $service_project_domain !\u003d $admin_project_domain {"},{"line_number":104,"context_line":"      keystone_domain { $admin_project_domain:"},{"line_number":105,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":106,"context_line":"        enabled \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_0373974e","line":103,"in_reply_to":"3a50d1a3_a30423c6","updated":"2015-07-24 21:55:15.000000000","message":"I thought using defined() was considered harmful^H^H^H^H^H^H^H not best practices.","commit_id":"49132817dfbdb2017b6ce6717cbf2ea371d78693"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87b6ba6c8609c8ef22986e2c84cb852bfa64007a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  if $admin_project_domain {"},{"line_number":103,"context_line":"    if $service_project_domain !\u003d $admin_project_domain {"},{"line_number":104,"context_line":"      keystone_domain { $admin_project_domain:"},{"line_number":105,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":106,"context_line":"        enabled \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_c3f28f6f","line":103,"in_reply_to":"3a50d1a3_c38ccf37","updated":"2015-07-24 22:03:38.000000000","message":"Might need a unique thing in there. I think stdlib has one but I could be wrong. If not I think there is a better way than a bunch of if clauses","commit_id":"49132817dfbdb2017b6ce6717cbf2ea371d78693"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"7c92c2ee2d65c23c868dbca0d3e78d871b3ff046","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  if $admin_project_domain {"},{"line_number":103,"context_line":"    if $service_project_domain !\u003d $admin_project_domain {"},{"line_number":104,"context_line":"      keystone_domain { $admin_project_domain:"},{"line_number":105,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":106,"context_line":"        enabled \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_63fdbb6d","line":103,"in_reply_to":"3a50d1a3_c38ccf37","updated":"2015-07-24 21:57:41.000000000","message":"excellent +1","commit_id":"49132817dfbdb2017b6ce6717cbf2ea371d78693"}]}