)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f1b74ed871132b90dc8f0bfb75ea02be17acf73","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for Keystone as Identity Provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implemts the class to configure Keystone"},{"line_number":10,"context_line":"as an Identity Provider for (K2K Federation)"},{"line_number":11,"context_line":"-Install required packages"},{"line_number":12,"context_line":"-Configure keystone.conf file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9a1a9d01_8a6dae34","line":9,"updated":"2015-09-24 18:34:06.000000000","message":"implements","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b5bd3916e70a95cf5004ef061266a6ae5da1d8dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for Keystone as Identity Provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implemts the class to configure Keystone"},{"line_number":10,"context_line":"as an Identity Provider for (K2K Federation)"},{"line_number":11,"context_line":"-Install required packages"},{"line_number":12,"context_line":"-Configure keystone.conf file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9a1a9d01_a5e4650d","line":9,"in_reply_to":"9a1a9d01_8a6dae34","updated":"2015-09-24 18:49:16.000000000","message":"Done","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"}],"manifests/federation/identity_provider.pp":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"228820d2b8f4e50e4bb94bd54e08ad84a68b2b13","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    ensure \u003d\u003e present"},{"line_number":105,"context_line":"  })"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  "},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  keystone_config {"},{"line_number":110,"context_line":"    \u0027saml/certfile\u0027:                      value \u003d\u003e $certfile;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_2e2a71e8","line":107,"updated":"2015-08-21 23:36:23.000000000","message":"whitespace","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c4821d30f402d82acb98ee8bceb4280429b770a2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    ensure \u003d\u003e present"},{"line_number":105,"context_line":"  })"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  "},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  keystone_config {"},{"line_number":110,"context_line":"    \u0027saml/certfile\u0027:                      value \u003d\u003e $certfile;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_b1aee4e5","line":107,"in_reply_to":"fa1b9901_2e2a71e8","updated":"2015-08-21 23:57:29.000000000","message":"I have seen now the comments i\u0027ll send other patch with some changes.","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"228820d2b8f4e50e4bb94bd54e08ad84a68b2b13","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \u0027saml/idp_contact_telephone\u0027:         value \u003d\u003e $idp_contact_telephone;"},{"line_number":123,"context_line":"  }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  if ! ($idp_contact_type in [\"technical\", \"support\",\"administrative\",\"billing\",\"other\"]) and $idp_contact_type {"},{"line_number":126,"context_line":"    fail(\u0027Allowed values for idp_contact_type are: technical, support, administrative, billing and other\u0027)"},{"line_number":127,"context_line":"  } else{"},{"line_number":128,"context_line":"    keystone_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_ae3e8127","line":125,"updated":"2015-08-21 23:36:23.000000000","message":"I think you should test the $idp_contact_type first before seeing if it is in the array.","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c4821d30f402d82acb98ee8bceb4280429b770a2","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \u0027saml/idp_contact_telephone\u0027:         value \u003d\u003e $idp_contact_telephone;"},{"line_number":123,"context_line":"  }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  if ! ($idp_contact_type in [\"technical\", \"support\",\"administrative\",\"billing\",\"other\"]) and $idp_contact_type {"},{"line_number":126,"context_line":"    fail(\u0027Allowed values for idp_contact_type are: technical, support, administrative, billing and other\u0027)"},{"line_number":127,"context_line":"  } else{"},{"line_number":128,"context_line":"    keystone_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_f17a1c77","line":125,"in_reply_to":"fa1b9901_ae3e8127","updated":"2015-08-21 23:57:29.000000000","message":"You mean $idp_contact_type and !($idp_contact_type in [\"technical\", \"support\",\"administrative\",\"billing\",\"other\"])","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"92c698b77389ac66fd6aeccf93d4a624f5fcfc4f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \u0027saml/idp_contact_telephone\u0027:         value \u003d\u003e $idp_contact_telephone;"},{"line_number":123,"context_line":"  }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  if ! ($idp_contact_type in [\"technical\", \"support\",\"administrative\",\"billing\",\"other\"]) and $idp_contact_type {"},{"line_number":126,"context_line":"    fail(\u0027Allowed values for idp_contact_type are: technical, support, administrative, billing and other\u0027)"},{"line_number":127,"context_line":"  } else{"},{"line_number":128,"context_line":"    keystone_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_b1afc42a","line":125,"in_reply_to":"fa1b9901_f17a1c77","updated":"2015-08-22 00:23:18.000000000","message":"yes","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"228820d2b8f4e50e4bb94bd54e08ad84a68b2b13","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  exec { \u0027keystone-manage saml_idp_metada\u0027:"},{"line_number":135,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":136,"context_line":"      user        \u003d\u003e \u0027keystone\u0027,"},{"line_number":137,"context_line":"      command     \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_6e4869cd","line":134,"updated":"2015-08-21 23:36:23.000000000","message":"saml_idp_metadata","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c4821d30f402d82acb98ee8bceb4280429b770a2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  exec { \u0027keystone-manage saml_idp_metada\u0027:"},{"line_number":135,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":136,"context_line":"      user        \u003d\u003e \u0027keystone\u0027,"},{"line_number":137,"context_line":"      command     \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_1180f045","line":134,"in_reply_to":"fa1b9901_6e4869cd","updated":"2015-08-21 23:57:29.000000000","message":"Done","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"228820d2b8f4e50e4bb94bd54e08ad84a68b2b13","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      creates     \u003d\u003e $idp_metadata_path,"},{"line_number":140,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":141,"context_line":"      subscribe   \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":142,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_ae25210b","line":142,"updated":"2015-08-21 23:36:23.000000000","message":"This will run every time.  You should have an unless or onlyif so that the exec will only run for a certain condition e.g. the metadata file is missing.","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"92c698b77389ac66fd6aeccf93d4a624f5fcfc4f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      creates     \u003d\u003e $idp_metadata_path,"},{"line_number":140,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":141,"context_line":"      subscribe   \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":142,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_f1421c68","line":142,"in_reply_to":"fa1b9901_11f790f6","updated":"2015-08-22 00:23:18.000000000","message":"http://docs.puppetlabs.com/references/3.8.latest/type.html#exec\n\nuse creates or onlyif or unless","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c4821d30f402d82acb98ee8bceb4280429b770a2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      creates     \u003d\u003e $idp_metadata_path,"},{"line_number":140,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":141,"context_line":"      subscribe   \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":142,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_11f790f6","line":142,"in_reply_to":"fa1b9901_ae25210b","updated":"2015-08-21 23:57:29.000000000","message":"I\u0027ll search about this and try to make it work, for now i\u0027ll let this way but I\u0027ll keep in mind \u003dD","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"72d282e6740405c78468d2edd10925b0ad0cd117","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      creates     \u003d\u003e $idp_metadata_path,"},{"line_number":140,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":141,"context_line":"      subscribe   \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":142,"context_line":"      require     \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_3cd4eb45","line":142,"in_reply_to":"fa1b9901_f1421c68","updated":"2015-08-22 00:33:42.000000000","message":"Thanks ^^","commit_id":"cc22a981d5cfeaacc6d4163634d178c5448f91ef"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"8627d722d931995f248844a5ed7f4ed32b12ca33","unresolved":false,"context_lines":[{"line_number":128,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":129,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":130,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":131,"context_line":"      onlyif    \u003d\u003e \"test -f ${idp_metadata_path}\","},{"line_number":132,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":133,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":134,"context_line":"      require   \u003d\u003e User[\u0027keystone\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da20952f_1179d7fc","line":131,"updated":"2015-08-26 20:21:58.000000000","message":"I\u0027m sorry.  The original version with only the `creates` is ok.  That means the exec will only run if `$idp_metadata_path` does not exist, which is what you want.  You can remove the `onlyif`.","commit_id":"69b1233efa8ffcf6ec5986f6bcfd8e606131ee19"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fca16b85e36de3515a81162ba6032f2fa24ba9e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*certfile*]"},{"line_number":6,"context_line":"#   Path of the certfile for SAML signing.The path cannot contain a comma."},{"line_number":7,"context_line":"#   (Required) Defaults to $::keystone::ssl_ca_certs value. (string value)"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# [*keyfile*]"},{"line_number":10,"context_line":"#   Path of the keyfile for SAML signing. The path cannot contain a comma."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da20952f_23f7b1f6","line":7,"updated":"2015-08-27 19:46:29.000000000","message":"minor: Isn\u0027t (required) or (optional) usually before the first line for parameters?","commit_id":"7a908eec13ccfd8000c6cc486fe0955c471cf596"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"99549f6761f5f38e14aa36d9fe5fea79cbe10098","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*certfile*]"},{"line_number":6,"context_line":"#   Path of the certfile for SAML signing.The path cannot contain a comma."},{"line_number":7,"context_line":"#   (Required) Defaults to $::keystone::ssl_ca_certs value. (string value)"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# [*keyfile*]"},{"line_number":10,"context_line":"#   Path of the keyfile for SAML signing. The path cannot contain a comma."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da20952f_7eba20c2","line":7,"in_reply_to":"da20952f_23f7b1f6","updated":"2015-08-27 19:59:06.000000000","message":"Hi Alex , thanks for your review.\nI\u0027ll change in the next patchset.","commit_id":"7a908eec13ccfd8000c6cc486fe0955c471cf596"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fca16b85e36de3515a81162ba6032f2fa24ba9e4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  #TODO"},{"line_number":92,"context_line":"  # veirfy if keystone is running over apache?"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  ensure_resource(\u0027package\u0027, \u0027xmlsec1\u0027, {"},{"line_number":95,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":96,"context_line":"  })"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da20952f_4313c5b8","line":94,"updated":"2015-08-27 19:46:29.000000000","message":"is there a reason to use ensure_resource over ensure_packages?\n\n  ensure_packages([\u0027xmlsec1\u0027,\u0027pysaml2\u0027])","commit_id":"7a908eec13ccfd8000c6cc486fe0955c471cf596"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"075f3a0844df79b8a7156bb63510e15a057d4b97","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  #TODO"},{"line_number":92,"context_line":"  # veirfy if keystone is running over apache?"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  ensure_resource(\u0027package\u0027, \u0027xmlsec1\u0027, {"},{"line_number":95,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":96,"context_line":"  })"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da20952f_7e646048","line":94,"in_reply_to":"da20952f_1ee8c4b3","updated":"2015-08-27 20:02:15.000000000","message":"I believe they do the same thing, except ensure_resource takes the \u0027package\u0027 as a param. I think the main point was to use these types of functions to prevent duplication.  Emilien would need to weigh in on if it is a hard requirement for ensure_resource or would ensure_packages suffice. My understanding is that ensure_packages should do what is necessary with less code.","commit_id":"7a908eec13ccfd8000c6cc486fe0955c471cf596"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"99549f6761f5f38e14aa36d9fe5fea79cbe10098","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  #TODO"},{"line_number":92,"context_line":"  # veirfy if keystone is running over apache?"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  ensure_resource(\u0027package\u0027, \u0027xmlsec1\u0027, {"},{"line_number":95,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":96,"context_line":"  })"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da20952f_1ee8c4b3","line":94,"in_reply_to":"da20952f_4313c5b8","updated":"2015-08-27 19:59:06.000000000","message":"Yes, threre is a reason for the usege of ensure_resource. You can find in https://review.openstack.org/#/c/190361/25/specs/liberty/enabling-federation.rst line 119","commit_id":"7a908eec13ccfd8000c6cc486fe0955c471cf596"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fdedce78aafd5665d546049ed3f08bee81c97a2c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  #TODO"},{"line_number":92,"context_line":"  # veirfy if keystone is running over apache?"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  ensure_resource(\u0027package\u0027, \u0027xmlsec1\u0027, {"},{"line_number":95,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":96,"context_line":"  })"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da20952f_5464dd20","line":94,"in_reply_to":"da20952f_7e646048","updated":"2015-08-27 20:46:39.000000000","message":"I will update in the next patchset. Thanks","commit_id":"7a908eec13ccfd8000c6cc486fe0955c471cf596"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"977e5491fc99eb4dcbbdeffbe741149abf8a3c43","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"      require   \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":130,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da20952f_40e94e7f","line":127,"updated":"2015-08-28 14:19:43.000000000","message":"So if this is running under apache, does this work?  Wouldn\u0027t the notify be to apache and not the keystone service name?","commit_id":"92a448c29ef39dfe6f8345740922f8775e0799f0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c366eca8a900dc4229d19fd3c6d9292165fc1c82","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"      require   \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":130,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da20952f_b7f2f1d0","line":127,"in_reply_to":"da20952f_40e94e7f","updated":"2015-08-28 14:45:08.000000000","message":"This need to be running under apache, do you have any idea how can i ensure that?\n\nso i need to use $::apache::params::service_name ?\n\none doubt, this will restart the Service?","commit_id":"92a448c29ef39dfe6f8345740922f8775e0799f0"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"33dab7d851ead97c0bcca97f0d5cfa766073e8c2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"      require   \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_54670425","line":129,"updated":"2015-09-15 07:55:14.000000000","message":"Do we need require on user? According this bug https://bugs.launchpad.net/puppet-keystone/+bug/1458915\nuser should be configured in package, so subscribe for package is enough, isn\u0027t?","commit_id":"7bf4033cb3ca3ad7e2a57e3413b7074d11c4c6c3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ed1c8f889d15f0fba8fc5d9c1750eb645208897f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"      require   \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_713eb6b9","line":129,"in_reply_to":"ba15a1d1_1dec4c8e","updated":"2015-09-15 19:04:28.000000000","message":"Thanks Ivan, i\u0027ll send another patch ;)","commit_id":"7bf4033cb3ca3ad7e2a57e3413b7074d11c4c6c3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"107e0428f94ebeeef21816859bc8b29225b97d57","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"      require   \u003d\u003e User[\u0027keystone\u0027],"},{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_1dec4c8e","line":129,"in_reply_to":"ba15a1d1_54670425","updated":"2015-09-15 09:51:56.000000000","message":"You right, Ivan, but that was done based on main db keystone class:\n\nhttps://github.com/openstack/puppet-keystone/blob/master/manifests/db/sync.pp\n\nSo, i think, it should be fixed in both classes.","commit_id":"7bf4033cb3ca3ad7e2a57e3413b7074d11c4c6c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f1b74ed871132b90dc8f0bfb75ea02be17acf73","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# \u003d\u003d Copyright"},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# Copyright"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class keystone::federation::identity_provider("},{"line_number":73,"context_line":"  $idp_entity_id,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_2a4fc293","line":70,"updated":"2015-09-24 18:34:06.000000000","message":"Copyright?","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b5bd3916e70a95cf5004ef061266a6ae5da1d8dd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# \u003d\u003d Copyright"},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# Copyright"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class keystone::federation::identity_provider("},{"line_number":73,"context_line":"  $idp_entity_id,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_a5cb0572","line":70,"in_reply_to":"9a1a9d01_2a4fc293","updated":"2015-09-24 18:49:16.000000000","message":"I have copy and paste from another file \u003dS\nWhat should i put here?","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c9b3f0d72f8ddaf20642e7ca86d7ad8becfbd74a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# \u003d\u003d Copyright"},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# Copyright"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class keystone::federation::identity_provider("},{"line_number":73,"context_line":"  $idp_entity_id,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_49656343","line":70,"in_reply_to":"9a1a9d01_a5cb0572","updated":"2015-09-24 19:12:47.000000000","message":"https://github.com/openstack/puppet-keystone/blob/a39ce03ac03cc31964ae530d7b6239a630059a5f/manifests/wsgi/apache.pp#L120-L123","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f1b74ed871132b90dc8f0bfb75ea02be17acf73","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":"  }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":123,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_0abc3e6b","line":122,"updated":"2015-09-24 18:34:06.000000000","message":"don\u0027t you need keystone_config *before* running the exec?\nDoes the exec use Keystone configuration?","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b5bd3916e70a95cf5004ef061266a6ae5da1d8dd","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":"  }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":123,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_659c0d6a","line":122,"in_reply_to":"9a1a9d01_0abc3e6b","updated":"2015-09-24 18:49:16.000000000","message":"Yeah I need to run the exec after apply the configuration in keystone.conf, yes the exec use the idp_metadata_páth.","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f1b74ed871132b90dc8f0bfb75ea02be17acf73","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":123,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_ea71cae1","line":124,"updated":"2015-09-24 18:34:06.000000000","message":"we try to not hard-code users. Please add a parameter, set to \u0027keystone\u0027 by default.","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c9b3f0d72f8ddaf20642e7ca86d7ad8becfbd74a","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":123,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_e934774b","line":124,"in_reply_to":"9a1a9d01_25093596","updated":"2015-09-24 19:12:47.000000000","message":"yes you\u0027ll need user for permissions (if it needs to write in logs, etc).","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b5bd3916e70a95cf5004ef061266a6ae5da1d8dd","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":123,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":124,"context_line":"      user      \u003d\u003e \u0027keystone\u0027,"},{"line_number":125,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_25093596","line":124,"in_reply_to":"9a1a9d01_ea71cae1","updated":"2015-09-24 18:49:16.000000000","message":"Sure I\u0027ll update. I\u0027m not sure if i really need a user here...","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f1b74ed871132b90dc8f0bfb75ea02be17acf73","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"  }"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_6a7e1ab0","line":129,"updated":"2015-09-24 18:34:06.000000000","message":"the exec does not seems idempotent, is it?","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c9b3f0d72f8ddaf20642e7ca86d7ad8becfbd74a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"  }"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_29126fb5","line":129,"in_reply_to":"9a1a9d01_05dd1114","updated":"2015-09-24 19:12:47.000000000","message":"ok, will see after your acceptance patch.","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b5bd3916e70a95cf5004ef061266a6ae5da1d8dd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":127,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":128,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"},{"line_number":129,"context_line":"  }"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a1a9d01_05dd1114","line":129,"in_reply_to":"9a1a9d01_6a7e1ab0","updated":"2015-09-24 18:49:16.000000000","message":"Well, the exec will only run if the file does not exist.","commit_id":"ead76142b03e81a976119187913a2a8adbdb7869"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"e7d0da098f00530a1ffa771c17941d42def43110","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    }"},{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":128,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":129,"context_line":"      user      \u003d\u003e \"${user}\","},{"line_number":130,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9a1a9d01_05b4fece","line":127,"updated":"2015-09-25 21:56:12.000000000","message":"saml_idp_metadata","commit_id":"2b275d5c425d2c3e4cde49dd9c1877df887538e0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"190cebb1659aeabd6a9eead3f1d1a97c505f6bd6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    }"},{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":128,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":129,"context_line":"      user      \u003d\u003e \"${user}\","},{"line_number":130,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9a1a9d01_598c1b35","line":127,"in_reply_to":"9a1a9d01_05b4fece","updated":"2015-09-26 00:58:26.000000000","message":"Done","commit_id":"2b275d5c425d2c3e4cde49dd9c1877df887538e0"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"e7d0da098f00530a1ffa771c17941d42def43110","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":128,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":129,"context_line":"      user      \u003d\u003e \"${user}\","},{"line_number":130,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":131,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":132,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":133,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9a1a9d01_e5feaa6a","line":130,"updated":"2015-09-25 21:56:12.000000000","message":"do you need to set the user, owner, and mode of this file?  If so, you can do that with a file resource.","commit_id":"2b275d5c425d2c3e4cde49dd9c1877df887538e0"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"4a477a2ec6012b57487d0396658781b865b9429e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":128,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":129,"context_line":"      user      \u003d\u003e \"${user}\","},{"line_number":130,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":131,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":132,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":133,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9a1a9d01_d059b45b","line":130,"in_reply_to":"9a1a9d01_99a9537e","updated":"2015-09-28 15:34:12.000000000","message":"Check the mode and ownership of other files in that directory.","commit_id":"2b275d5c425d2c3e4cde49dd9c1877df887538e0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2bd74eafae06b27ad52562c8333d5dba9f6f84e9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":128,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":129,"context_line":"      user      \u003d\u003e \"${user}\","},{"line_number":130,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":131,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":132,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":133,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9a1a9d01_e1c0ac2c","line":130,"in_reply_to":"9a1a9d01_d059b45b","updated":"2015-09-28 16:18:17.000000000","message":"mode - 664\nowner - ubuntu\n-rw-rw-r--   1 ubuntu ubuntu  1936 Jun 26 14:19 keystone_idp_metadata.xml","commit_id":"2b275d5c425d2c3e4cde49dd9c1877df887538e0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"190cebb1659aeabd6a9eead3f1d1a97c505f6bd6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  exec {\u0027saml_idp_metada\u0027:"},{"line_number":128,"context_line":"      path      \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":129,"context_line":"      user      \u003d\u003e \"${user}\","},{"line_number":130,"context_line":"      command   \u003d\u003e \"keystone-manage saml_idp_metadata \u003e ${idp_metadata_path}\","},{"line_number":131,"context_line":"      creates   \u003d\u003e $idp_metadata_path,"},{"line_number":132,"context_line":"      notify    \u003d\u003e Service[$::keystone::params::service_name],"},{"line_number":133,"context_line":"      subscribe \u003d\u003e Package[\u0027keystone\u0027],"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9a1a9d01_99a9537e","line":130,"in_reply_to":"9a1a9d01_e5feaa6a","updated":"2015-09-26 00:58:26.000000000","message":"Good point Richard.\nWhen \u0027im doing this manually in ubuntu i need tu use the root user because is the only user that can modify things inside the Keystone directory. Soo I think this is not necessary.","commit_id":"2b275d5c425d2c3e4cde49dd9c1877df887538e0"}],"manifests/identityprovider.pp":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f242e46b9b3efc162778c92af2ee8ee687a76531","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  include ::apache::params"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  #TODO"},{"line_number":91,"context_line":"  # veirfy if keystone is running over apache?"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  # fail if any one of the required parameters are missing"},{"line_number":94,"context_line":"  if !$idp_entity_id or !$idp_sso_endpoint or !$idp_metadata_path or !$certfile or !$keyfile{"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_d561b7d4","line":91,"updated":"2015-07-31 20:38:24.000000000","message":"yeah, not sure how to do this - maybe have a require \u003d\u003e Class[\u0027::keystone::wsgi::apache\u0027]?","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1ceff1e54eea95fffe81858633d93627a5f455d1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  include ::apache::params"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  #TODO"},{"line_number":91,"context_line":"  # veirfy if keystone is running over apache?"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  # fail if any one of the required parameters are missing"},{"line_number":94,"context_line":"  if !$idp_entity_id or !$idp_sso_endpoint or !$idp_metadata_path or !$certfile or !$keyfile{"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_95780ffa","line":91,"in_reply_to":"3a50d1a3_d561b7d4","updated":"2015-07-31 20:57:54.000000000","message":"I\u0027ll put the require and let the TODO for further discussions.","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f242e46b9b3efc162778c92af2ee8ee687a76531","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027saml/keyfile\u0027: value \u003d\u003e $keyfile;"},{"line_number":108,"context_line":"    \u0027saml/idp_entity_id\u0027: value \u003d\u003e $idp_entity_id;"},{"line_number":109,"context_line":"    \u0027saml/idp_sso_endpoint\u0027: value \u003d\u003e $idp_sso_endpoint;"},{"line_number":110,"context_line":"    \u0027saml/idp_metadata_path\u0027: value \u003d\u003e $idp_metadata_path;"},{"line_number":111,"context_line":"  }"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  #Apply the option configuration to keystone.conf"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_d533f7f4","line":110,"updated":"2015-07-31 20:38:24.000000000","message":"You need to align on the \"\u003d\u003e\".  If you use emacs, see http://richmegginson.livejournal.com/26751.html","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1ceff1e54eea95fffe81858633d93627a5f455d1","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027saml/keyfile\u0027: value \u003d\u003e $keyfile;"},{"line_number":108,"context_line":"    \u0027saml/idp_entity_id\u0027: value \u003d\u003e $idp_entity_id;"},{"line_number":109,"context_line":"    \u0027saml/idp_sso_endpoint\u0027: value \u003d\u003e $idp_sso_endpoint;"},{"line_number":110,"context_line":"    \u0027saml/idp_metadata_path\u0027: value \u003d\u003e $idp_metadata_path;"},{"line_number":111,"context_line":"  }"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  #Apply the option configuration to keystone.conf"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_f599537a","line":110,"in_reply_to":"3a50d1a3_d533f7f4","updated":"2015-07-31 20:57:54.000000000","message":"Thanks o/ i\u0027ll fix this in the next patch.","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f242e46b9b3efc162778c92af2ee8ee687a76531","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \u0027saml/idp_contact_surname\u0027: value \u003d\u003e $idp_contact_surname;"},{"line_number":123,"context_line":"    \u0027saml/idp_contact_email\u0027: value \u003d\u003e $idp_contact_email;"},{"line_number":124,"context_line":"    \u0027saml/idp_contact_telephone\u0027: value \u003d\u003e $idp_contact_telephone;"},{"line_number":125,"context_line":"    \u0027saml/idp_contact_type\u0027: value \u003d\u003e $idp_contact_type; "},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  #TODO"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_b528ab86","line":125,"updated":"2015-07-31 20:38:24.000000000","message":"trailing whitespace","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1ceff1e54eea95fffe81858633d93627a5f455d1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \u0027saml/idp_contact_surname\u0027: value \u003d\u003e $idp_contact_surname;"},{"line_number":123,"context_line":"    \u0027saml/idp_contact_email\u0027: value \u003d\u003e $idp_contact_email;"},{"line_number":124,"context_line":"    \u0027saml/idp_contact_telephone\u0027: value \u003d\u003e $idp_contact_telephone;"},{"line_number":125,"context_line":"    \u0027saml/idp_contact_type\u0027: value \u003d\u003e $idp_contact_type; "},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  #TODO"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_b58aeb18","line":125,"in_reply_to":"3a50d1a3_b528ab86","updated":"2015-07-31 20:57:54.000000000","message":"Done","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f242e46b9b3efc162778c92af2ee8ee687a76531","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    \u0027saml/idp_contact_email\u0027: value \u003d\u003e $idp_contact_email;"},{"line_number":124,"context_line":"    \u0027saml/idp_contact_telephone\u0027: value \u003d\u003e $idp_contact_telephone;"},{"line_number":125,"context_line":"    \u0027saml/idp_contact_type\u0027: value \u003d\u003e $idp_contact_type; "},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  #TODO"},{"line_number":129,"context_line":"  #Create idp_metadata_file"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_55560707","line":126,"updated":"2015-07-31 20:38:24.000000000","message":"You need to align on the \"\u003d\u003e\".  If you use emacs, see http://richmegginson.livejournal.com/26751.html","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1ceff1e54eea95fffe81858633d93627a5f455d1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    \u0027saml/idp_contact_email\u0027: value \u003d\u003e $idp_contact_email;"},{"line_number":124,"context_line":"    \u0027saml/idp_contact_telephone\u0027: value \u003d\u003e $idp_contact_telephone;"},{"line_number":125,"context_line":"    \u0027saml/idp_contact_type\u0027: value \u003d\u003e $idp_contact_type; "},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  #TODO"},{"line_number":129,"context_line":"  #Create idp_metadata_file"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_d580d78d","line":126,"in_reply_to":"3a50d1a3_55560707","updated":"2015-07-31 20:57:54.000000000","message":"Done","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f242e46b9b3efc162778c92af2ee8ee687a76531","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  # keystone-manage saml_idp_metadata \u003e /etc/keystone/keystone_idp_metadata.xml"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  #restart keystone in apache after apply the configuration."},{"line_number":133,"context_line":"  exec { \u0027restart_keystone\u0027:"},{"line_number":134,"context_line":"    path        \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027, \u0027/sbin\u0027, \u0027/bin/\u0027],"},{"line_number":135,"context_line":"    command     \u003d\u003e \"service ${$::apache::params::service_name} restart\","},{"line_number":136,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_f5171343","line":133,"updated":"2015-07-31 20:38:24.000000000","message":"This shouldn\u0027t be necessary - there is already a notify for keystone_config to restart the Keystone service (including httpd).","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"d72c2d3092ff1652012b7d5bd020107cb38d6f71","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  # keystone-manage saml_idp_metadata \u003e /etc/keystone/keystone_idp_metadata.xml"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  #restart keystone in apache after apply the configuration."},{"line_number":133,"context_line":"  exec { \u0027restart_keystone\u0027:"},{"line_number":134,"context_line":"    path        \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027, \u0027/sbin\u0027, \u0027/bin/\u0027],"},{"line_number":135,"context_line":"    command     \u003d\u003e \"service ${$::apache::params::service_name} restart\","},{"line_number":136,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_988e0626","line":133,"in_reply_to":"3a50d1a3_5534c748","updated":"2015-07-31 21:03:49.000000000","message":"Something like that.  The keystone-manage should be run after the config is added but before keystone is started for the first time.  Emilien can help figure out how to do that.","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1ceff1e54eea95fffe81858633d93627a5f455d1","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  # keystone-manage saml_idp_metadata \u003e /etc/keystone/keystone_idp_metadata.xml"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  #restart keystone in apache after apply the configuration."},{"line_number":133,"context_line":"  exec { \u0027restart_keystone\u0027:"},{"line_number":134,"context_line":"    path        \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027, \u0027/sbin\u0027, \u0027/bin/\u0027],"},{"line_number":135,"context_line":"    command     \u003d\u003e \"service ${$::apache::params::service_name} restart\","},{"line_number":136,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_5534c748","line":133,"in_reply_to":"3a50d1a3_f5171343","updated":"2015-07-31 20:57:54.000000000","message":"Hi Richard, you mean like this:\nExec[\u0027keystone-manage saml_idp_metadata \u003e /etc/keystone/keystone_idp_metadata.xml\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027keystone\u0027 |\u003e\n?","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"1b78f983eb944dc8a17cb9a624e716d2a2ba31b1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Copyright"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class keystone::identityprovider("},{"line_number":73,"context_line":"  require                        \u003d\u003e Class[\u0027::keystone::wsgi::apache\u0027]"},{"line_number":74,"context_line":"  $idp_entity_id,"},{"line_number":75,"context_line":"  $idp_sso_endpoint,"},{"line_number":76,"context_line":"  $idp_metadata_path,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_33cef383","line":73,"updated":"2015-07-31 21:27:28.000000000","message":"This is probably not the right way to do this.\n\nYou should probably run a local spec test, which would have caught this, before submitting the patch for review.","commit_id":"54c55bfc7e0a76923ad053263aac7413e78ae98f"}],"spec/acceptance/keystone_federation_identity_provider_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ef2c4a87ad2c0a7de20b03973588e0e78de4a8e8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                       \u0027--os-username beaker-civ3 --os-password secret --os-project-name servicesv3 --os-user-domain-name service_domain --os-project-domain-name service_domain\u0027"},{"line_number":248,"context_line":"    end"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"  end"},{"line_number":251,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"7a2fa921_08f09e8f","line":250,"updated":"2015-10-06 16:47:01.000000000","message":"Is there value in copying all these tests from basic_spec.rb, when there is only one class added? Would it be more beneficial to instead create a different test that checks the status of the identity provider?","commit_id":"cb8bc35d58840fdc7164eb90e870dad70640dbcc"}],"spec/classes/keystone_identityprovider_spec.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f242e46b9b3efc162778c92af2ee8ee687a76531","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        :idp_contact_surname \u003d\u003e \u0027\u0027,"},{"line_number":18,"context_line":"        :idp_contact_email \u003d\u003e \u0027\u0027,"},{"line_number":19,"context_line":"        :idp_contact_telephone \u003d\u003e \u0027\u0027,"},{"line_number":20,"context_line":"        :idp_contact_type \u003d\u003e \u0027technical,support,administrative billing,other\u0027,"},{"line_number":21,"context_line":"      }"},{"line_number":22,"context_line":"    end"},{"line_number":23,"context_line":"    it { is_expected.to contain_package(\u0027pysaml2\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a50d1a3_557b677b","line":20,"updated":"2015-07-31 20:38:24.000000000","message":"align on the \"\u003d\u003e\"","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1ceff1e54eea95fffe81858633d93627a5f455d1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        :idp_contact_surname \u003d\u003e \u0027\u0027,"},{"line_number":18,"context_line":"        :idp_contact_email \u003d\u003e \u0027\u0027,"},{"line_number":19,"context_line":"        :idp_contact_telephone \u003d\u003e \u0027\u0027,"},{"line_number":20,"context_line":"        :idp_contact_type \u003d\u003e \u0027technical,support,administrative billing,other\u0027,"},{"line_number":21,"context_line":"      }"},{"line_number":22,"context_line":"    end"},{"line_number":23,"context_line":"    it { is_expected.to contain_package(\u0027pysaml2\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a50d1a3_3559fb5b","line":20,"in_reply_to":"3a50d1a3_557b677b","updated":"2015-07-31 20:57:54.000000000","message":"Done","commit_id":"ed5455102992bc7f31d8e3777a355b374afb810d"}]}