)]}'
{"manifests/endpoint.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b7a9e334972cd303940ad6dea4b0ad2b7220d157","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_2fccebb9","line":42,"updated":"2015-08-20 23:46:36.000000000","message":"Wrong, the default is not \u0027v2.0\u0027.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"2c7877afa90a11d5148eceaedd8c1bba9a0368be","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_6f318359","line":42,"in_reply_to":"fa1b9901_2fccebb9","updated":"2015-08-21 00:11:28.000000000","message":"Those are the lines from the previous code, see on left column, I moved them to the DEPRECATED section.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"57056daa7e0e876191db6cfd975294a39d4db864","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_cadafa16","line":42,"in_reply_to":"fa1b9901_3acc2bba","updated":"2015-08-21 05:37:12.000000000","message":"Done","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9d494632a15690270cbc83805732526be554cd11","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_3acc2bba","line":42,"in_reply_to":"fa1b9901_6f318359","updated":"2015-08-21 00:31:04.000000000","message":"the documentation here is saying \u0027v2.0\u0027 for the default value, while the default parameter IS NOT \u0027v2.0\u0027 since you\u0027re changing it. Please adapt the change.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b7a9e334972cd303940ad6dea4b0ad2b7220d157","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# \u003d\u003d\u003d Examples"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_6f3d038e","line":43,"updated":"2015-08-20 23:46:36.000000000","message":"what if I don\u0027t run API v3 ?","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"2c7877afa90a11d5148eceaedd8c1bba9a0368be","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# \u003d\u003d\u003d Examples"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_af431bae","line":43,"in_reply_to":"fa1b9901_6f3d038e","updated":"2015-08-21 00:11:28.000000000","message":"Keystone V3 is capable of handling API v2.0 and v3 requests, it\u0027s based the context please see keystone developer documentation link available in commit message.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9d494632a15690270cbc83805732526be554cd11","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*version*]"},{"line_number":42,"context_line":"#   (optional) API version for endpoint. Appended to all endpoint urls. (Defaults to \u0027v2.0\u0027)"},{"line_number":43,"context_line":"#   Keystone V3 handles API versions from the context."},{"line_number":44,"context_line":"#   The version is not relevant anymore in the endpoints and to be removed."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# \u003d\u003d\u003d Examples"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_dac72f94","line":43,"in_reply_to":"fa1b9901_af431bae","updated":"2015-08-21 00:31:04.000000000","message":"ok fair enough.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b7a9e334972cd303940ad6dea4b0ad2b7220d157","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $user_domain       \u003d undef,"},{"line_number":60,"context_line":"  $project_domain    \u003d undef,"},{"line_number":61,"context_line":"  $default_domain    \u003d undef,"},{"line_number":62,"context_line":"  $version           \u003d \u0027\u0027, # DEPRECATED"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $internal_url {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_cfe0cf2b","line":62,"updated":"2015-08-20 23:46:36.000000000","message":"you\u0027re not deprecating the parameter here, you\u0027re just not using it anymore and this is not acceptable from an user point of view.\n\nWhat you should do is:\n\n* set the parameter to undef\n* test if the parameter is set and send a warning in the catalog to explain why the parameter should not be used anymore.\n\nIf APIs Endpoints version-less work in Kilo, then you can drop the parameter from the *_url_real. Otherwise, we will have to keep it for backward compatibility.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9d494632a15690270cbc83805732526be554cd11","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $user_domain       \u003d undef,"},{"line_number":60,"context_line":"  $project_domain    \u003d undef,"},{"line_number":61,"context_line":"  $default_domain    \u003d undef,"},{"line_number":62,"context_line":"  $version           \u003d \u0027\u0027, # DEPRECATED"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $internal_url {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_bac27b51","line":62,"in_reply_to":"fa1b9901_6f9bc318","updated":"2015-08-21 00:31:04.000000000","message":"I agree master is targeting Liberty but you have to consider some of our users are running master.\nIf we change the default value, we need more discussion about that because this patch is going to break (by default!) people still running Kilo.\nThe safest way I\u0027m seeing here is, keep the default value in Liberty cycle with sending a warning if something is set, set it to undef in \u0027M\u0027 and keeping the warning, and totally drop the parameter in \u0027N\u0027 and also drop the warning.\nOf course, for our needs, we would change the acceptance manifests to override $version to undef to we would run version-less.\n\nThe point here is to keep the interface backward compatible one release.\n\nIf we decide to not keep backward compatibility here, at least I would like to send warnings and not use \u0027\u0027 for default value (use undef instead). Also please update doc.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"57056daa7e0e876191db6cfd975294a39d4db864","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $user_domain       \u003d undef,"},{"line_number":60,"context_line":"  $project_domain    \u003d undef,"},{"line_number":61,"context_line":"  $default_domain    \u003d undef,"},{"line_number":62,"context_line":"  $version           \u003d \u0027\u0027, # DEPRECATED"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $internal_url {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_cc6692ba","line":62,"in_reply_to":"fa1b9901_bac27b51","updated":"2015-08-21 05:37:12.000000000","message":"I\u0027ll add proper \u0027Deprecated\u0027 message.\n\nAlso, apologies, I confused:\n- A parameter with a default value of undef \nversus  \n-A parameter with no value assigned at all, making it mandatory.\n\nSo yes I\u0027ll use the undef  value.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"f94680a9e14136a386e125d1df4de7a70b92ecdb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $user_domain       \u003d undef,"},{"line_number":60,"context_line":"  $project_domain    \u003d undef,"},{"line_number":61,"context_line":"  $default_domain    \u003d undef,"},{"line_number":62,"context_line":"  $version           \u003d \u0027\u0027, # DEPRECATED"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $internal_url {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_aeea33d9","line":62,"in_reply_to":"fa1b9901_cc6692ba","updated":"2015-08-21 06:06:02.000000000","message":"Sorry I was a bit short on my previous comment.\nIn the meantime we have a community based decision, I\u0027ll set the value to undef, so we can use a version-less approach in Liberty but keep the version approach if the value is set while sending a warning at the same time.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"2c7877afa90a11d5148eceaedd8c1bba9a0368be","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $user_domain       \u003d undef,"},{"line_number":60,"context_line":"  $project_domain    \u003d undef,"},{"line_number":61,"context_line":"  $default_domain    \u003d undef,"},{"line_number":62,"context_line":"  $version           \u003d \u0027\u0027, # DEPRECATED"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $internal_url {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_6f9bc318","line":62,"in_reply_to":"fa1b9901_cfe0cf2b","updated":"2015-08-21 00:11:28.000000000","message":"The parameter is not used anymore but for backward compatibility we have to leave it as \u0027deprecated\u0027.\n\n\u003e set the parameter to undef\nWe cannot use undef because that would make the parameter required.\nEmpty value makes the more sense to me, because it\u0027s not used but it could be back to its original value \u0027v2.0\u0027, it\u0027s not used anyway.\n\n\u003e test if the parameter is set and send a warning in the catalog to explain why the parameter should not be used anymore.\n\nYes, \u0027Done\u0027\n\n\u003e If APIs Endpoints version-less work in Kilo, then you can drop the parameter from the *_url_real. Otherwise, we will have to keep it for backward compatibility.\n\nEndpoints cannot be API\u0027s version-less in Kilo because its OSC version (1.0.4) doesn\u0027t support it.\n\nThis patch is for master branch (Liberty) only with no intend to backport it to Kilo.\nI don\u0027t see the point of keeping any *_url_real variables which have no impact on the manifest\u0027s API (inside scope)","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"499335ee2ec22140a29e2b944e66f894acf9da6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $version           \u003d \u0027v2.0\u0027, # DEPRECATED"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($version \u003d\u003d \u0027\u0027) {"},{"line_number":68,"context_line":"    $admin_url_real \u003d  $admin_url"},{"line_number":69,"context_line":"    $public_url_real \u003d $public_url"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da20952f_1bd1a857","line":67,"updated":"2015-08-28 01:54:36.000000000","message":"How will this ever be true?  That means someone is doing::\n\n    class { \u0027keystone::endpoint\u0027: \n      $version \u003d \u0027\u0027,\n    }\n\n?  That seems wrong to me.  Maybe use `undef` instead of \u0027\u0027?  Not sure what the proper puppet idiom is in this case.","commit_id":"c8863aba23d4cffc1d784992110d2956ba123949"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"27e878c228e50d6fbcbb99912a6238fda0d78fd6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $version           \u003d \u0027v2.0\u0027, # DEPRECATED"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($version \u003d\u003d \u0027\u0027) {"},{"line_number":68,"context_line":"    $admin_url_real \u003d  $admin_url"},{"line_number":69,"context_line":"    $public_url_real \u003d $public_url"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da20952f_31512d0f","line":67,"in_reply_to":"da20952f_1bd1a857","updated":"2015-08-28 02:57:44.000000000","message":"This is sort of the same thing, undef is interpolated as nil string \u0027\u0027.\n\nBoth form should work:  \n  \nkeystone_endpoint {\"endpoint1\":  \n  version \u003d\u003e \u0027\u0027  \n}  \n  \nor   \n  \nkeystone_endpoint {\"endpoint1\":  \n  version \u003d\u003e undef  \n}\n\nTherefore the test needs to be more robust.\nThanks","commit_id":"c8863aba23d4cffc1d784992110d2956ba123949"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"8438f672c8d7080b50b2fbd36f66ea79e777cfef","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $version           \u003d \u0027v2.0\u0027, # DEPRECATED"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($version \u003d\u003d \u0027\u0027) {"},{"line_number":68,"context_line":"    $admin_url_real \u003d  $admin_url"},{"line_number":69,"context_line":"    $public_url_real \u003d $public_url"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da20952f_3eb476cf","line":67,"in_reply_to":"da20952f_31512d0f","updated":"2015-08-28 16:15:53.000000000","message":"ack","commit_id":"c8863aba23d4cffc1d784992110d2956ba123949"}],"manifests/init.pp":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"dc13298cbce597ea660bac59ade2044b863fbd64","unresolved":false,"context_lines":[{"line_number":870,"context_line":"        validate     \u003d\u003e false,"},{"line_number":871,"context_line":"      }"},{"line_number":872,"context_line":"    }"},{"line_number":873,"context_line":"    warning(\u0027Keystone under Eventlet has been drepecated during the Kilo cycle. Support for deploying under eventlet will be dropped as of the M-release of OpenStack.\u0027)"},{"line_number":874,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":875,"context_line":"    include ::apache::params"},{"line_number":876,"context_line":"    class { \u0027::keystone::service\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"da20952f_9c9d090d","line":873,"updated":"2015-09-01 14:16:20.000000000","message":"This should be in a separate review/commit.","commit_id":"c195e9d50d2e8a958e22bfaefb4b7c82c343d812"}],"spec/acceptance/basic_keystone_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b7a9e334972cd303940ad6dea4b0ad2b7220d157","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        password               \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      class { \u0027::keystone::endpoint\u0027:"},{"line_number":67,"context_line":"        public_url     \u003d\u003e \"http://127.0.0.1:5000\","},{"line_number":68,"context_line":"        admin_url      \u003d\u003e \"http://127.0.0.1:35357\","},{"line_number":69,"context_line":"        default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":70,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa1b9901_6f6423b8","line":67,"updated":"2015-08-20 23:46:36.000000000","message":"useless, since they are already default values. You can drop the 2 params I guess.","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"2c7877afa90a11d5148eceaedd8c1bba9a0368be","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        password               \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      class { \u0027::keystone::endpoint\u0027:"},{"line_number":67,"context_line":"        public_url     \u003d\u003e \"http://127.0.0.1:5000\","},{"line_number":68,"context_line":"        admin_url      \u003d\u003e \"http://127.0.0.1:35357\","},{"line_number":69,"context_line":"        default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":70,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa1b9901_afa47b4a","line":67,"in_reply_to":"fa1b9901_6f6423b8","updated":"2015-08-21 00:11:28.000000000","message":"You\u0027re right, although it doesn\u0027t hurt, for clarity.\nBut I\u0027m happy to drop them!","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9d494632a15690270cbc83805732526be554cd11","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        password               \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      class { \u0027::keystone::endpoint\u0027:"},{"line_number":67,"context_line":"        public_url     \u003d\u003e \"http://127.0.0.1:5000\","},{"line_number":68,"context_line":"        admin_url      \u003d\u003e \"http://127.0.0.1:35357\","},{"line_number":69,"context_line":"        default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":70,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa1b9901_da988f7a","line":67,"in_reply_to":"fa1b9901_afa47b4a","updated":"2015-08-21 00:31:04.000000000","message":"thx","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c8ad58157e92115f83fed1223d7b732ec82f8520","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        public_url          \u003d\u003e \u0027http://127.0.0.1:1234\u0027,"},{"line_number":83,"context_line":"        admin_url           \u003d\u003e \u0027http://127.0.0.1:1234\u0027,"},{"line_number":84,"context_line":"        internal_url        \u003d\u003e \u0027http://127.0.0.1:1234\u0027,"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      }"},{"line_number":87,"context_line":"      # v3 admin"},{"line_number":88,"context_line":"      # we don\u0027t use ::keystone::roles::admin but still create resources manually:"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da20952f_d9c4a693","line":85,"updated":"2015-09-02 19:55:32.000000000","message":"please do not add empty line.","commit_id":"9a510ff6d9725b09928718e930b03c028b71942f"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"193c66fa0dec4b63f3cb1c546d150de25abb9eb3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        public_url          \u003d\u003e \u0027http://127.0.0.1:1234\u0027,"},{"line_number":83,"context_line":"        admin_url           \u003d\u003e \u0027http://127.0.0.1:1234\u0027,"},{"line_number":84,"context_line":"        internal_url        \u003d\u003e \u0027http://127.0.0.1:1234\u0027,"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      }"},{"line_number":87,"context_line":"      # v3 admin"},{"line_number":88,"context_line":"      # we don\u0027t use ::keystone::roles::admin but still create resources manually:"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da20952f_923a8433","line":85,"in_reply_to":"da20952f_d9c4a693","updated":"2015-09-03 01:46:52.000000000","message":"Done","commit_id":"9a510ff6d9725b09928718e930b03c028b71942f"}],"spec/acceptance/keystone_wsgi_apache_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b7a9e334972cd303940ad6dea4b0ad2b7220d157","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        password               \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":71,"context_line":"      }"},{"line_number":72,"context_line":"      class { \u0027::keystone::endpoint\u0027:"},{"line_number":73,"context_line":"        public_url     \u003d\u003e \"http://127.0.0.1:5000\","},{"line_number":74,"context_line":"        admin_url      \u003d\u003e \"http://127.0.0.1:35357\","},{"line_number":75,"context_line":"        default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":76,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa1b9901_8f6bb784","line":73,"updated":"2015-08-20 23:46:36.000000000","message":"same","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"2c7877afa90a11d5148eceaedd8c1bba9a0368be","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        password               \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":71,"context_line":"      }"},{"line_number":72,"context_line":"      class { \u0027::keystone::endpoint\u0027:"},{"line_number":73,"context_line":"        public_url     \u003d\u003e \"http://127.0.0.1:5000\","},{"line_number":74,"context_line":"        admin_url      \u003d\u003e \"http://127.0.0.1:35357\","},{"line_number":75,"context_line":"        default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":76,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa1b9901_2f6f0bfd","line":73,"in_reply_to":"fa1b9901_8f6bb784","updated":"2015-08-21 00:11:28.000000000","message":"Done","commit_id":"32b95701ce58f915a9abf16ab5b360681e1f57fe"}],"spec/classes/keystone_endpoint_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c8ad58157e92115f83fed1223d7b732ec82f8520","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  describe \u0027without a version\u0027 do"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    let :params do"},{"line_number":40,"context_line":"      { :version \u003d\u003e \u0027\u0027 }"},{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/keystone\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da20952f_b9b9b217","line":40,"updated":"2015-09-02 19:55:32.000000000","message":"I would rather test \u0027nil\u0027 that test undef.","commit_id":"9a510ff6d9725b09928718e930b03c028b71942f"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"193c66fa0dec4b63f3cb1c546d150de25abb9eb3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  describe \u0027without a version\u0027 do"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    let :params do"},{"line_number":40,"context_line":"      { :version \u003d\u003e \u0027\u0027 }"},{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/keystone\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da20952f_f21180b0","line":40,"in_reply_to":"da20952f_b9b9b217","updated":"2015-09-03 01:46:52.000000000","message":"Done","commit_id":"9a510ff6d9725b09928718e930b03c028b71942f"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"f30c789fcbed9191beeda17e22d079fe81d19fa9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  describe \u0027without a version\u0027 do"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    let :params do"},{"line_number":40,"context_line":"      { :version \u003d\u003e \u0027\u0027 }"},{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/keystone\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":13,"id":"da20952f_ce436c6b","line":40,"in_reply_to":"da20952f_f21180b0","updated":"2015-09-03 02:04:28.000000000","message":"Actually neither nil or undef work:\n\n{ :version \u003d\u003e nil }\n\n-http://127.0.0.1:5000\n+http://127.0.0.1:5000/nil\n\n\nAnd undef word is breaking rspec.\n\nSo I leave to \u0027\u0027 for now.","commit_id":"9a510ff6d9725b09928718e930b03c028b71942f"}]}