)]}'
{"spec/acceptance/basic_keystone_spec.rb":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"691bb38a9d33faa52a2f90341bfa26fc5b73a158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa1b9901_57e47cdf","updated":"2015-08-20 11:37:52.000000000","message":"I suggest to use Keystone_domain \u003c||\u003e -\u003e Keystone_tenant \u003c||\u003e -\u003e Keystone_user \u003c||\u003e -\u003e Keystone_user_role \u003c||\u003e","commit_id":"7d064b2fcb4b7737b6ee963480530a455750de0d"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"971dc8fb659a4a85790c8810f8b427a863fef854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa1b9901_29288785","in_reply_to":"fa1b9901_57e47cdf","updated":"2015-08-20 13:30:52.000000000","message":"I thought about that too but wasn\u0027t sure.\nBut you\u0027re right it makes think better.\nI\u0027ll change it.","commit_id":"7d064b2fcb4b7737b6ee963480530a455750de0d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b6e4ec1fa518f941234aa32d49a298cb628d597a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        enabled     \u003d\u003e true,"},{"line_number":114,"context_line":"        description \u003d\u003e \u0027Tenant for the openstack services\u0027,"},{"line_number":115,"context_line":"        domain      \u003d\u003e \u0027service_domain\u0027,"},{"line_number":116,"context_line":"      }"},{"line_number":117,"context_line":"      # service user exists only in the service_domain - must"},{"line_number":118,"context_line":"      # use v3 api"},{"line_number":119,"context_line":"      ::keystone::resource::service_identity { \u0027beaker-civ3\u0027:"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_a9a577a2","line":116,"updated":"2015-08-20 13:39:17.000000000","message":"this change is useless. Puppet manifests do not take in account resource order like this.\n\nhttps://docs.puppetlabs.com/puppet/latest/reference/lang_relationships.html","commit_id":"b7a671e27b62cd21587b4eda6764d3844e8c00d6"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"325e9f3df46d636a25005fd55875ef507f74eab2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        enabled     \u003d\u003e true,"},{"line_number":114,"context_line":"        description \u003d\u003e \u0027Tenant for the openstack services\u0027,"},{"line_number":115,"context_line":"        domain      \u003d\u003e \u0027service_domain\u0027,"},{"line_number":116,"context_line":"      }"},{"line_number":117,"context_line":"      # service user exists only in the service_domain - must"},{"line_number":118,"context_line":"      # use v3 api"},{"line_number":119,"context_line":"      ::keystone::resource::service_identity { \u0027beaker-civ3\u0027:"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_ba2efb89","line":116,"in_reply_to":"fa1b9901_a9a577a2","updated":"2015-08-21 00:22:11.000000000","message":"I know, those resources were moved between patch sets, the real change is the ordering below you commented too!","commit_id":"b7a671e27b62cd21587b4eda6764d3844e8c00d6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b6e4ec1fa518f941234aa32d49a298cb628d597a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        project_domain      \u003d\u003e \u0027service_domain\u0027,"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"      Keystone_domain \u003c||\u003e -\u003e Keystone_tenant \u003c||\u003e -\u003e Keystone_user \u003c||\u003e -\u003e Keystone_user_role \u003c||\u003e"},{"line_number":133,"context_line":"      EOS"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      # Run it twice and test for idempotency"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_a9d33703","line":132,"updated":"2015-08-20 13:39:17.000000000","message":"No. You should rather patch provider to use autorequire:\n\nhttps://docs.puppetlabs.com/guides/custom_types.html#automatic-relationships","commit_id":"b7a671e27b62cd21587b4eda6764d3844e8c00d6"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"325e9f3df46d636a25005fd55875ef507f74eab2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        project_domain      \u003d\u003e \u0027service_domain\u0027,"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"      Keystone_domain \u003c||\u003e -\u003e Keystone_tenant \u003c||\u003e -\u003e Keystone_user \u003c||\u003e -\u003e Keystone_user_role \u003c||\u003e"},{"line_number":133,"context_line":"      EOS"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      # Run it twice and test for idempotency"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_1a7b677c","line":132,"in_reply_to":"fa1b9901_a9d33703","updated":"2015-08-21 00:22:11.000000000","message":"Well I agree that on the long run use autorequire is more robust, but in the meantime that fixes the issue.\n\nBTW, \u0027git blame\u0027 makes me wonder why didn\u0027t you such recommendation at the time you coded this?","commit_id":"b7a671e27b62cd21587b4eda6764d3844e8c00d6"}]}