)]}'
{"lib/puppet/type/keystone_user_role.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"15c32c4efd583bf8783e1045c82a6eaec6dcdc7f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Ongoing deprecation warning ending after Mitaka"},{"line_number":53,"context_line":"    # http://specs.openstack.org/openstack/puppet-openstack-specs/specs/kilo/api-v3-support.html"},{"line_number":54,"context_line":"    unless self.class::ProviderOpenstack.domain_check?(domain_name)"},{"line_number":55,"context_line":"      warning(\"In Liberty, not providing a domain name (::domain) for a resource name (#{self[:name]}) is deprecated when the default_domain_id is not \u0027default\u0027\")"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da20952f_f6ae9997","line":54,"updated":"2015-09-01 17:15:56.000000000","message":"domain_check? should take the full resource name, and should print/raise the appropriate message.\n\nNote that in this case, the full resource name is self[:name].rpartition(\u0027@\u0027).first","commit_id":"3c4c0b30e6d4cecfcc66aa935bfc7290868eb7ea"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"a0130b02457384d6a95a4c9a25afd4de6d01bc3a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Ongoing deprecation warning ending after Mitaka"},{"line_number":53,"context_line":"    # http://specs.openstack.org/openstack/puppet-openstack-specs/specs/kilo/api-v3-support.html"},{"line_number":54,"context_line":"    unless self.class::ProviderOpenstack.domain_check?(domain_name)"},{"line_number":55,"context_line":"      warning(\"In Liberty, not providing a domain name (::domain) for a resource name (#{self[:name]}) is deprecated when the default_domain_id is not \u0027default\u0027\")"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da20952f_db1607f1","line":54,"in_reply_to":"da20952f_3b562307","updated":"2015-09-02 02:01:05.000000000","message":"Actually using the self[:name] for the warning message is more meaningful:  \n  \nWarning: Puppet::Type::Keystone_user_role::ProviderOpenstack: In Liberty, not providing a domain name (::domain) for a resource name (user3@tenant1) is deprecated when the default_domain_id is not \u0027default\u0027  \n  \nInstead of:  \n\nWarning: Puppet::Type::Keystone_user_role::ProviderOpenstack: In Liberty, not providing a domain name (::domain) for a resource name (user3) is deprecated when the default_domain_id is not \u0027default\u0027","commit_id":"3c4c0b30e6d4cecfcc66aa935bfc7290868eb7ea"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"1b5e66968b0d55178bf13473237b29ce5f9f6c2a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Ongoing deprecation warning ending after Mitaka"},{"line_number":53,"context_line":"    # http://specs.openstack.org/openstack/puppet-openstack-specs/specs/kilo/api-v3-support.html"},{"line_number":54,"context_line":"    unless self.class::ProviderOpenstack.domain_check?(domain_name)"},{"line_number":55,"context_line":"      warning(\"In Liberty, not providing a domain name (::domain) for a resource name (#{self[:name]}) is deprecated when the default_domain_id is not \u0027default\u0027\")"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da20952f_3b562307","line":54,"in_reply_to":"da20952f_f6ae9997","updated":"2015-09-02 01:51:02.000000000","message":"Done","commit_id":"3c4c0b30e6d4cecfcc66aa935bfc7290868eb7ea"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"15c32c4efd583bf8783e1045c82a6eaec6dcdc7f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    if userdom"},{"line_number":59,"context_line":"      rv \u003c\u003c userdom"},{"line_number":60,"context_line":"    end"},{"line_number":61,"context_line":"    projectdom \u003d Util.split_domain(self[:name].rpartition(\u0027@\u0027).last)[1]"},{"line_number":62,"context_line":"    if projectdom"},{"line_number":63,"context_line":"      rv \u003c\u003c projectdom"},{"line_number":64,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da20952f_769b6973","line":61,"updated":"2015-09-01 17:15:56.000000000","message":"Also need domain_check? here.","commit_id":"3c4c0b30e6d4cecfcc66aa935bfc7290868eb7ea"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"1b5e66968b0d55178bf13473237b29ce5f9f6c2a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    if userdom"},{"line_number":59,"context_line":"      rv \u003c\u003c userdom"},{"line_number":60,"context_line":"    end"},{"line_number":61,"context_line":"    projectdom \u003d Util.split_domain(self[:name].rpartition(\u0027@\u0027).last)[1]"},{"line_number":62,"context_line":"    if projectdom"},{"line_number":63,"context_line":"      rv \u003c\u003c projectdom"},{"line_number":64,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da20952f_db3047eb","line":61,"in_reply_to":"da20952f_769b6973","updated":"2015-09-02 01:51:02.000000000","message":"Yes I realized that afterwards, thanks.","commit_id":"3c4c0b30e6d4cecfcc66aa935bfc7290868eb7ea"}]}