)]}'
{"lib/puppet/provider/keystone.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"8b75d24104fe246f1e35023a3c36c98689be44aa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      @domain_hash[id] \u003d name if name"},{"line_number":55,"context_line":"    end"},{"line_number":56,"context_line":"    unless @domain_hash.include?(id)"},{"line_number":57,"context_line":"      err(\"Could not find domain with id [#{id}]\")"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"    @domain_hash[id]"},{"line_number":60,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_cedf3f39","line":57,"updated":"2015-09-08 11:48:23.000000000","message":"Could not find any reference to err()","commit_id":"c5d3e31bfa317d94a15a4ff9b741a828bd5aa88d"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"eed538b07445942e139272e11d8e85c8ea17bbc4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      @domain_hash[id] \u003d name if name"},{"line_number":55,"context_line":"    end"},{"line_number":56,"context_line":"    unless @domain_hash.include?(id)"},{"line_number":57,"context_line":"      err(\"Could not find domain with id [#{id}]\")"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"    @domain_hash[id]"},{"line_number":60,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_9e615dab","line":57,"in_reply_to":"da20952f_b1590b5e","updated":"2015-09-08 22:36:15.000000000","message":"Thanks","commit_id":"c5d3e31bfa317d94a15a4ff9b741a828bd5aa88d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"2382f3afb4d90a10f2f4d3596da5c7f1fe7e5c47","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      @domain_hash[id] \u003d name if name"},{"line_number":55,"context_line":"    end"},{"line_number":56,"context_line":"    unless @domain_hash.include?(id)"},{"line_number":57,"context_line":"      err(\"Could not find domain with id [#{id}]\")"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"    @domain_hash[id]"},{"line_number":60,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_b1590b5e","line":57,"in_reply_to":"da20952f_cedf3f39","updated":"2015-09-08 14:13:13.000000000","message":"http://docs.puppetlabs.com/references/3.8.latest/function.html#err","commit_id":"c5d3e31bfa317d94a15a4ff9b741a828bd5aa88d"}],"spec/unit/provider/keystone_user/openstack_spec.rb":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"24f919ad631eabc44ebb7492dfd45e679aca6e6a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    before_hook(false, false, true, true, false)"},{"line_number":126,"context_line":"  end"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  describe \u0027when managing a user\u0027 do"},{"line_number":129,"context_line":"    it_behaves_like \u0027authenticated with environment variables\u0027 do"},{"line_number":130,"context_line":"      describe \u0027#create\u0027, :project_only \u003d\u003e true do"},{"line_number":131,"context_line":"        it \u0027creates a user\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_7b71e0a7","line":128,"updated":"2015-09-09 13:09:50.000000000","message":"Ack.","commit_id":"74f01da92f8de2fcb471ec5f9833ead1bff2dee1"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ccdc69aaf0dfe2e25fb358d586c9821a426e8e9a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    before_hook(false, false, true, true, false)"},{"line_number":126,"context_line":"  end"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  describe \u0027when managing a user\u0027 do"},{"line_number":129,"context_line":"    it_behaves_like \u0027authenticated with environment variables\u0027 do"},{"line_number":130,"context_line":"      describe \u0027#create\u0027, :project_only \u003d\u003e true do"},{"line_number":131,"context_line":"        it \u0027creates a user\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_178c427e","line":128,"updated":"2015-09-09 09:44:21.000000000","message":"As noted there https://bugs.launchpad.net/puppet-keystone/+bug/1482243 this way to set env is flawed.  As you started cleaning up the test code is this patch should we fix this here as well or wait for an independent patch.","commit_id":"74f01da92f8de2fcb471ec5f9833ead1bff2dee1"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"489989ea6ecf95b1c150071b2679077f79052311","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    before_hook(false, false, true, true, false)"},{"line_number":126,"context_line":"  end"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  describe \u0027when managing a user\u0027 do"},{"line_number":129,"context_line":"    it_behaves_like \u0027authenticated with environment variables\u0027 do"},{"line_number":130,"context_line":"      describe \u0027#create\u0027, :project_only \u003d\u003e true do"},{"line_number":131,"context_line":"        it \u0027creates a user\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_afec1693","line":128,"in_reply_to":"da20952f_178c427e","updated":"2015-09-09 11:54:19.000000000","message":"There effectively are a bunch of rspec files that have the issue.  \n\nWe definitely need to address those but because at the moment there are issues with domains, which involve a sequence of reviews (dependencies), I\u0027m   voting for having them fixed in a separate patch, although coming very next.","commit_id":"74f01da92f8de2fcb471ec5f9833ead1bff2dee1"}]}