)]}'
{"manifests/roles/admin.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d774e70ec4e067beaa075fa98a6e93007cddcc60","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*ignore_default_tenant*]"},{"line_number":37,"context_line":"#   Ignore setting the default tenant value when the user is created. Optional."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*admin_tenant_desc*]"},{"line_number":41,"context_line":"#   Optional. Description for admin tenant,"},{"line_number":42,"context_line":"#   Defaults to \u0027admin tenant\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a29b11f_75a6dbc2","side":"PARENT","line":39,"updated":"2015-10-19 13:17:27.000000000","message":"This is not how we do parameter deprecation.\nYou should respect backward compatibility rules, that keep the parameter for one release, send a warning to explain we will drop the parameter later, and keep the interface working with this parameter.","commit_id":"d2c44f731caa1ac3e57c407fc63c0c790e99e43f"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"fdcd2f1695411bf59153d701bcfd28b73a190cce","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*ignore_default_tenant*]"},{"line_number":37,"context_line":"#   Ignore setting the default tenant value when the user is created. Optional."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*admin_tenant_desc*]"},{"line_number":41,"context_line":"#   Optional. Description for admin tenant,"},{"line_number":42,"context_line":"#   Defaults to \u0027admin tenant\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a29b11f_c897f48e","side":"PARENT","line":39,"in_reply_to":"3a29b11f_75a6dbc2","updated":"2015-10-20 02:22:22.000000000","message":"I don\u0027t understand, the feature has been deprecated and was scheduled to be removed in Liberty.","commit_id":"d2c44f731caa1ac3e57c407fc63c0c790e99e43f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"48f9074bae9eefc66eb09d60917d3267b79bcd89","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*ignore_default_tenant*]"},{"line_number":37,"context_line":"#   Ignore setting the default tenant value when the user is created. Optional."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*admin_tenant_desc*]"},{"line_number":41,"context_line":"#   Optional. Description for admin tenant,"},{"line_number":42,"context_line":"#   Defaults to \u0027admin tenant\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a29b11f_ea4accc4","side":"PARENT","line":39,"in_reply_to":"3a29b11f_aa75b498","updated":"2015-10-20 14:10:22.000000000","message":"Oh, it was done in provider. Sorry.","commit_id":"d2c44f731caa1ac3e57c407fc63c0c790e99e43f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"370ab65f611eb07da676645c66cf6e4a335fd41e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*ignore_default_tenant*]"},{"line_number":37,"context_line":"#   Ignore setting the default tenant value when the user is created. Optional."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*admin_tenant_desc*]"},{"line_number":41,"context_line":"#   Optional. Description for admin tenant,"},{"line_number":42,"context_line":"#   Defaults to \u0027admin tenant\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a29b11f_20554e1c","side":"PARENT","line":39,"in_reply_to":"3a29b11f_c897f48e","updated":"2015-10-20 11:39:29.000000000","message":"Emilien is right. So, you\u0027re removing some parameter, which is not deprecated yet. And hence you must mark this parameter as deprecated and raise some warning message. You can set this parameter to undef, remove using of this parameter, but you must keep this parameter in class definition.\n\nJust for example, some user has never seen before any warnings for this parameter and if he will try to use it again - puppet will failed.","commit_id":"d2c44f731caa1ac3e57c407fc63c0c790e99e43f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d602785ad84340beeb65c577a19aa6d06f4a3a9b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*ignore_default_tenant*]"},{"line_number":37,"context_line":"#   Ignore setting the default tenant value when the user is created. Optional."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*admin_tenant_desc*]"},{"line_number":41,"context_line":"#   Optional. Description for admin tenant,"},{"line_number":42,"context_line":"#   Defaults to \u0027admin tenant\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a29b11f_aa75b498","side":"PARENT","line":39,"in_reply_to":"3a29b11f_c897f48e","updated":"2015-10-20 14:00:22.000000000","message":"Warning: ([keystone_user]: The ignore_default_tenant parameter is deprecated and will be removed in the future.\n\nI missed that deprecating warning. It\u0027s fine now.","commit_id":"d2c44f731caa1ac3e57c407fc63c0c790e99e43f"}]}