)]}'
{"manifests/endpoint.pp":[{"author":{"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},"change_message_id":"16f211725201a5926a209026eb7999dc03dc791b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*service_name*]"},{"line_number":40,"context_line":"#    Name of the service. Optional."},{"line_number":41,"context_line":"#    Defaults to \u0027keystone\u0027."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":44,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_2deec68b","line":41,"updated":"2015-12-10 13:22:23.000000000","message":"\u0027service_name\" default values in description and in keystone::endpoint class are not the same.","commit_id":"b98b56f48f51b7136d0be6640de6824112b65b77"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"b53c95b1cebecc8c3c9c037332e7e5d703aaa365","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*service_name*]"},{"line_number":40,"context_line":"#    Name of the service. Optional."},{"line_number":41,"context_line":"#    Defaults to \u0027keystone\u0027."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":44,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a710552_1f5a2a84","line":41,"in_reply_to":"7a740942_2deec68b","updated":"2015-12-15 12:05:03.000000000","message":"Done","commit_id":"b98b56f48f51b7136d0be6640de6824112b65b77"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e4d8fd5836718de646a30a968d38b864339ed687","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  # TODO(mmagr): change default service names according to default_catalog in next (M) cycle"},{"line_number":100,"context_line":"  if !$service_name {"},{"line_number":101,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Identity Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa69d971_386a721b","line":100,"updated":"2016-01-04 13:34:38.000000000","message":"I would rather check if the service_name \u003d\u003d \"Identity Service\".\n\nI noticed that after you did puppet-glance and others.","commit_id":"b3458b0ee5638ffb56ccc514abb3ca4ef6d09e56"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6f998be57e913d0c4647daa3a4890a9bec727580","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    configure_user      \u003d\u003e false,"},{"line_number":106,"context_line":"    configure_user_role \u003d\u003e false,"},{"line_number":107,"context_line":"    service_type        \u003d\u003e \u0027identity\u0027,"},{"line_number":108,"context_line":"    service_name        \u003d\u003e $service_name,"},{"line_number":109,"context_line":"    service_description \u003d\u003e \u0027OpenStack Identity Service\u0027,"},{"line_number":110,"context_line":"    public_url          \u003d\u003e $public_url_real,"},{"line_number":111,"context_line":"    admin_url           \u003d\u003e $admin_url_real,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fa69d971_6acdcc85","line":108,"updated":"2016-01-07 14:22:37.000000000","message":"isn\u0027t a big deal to have undef by default for this parameter? What is the expected result?","commit_id":"6f1d1e918ff7795a319b8725eee2c69a75940fe1"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"01b4bd6157c36e42b285b6701c6a79082c4d7b68","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    configure_user      \u003d\u003e false,"},{"line_number":106,"context_line":"    configure_user_role \u003d\u003e false,"},{"line_number":107,"context_line":"    service_type        \u003d\u003e \u0027identity\u0027,"},{"line_number":108,"context_line":"    service_name        \u003d\u003e $service_name,"},{"line_number":109,"context_line":"    service_description \u003d\u003e \u0027OpenStack Identity Service\u0027,"},{"line_number":110,"context_line":"    public_url          \u003d\u003e $public_url_real,"},{"line_number":111,"context_line":"    admin_url           \u003d\u003e $admin_url_real,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bae84128_5fe1cecf","line":108,"in_reply_to":"fa69d971_6acdcc85","updated":"2016-02-25 15:12:49.000000000","message":"Service name will be \u0027keystone\u0027 by default, see [1]. IMHO it is not a big deal as it was undef the whole time. This patch just adds possibility to change the value.\n\n[1] https://github.com/openstack/puppet-keystone/blob/master/manifests/resource/service_identity.pp#L128","commit_id":"6f1d1e918ff7795a319b8725eee2c69a75940fe1"}]}