)]}'
{"lib/puppet/parser/functions/get_scoped_args.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f7f120b00cf48a89317dcca5c83dbdb1359cd431","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    # Grab the current scope, turn it to a hash but do not be recursive"},{"line_number":17,"context_line":"    # about it."},{"line_number":18,"context_line":"    classhash \u003d to_hash(recursive\u003dfalse)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    # Strip bits that do not matter for validation"},{"line_number":21,"context_line":"    classhash.delete(\u0027name\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a29b11f_3e53e23a","line":18,"updated":"2015-10-21 16:59:42.000000000","message":"What object is to_hash operating on?  `arguments`?","commit_id":"a3cd9a7a191e5bbbda5f92bf6196d955823c461d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"63dc07f415f67bfd573002516bd001456c19cbd3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    # Grab the current scope, turn it to a hash but do not be recursive"},{"line_number":17,"context_line":"    # about it."},{"line_number":18,"context_line":"    classhash \u003d to_hash(recursive\u003dfalse)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    # Strip bits that do not matter for validation"},{"line_number":21,"context_line":"    classhash.delete(\u0027name\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a29b11f_9966a24f","line":18,"in_reply_to":"3a29b11f_3e53e23a","updated":"2015-10-22 15:56:41.000000000","message":"A Puppet::Parser::Scope object which is self at that moment.  It the ldap class context it gives exactly that : Scope(Class[Keystone::Ldap])","commit_id":"a3cd9a7a191e5bbbda5f92bf6196d955823c461d"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"8aa8a37b1f67b04168ab4adec1960c01e2398af8","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    # Grab the current scope, turn it to a hash but do not be recursive"},{"line_number":17,"context_line":"    # about it."},{"line_number":18,"context_line":"    classhash \u003d to_hash(recursive\u003dfalse)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    # Strip bits that do not matter for validation"},{"line_number":21,"context_line":"    classhash.delete(\u0027name\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a29b11f_742f0b3f","line":18,"in_reply_to":"3a29b11f_9966a24f","updated":"2015-10-22 16:11:07.000000000","message":"that\u0027s very cool - I will have to remember that","commit_id":"a3cd9a7a191e5bbbda5f92bf6196d955823c461d"}],"manifests/ldap_backend.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"cb8b408af18244f11ddaa985a906fcbefab2c2a5","unresolved":false,"context_lines":[{"line_number":483,"context_line":"  $domain_dir_enabled \u003d getparam(Keystone_config[\u0027identity/domain_config_dir\u0027], \u0027value\u0027)"},{"line_number":484,"context_line":"  $err_msg \u003d \"You should add \\\"using_domain_config \u003d\u003e true\\\" parameter to your Keystone class, got \\\"${domain_enabled}\\\" for identity/domain_specific_drivers_enabled and \\\"${domain_dir_enabled}\\\" for identity/domain_config_dir\""},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"  if(bool2num($domain_enabled) \u003d\u003d 0) {"},{"line_number":487,"context_line":"    fail($err_msg)"},{"line_number":488,"context_line":"  }"},{"line_number":489,"context_line":"  validate_re($domain_dir_enabled, \u0027^/.+\u0027, $err_msg)"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7a740942_6610844f","line":486,"updated":"2015-12-10 06:04:31.000000000","message":"Why not just \"if $domain_enabled\"?","commit_id":"c4e18db2631dd270a22d4485d8f4aba4a363250a"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4c61872a3c7872dcecac789d685518099ee561d1","unresolved":false,"context_lines":[{"line_number":483,"context_line":"  $domain_dir_enabled \u003d getparam(Keystone_config[\u0027identity/domain_config_dir\u0027], \u0027value\u0027)"},{"line_number":484,"context_line":"  $err_msg \u003d \"You should add \\\"using_domain_config \u003d\u003e true\\\" parameter to your Keystone class, got \\\"${domain_enabled}\\\" for identity/domain_specific_drivers_enabled and \\\"${domain_dir_enabled}\\\" for identity/domain_config_dir\""},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"  if(bool2num($domain_enabled) \u003d\u003d 0) {"},{"line_number":487,"context_line":"    fail($err_msg)"},{"line_number":488,"context_line":"  }"},{"line_number":489,"context_line":"  validate_re($domain_dir_enabled, \u0027^/.+\u0027, $err_msg)"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7a740942_dafd7d6f","line":486,"in_reply_to":"7a740942_6610844f","updated":"2015-12-10 12:14:27.000000000","message":"identity/domain_specific_drivers_enabled can have value like \u0027False\u0027, \u0027f\u0027, 0 which would then be interpreted as true if I\u0027d use \"if $domain_enabled\".  bool2num (https://forge.puppetlabs.com/puppetlabs/stdlib#bool2num) solves this for me.","commit_id":"c4e18db2631dd270a22d4485d8f4aba4a363250a"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"097ba9e695c16489df93a815a4158163d588844e","unresolved":false,"context_lines":[{"line_number":483,"context_line":"  $domain_dir_enabled \u003d getparam(Keystone_config[\u0027identity/domain_config_dir\u0027], \u0027value\u0027)"},{"line_number":484,"context_line":"  $err_msg \u003d \"You should add \\\"using_domain_config \u003d\u003e true\\\" parameter to your Keystone class, got \\\"${domain_enabled}\\\" for identity/domain_specific_drivers_enabled and \\\"${domain_dir_enabled}\\\" for identity/domain_config_dir\""},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"  if(bool2num($domain_enabled) \u003d\u003d 0) {"},{"line_number":487,"context_line":"    fail($err_msg)"},{"line_number":488,"context_line":"  }"},{"line_number":489,"context_line":"  validate_re($domain_dir_enabled, \u0027^/.+\u0027, $err_msg)"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7a740942_cc2a7990","line":486,"in_reply_to":"7a740942_dafd7d6f","updated":"2015-12-11 05:40:56.000000000","message":"Ah yeah. I recall the mailing list discussion now too about building a generic solution for this issue.","commit_id":"c4e18db2631dd270a22d4485d8f4aba4a363250a"}],"spec/acceptance/basic_keystone_spec.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"face4c329cafcd240b51542c4e0d82c01eea605b","unresolved":false,"context_lines":[{"line_number":430,"context_line":"          # which doesn\u0027t exit.  The next \"test\" clean everything up"},{"line_number":431,"context_line":"          # to have a working keystone again."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"          # TODO: Sould we add a working ldap server ?"},{"line_number":434,"context_line":"        end"},{"line_number":435,"context_line":"        context \u0027/etc/keystone/domains/keystone.domain_1_ldap_backend.conf\u0027 do"},{"line_number":436,"context_line":"          it_behaves_like \u0027a_valid_keystone_domain_configuration\u0027, \u003c\u003c-EOC"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"1a26ad4f_5118a584","line":433,"updated":"2015-10-28 00:04:03.000000000","message":"Yes, but that is outside the scope of this issue/feature.  There should be another task to add support for using an LDAP server in CI.","commit_id":"ee6ae85b6aa7b5d875def41639094dd0f3f287bd"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"7c59e3666d3fcffbb6abdbf176614ef69d083ecb","unresolved":false,"context_lines":[{"line_number":430,"context_line":"          # which doesn\u0027t exit.  The next \"test\" clean everything up"},{"line_number":431,"context_line":"          # to have a working keystone again."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"          # TODO: Sould we add a working ldap server ?"},{"line_number":434,"context_line":"        end"},{"line_number":435,"context_line":"        context \u0027/etc/keystone/domains/keystone.domain_1_ldap_backend.conf\u0027 do"},{"line_number":436,"context_line":"          it_behaves_like \u0027a_valid_keystone_domain_configuration\u0027, \u003c\u003c-EOC"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"1a26ad4f_a0f2f798","line":433,"in_reply_to":"1a26ad4f_5118a584","updated":"2015-10-28 10:23:01.000000000","message":"Make sense.  I captured this comment here https://trello.com/c/DuNmElKz/70-add-a-ldap-server-to-keystone-acceptance-test-for-testing-ldap-backend .","commit_id":"ee6ae85b6aa7b5d875def41639094dd0f3f287bd"}]}