)]}'
{"lib/puppet/provider/keystone_endpoint/openstack.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"96be4c39346bcaf50987649e5c03a4237184fa0d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  end"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  def self.service_type(services, region, name)"},{"line_number":159,"context_line":"    # make it a case"},{"line_number":160,"context_line":"    if services.count \u003e 1"},{"line_number":161,"context_line":"      fail(\u0027Cannot get the correct endpoint: \u0027 \\"},{"line_number":162,"context_line":"           \"got multiple service matches: #{endpoint.join(\u0027 \u0027)} \" \\"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_7aa61baf","line":159,"updated":"2015-11-20 03:55:11.000000000","message":"A case sounds good. :)","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"7d93ba3a148d681978ea598e838f80be701f6446","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  end"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  def self.service_type(services, region, name)"},{"line_number":159,"context_line":"    # make it a case"},{"line_number":160,"context_line":"    if services.count \u003e 1"},{"line_number":161,"context_line":"      fail(\u0027Cannot get the correct endpoint: \u0027 \\"},{"line_number":162,"context_line":"           \"got multiple service matches: #{endpoint.join(\u0027 \u0027)} \" \\"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_5aeea2b5","line":159,"in_reply_to":"ba8a016a_7aa61baf","updated":"2015-11-23 10:37:06.000000000","message":"Done, and more...","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"}],"lib/puppet/type/keystone_endpoint.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"96be4c39346bcaf50987649e5c03a4237184fa0d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    defaultto do"},{"line_number":28,"context_line":"      deprecation_msg \u003d \u0027Support for a endpoint without the type \u0027 \\"},{"line_number":29,"context_line":"      \u0027set is deprecated in Liberty cycle. \u0027 \\"},{"line_number":30,"context_line":"      \u0027It will be dropped in the M-cycle. \u0027"},{"line_number":31,"context_line":"      warning(deprecation_msg)"},{"line_number":32,"context_line":"      PuppetX::Keystone::CompositeNamevar::Unset"},{"line_number":33,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_badb234e","line":30,"updated":"2015-11-20 03:55:11.000000000","message":"Liberty cycle is just Liberty.\nM-cycle is Mikata.","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"7d93ba3a148d681978ea598e838f80be701f6446","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    defaultto do"},{"line_number":28,"context_line":"      deprecation_msg \u003d \u0027Support for a endpoint without the type \u0027 \\"},{"line_number":29,"context_line":"      \u0027set is deprecated in Liberty cycle. \u0027 \\"},{"line_number":30,"context_line":"      \u0027It will be dropped in the M-cycle. \u0027"},{"line_number":31,"context_line":"      warning(deprecation_msg)"},{"line_number":32,"context_line":"      PuppetX::Keystone::CompositeNamevar::Unset"},{"line_number":33,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_1a7d7ae7","line":30,"in_reply_to":"ba8a016a_badb234e","updated":"2015-11-23 10:37:06.000000000","message":"Done","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"}],"lib/puppet_x/keystone/type/required.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"e54c9ca289c9e328deafea4835b1284ae6d8b3ab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"              end"},{"line_number":12,"context_line":"              fail(Puppet::ResourceError,"},{"line_number":13,"context_line":"                   \"#{custom}\" \\"},{"line_number":14,"context_line":"                     \"Parameter #{name} failed on \" \\"},{"line_number":15,"context_line":"                     \"#{resource.class.to_s.split(\u0027::\u0027)[-1]}[#{resource.name}]: \" \\"},{"line_number":16,"context_line":"                     \u0027Required parameter.\u0027)"},{"line_number":17,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da85f559_7aeb36b1","line":14,"updated":"2015-11-13 19:08:53.000000000","message":"Is this indentation correct?  Looks weird.","commit_id":"ab5df1ef5801a6a6bb8b13e759aaa2d8f293ab70"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f89aeb5acd49710e33996460195966fde200ac90","unresolved":false,"context_lines":[{"line_number":11,"context_line":"              end"},{"line_number":12,"context_line":"              fail(Puppet::ResourceError,"},{"line_number":13,"context_line":"                   \"#{custom}\" \\"},{"line_number":14,"context_line":"                     \"Parameter #{name} failed on \" \\"},{"line_number":15,"context_line":"                     \"#{resource.class.to_s.split(\u0027::\u0027)[-1]}[#{resource.name}]: \" \\"},{"line_number":16,"context_line":"                     \u0027Required parameter.\u0027)"},{"line_number":17,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_ebb30309","line":14,"in_reply_to":"da85f559_12ba0ae2","updated":"2015-11-16 15:11:12.000000000","message":"ack","commit_id":"ab5df1ef5801a6a6bb8b13e759aaa2d8f293ab70"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fd70c778ace9922a23eb43aa969232f0b4e2e624","unresolved":false,"context_lines":[{"line_number":11,"context_line":"              end"},{"line_number":12,"context_line":"              fail(Puppet::ResourceError,"},{"line_number":13,"context_line":"                   \"#{custom}\" \\"},{"line_number":14,"context_line":"                     \"Parameter #{name} failed on \" \\"},{"line_number":15,"context_line":"                     \"#{resource.class.to_s.split(\u0027::\u0027)[-1]}[#{resource.name}]: \" \\"},{"line_number":16,"context_line":"                     \u0027Required parameter.\u0027)"},{"line_number":17,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"da85f559_12ba0ae2","line":14,"in_reply_to":"da85f559_7aeb36b1","updated":"2015-11-14 01:00:04.000000000","message":"Rubycop seems ok with it, and it\u0027s the default emacs.  The \"\\\" seems to trigger some sort of continuation line that is being shown with the usual 2 spaces prefix.","commit_id":"ab5df1ef5801a6a6bb8b13e759aaa2d8f293ab70"}],"spec/unit/provider/keystone_endpoint/openstack_spec.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"96be4c39346bcaf50987649e5c03a4237184fa0d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        end"},{"line_number":68,"context_line":"      end"},{"line_number":69,"context_line":"      context \u0027with the type\u0027 do"},{"line_number":70,"context_line":"        let(:service_name) { \u00277879613d0f3d4b3db1ce57203d17918d\u0027 }"},{"line_number":71,"context_line":"        let(:endpoint_attrs) do"},{"line_number":72,"context_line":"          {"},{"line_number":73,"context_line":"            :title        \u003d\u003e \u0027region/endpoint\u0027,"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_9acc1f8a","line":70,"updated":"2015-11-20 03:55:11.000000000","message":"Can we use instead \"endpoint1_id\" for the id?","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"7d93ba3a148d681978ea598e838f80be701f6446","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        end"},{"line_number":68,"context_line":"      end"},{"line_number":69,"context_line":"      context \u0027with the type\u0027 do"},{"line_number":70,"context_line":"        let(:service_name) { \u00277879613d0f3d4b3db1ce57203d17918d\u0027 }"},{"line_number":71,"context_line":"        let(:endpoint_attrs) do"},{"line_number":72,"context_line":"          {"},{"line_number":73,"context_line":"            :title        \u003d\u003e \u0027region/endpoint\u0027,"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_adb2fa04","line":70,"in_reply_to":"ba8a016a_9acc1f8a","updated":"2015-11-23 10:37:06.000000000","message":"Well, it\u0027s really the service id, so I put service_id1 here.","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"96be4c39346bcaf50987649e5c03a4237184fa0d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          described_class.expects(:openstack)"},{"line_number":84,"context_line":"            .with(\u0027service\u0027, \u0027list\u0027, \u0027--quiet\u0027, \u0027--format\u0027, \u0027csv\u0027, [])"},{"line_number":85,"context_line":"            .returns(\u0027\"ID\",\"Name\",\"Type\""},{"line_number":86,"context_line":"\"7879613d0f3d4b3db1ce57203d17918d\",\"endpoint\",\"type_one\""},{"line_number":87,"context_line":"\u0027)"},{"line_number":88,"context_line":"          provider.create"},{"line_number":89,"context_line":"          expect(provider.exists?).to be_truthy"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_3ac73365","line":86,"updated":"2015-11-20 03:55:11.000000000","message":"Same","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"7d93ba3a148d681978ea598e838f80be701f6446","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          described_class.expects(:openstack)"},{"line_number":84,"context_line":"            .with(\u0027service\u0027, \u0027list\u0027, \u0027--quiet\u0027, \u0027--format\u0027, \u0027csv\u0027, [])"},{"line_number":85,"context_line":"            .returns(\u0027\"ID\",\"Name\",\"Type\""},{"line_number":86,"context_line":"\"7879613d0f3d4b3db1ce57203d17918d\",\"endpoint\",\"type_one\""},{"line_number":87,"context_line":"\u0027)"},{"line_number":88,"context_line":"          provider.create"},{"line_number":89,"context_line":"          expect(provider.exists?).to be_truthy"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_6dcdf285","line":86,"in_reply_to":"ba8a016a_3ac73365","updated":"2015-11-23 10:37:06.000000000","message":"Same.","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"}],"spec/unit/type/keystone_endpoint_spec.rb":[{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"96be4c39346bcaf50987649e5c03a4237184fa0d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        include_examples \u0027autorequire the correct resources\u0027"},{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":"    context \u0027domain autorequire from title without type (to be removed at Mitika)\u0027 do"},{"line_number":38,"context_line":"      let(:endpoint) do"},{"line_number":39,"context_line":"        Puppet::Type.type(:keystone_endpoint).new(:title \u003d\u003e \u0027region_one/service_one\u0027)"},{"line_number":40,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_ba8003f8","line":37,"updated":"2015-11-20 03:55:11.000000000","message":"Mitaka :)","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"7d93ba3a148d681978ea598e838f80be701f6446","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        include_examples \u0027autorequire the correct resources\u0027"},{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":"    context \u0027domain autorequire from title without type (to be removed at Mitika)\u0027 do"},{"line_number":38,"context_line":"      let(:endpoint) do"},{"line_number":39,"context_line":"        Puppet::Type.type(:keystone_endpoint).new(:title \u003d\u003e \u0027region_one/service_one\u0027)"},{"line_number":40,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ba8a016a_0da546b4","line":37,"in_reply_to":"ba8a016a_ba8003f8","updated":"2015-11-23 10:37:06.000000000","message":"I think I don\u0027t like this name :)","commit_id":"4c8217a360cc2c4e0815771a6d9692fccf7693b6"}]}