)]}'
{"lib/puppet/provider/keystone_domain/openstack.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"018470a2789280305c2b3a94190116afedf44522","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property_flush[:is_default] \u003d value"},{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def current_default_domain_id"},{"line_number":73,"context_line":"    self.class.current_default_domain_id"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_8559c95c","line":72,"updated":"2015-11-04 21:08:37.000000000","message":"Not sure what the thinking is about using instance methods to wrap class methods, rather than just call the class method directly.  It doesn\u0027t matter to me, but I\u0027ve been dinged in the past about doing this sort of thing.","commit_id":"5585ad6ebf788be91319d8c4d34b085f6435604b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ea80ec9e803648926710b4807a2815df81f0ea35","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property_flush[:is_default] \u003d value"},{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def current_default_domain_id"},{"line_number":73,"context_line":"    self.class.current_default_domain_id"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_f047f2b9","line":72,"in_reply_to":"fa80f949_8559c95c","updated":"2015-11-06 09:21:35.000000000","message":"Hum .. should be no different than calling the class method.  It\u0027s just a convenient wrapper.  If you have some reference, I\u0027d be interested as I may be missing something.","commit_id":"5585ad6ebf788be91319d8c4d34b085f6435604b"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"066f4be0b74fd2c07ec6ee66bba90e73339dfd45","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property_flush[:is_default] \u003d value"},{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def current_default_domain_id"},{"line_number":73,"context_line":"    self.class.current_default_domain_id"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_3ec69d68","line":72,"in_reply_to":"fa80f949_f047f2b9","updated":"2015-11-06 14:52:22.000000000","message":"It was gildub who recommended to me not to do this.","commit_id":"5585ad6ebf788be91319d8c4d34b085f6435604b"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"018470a2789280305c2b3a94190116afedf44522","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      if curid \u003d\u003d newid"},{"line_number":89,"context_line":"        entry.destroy"},{"line_number":90,"context_line":"      end"},{"line_number":91,"context_line":"    end"},{"line_number":92,"context_line":"  end"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  def self.instances"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_85ab091d","line":91,"updated":"2015-11-04 21:08:37.000000000","message":"cool!","commit_id":"5585ad6ebf788be91319d8c4d34b085f6435604b"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6690b92e413d446e07366f5c8c985ab0c29a85f3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property_flush[:is_default] \u003d value"},{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def current_default_domain_id"},{"line_number":73,"context_line":"    self.class.current_default_domain_id"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_98b947ec","line":72,"updated":"2015-11-17 05:27:01.000000000","message":"This instance method is not needed, the class method to be called when needed. See below.","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"8fb214124757aae7f41b1a5996254efbb4206987","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property_flush[:is_default] \u003d value"},{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def current_default_domain_id"},{"line_number":73,"context_line":"    self.class.current_default_domain_id"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_31e3e3da","line":72,"in_reply_to":"ba8a016a_7f0b89d6","updated":"2015-11-19 23:03:27.000000000","message":"LOL!\n\nAt some time we almost got burned with every class method being doubled as instance methods so both could be accessed depending on the context (self.instances or single resource). I had to slam the OO book on the table! ;)","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"342bdb4fa6146aaf59004b0e3fea8c5bd94d7ed0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property_flush[:is_default] \u003d value"},{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  def current_default_domain_id"},{"line_number":73,"context_line":"    self.class.current_default_domain_id"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_7f0b89d6","line":72,"in_reply_to":"ba8a016a_98b947ec","updated":"2015-11-19 19:45:39.000000000","message":"Yes, I though I was a conveniant helper.  Rich told me that you don\u0027t like it.  Not sure why, but I remove it anyway :)\n\nAnyway, this is changed with https://review.openstack.org/#/c/247063/","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6690b92e413d446e07366f5c8c985ab0c29a85f3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  def ensure_default_domain(create, destroy\u003dfalse, value\u003dnil)"},{"line_number":77,"context_line":"    curid \u003d current_default_domain_id"},{"line_number":78,"context_line":"    newid \u003d id"},{"line_number":79,"context_line":"    default \u003d (is_default \u003d\u003d :true)"},{"line_number":80,"context_line":"    entry \u003d keystone_conf_default_domain_id_entry(newid)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_78b4a3f1","line":77,"updated":"2015-11-17 05:27:01.000000000","message":"Why not use the class method to directly?  \n\ncurid \u003d self.class.current_default_domain_id","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6690b92e413d446e07366f5c8c985ab0c29a85f3","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  def ensure_default_domain(create, destroy\u003dfalse, value\u003dnil)"},{"line_number":77,"context_line":"    curid \u003d current_default_domain_id"},{"line_number":78,"context_line":"    newid \u003d id"},{"line_number":79,"context_line":"    default \u003d (is_default \u003d\u003d :true)"},{"line_number":80,"context_line":"    entry \u003d keystone_conf_default_domain_id_entry(newid)"},{"line_number":81,"context_line":"    if (default \u0026\u0026 create) || (!default \u0026\u0026 (value \u003d\u003d :true))"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_1801d7ae","line":78,"updated":"2015-11-17 05:27:01.000000000","message":"Why not just use id?","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"342bdb4fa6146aaf59004b0e3fea8c5bd94d7ed0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  def ensure_default_domain(create, destroy\u003dfalse, value\u003dnil)"},{"line_number":77,"context_line":"    curid \u003d current_default_domain_id"},{"line_number":78,"context_line":"    newid \u003d id"},{"line_number":79,"context_line":"    default \u003d (is_default \u003d\u003d :true)"},{"line_number":80,"context_line":"    entry \u003d keystone_conf_default_domain_id_entry(newid)"},{"line_number":81,"context_line":"    if (default \u0026\u0026 create) || (!default \u0026\u0026 (value \u003d\u003d :true))"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_5fbd65d6","line":78,"in_reply_to":"ba8a016a_1801d7ae","updated":"2015-11-19 19:45:39.000000000","message":"This code I didn\u0027t change :)  But I can refactor it as well.","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"8fb214124757aae7f41b1a5996254efbb4206987","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  def ensure_default_domain(create, destroy\u003dfalse, value\u003dnil)"},{"line_number":77,"context_line":"    curid \u003d current_default_domain_id"},{"line_number":78,"context_line":"    newid \u003d id"},{"line_number":79,"context_line":"    default \u003d (is_default \u003d\u003d :true)"},{"line_number":80,"context_line":"    entry \u003d keystone_conf_default_domain_id_entry(newid)"},{"line_number":81,"context_line":"    if (default \u0026\u0026 create) || (!default \u0026\u0026 (value \u003d\u003d :true))"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_1161ffa8","line":78,"in_reply_to":"ba8a016a_5fbd65d6","updated":"2015-11-19 23:03:27.000000000","message":"My bad! No worries :)","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6690b92e413d446e07366f5c8c985ab0c29a85f3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    entry \u003d keystone_conf_default_domain_id_entry(newid)"},{"line_number":81,"context_line":"    if (default \u0026\u0026 create) || (!default \u0026\u0026 (value \u003d\u003d :true))"},{"line_number":82,"context_line":"      # new default domain, or making existing domain the default domain"},{"line_number":83,"context_line":"      if curid !\u003d newid"},{"line_number":84,"context_line":"        entry.create"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":"    elsif (default \u0026\u0026 destroy) || (default \u0026\u0026 (value \u003d\u003d :false))"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_58cc3f89","line":83,"updated":"2015-11-17 05:27:01.000000000","message":"Same","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"6690b92e413d446e07366f5c8c985ab0c29a85f3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":"    elsif (default \u0026\u0026 destroy) || (default \u0026\u0026 (value \u003d\u003d :false))"},{"line_number":87,"context_line":"      # removing default domain, or making this domain not the default"},{"line_number":88,"context_line":"      if curid \u003d\u003d newid"},{"line_number":89,"context_line":"        entry.destroy"},{"line_number":90,"context_line":"      end"},{"line_number":91,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_f8c89376","line":88,"updated":"2015-11-17 05:27:01.000000000","message":"same","commit_id":"767e9097ca19e925bd1a1927743df950170c9471"}]}