)]}'
{"manifests/service.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"ba4a94cdaba91c11631a58c3c82d7a57ff29608c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    $cacert_s \u003d \u0027\u0027"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $validate and $admin_token and $admin_endpoint {"},{"line_number":106,"context_line":"    $cmd \u003d \"openstack --os-auth-url ${admin_endpoint} --os-token ${admin_token} ${insecure_s} ${cacert_s} user list\""},{"line_number":107,"context_line":"    $catch \u003d \u0027name\u0027"},{"line_number":108,"context_line":"    exec { \u0027validate_keystone_connection\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_f037da4a","side":"PARENT","line":105,"updated":"2015-11-27 01:13:23.000000000","message":"I think the exec just needs to subscribe to the httpd service and then this should still work, right? This could probably go into a new class if this one is being removed, or perhaps we could consolidate the validation code into extras. Thoughts?","commit_id":"02061e6e7cc3c1c13dc4b59c697585a896593468"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"2b5044689e6a9e94373815c2a6d178af08e27569","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    $cacert_s \u003d \u0027\u0027"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $validate and $admin_token and $admin_endpoint {"},{"line_number":106,"context_line":"    $cmd \u003d \"openstack --os-auth-url ${admin_endpoint} --os-token ${admin_token} ${insecure_s} ${cacert_s} user list\""},{"line_number":107,"context_line":"    $catch \u003d \u0027name\u0027"},{"line_number":108,"context_line":"    exec { \u0027validate_keystone_connection\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_cec07f2d","side":"PARENT","line":105,"in_reply_to":"9a8ffd7b_7b16fdf2","updated":"2015-12-01 03:35:34.000000000","message":"Oh neat, a proper solution :D","commit_id":"02061e6e7cc3c1c13dc4b59c697585a896593468"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"ca46802ab867da2db627761be0c0be8f34042590","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    $cacert_s \u003d \u0027\u0027"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $validate and $admin_token and $admin_endpoint {"},{"line_number":106,"context_line":"    $cmd \u003d \"openstack --os-auth-url ${admin_endpoint} --os-token ${admin_token} ${insecure_s} ${cacert_s} user list\""},{"line_number":107,"context_line":"    $catch \u003d \u0027name\u0027"},{"line_number":108,"context_line":"    exec { \u0027validate_keystone_connection\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_f510e701","side":"PARENT","line":105,"in_reply_to":"9a8ffd7b_c9f54ced","updated":"2015-11-30 03:21:22.000000000","message":"I posted this in IRC but I\u0027ll also leave it here for anyone else watching:\n\nI originally wrote the validation code because during some puppet runs, all my keystone users would fail to be created sometimes because the resource ordering ended up like this:\n\nService[keystone] -\u003e Keystone_user[admin]\n\nWhich looks fine, but in reality this equates to running these two commands, one immediately after the other:\n\nservice keystone restart\n\nkeystone user-add admin\n\nWhich will *sometimes* fail, because after restart returns, the keystone process may not have finished setting up its socket, or reading config, or any of a half dozen other things that it does during initialisation before it\u0027s actually ready to accept requests despite the service being \u0027running\u0027. So I implemented the validation exec as a way to stop my CI system from getting random failures.\n\nI suspect this will not change regardless of the switch to httpd, and the only change needed to keep this functionality is to change the service subscription to Service[\u0027httpd\u0027] along with moving the code to another class if this one is being removed.","commit_id":"02061e6e7cc3c1c13dc4b59c697585a896593468"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"12d640e0b43adb2f9b0438dd2bce1ebbd24b7632","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    $cacert_s \u003d \u0027\u0027"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $validate and $admin_token and $admin_endpoint {"},{"line_number":106,"context_line":"    $cmd \u003d \"openstack --os-auth-url ${admin_endpoint} --os-token ${admin_token} ${insecure_s} ${cacert_s} user list\""},{"line_number":107,"context_line":"    $catch \u003d \u0027name\u0027"},{"line_number":108,"context_line":"    exec { \u0027validate_keystone_connection\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_c9f54ced","side":"PARENT","line":105,"in_reply_to":"9a8ffd7b_f037da4a","updated":"2015-11-27 08:07:36.000000000","message":"This code (that you initiated some time ago) was useful because of the previous state of the module.\n\nI\u0027m not sure this validation is useful anymore, can you tell us a usecase?","commit_id":"02061e6e7cc3c1c13dc4b59c697585a896593468"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"eb289a868f283e8319688481d2c648681bafba96","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    $cacert_s \u003d \u0027\u0027"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $validate and $admin_token and $admin_endpoint {"},{"line_number":106,"context_line":"    $cmd \u003d \"openstack --os-auth-url ${admin_endpoint} --os-token ${admin_token} ${insecure_s} ${cacert_s} user list\""},{"line_number":107,"context_line":"    $catch \u003d \u0027name\u0027"},{"line_number":108,"context_line":"    exec { \u0027validate_keystone_connection\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_7b16fdf2","side":"PARENT","line":105,"in_reply_to":"9a8ffd7b_f510e701","updated":"2015-11-30 18:52:45.000000000","message":"\u003e after restart returns, the keystone process may not have finished setting up\n\nThis is solved when running under systemd: oslo.service sends readiness notification when service initialization is done: \n\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L280\n\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/systemd.py","commit_id":"02061e6e7cc3c1c13dc4b59c697585a896593468"}]}