)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0c5493dced5de2f43efde1a43e9b8b993d4d7f5c","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    warning(\u0027Version string /v2.0/ should not be included in keystone::public_endpoint\u0027)"},{"line_number":579,"context_line":"  }"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"  if ! is_service_default($rabbit_use_ssl) {"},{"line_number":582,"context_line":"    if is_service_default($kombu_ssl_ca_certs) {"},{"line_number":583,"context_line":"      fail(\u0027The kombu_ssl_ca_certs parameter is required when rabbit_use_ssl is set to true\u0027)"},{"line_number":584,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_10f681f9","line":581,"updated":"2015-12-10 13:28:35.000000000","message":"and $rabbit_use_ssl","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de712cd88dcb9b5c8a88b80e151c9af4e5c2c9a1","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    warning(\u0027Version string /v2.0/ should not be included in keystone::public_endpoint\u0027)"},{"line_number":579,"context_line":"  }"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"  if ! is_service_default($rabbit_use_ssl) {"},{"line_number":582,"context_line":"    if is_service_default($kombu_ssl_ca_certs) {"},{"line_number":583,"context_line":"      fail(\u0027The kombu_ssl_ca_certs parameter is required when rabbit_use_ssl is set to true\u0027)"},{"line_number":584,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_fd4f0568","line":581,"in_reply_to":"7a740942_10f681f9","updated":"2015-12-10 16:12:49.000000000","message":"Done","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0c5493dced5de2f43efde1a43e9b8b993d4d7f5c","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \u0027cache/memcache_socket_timeout\u0027:      value \u003d\u003e $memcache_socket_timeout;"},{"line_number":728,"context_line":"    \u0027cache/memcache_pool_maxsize\u0027:        value \u003d\u003e $memcache_pool_maxsize;"},{"line_number":729,"context_line":"    \u0027cache/memcache_pool_unused_timeout\u0027: value \u003d\u003e $memcache_pool_unused_timeout;"},{"line_number":730,"context_line":"    \u0027cache/backend\u0027:                      value \u003d\u003e $cache_backend;"},{"line_number":731,"context_line":"    \u0027cache/debug_cache_backend\u0027:          value \u003d\u003e $debug_cache_backend;"},{"line_number":732,"context_line":"    \u0027token/caching\u0027:                      value \u003d\u003e $token_caching;"},{"line_number":733,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_2d31e60b","line":730,"updated":"2015-12-10 13:28:35.000000000","message":"duplicate for 715 line\n\nand also i\u0027m not sure that we can change this section and how it will work if we will disable memcache_servers, but pass another parameters.","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"641dd09acae2b3a03f586ccdc283a5df61dcb5c7","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \u0027cache/memcache_socket_timeout\u0027:      value \u003d\u003e $memcache_socket_timeout;"},{"line_number":728,"context_line":"    \u0027cache/memcache_pool_maxsize\u0027:        value \u003d\u003e $memcache_pool_maxsize;"},{"line_number":729,"context_line":"    \u0027cache/memcache_pool_unused_timeout\u0027: value \u003d\u003e $memcache_pool_unused_timeout;"},{"line_number":730,"context_line":"    \u0027cache/backend\u0027:                      value \u003d\u003e $cache_backend;"},{"line_number":731,"context_line":"    \u0027cache/debug_cache_backend\u0027:          value \u003d\u003e $debug_cache_backend;"},{"line_number":732,"context_line":"    \u0027token/caching\u0027:                      value \u003d\u003e $token_caching;"},{"line_number":733,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_632052b1","line":730,"in_reply_to":"7a740942_1d4bf15a","updated":"2015-12-10 16:28:45.000000000","message":"Or you can find out how it will work :)","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de712cd88dcb9b5c8a88b80e151c9af4e5c2c9a1","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \u0027cache/memcache_socket_timeout\u0027:      value \u003d\u003e $memcache_socket_timeout;"},{"line_number":728,"context_line":"    \u0027cache/memcache_pool_maxsize\u0027:        value \u003d\u003e $memcache_pool_maxsize;"},{"line_number":729,"context_line":"    \u0027cache/memcache_pool_unused_timeout\u0027: value \u003d\u003e $memcache_pool_unused_timeout;"},{"line_number":730,"context_line":"    \u0027cache/backend\u0027:                      value \u003d\u003e $cache_backend;"},{"line_number":731,"context_line":"    \u0027cache/debug_cache_backend\u0027:          value \u003d\u003e $debug_cache_backend;"},{"line_number":732,"context_line":"    \u0027token/caching\u0027:                      value \u003d\u003e $token_caching;"},{"line_number":733,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_1d4bf15a","line":730,"in_reply_to":"7a740942_2d31e60b","updated":"2015-12-10 16:12:49.000000000","message":"For now maybe i should not switch?","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"08597eeb5878c7de5d3e5b6ff4a3699bee6f5c30","unresolved":false,"context_lines":[{"line_number":901,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":902,"context_line":"      user        \u003d\u003e \u0027keystone\u0027,"},{"line_number":903,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":904,"context_line":"      creates     \u003d\u003e \"${fernet_key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e [Package[\u0027keystone\u0027], Keystone_config[\u0027fernet_tokens/key_repository\u0027]],"},{"line_number":907,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_4d964040","line":904,"updated":"2015-12-08 09:57:55.000000000","message":"if you will leave $fernet_key_repository set to os_service_default, it will try to create \u003cSERVICE DEFAULT\u003e/0 directory, this will not work because in fact default service config is pointed to \"key_repository \u003d /etc/keystone/fernet-keys/\", thats why i think we should not to switch it to service_default or add some check here (is_service_default)","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0c5493dced5de2f43efde1a43e9b8b993d4d7f5c","unresolved":false,"context_lines":[{"line_number":901,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":902,"context_line":"      user        \u003d\u003e \u0027keystone\u0027,"},{"line_number":903,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":904,"context_line":"      creates     \u003d\u003e \"${fernet_key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e [Package[\u0027keystone\u0027], Keystone_config[\u0027fernet_tokens/key_repository\u0027]],"},{"line_number":907,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_90b91118","line":904,"in_reply_to":"7a740942_332a27dc","updated":"2015-12-10 13:28:35.000000000","message":"Agree with Nikita.","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fb68bc5b7e825dea3528eb5231cb8c43eb7e67be","unresolved":false,"context_lines":[{"line_number":901,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":902,"context_line":"      user        \u003d\u003e \u0027keystone\u0027,"},{"line_number":903,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":904,"context_line":"      creates     \u003d\u003e \"${fernet_key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e [Package[\u0027keystone\u0027], Keystone_config[\u0027fernet_tokens/key_repository\u0027]],"},{"line_number":907,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_332a27dc","line":904,"in_reply_to":"7a740942_4d964040","updated":"2015-12-08 14:34:12.000000000","message":"Hello Mykyta,  i\u0027ll consider add is_service_default, i\u0027ll wailt for Denis review and in the next patch i\u0027ll update this.\nThank you o/","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de712cd88dcb9b5c8a88b80e151c9af4e5c2c9a1","unresolved":false,"context_lines":[{"line_number":901,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":902,"context_line":"      user        \u003d\u003e \u0027keystone\u0027,"},{"line_number":903,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":904,"context_line":"      creates     \u003d\u003e \"${fernet_key_repository}/0\","},{"line_number":905,"context_line":"      notify      \u003d\u003e Service[$service_name],"},{"line_number":906,"context_line":"      subscribe   \u003d\u003e [Package[\u0027keystone\u0027], Keystone_config[\u0027fernet_tokens/key_repository\u0027]],"},{"line_number":907,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_7d68f521","line":904,"in_reply_to":"7a740942_90b91118","updated":"2015-12-10 16:12:49.000000000","message":"i just let fernet_key_repository without service_default.","commit_id":"3678b296e2f0df69cbbb5ea5f4c31fad44f622b3"}]}