)]}'
{"manifests/endpoint.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"1ddee489bfdd38f92f4c67f594362b9d7353869d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $version           \u003d \u0027unset\u0027, # defaults to \u0027v2.0\u0027 if unset by user"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $version \u003d\u003d \u0027unset\u0027 {"},{"line_number":66,"context_line":"    warning(\u0027In Mitaka, the default value of $keystone::endpoint::version will change to \\\u0027\\\u0027. To avoid this warning, please set the $version parameter.\u0027)"},{"line_number":67,"context_line":"    $_version \u003d \u0027v2.0\u0027"},{"line_number":68,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a710552_dc06e21f","line":65,"updated":"2015-12-15 15:34:26.000000000","message":"I do not understand why you used a string of \u0027unset\u0027.  Why not just undef?","commit_id":"839fb7e08ebc15da67754852d62c4bfcf38318d6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"41ad5dabf2ae6f6c3381231ff87e6d525ce74c9e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $version           \u003d \u0027unset\u0027, # defaults to \u0027v2.0\u0027 if unset by user"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $version \u003d\u003d \u0027unset\u0027 {"},{"line_number":66,"context_line":"    warning(\u0027In Mitaka, the default value of $keystone::endpoint::version will change to \\\u0027\\\u0027. To avoid this warning, please set the $version parameter.\u0027)"},{"line_number":67,"context_line":"    $_version \u003d \u0027v2.0\u0027"},{"line_number":68,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a710552_2d932e5d","line":65,"in_reply_to":"5a710552_dc06e21f","updated":"2015-12-15 16:04:03.000000000","message":"This is explained in the commit message. If the default is undef, then puppet 3 can\u0027t tell the difference between whether the user passed in \u0027\u0027 or didn\u0027t pass anything. We want it to be valid for the user to pass in an empty string, but we want to be able to check the case that the user didn\u0027t pass anything.","commit_id":"839fb7e08ebc15da67754852d62c4bfcf38318d6"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"b36eca3200f1c35e5138671148bf528d5870d0a1","unresolved":false,"context_lines":[{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $version \u003d\u003d \u0027unset\u0027 {"},{"line_number":66,"context_line":"    warning(\u0027In Mitaka, the default value of $keystone::endpoint::version will change to \\\u0027\\\u0027. To avoid this warning, please set the $version parameter.\u0027)"},{"line_number":67,"context_line":"    $_version \u003d \u0027v2.0\u0027"},{"line_number":68,"context_line":"  } else {"},{"line_number":69,"context_line":"    $_version \u003d $version"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a710552_1769a5be","line":66,"updated":"2015-12-15 15:35:52.000000000","message":"The interface the user interacts with will no reference the version parameter as $version, just version.","commit_id":"839fb7e08ebc15da67754852d62c4bfcf38318d6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"41ad5dabf2ae6f6c3381231ff87e6d525ce74c9e","unresolved":false,"context_lines":[{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $version \u003d\u003d \u0027unset\u0027 {"},{"line_number":66,"context_line":"    warning(\u0027In Mitaka, the default value of $keystone::endpoint::version will change to \\\u0027\\\u0027. To avoid this warning, please set the $version parameter.\u0027)"},{"line_number":67,"context_line":"    $_version \u003d \u0027v2.0\u0027"},{"line_number":68,"context_line":"  } else {"},{"line_number":69,"context_line":"    $_version \u003d $version"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a710552_6d87f60f","line":66,"in_reply_to":"5a710552_1769a5be","updated":"2015-12-15 16:04:03.000000000","message":"Done","commit_id":"839fb7e08ebc15da67754852d62c4bfcf38318d6"}]}