)]}'
{"lib/puppet/provider/keystone.rb":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"53c7d94ad6d56702657005f89028ef2289fc513a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  def self.domain_id_from_name(name)"},{"line_number":117,"context_line":"    unless @domain_name_hash"},{"line_number":118,"context_line":"      list \u003d request(\u0027domain\u0027, \u0027list\u0027)"},{"line_number":119,"context_line":"      @domain_name_hash \u003d Hash[list.collect{|domain| [domain[:id], domain[:name]]}]"},{"line_number":120,"context_line":"    end"},{"line_number":121,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":122,"context_line":"      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da6ed579_d9180d87","line":119,"range":{"start_line":119,"start_character":54,"end_line":119,"end_character":80},"updated":"2016-01-13 09:11:17.000000000","message":"maybe vise versa? 1st :name as key and 2nd :id as value","commit_id":"777243daf850db0bf00a1c82d989b5f1291d1b64"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b440e6be673cbe9262041835485aa47501efd2c4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  def self.domain_id_from_name(name)"},{"line_number":117,"context_line":"    unless @domain_name_hash"},{"line_number":118,"context_line":"      list \u003d request(\u0027domain\u0027, \u0027list\u0027)"},{"line_number":119,"context_line":"      @domain_name_hash \u003d Hash[list.collect{|domain| [domain[:id], domain[:name]]}]"},{"line_number":120,"context_line":"    end"},{"line_number":121,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":122,"context_line":"      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da6ed579_c796d6ef","line":119,"range":{"start_line":119,"start_character":54,"end_line":119,"end_character":80},"in_reply_to":"da6ed579_d9180d87","updated":"2016-01-13 14:14:51.000000000","message":"Agree. Below we trying to find by name.\n\n  irb(main):010:0\u003e var1 \u003d Hash[list.collect{|instance| [instance[:id], instance[:name]]}]\n\u003d\u003e {\"1213\"\u003d\u003e\"name1\", \"1321\"\u003d\u003e\"name2\"}\n  irb(main):011:0\u003e var1.include?(\u0027name1\u0027)\n\u003d\u003e false\n  irb(main):012:0\u003e var2 \u003d Hash[list.collect{|instance| [instance[:name], instance[:id]]}]\n\u003d\u003e {\"name1\"\u003d\u003e\"1213\", \"name2\"\u003d\u003e\"1321\"}\n  irb(main):013:0\u003e var2.include?(\u0027name1\u0027)\n\u003d\u003e true","commit_id":"777243daf850db0bf00a1c82d989b5f1291d1b64"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"53c7d94ad6d56702657005f89028ef2289fc513a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      list \u003d request(\u0027domain\u0027, \u0027list\u0027)"},{"line_number":119,"context_line":"      @domain_name_hash \u003d Hash[list.collect{|domain| [domain[:id], domain[:name]]}]"},{"line_number":120,"context_line":"    end"},{"line_number":121,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":122,"context_line":"      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]"},{"line_number":123,"context_line":"      @domain_name_hash[name] \u003d id if id"},{"line_number":124,"context_line":"    end"},{"line_number":125,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":126,"context_line":"      err(\"Could not find domain with name [#{name}]\")"},{"line_number":127,"context_line":"    end"},{"line_number":128,"context_line":"    @domain_name_hash[name]"},{"line_number":129,"context_line":"  end"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  def self.fetch_project(name, domain)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da6ed579_b4cd20b9","line":128,"range":{"start_line":121,"start_character":4,"end_line":128,"end_character":27},"updated":"2016-01-13 09:11:17.000000000","message":"just to simplify:\n    unless @domain_name_hash.has_key?(name)\n      if id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]\n        @domain_name_hash[name] \u003d id\n      else\n        err(\"Could not find domain with name [#{name}]\")\n      end\n    end","commit_id":"777243daf850db0bf00a1c82d989b5f1291d1b64"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"3a690806770992fa6c57d2eff659d6bce294f4ed","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      list \u003d request(\u0027domain\u0027, \u0027list\u0027)"},{"line_number":119,"context_line":"      @domain_name_hash \u003d Hash[list.collect{|domain| [domain[:id], domain[:name]]}]"},{"line_number":120,"context_line":"    end"},{"line_number":121,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":122,"context_line":"      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]"},{"line_number":123,"context_line":"      @domain_name_hash[name] \u003d id if id"},{"line_number":124,"context_line":"    end"},{"line_number":125,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":126,"context_line":"      err(\"Could not find domain with name [#{name}]\")"},{"line_number":127,"context_line":"    end"},{"line_number":128,"context_line":"    @domain_name_hash[name]"},{"line_number":129,"context_line":"  end"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  def self.fetch_project(name, domain)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da6ed579_afd4d446","line":128,"range":{"start_line":121,"start_character":4,"end_line":128,"end_character":27},"in_reply_to":"da6ed579_227480fb","updated":"2016-01-13 15:07:50.000000000","message":"+ good, but \"assign to hash\" should go next after err()\nI mean:\nerr(\"Could not ...) unless id\n@domain_name_hash[name] \u003d id","commit_id":"777243daf850db0bf00a1c82d989b5f1291d1b64"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d3ba6d8a323029377ae056bd3f760dc8da988523","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      list \u003d request(\u0027domain\u0027, \u0027list\u0027)"},{"line_number":119,"context_line":"      @domain_name_hash \u003d Hash[list.collect{|domain| [domain[:id], domain[:name]]}]"},{"line_number":120,"context_line":"    end"},{"line_number":121,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":122,"context_line":"      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]"},{"line_number":123,"context_line":"      @domain_name_hash[name] \u003d id if id"},{"line_number":124,"context_line":"    end"},{"line_number":125,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":126,"context_line":"      err(\"Could not find domain with name [#{name}]\")"},{"line_number":127,"context_line":"    end"},{"line_number":128,"context_line":"    @domain_name_hash[name]"},{"line_number":129,"context_line":"  end"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  def self.fetch_project(name, domain)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da6ed579_e1473c49","line":128,"range":{"start_line":121,"start_character":4,"end_line":128,"end_character":27},"in_reply_to":"da6ed579_afd4d446","updated":"2016-01-13 16:48:15.000000000","message":"Yep, sure :)","commit_id":"777243daf850db0bf00a1c82d989b5f1291d1b64"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b440e6be673cbe9262041835485aa47501efd2c4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      list \u003d request(\u0027domain\u0027, \u0027list\u0027)"},{"line_number":119,"context_line":"      @domain_name_hash \u003d Hash[list.collect{|domain| [domain[:id], domain[:name]]}]"},{"line_number":120,"context_line":"    end"},{"line_number":121,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":122,"context_line":"      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]"},{"line_number":123,"context_line":"      @domain_name_hash[name] \u003d id if id"},{"line_number":124,"context_line":"    end"},{"line_number":125,"context_line":"    unless @domain_name_hash.include?(name)"},{"line_number":126,"context_line":"      err(\"Could not find domain with name [#{name}]\")"},{"line_number":127,"context_line":"    end"},{"line_number":128,"context_line":"    @domain_name_hash[name]"},{"line_number":129,"context_line":"  end"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  def self.fetch_project(name, domain)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da6ed579_227480fb","line":128,"range":{"start_line":121,"start_character":4,"end_line":128,"end_character":27},"in_reply_to":"da6ed579_b4cd20b9","updated":"2016-01-13 14:14:51.000000000","message":"Make sense. We also can use include? method. One more way, like:\n\nunless @domain_name_hash.include?(name)\n      id \u003d request(\u0027domain\u0027, \u0027show\u0027, name)[:id]\n      @domain_name_hash[name] \u003d id\n      err(\"Could not find domain with name [#{name}]\") unless id\nend","commit_id":"777243daf850db0bf00a1c82d989b5f1291d1b64"}]}