)]}'
{"manifests/resource/authtoken.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e4f853e36f497a6a09587ba0229de876ab1cca0e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"# [*project_id*]"},{"line_number":232,"context_line":"# [*project_domain_name*]"},{"line_number":233,"context_line":"# [*project_domain_id*]"},{"line_number":234,"context_line":"# [*domain_name*]"},{"line_number":235,"context_line":"# [*domain_id*]"},{"line_number":236,"context_line":"# [*default_domain_name*]"},{"line_number":237,"context_line":"# [*default_domain_id*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_b630b59f","line":234,"range":{"start_line":234,"start_character":15,"end_line":234,"end_character":17},"updated":"2016-01-13 14:28:32.000000000","message":"you can\u0027t just remove some parameters, you should respect our deprecation policy. Make them deprecated at first and raise warning message.","commit_id":"5614ec9c6b2c22d24759a64b64ed268045b7ae6b"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"d7502d135fff68d438bdff3ed29f9de4bbf8ff83","unresolved":false,"context_lines":[{"line_number":231,"context_line":"# [*project_id*]"},{"line_number":232,"context_line":"# [*project_domain_name*]"},{"line_number":233,"context_line":"# [*project_domain_id*]"},{"line_number":234,"context_line":"# [*domain_name*]"},{"line_number":235,"context_line":"# [*domain_id*]"},{"line_number":236,"context_line":"# [*default_domain_name*]"},{"line_number":237,"context_line":"# [*default_domain_id*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_4565f9de","line":234,"range":{"start_line":234,"start_character":15,"end_line":234,"end_character":17},"in_reply_to":"da6ed579_b630b59f","updated":"2016-01-13 15:35:09.000000000","message":"This patch is still WIP, warning info and related test will be added ASAP.","commit_id":"5614ec9c6b2c22d24759a64b64ed268045b7ae6b"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"cfa8ce7dc89a439f2c6194d422e02e2b09770053","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*auth_version*]"},{"line_number":59,"context_line":"#   (Optional) API version of the admin Identity API endpoint. (string value)"},{"line_number":60,"context_line":"#   Defaults to $::os_serice_default."},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"# [*delay_auth_decision*]"},{"line_number":63,"context_line":"#   (Optional) Do not handle authorization requests within the middleware, but"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_659d4f65","line":60,"updated":"2016-01-14 18:11:40.000000000","message":"s/os_serice_default/os_service_default\n\nHere and below as well","commit_id":"dcf5872931f4c8237bd0af6f486319094cc4802c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8968245b5567550b1c88a09d39efa3d8a27e2834","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  $enforce_token_bind             \u003d $::os_service_default,"},{"line_number":278,"context_line":"  $check_revocations_for_cached   \u003d $::os_service_default,"},{"line_number":279,"context_line":"  $hash_algorithms                \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $identity_uri                   \u003d false,"},{"line_number":281,"context_line":"  $admin_tenant_name              \u003d \u0027admin\u0027,"},{"line_number":282,"context_line":"  # Deprecated params, will be removed in future release."},{"line_number":283,"context_line":"  $admin_token                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_b1e1242c","line":280,"range":{"start_line":280,"start_character":36,"end_line":280,"end_character":41},"updated":"2016-01-15 11:30:50.000000000","message":"os_service_default?","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"48d61e8c5cea532731d347a06a148bdd490adad3","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  $enforce_token_bind             \u003d $::os_service_default,"},{"line_number":278,"context_line":"  $check_revocations_for_cached   \u003d $::os_service_default,"},{"line_number":279,"context_line":"  $hash_algorithms                \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $identity_uri                   \u003d false,"},{"line_number":281,"context_line":"  $admin_tenant_name              \u003d \u0027admin\u0027,"},{"line_number":282,"context_line":"  # Deprecated params, will be removed in future release."},{"line_number":283,"context_line":"  $admin_token                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_30a445b8","line":280,"range":{"start_line":280,"start_character":36,"end_line":280,"end_character":41},"in_reply_to":"da6ed579_b1e1242c","updated":"2016-01-15 14:34:38.000000000","message":"Done","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"225a64c9d819155edcbf35f3a0526028cb6cc412","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  $key                            \u003d undef"},{"line_number":308,"context_line":") {"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  if $user_id {"},{"line_number":311,"context_line":"    warning(\u0027user_id has already been removed and has no effect.\u0027)"},{"line_number":312,"context_line":"  }"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  if $user_domain_name {"},{"line_number":315,"context_line":"    warning(\u0027user_domain_name has already been removed and has no effect.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_8c15ec9c","line":312,"range":{"start_line":310,"start_character":2,"end_line":312,"end_character":3},"updated":"2016-01-15 09:28:50.000000000","message":"couldn\u0027t this just be a define with warning?","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3e0359239f208df7658e52d2de95383bce456fa2","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  $key                            \u003d undef"},{"line_number":308,"context_line":") {"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  if $user_id {"},{"line_number":311,"context_line":"    warning(\u0027user_id has already been removed and has no effect.\u0027)"},{"line_number":312,"context_line":"  }"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  if $user_domain_name {"},{"line_number":315,"context_line":"    warning(\u0027user_domain_name has already been removed and has no effect.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba63e191_80d81c1f","line":312,"range":{"start_line":310,"start_character":2,"end_line":312,"end_character":3},"in_reply_to":"da6ed579_353709e5","updated":"2016-01-18 23:26:44.000000000","message":"I think it\u0027s fine the way it is.","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"48d61e8c5cea532731d347a06a148bdd490adad3","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  $key                            \u003d undef"},{"line_number":308,"context_line":") {"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  if $user_id {"},{"line_number":311,"context_line":"    warning(\u0027user_id has already been removed and has no effect.\u0027)"},{"line_number":312,"context_line":"  }"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  if $user_domain_name {"},{"line_number":315,"context_line":"    warning(\u0027user_domain_name has already been removed and has no effect.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_90fdf1b2","line":312,"range":{"start_line":310,"start_character":2,"end_line":312,"end_character":3},"in_reply_to":"da6ed579_8c15ec9c","updated":"2016-01-15 14:34:38.000000000","message":"I didn\u0027t get your mean, could you explain it?","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"b3658cbef953b0532f5be44b65aa6119f848d422","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  $key                            \u003d undef"},{"line_number":308,"context_line":") {"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  if $user_id {"},{"line_number":311,"context_line":"    warning(\u0027user_id has already been removed and has no effect.\u0027)"},{"line_number":312,"context_line":"  }"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  if $user_domain_name {"},{"line_number":315,"context_line":"    warning(\u0027user_domain_name has already been removed and has no effect.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_353709e5","line":312,"range":{"start_line":310,"start_character":2,"end_line":312,"end_character":3},"in_reply_to":"da6ed579_90fdf1b2","updated":"2016-01-18 10:24:55.000000000","message":"I mean to wrap all \"if..warning\" code by define:\ndefine warning_if( $opt \u003d $title) {\nif getvar($opt) {\n    warning(\"$opt has already been removed and has no effect.\")\n  }\n}\n\nAnd use it as:\nwarning_if(\u0027user_id\u0027)\nwarning_if(\u0027user_domain_name\u0027)\nwarning_if(\u0027user_domain_id\u0027)\n....","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8968245b5567550b1c88a09d39efa3d8a27e2834","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    create_resources($name, {\u0027keystone_authtoken/auth_plugin\u0027 \u003d\u003e {ensure \u003d\u003e absent}})"},{"line_number":402,"context_line":"  }"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"  create_resources($name, {\u0027keystone_authtoken/auth_uri\u0027 \u003d\u003e { value \u003d\u003e $auth_uri }})"},{"line_number":405,"context_line":"  create_resources($name, {\u0027keystone_authtoken/admin_tenant_name\u0027 \u003d\u003e { value \u003d\u003e $admin_tenant_name }})"},{"line_number":406,"context_line":"  create_resources($name, {\u0027keystone_authtoken/admin_user\u0027 \u003d\u003e {value \u003d\u003e $admin_user}})"},{"line_number":407,"context_line":"  create_resources($name, {\u0027keystone_authtoken/admin_password\u0027 \u003d\u003e {value \u003d\u003e $admin_password, secret \u003d\u003e true}})"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_71ef2c1e","line":404,"range":{"start_line":404,"start_character":47,"end_line":404,"end_character":55},"updated":"2016-01-15 11:30:50.000000000","message":"it can be duplicated declaration, if someone will pass auth_uri and auth_{host,port,protocol} parameters.\n\nwill be better to use way like here:\n\nhttps://github.com/openstack/puppet-sahara/blob/stable/kilo/manifests/keystone/auth.pp#L174-L202\n\nWe have had this way for all keystone/auth manifests btw. It will avoid duplication error.","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"48d61e8c5cea532731d347a06a148bdd490adad3","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    create_resources($name, {\u0027keystone_authtoken/auth_plugin\u0027 \u003d\u003e {ensure \u003d\u003e absent}})"},{"line_number":402,"context_line":"  }"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"  create_resources($name, {\u0027keystone_authtoken/auth_uri\u0027 \u003d\u003e { value \u003d\u003e $auth_uri }})"},{"line_number":405,"context_line":"  create_resources($name, {\u0027keystone_authtoken/admin_tenant_name\u0027 \u003d\u003e { value \u003d\u003e $admin_tenant_name }})"},{"line_number":406,"context_line":"  create_resources($name, {\u0027keystone_authtoken/admin_user\u0027 \u003d\u003e {value \u003d\u003e $admin_user}})"},{"line_number":407,"context_line":"  create_resources($name, {\u0027keystone_authtoken/admin_password\u0027 \u003d\u003e {value \u003d\u003e $admin_password, secret \u003d\u003e true}})"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_b0d11525","line":404,"range":{"start_line":404,"start_character":47,"end_line":404,"end_character":55},"in_reply_to":"da6ed579_71ef2c1e","updated":"2016-01-15 14:34:38.000000000","message":"good catch.","commit_id":"9d71b987341d0a77ade201464cfcbcdc0db105cf"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1f974b84657c8447d3c680e579517a86b62ac028","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# This resource configures Keystone authentication resources for an OpenStack"},{"line_number":4,"context_line":"# service.  It will manage the [keystone_authtoken] section in the given"},{"line_number":5,"context_line":"# config resource.  It supports all of the authentication parameters specified at"},{"line_number":6,"context_line":"# https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# For example, when configuring glance keystone_authtoken, instead of doing this:"},{"line_number":9,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba63e191_3d307956","line":6,"updated":"2016-01-18 23:31:40.000000000","message":"Is there a documentation resource we can provide instead? Providing a 1100-line long python file is not the most friendly. At minimum this should use the git.openstack.org source rather than github.","commit_id":"6f2ee7b3705f090095bb04ae62e204f24fc71f09"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"6504aeb70f894008b3afe09e719f89b8ee5dfd56","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# This resource configures Keystone authentication resources for an OpenStack"},{"line_number":4,"context_line":"# service.  It will manage the [keystone_authtoken] section in the given"},{"line_number":5,"context_line":"# config resource.  It supports all of the authentication parameters specified at"},{"line_number":6,"context_line":"# https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# For example, when configuring glance keystone_authtoken, instead of doing this:"},{"line_number":9,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba63e191_0499996e","line":6,"in_reply_to":"ba63e191_3d307956","updated":"2016-01-19 03:37:52.000000000","message":"I try to find the full list of keystonemiddleware options, but by now  there is no better one.\nI will use git.openstack.org to replace it.","commit_id":"6f2ee7b3705f090095bb04ae62e204f24fc71f09"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1f974b84657c8447d3c680e579517a86b62ac028","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#      ..."},{"line_number":27,"context_line":"#    }"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# or add following code in glance::api:"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"#    create_resources(keystone::resource::authtoken, $authtoken_config)"},{"line_number":32,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba63e191_e05798c8","line":29,"updated":"2016-01-18 23:31:40.000000000","message":"We maintain glance::api, so we don\u0027t need to include instructions for how to use it - just fix it and relate it to this patch","commit_id":"6f2ee7b3705f090095bb04ae62e204f24fc71f09"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"6504aeb70f894008b3afe09e719f89b8ee5dfd56","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#      ..."},{"line_number":27,"context_line":"#    }"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# or add following code in glance::api:"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"#    create_resources(keystone::resource::authtoken, $authtoken_config)"},{"line_number":32,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba63e191_4431d10a","line":29,"in_reply_to":"ba63e191_e05798c8","updated":"2016-01-19 03:37:52.000000000","message":"Here I just take glance::api as an example to contrast two ways of managing keystone_authtoken params.\n\nIn puppet-glance, I explain how to use this define in glance::api authtoken_config params docs, please check it in:\nhttps://review.openstack.org/#/c/268233/2/manifests/api.pp","commit_id":"6f2ee7b3705f090095bb04ae62e204f24fc71f09"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"a3ae83d8b8f3942e6fc89085105061c41436bf0e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"#   tokens are expired this option should be set to a single value for better"},{"line_number":196,"context_line":"#   performance. (list value)"},{"line_number":197,"context_line":"#   Defaults to $::os_service_default."},{"line_number":198,"context_line":"#"},{"line_number":199,"context_line":"# [*identity_uri*]"},{"line_number":200,"context_line":"#   (Optional) Complete admin Identity API endpoint. This should specify the unversioned"},{"line_number":201,"context_line":"#   root endpoint e.g. https://localhost:35357/ (string value)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_51264d69","line":198,"updated":"2016-01-19 15:38:00.000000000","message":"Up to this point, these are the parameters from the base class that are applicable to all auth token plugins, as defined here: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L363","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"e77b4fcefabd2419ed63bb9589e5f36d0063c53a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"#   tokens are expired this option should be set to a single value for better"},{"line_number":196,"context_line":"#   performance. (list value)"},{"line_number":197,"context_line":"#   Defaults to $::os_service_default."},{"line_number":198,"context_line":"#"},{"line_number":199,"context_line":"# [*identity_uri*]"},{"line_number":200,"context_line":"#   (Optional) Complete admin Identity API endpoint. This should specify the unversioned"},{"line_number":201,"context_line":"#   root endpoint e.g. https://localhost:35357/ (string value)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_84a9de7d","line":198,"in_reply_to":"ba63e191_51264d69","updated":"2016-01-19 17:16:34.000000000","message":"Please see line 7-8","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"a3ae83d8b8f3942e6fc89085105061c41436bf0e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"# [*admin_tenant_name*]"},{"line_number":211,"context_line":"#   (Optional) Service tenant name. (string value)"},{"line_number":212,"context_line":"#   Defaults to \u0027admin\u0027."},{"line_number":213,"context_line":"#"},{"line_number":214,"context_line":"# [*auth_type*]"},{"line_number":215,"context_line":"#   (Optional) Authentication type to load"},{"line_number":216,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_6c813a4a","line":213,"updated":"2016-01-19 15:38:00.000000000","message":"And these are the old (v2) style parameters from https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L184","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"e77b4fcefabd2419ed63bb9589e5f36d0063c53a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"# [*admin_tenant_name*]"},{"line_number":211,"context_line":"#   (Optional) Service tenant name. (string value)"},{"line_number":212,"context_line":"#   Defaults to \u0027admin\u0027."},{"line_number":213,"context_line":"#"},{"line_number":214,"context_line":"# [*auth_type*]"},{"line_number":215,"context_line":"#   (Optional) Authentication type to load"},{"line_number":216,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_24b7d2d9","line":213,"in_reply_to":"ba63e191_6c813a4a","updated":"2016-01-19 17:16:34.000000000","message":"same, please see line 7-8","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"a3ae83d8b8f3942e6fc89085105061c41436bf0e","unresolved":false,"context_lines":[{"line_number":228,"context_line":"# [*auth_url*]"},{"line_number":229,"context_line":"# [*admin_token*]"},{"line_number":230,"context_line":"# [*auth_plugin*]"},{"line_number":231,"context_line":"#"},{"line_number":232,"context_line":"# \u003d\u003d\u003d Removed:"},{"line_number":233,"context_line":"#"},{"line_number":234,"context_line":"# [*username*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_0cc51e8d","line":231,"updated":"2016-01-19 15:38:00.000000000","message":"Some of these are also from https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L184\n\nSo you are deprecating some of them, but still supporting some of them?","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"e77b4fcefabd2419ed63bb9589e5f36d0063c53a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"# [*auth_url*]"},{"line_number":229,"context_line":"# [*admin_token*]"},{"line_number":230,"context_line":"# [*auth_plugin*]"},{"line_number":231,"context_line":"#"},{"line_number":232,"context_line":"# \u003d\u003d\u003d Removed:"},{"line_number":233,"context_line":"#"},{"line_number":234,"context_line":"# [*username*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_64c94a78","line":231,"in_reply_to":"ba63e191_0cc51e8d","updated":"2016-01-19 17:16:34.000000000","message":"These params are claimed as deprecated in keystonemiddleware, not by myself.\nI collect all of params which has been marked as deprecated.\n\nDeprecated means not encourage to use, we stiil need to support them.","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"c9b547255d8c616b20ee5d0f6652746c628bf8fd","unresolved":false,"context_lines":[{"line_number":228,"context_line":"# [*auth_url*]"},{"line_number":229,"context_line":"# [*admin_token*]"},{"line_number":230,"context_line":"# [*auth_plugin*]"},{"line_number":231,"context_line":"#"},{"line_number":232,"context_line":"# \u003d\u003d\u003d Removed:"},{"line_number":233,"context_line":"#"},{"line_number":234,"context_line":"# [*username*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_8a19e77b","line":231,"in_reply_to":"ba63e191_64c94a78","updated":"2016-01-19 17:45:24.000000000","message":"Yes, I understand what \"deprecated\" means.  It means that these parameters will be supported for now, and, at some point in the future, they will be removed.","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"a3ae83d8b8f3942e6fc89085105061c41436bf0e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# [*domain_id*]"},{"line_number":245,"context_line":"# [*default_domain_name*]"},{"line_number":246,"context_line":"# [*default_domain_id*]"},{"line_number":247,"context_line":"# [*trust_id*]"},{"line_number":248,"context_line":"# [*cacert*]"},{"line_number":249,"context_line":"# [*cert*]"},{"line_number":250,"context_line":"# [*key*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_6c2b7a31","line":247,"updated":"2016-01-19 15:38:00.000000000","message":"These are deprecated for now, but still supported.  That means they will be removed in the future.\n\nOnce they are removed, if I want to do v3 authentication, how will I specify my user domain name, my project domain name, and my domain name?","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"d0c534505f7c8c6130f1fb6ce790897ef2f8fe17","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# [*domain_id*]"},{"line_number":245,"context_line":"# [*default_domain_name*]"},{"line_number":246,"context_line":"# [*default_domain_id*]"},{"line_number":247,"context_line":"# [*trust_id*]"},{"line_number":248,"context_line":"# [*cacert*]"},{"line_number":249,"context_line":"# [*cert*]"},{"line_number":250,"context_line":"# [*key*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a5de9d1_1ccddbb6","line":247,"in_reply_to":"ba63e191_6aba7325","updated":"2016-01-31 12:00:00.000000000","message":"This defines is aim to manage parameters of keystonemiddleware, not keystoneauth, you can find these parameters in keystone.conf.","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"e77b4fcefabd2419ed63bb9589e5f36d0063c53a","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# [*domain_id*]"},{"line_number":245,"context_line":"# [*default_domain_name*]"},{"line_number":246,"context_line":"# [*default_domain_id*]"},{"line_number":247,"context_line":"# [*trust_id*]"},{"line_number":248,"context_line":"# [*cacert*]"},{"line_number":249,"context_line":"# [*cert*]"},{"line_number":250,"context_line":"# [*key*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_c436f6e6","line":247,"in_reply_to":"ba63e191_6c2b7a31","updated":"2016-01-19 17:16:34.000000000","message":"I didn\u0027t find domain related params in keystonemiddleware. Could you give the link?","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"c9b547255d8c616b20ee5d0f6652746c628bf8fd","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# [*domain_id*]"},{"line_number":245,"context_line":"# [*default_domain_name*]"},{"line_number":246,"context_line":"# [*default_domain_id*]"},{"line_number":247,"context_line":"# [*trust_id*]"},{"line_number":248,"context_line":"# [*cacert*]"},{"line_number":249,"context_line":"# [*cert*]"},{"line_number":250,"context_line":"# [*key*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba63e191_6aba7325","line":247,"in_reply_to":"ba63e191_c436f6e6","updated":"2016-01-19 17:45:24.000000000","message":"I do not know how this is implemented in the config - that is, I have not been able to find the oslo.config definitions for \"user_domain_name\", etc.  But, for example, these are the parameters supported for doing v3 password authentication: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/identity/v3/password.py#L72","commit_id":"429e3b4d9fe85122b65e8132cdbb540fa3f758f3"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0ad0b5ab410d9e06e33feb626e4b41ea5e3d1379","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# [*http_request_max_retries*]"},{"line_number":75,"context_line":"#   (Optional) How many times are we trying to reconnect when communicating with Identity"},{"line_number":76,"context_line":"# API Server. (integer value)"},{"line_number":77,"context_line":"#   Defaults to 3."},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*cache*]"},{"line_number":80,"context_line":"#   (Optional) Env key for the swift cache."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_8aa436ba","line":77,"range":{"start_line":77,"start_character":17,"end_line":77,"end_character":18},"updated":"2016-04-20 14:22:10.000000000","message":"Defaults to $::os_service_default","commit_id":"0a0654243182ea855222a133fa97c92739d49f53"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0ad0b5ab410d9e06e33feb626e4b41ea5e3d1379","unresolved":false,"context_lines":[{"line_number":107,"context_line":"#   Defaults to $::os_service_default."},{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":"# [*memcached_servers*]"},{"line_number":110,"context_line":"#   (Optionally) specify a list of memcached server(s) to use for caching. If left"},{"line_number":111,"context_line":"#   undefined, tokens will instead be cached in-process. (list value)"},{"line_number":112,"context_line":"#   Defaults to $::os_service_default."},{"line_number":113,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_6a69daf8","line":110,"updated":"2016-04-20 14:22:10.000000000","message":"Optional","commit_id":"0a0654243182ea855222a133fa97c92739d49f53"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0ad0b5ab410d9e06e33feb626e4b41ea5e3d1379","unresolved":false,"context_lines":[{"line_number":112,"context_line":"#   Defaults to $::os_service_default."},{"line_number":113,"context_line":"#"},{"line_number":114,"context_line":"# [*token_cache_time*]"},{"line_number":115,"context_line":"#   (Optionally) In order to prevent excessive effort spent validating tokens, the middleware"},{"line_number":116,"context_line":"#   caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":117,"context_line":"#   Set to -1 to disable caching completely. (integer value)"},{"line_number":118,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_aa6f72fa","line":115,"updated":"2016-04-20 14:22:10.000000000","message":"Optional","commit_id":"0a0654243182ea855222a133fa97c92739d49f53"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0ad0b5ab410d9e06e33feb626e4b41ea5e3d1379","unresolved":false,"context_lines":[{"line_number":117,"context_line":"#   Set to -1 to disable caching completely. (integer value)"},{"line_number":118,"context_line":"#   Defaults to $::os_service_default."},{"line_number":119,"context_line":"#"},{"line_number":120,"context_line":"# [*revocation_cache_time*]"},{"line_number":121,"context_line":"#   In order to prevent excessive effort spent validating tokens, the middleware"},{"line_number":122,"context_line":"#   caches previously-seen tokens for a configurable duration (in seconds). Set"},{"line_number":123,"context_line":"#   to -1 to disable caching completely. (integer value)"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_2a7c02b4","line":120,"updated":"2016-04-20 14:22:10.000000000","message":"(Optional)","commit_id":"0a0654243182ea855222a133fa97c92739d49f53"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0ad0b5ab410d9e06e33feb626e4b41ea5e3d1379","unresolved":false,"context_lines":[{"line_number":312,"context_line":"  include ::keystone::deps"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  if !$project_name and !$project_id and !$domain_name and !$domain_id {"},{"line_number":315,"context_line":"    fail(\u0027Must specify either a project (project_name or project_id, for a project scoped token) or a domain (domain_name or domain_id, for a domain scoped token)\u0027)"},{"line_number":316,"context_line":"  }"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"  if $user_id {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_2d2ffc88","line":315,"updated":"2016-04-20 14:22:10.000000000","message":"these parameters are removed and has no effect, so we need to remove this \u0027fail\u0027.","commit_id":"0a0654243182ea855222a133fa97c92739d49f53"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"557738d32dd9b1f48adccb41cf6d72dc47a2e5d5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# [*http_request_max_retries*]"},{"line_number":75,"context_line":"#   (Optional) How many times are we trying to reconnect when communicating with Identity"},{"line_number":76,"context_line":"# API Server. (integer value)"},{"line_number":77,"context_line":"#   Defaults to 3."},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*cache*]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a122d0e_2cd37561","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":22},"updated":"2016-04-20 16:54:01.000000000","message":"can you please add 2 spaces before \u0027API Server\u0027?","commit_id":"5e0725e223b20abd21f41febf0730eedd581155c"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"972701dc1070f0e11f1ad9dd94c158cfb198b6e2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# [*http_request_max_retries*]"},{"line_number":75,"context_line":"#   (Optional) How many times are we trying to reconnect when communicating with Identity"},{"line_number":76,"context_line":"# API Server. (integer value)"},{"line_number":77,"context_line":"#   Defaults to 3."},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*cache*]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a122d0e_4e94d289","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":22},"in_reply_to":"1a122d0e_2cd37561","updated":"2016-04-21 02:03:48.000000000","message":"Done","commit_id":"5e0725e223b20abd21f41febf0730eedd581155c"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"557738d32dd9b1f48adccb41cf6d72dc47a2e5d5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# [*http_request_max_retries*]"},{"line_number":75,"context_line":"#   (Optional) How many times are we trying to reconnect when communicating with Identity"},{"line_number":76,"context_line":"# API Server. (integer value)"},{"line_number":77,"context_line":"#   Defaults to 3."},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*cache*]"},{"line_number":80,"context_line":"#   (Optional) Env key for the swift cache."}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a122d0e_4cf511eb","line":77,"updated":"2016-04-20 16:54:01.000000000","message":"Defaults to $::os_service_default","commit_id":"5e0725e223b20abd21f41febf0730eedd581155c"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"972701dc1070f0e11f1ad9dd94c158cfb198b6e2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# [*http_request_max_retries*]"},{"line_number":75,"context_line":"#   (Optional) How many times are we trying to reconnect when communicating with Identity"},{"line_number":76,"context_line":"# API Server. (integer value)"},{"line_number":77,"context_line":"#   Defaults to 3."},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*cache*]"},{"line_number":80,"context_line":"#   (Optional) Env key for the swift cache."}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a122d0e_2e7b567c","line":77,"in_reply_to":"1a122d0e_4cf511eb","updated":"2016-04-21 02:03:48.000000000","message":"Sorry for missing this,done.","commit_id":"5e0725e223b20abd21f41febf0730eedd581155c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"9fc87cae4dd07bc449618e1b0b2c0a34bacf4337","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    warning(\u0027project_id has already been removed and has no effect.\u0027)"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  if $project_domain_name {"},{"line_number":335,"context_line":"    warning(\u0027project_domain_name has already been removed and has no effect.\u0027)"},{"line_number":336,"context_line":"  }"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_2f997ec4","line":334,"range":{"start_line":334,"start_character":6,"end_line":334,"end_character":25},"updated":"2016-04-21 11:30:09.000000000","message":"This parameter and all other below are Keystone V3 related options, why are you removing them?","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"ac228d1b207a960351434ccd253ab7155f37845c","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    warning(\u0027project_id has already been removed and has no effect.\u0027)"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  if $project_domain_name {"},{"line_number":335,"context_line":"    warning(\u0027project_domain_name has already been removed and has no effect.\u0027)"},{"line_number":336,"context_line":"  }"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_4f995a78","line":334,"range":{"start_line":334,"start_character":6,"end_line":334,"end_character":25},"in_reply_to":"1a122d0e_0f700271","updated":"2016-04-21 11:36:35.000000000","message":"For example, here https://github.com/openstack/keystone/blob/8a56c161ee29e34e70c6334b048881e8fbbd7514/keystone/models/token_model.py","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"27a93290d5ecb78a195ea362c462af05acad0c53","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    warning(\u0027project_id has already been removed and has no effect.\u0027)"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  if $project_domain_name {"},{"line_number":335,"context_line":"    warning(\u0027project_domain_name has already been removed and has no effect.\u0027)"},{"line_number":336,"context_line":"  }"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"dab17558_6b4fafbd","line":334,"range":{"start_line":334,"start_character":6,"end_line":334,"end_character":25},"in_reply_to":"1a122d0e_1841333a","updated":"2016-05-09 08:03:55.000000000","message":"I think you are right.  keystonemiddle include some codes from keystonauth. if auth_type be set, then will use username,password,etc options as you mentioned.","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5555806046faedc0d449ceb1a844974499287341","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    warning(\u0027project_id has already been removed and has no effect.\u0027)"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  if $project_domain_name {"},{"line_number":335,"context_line":"    warning(\u0027project_domain_name has already been removed and has no effect.\u0027)"},{"line_number":336,"context_line":"  }"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_1841333a","line":334,"range":{"start_line":334,"start_character":6,"end_line":334,"end_character":25},"in_reply_to":"1a122d0e_28f7a5f6","updated":"2016-04-22 11:41:44.000000000","message":"Yep, but as I understand, options provided here are used to authenticate in Keystone. So how is it possible to use pure V3 authentication for any component (Neutron , Nova), without passing V3-specific options? I mean, domain_name, trust_id and so on? In current implementation you leave only   admin_user, admin_password, admin_tenant_name which are common and seems to be outdated according to this https://github.com/openstack/keystonemiddleware/blob/6e58f8620ae60eb4f26984258d15a9823345c310/keystonemiddleware/auth_token/_auth.py#L35.","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"453543548fcaf84dadade41bc11688d2937afb7b","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    warning(\u0027project_id has already been removed and has no effect.\u0027)"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  if $project_domain_name {"},{"line_number":335,"context_line":"    warning(\u0027project_domain_name has already been removed and has no effect.\u0027)"},{"line_number":336,"context_line":"  }"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_0f700271","line":334,"range":{"start_line":334,"start_character":6,"end_line":334,"end_character":25},"in_reply_to":"1a122d0e_2f997ec4","updated":"2016-04-21 11:34:07.000000000","message":"I didn\u0027t find this option. Could you provide a url for that ?","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"a1dde41a038c59b4053d484afe0dde41bfe7d453","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    warning(\u0027project_id has already been removed and has no effect.\u0027)"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  if $project_domain_name {"},{"line_number":335,"context_line":"    warning(\u0027project_domain_name has already been removed and has no effect.\u0027)"},{"line_number":336,"context_line":"  }"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_28f7a5f6","line":334,"range":{"start_line":334,"start_character":6,"end_line":334,"end_character":25},"in_reply_to":"1a122d0e_4f995a78","updated":"2016-04-21 16:37:57.000000000","message":"Hmm, first thing project_domain_name is not an option, this is an attribute of class KeystoneToken.\nAnd second what we talk about is options in [authtoken] section, which are belong to keystonemiddleware project(https://github.com/openstack/keystonemiddleware), not keystone. \nThere only exists an option named admin_project_domain_id\n(https://review.openstack.org/#/c/123011/), but it has been removed now.","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"1665818d496bb8733e0c65a9a7cbfe29a1275e61","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    create_resources($name, {\u0027keystone_authtoken/auth_uri\u0027 \u003d\u003e {value \u003d\u003e $auth_uri}})"},{"line_number":394,"context_line":"  }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"  if $auth_url {"},{"line_number":397,"context_line":"    warning(\u0027The auth_url parameter is deprecated, use auth_uri instead.\u0027)"},{"line_number":398,"context_line":"    create_resources($name, {\u0027keystone_authtoken/auth_url\u0027 \u003d\u003e {value \u003d\u003e $auth_url}})"},{"line_number":399,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_0f3802d2","line":396,"range":{"start_line":396,"start_character":6,"end_line":396,"end_character":14},"updated":"2016-04-21 11:28:17.000000000","message":"These are different options and they both should be used. Here is some explanation: http://www.jamielennox.net/blog/2015/02/23/v3-authentication-with-auth-token-middleware/","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"67a2eac40c28c4a827671a4de2981cb260fbb204","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027 \u003d\u003e { value \u003d\u003e $admin_tenant_name },"},{"line_number":412,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 \u003d\u003e {value \u003d\u003e $admin_user},"},{"line_number":413,"context_line":"    \u0027keystone_authtoken/admin_password\u0027 \u003d\u003e {value \u003d\u003e $admin_password, secret \u003d\u003e true},"},{"line_number":414,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027 \u003d\u003e {value \u003d\u003e $identity_uri},"},{"line_number":415,"context_line":"    \u0027keystone_authtoken/auth_version\u0027 \u003d\u003e { value \u003d\u003e $auth_version },"},{"line_number":416,"context_line":"    \u0027keystone_authtoken/delay_auth_decision\u0027 \u003d\u003e { value \u003d\u003e $delay_auth_decision },"},{"line_number":417,"context_line":"    \u0027keystone_authtoken/http_connect_timeout\u0027 \u003d\u003e { value \u003d\u003e $http_connect_timeout },"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_14001733","line":414,"range":{"start_line":414,"start_character":0,"end_line":414,"end_character":66},"updated":"2016-04-21 11:25:02.000000000","message":"https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L36-L41\n\ni think we need to figure out which parameters are deprecated and which should be used.","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"453543548fcaf84dadade41bc11688d2937afb7b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027 \u003d\u003e { value \u003d\u003e $admin_tenant_name },"},{"line_number":412,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 \u003d\u003e {value \u003d\u003e $admin_user},"},{"line_number":413,"context_line":"    \u0027keystone_authtoken/admin_password\u0027 \u003d\u003e {value \u003d\u003e $admin_password, secret \u003d\u003e true},"},{"line_number":414,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027 \u003d\u003e {value \u003d\u003e $identity_uri},"},{"line_number":415,"context_line":"    \u0027keystone_authtoken/auth_version\u0027 \u003d\u003e { value \u003d\u003e $auth_version },"},{"line_number":416,"context_line":"    \u0027keystone_authtoken/delay_auth_decision\u0027 \u003d\u003e { value \u003d\u003e $delay_auth_decision },"},{"line_number":417,"context_line":"    \u0027keystone_authtoken/http_connect_timeout\u0027 \u003d\u003e { value \u003d\u003e $http_connect_timeout },"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_0fdbe27c","line":414,"range":{"start_line":414,"start_character":0,"end_line":414,"end_character":66},"in_reply_to":"1a122d0e_14001733","updated":"2016-04-21 11:34:07.000000000","message":"Hmm, this is because this patch submited before Mitaka release.\nI will update this.","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"1665818d496bb8733e0c65a9a7cbfe29a1275e61","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027 \u003d\u003e { value \u003d\u003e $admin_tenant_name },"},{"line_number":412,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 \u003d\u003e {value \u003d\u003e $admin_user},"},{"line_number":413,"context_line":"    \u0027keystone_authtoken/admin_password\u0027 \u003d\u003e {value \u003d\u003e $admin_password, secret \u003d\u003e true},"},{"line_number":414,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027 \u003d\u003e {value \u003d\u003e $identity_uri},"},{"line_number":415,"context_line":"    \u0027keystone_authtoken/auth_version\u0027 \u003d\u003e { value \u003d\u003e $auth_version },"},{"line_number":416,"context_line":"    \u0027keystone_authtoken/delay_auth_decision\u0027 \u003d\u003e { value \u003d\u003e $delay_auth_decision },"},{"line_number":417,"context_line":"    \u0027keystone_authtoken/http_connect_timeout\u0027 \u003d\u003e { value \u003d\u003e $http_connect_timeout },"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a122d0e_74050b12","line":414,"range":{"start_line":414,"start_character":0,"end_line":414,"end_character":66},"in_reply_to":"1a122d0e_14001733","updated":"2016-04-21 11:28:17.000000000","message":"I agree here. As I understand, though identity_uri can be used, it should be replaced by auth_url which is used for auth plugins:\nhttp://docs.openstack.org/developer/python-keystoneclient/authentication-plugins.html","commit_id":"4953b4cbc13b44b6ff7ca64081a2cd1c5c1f5fc3"}]}