)]}'
{"manifests/wsgi/apache.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fadf43ed6722971918cb823ef53e5aa172ba840f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"#   [*admin_bind_host*]"},{"line_number":33,"context_line":"#     The host/ip address Apache will listen on for admin API connections."},{"line_number":34,"context_line":"#     Optional. Defaults to $bind_host."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"#   [*public_path*]"},{"line_number":37,"context_line":"#     The prefix for the public endpoint."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_023f22d7","line":34,"range":{"start_line":34,"start_character":28,"end_line":34,"end_character":38},"updated":"2016-01-28 13:00:47.000000000","message":"undef","commit_id":"09f436fec9dd9100495946f9951e078a358fd072"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"adc6ed36ef8c8d4a64af0fa779231651cff8a102","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"#   [*admin_bind_host*]"},{"line_number":33,"context_line":"#     The host/ip address Apache will listen on for admin API connections."},{"line_number":34,"context_line":"#     Optional. Defaults to $bind_host."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"#   [*public_path*]"},{"line_number":37,"context_line":"#     The prefix for the public endpoint."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_95f82b4b","line":34,"range":{"start_line":34,"start_character":28,"end_line":34,"end_character":38},"in_reply_to":"7a5de9d1_023f22d7","updated":"2016-01-28 13:59:05.000000000","message":"it defaults to bind_host here so that it is backwards compatible. I added a unit test to cover this which would break if I changed the default.","commit_id":"09f436fec9dd9100495946f9951e078a358fd072"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9996c5acd57660ea742825864f38f98cfbd611b7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"#   [*admin_bind_host*]"},{"line_number":33,"context_line":"#     The host/ip address Apache will listen on for admin API connections."},{"line_number":34,"context_line":"#     Optional. Defaults to $bind_host."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"#   [*public_path*]"},{"line_number":37,"context_line":"#     The prefix for the public endpoint."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_2ed4841e","line":34,"range":{"start_line":34,"start_character":28,"end_line":34,"end_character":38},"in_reply_to":"7a5de9d1_95f82b4b","updated":"2016-01-28 14:38:53.000000000","message":"But in fact both values are set to undef.","commit_id":"09f436fec9dd9100495946f9951e078a358fd072"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fadf43ed6722971918cb823ef53e5aa172ba840f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  $servername              \u003d $::fqdn,"},{"line_number":139,"context_line":"  $public_port             \u003d 5000,"},{"line_number":140,"context_line":"  $admin_port              \u003d 35357,"},{"line_number":141,"context_line":"  $bind_host               \u003d undef,"},{"line_number":142,"context_line":"  $admin_bind_host         \u003d undef,"},{"line_number":143,"context_line":"  $public_path             \u003d \u0027/\u0027,"},{"line_number":144,"context_line":"  $admin_path              \u003d \u0027/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_22325e11","line":141,"range":{"start_line":141,"start_character":3,"end_line":141,"end_character":12},"updated":"2016-01-28 13:00:47.000000000","message":"can you please deprecate this parameter then?","commit_id":"09f436fec9dd9100495946f9951e078a358fd072"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"adc6ed36ef8c8d4a64af0fa779231651cff8a102","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  $servername              \u003d $::fqdn,"},{"line_number":139,"context_line":"  $public_port             \u003d 5000,"},{"line_number":140,"context_line":"  $admin_port              \u003d 35357,"},{"line_number":141,"context_line":"  $bind_host               \u003d undef,"},{"line_number":142,"context_line":"  $admin_bind_host         \u003d undef,"},{"line_number":143,"context_line":"  $public_path             \u003d \u0027/\u0027,"},{"line_number":144,"context_line":"  $admin_path              \u003d \u0027/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_55cb931e","line":141,"range":{"start_line":141,"start_character":3,"end_line":141,"end_character":12},"in_reply_to":"7a5de9d1_22325e11","updated":"2016-01-28 13:59:05.000000000","message":"bind_host is still used. bind_host is used for the public keystone port (5000).","commit_id":"09f436fec9dd9100495946f9951e078a358fd072"}],"spec/classes/keystone_wsgi_apache_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fadf43ed6722971918cb823ef53e5aa172ba840f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      let :params do"},{"line_number":107,"context_line":"        {"},{"line_number":108,"context_line":"          :servername            \u003d\u003e \u0027dummy.host\u0027,"},{"line_number":109,"context_line":"          :bind_host             \u003d\u003e \u002710.42.51.1\u0027,"},{"line_number":110,"context_line":"          :admin_bind_host       \u003d\u003e \u002710.42.51.2\u0027,"},{"line_number":111,"context_line":"          :public_port           \u003d\u003e 12345,"},{"line_number":112,"context_line":"          :admin_port            \u003d\u003e 4142,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a5de9d1_a20dee3f","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":20},"updated":"2016-01-28 13:00:47.000000000","message":"let\u0027s remove this from params","commit_id":"09f436fec9dd9100495946f9951e078a358fd072"}]}