)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e5e08c45339fc075049303ca051e84aa4343a350","unresolved":false,"context_lines":[{"line_number":620,"context_line":"  }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"  if ! is_service_default($rabbit_use_ssl) and !$rabbit_use_ssl {"},{"line_number":623,"context_line":"    if ! is_service_default($kombu_ssl_ca_certs) and ($kombu_ssl_ca_certs) {"},{"line_number":624,"context_line":"      fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":625,"context_line":"    }"},{"line_number":626,"context_line":"    if ! is_service_default($kombu_ssl_certfile) and ($kombu_ssl_certfile) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_272cb101","line":623,"updated":"2016-02-16 09:58:02.000000000","message":"current scheme will not help, if we will set $rabbit_use_ssl \u003d\u003e true and will not set any kombu ssl parameters.","commit_id":"96df03cd29931109fca01588e5b6f9b39fce3801"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e1333c52d673170c9c7a69bf3108a40a17d46e2b","unresolved":false,"context_lines":[{"line_number":620,"context_line":"  }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"  if ! is_service_default($rabbit_use_ssl) and !$rabbit_use_ssl {"},{"line_number":623,"context_line":"    if ! is_service_default($kombu_ssl_ca_certs) and ($kombu_ssl_ca_certs) {"},{"line_number":624,"context_line":"      fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":625,"context_line":"    }"},{"line_number":626,"context_line":"    if ! is_service_default($kombu_ssl_certfile) and ($kombu_ssl_certfile) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_32168ca7","line":623,"in_reply_to":"dae33548_272cb101","updated":"2016-02-16 20:51:46.000000000","message":"That\u0027s fine - the kombu_* parameters are not required for $rabbit_use_ssl to work. It\u0027s the opposite that we need to check for - the kombu_* params need rabbit_use_ssl to be set.","commit_id":"96df03cd29931109fca01588e5b6f9b39fce3801"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fd970aa2ce63d91f8e02b070d9ec8bdda2d35e7d","unresolved":false,"context_lines":[{"line_number":620,"context_line":"  }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"  if ! is_service_default($rabbit_use_ssl) and !$rabbit_use_ssl {"},{"line_number":623,"context_line":"    if ! is_service_default($kombu_ssl_ca_certs) and ($kombu_ssl_ca_certs) {"},{"line_number":624,"context_line":"      fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":625,"context_line":"    }"},{"line_number":626,"context_line":"    if ! is_service_default($kombu_ssl_certfile) and ($kombu_ssl_certfile) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_cec32288","line":623,"in_reply_to":"dae33548_32168ca7","updated":"2016-02-17 08:40:46.000000000","message":"Well, according this: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L428\n\nthey will be ignored, if we not use rabbit_ssl.\n\nSo, why we need this check at all then?","commit_id":"96df03cd29931109fca01588e5b6f9b39fce3801"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"99c3a9dae83edbdc3bf963bba312878ecf5ac76b","unresolved":false,"context_lines":[{"line_number":620,"context_line":"  }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"  if ! is_service_default($rabbit_use_ssl) and !$rabbit_use_ssl {"},{"line_number":623,"context_line":"    if ! is_service_default($kombu_ssl_ca_certs) and ($kombu_ssl_ca_certs) {"},{"line_number":624,"context_line":"      fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":625,"context_line":"    }"},{"line_number":626,"context_line":"    if ! is_service_default($kombu_ssl_certfile) and ($kombu_ssl_certfile) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_72052f12","line":623,"in_reply_to":"dae33548_cec32288","updated":"2016-02-18 20:54:31.000000000","message":"The check is needed precisely because the kombu parameters will have no effect if rabbit_use_ssl is not set, and we don\u0027t want to set useless parameters and have the user wonder why it\u0027s not working.","commit_id":"96df03cd29931109fca01588e5b6f9b39fce3801"}]}
