)]}'
{"manifests/db/mysql.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"596a2ed73d9430fb5dcf5c75b4cf1692f9e4b997","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Anchor[\u0027keystone::db::begin\u0027]"},{"line_number":76,"context_line":"  ~\u003e Class[\u0027keystone::db::mysql\u0027]"},{"line_number":77,"context_line":"  ~\u003e Anchor[\u0027keystone::db::end\u0027]"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3afc51ec_56333114","line":76,"range":{"start_line":76,"start_character":5,"end_line":76,"end_character":33},"updated":"2016-03-15 10:31:33.000000000","message":"Probably this is not a good idea to use class itself for relationship from inside of this class. Why not ::Openstacklib::Db::Mysql[\u0027keystone\u0027] as it was before?\n\nOr we can use require/subscribe and notify for ::Openstacklib::Db::Mysql.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"830d71d5915a6ee60e0f443b88fe4ac647a6ec87","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Anchor[\u0027keystone::db::begin\u0027]"},{"line_number":76,"context_line":"  ~\u003e Class[\u0027keystone::db::mysql\u0027]"},{"line_number":77,"context_line":"  ~\u003e Anchor[\u0027keystone::db::end\u0027]"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1af94dfe_fc8e1326","line":76,"range":{"start_line":76,"start_character":5,"end_line":76,"end_character":33},"in_reply_to":"1af94dfe_a17468fd","updated":"2016-03-15 16:37:14.000000000","message":"Ack, ok.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"d73e9109f22ed973bda34f8f9ddb32f6ff79c55b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Anchor[\u0027keystone::db::begin\u0027]"},{"line_number":76,"context_line":"  ~\u003e Class[\u0027keystone::db::mysql\u0027]"},{"line_number":77,"context_line":"  ~\u003e Anchor[\u0027keystone::db::end\u0027]"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1af94dfe_a17468fd","line":76,"range":{"start_line":76,"start_character":5,"end_line":76,"end_character":33},"in_reply_to":"3afc51ec_56333114","updated":"2016-03-15 16:26:22.000000000","message":"Doing it this way for a couple reasons, mainly because this handles the case where more stuff is added to this class and people forget to update the deps. This is how we did it in nova \u0026 heat for that reason.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"}],"manifests/db/postgresql.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"596a2ed73d9430fb5dcf5c75b4cf1692f9e4b997","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Anchor[\u0027keystone::db::begin\u0027]"},{"line_number":56,"context_line":"  ~\u003e Class[\u0027keystone::db::postgresql\u0027]"},{"line_number":57,"context_line":"  ~\u003e Anchor[\u0027keystone::db::end\u0027]"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3afc51ec_763e2ddb","line":56,"updated":"2016-03-15 10:31:33.000000000","message":"same here","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"d73e9109f22ed973bda34f8f9ddb32f6ff79c55b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Anchor[\u0027keystone::db::begin\u0027]"},{"line_number":56,"context_line":"  ~\u003e Class[\u0027keystone::db::postgresql\u0027]"},{"line_number":57,"context_line":"  ~\u003e Anchor[\u0027keystone::db::end\u0027]"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1af94dfe_0160bc34","line":56,"in_reply_to":"3afc51ec_763e2ddb","updated":"2016-03-15 16:26:22.000000000","message":"same response as in mysql","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"}],"manifests/deps.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"596a2ed73d9430fb5dcf5c75b4cf1692f9e4b997","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  Package\u003c| tag \u003d\u003d \u0027openstack\u0027|\u003e"},{"line_number":53,"context_line":"  ~\u003e Anchor[\u0027keystone::service::end\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  # The following resources need to be provisioned after the service is up."},{"line_number":56,"context_line":"  Anchor[\u0027keystone::service::end\u0027]"},{"line_number":57,"context_line":"  -\u003e Keystone_domain\u003c||\u003e"},{"line_number":58,"context_line":"  Anchor[\u0027keystone::service::end\u0027]"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3afc51ec_169249f6","line":55,"updated":"2016-03-15 10:31:33.000000000","message":"do we need these relationships? We have autorequire in types on anchors.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"830d71d5915a6ee60e0f443b88fe4ac647a6ec87","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  Package\u003c| tag \u003d\u003d \u0027openstack\u0027|\u003e"},{"line_number":53,"context_line":"  ~\u003e Anchor[\u0027keystone::service::end\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  # The following resources need to be provisioned after the service is up."},{"line_number":56,"context_line":"  Anchor[\u0027keystone::service::end\u0027]"},{"line_number":57,"context_line":"  -\u003e Keystone_domain\u003c||\u003e"},{"line_number":58,"context_line":"  Anchor[\u0027keystone::service::end\u0027]"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1af94dfe_3c351b46","line":55,"in_reply_to":"1af94dfe_4183e4cc","updated":"2016-03-15 16:37:14.000000000","message":"Yeah, sorry, not-valid, because resources are using *these* anchors.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"d73e9109f22ed973bda34f8f9ddb32f6ff79c55b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  Package\u003c| tag \u003d\u003d \u0027openstack\u0027|\u003e"},{"line_number":53,"context_line":"  ~\u003e Anchor[\u0027keystone::service::end\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  # The following resources need to be provisioned after the service is up."},{"line_number":56,"context_line":"  Anchor[\u0027keystone::service::end\u0027]"},{"line_number":57,"context_line":"  -\u003e Keystone_domain\u003c||\u003e"},{"line_number":58,"context_line":"  Anchor[\u0027keystone::service::end\u0027]"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1af94dfe_4183e4cc","line":55,"in_reply_to":"3afc51ec_169249f6","updated":"2016-03-15 16:26:22.000000000","message":"without these it didn\u0027t work. Where are the autorequires you are mentioning?","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"}],"manifests/federation/identity_provider.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7bde90aeba10ed5d65ca16a207936dd6d2c66027","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    creates   \u003d\u003e $idp_metadata_path,"},{"line_number":141,"context_line":"    subscribe \u003d\u003e Anchor[\u0027keystone::config::end\u0027],"},{"line_number":142,"context_line":"    notify    \u003d\u003e Anchor[\u0027keystone::service::end\u0027],"},{"line_number":143,"context_line":"    tag       \u003d\u003e \u0027keystone-exec\u0027,"},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  file { $idp_metadata_path:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"1af94dfe_c4f35909","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":33},"updated":"2016-03-16 10:39:37.000000000","message":"do we need this tag? I don\u0027t see where it is using","commit_id":"a5da52ec522110ce5ec390a2fef0e15a8ef44531"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b7108b6cc3be41a0644ed0b306b2bba2cd2c8f4a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    creates   \u003d\u003e $idp_metadata_path,"},{"line_number":141,"context_line":"    subscribe \u003d\u003e Anchor[\u0027keystone::config::end\u0027],"},{"line_number":142,"context_line":"    notify    \u003d\u003e Anchor[\u0027keystone::service::end\u0027],"},{"line_number":143,"context_line":"    tag       \u003d\u003e \u0027keystone-exec\u0027,"},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  file { $idp_metadata_path:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"1af94dfe_2b5ab750","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":33},"in_reply_to":"1af94dfe_0b109b00","updated":"2016-03-16 16:00:27.000000000","message":"Ok","commit_id":"a5da52ec522110ce5ec390a2fef0e15a8ef44531"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a9c930aea5f23ff469ca2a8474dffe2eb31d3bda","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    creates   \u003d\u003e $idp_metadata_path,"},{"line_number":141,"context_line":"    subscribe \u003d\u003e Anchor[\u0027keystone::config::end\u0027],"},{"line_number":142,"context_line":"    notify    \u003d\u003e Anchor[\u0027keystone::service::end\u0027],"},{"line_number":143,"context_line":"    tag       \u003d\u003e \u0027keystone-exec\u0027,"},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  file { $idp_metadata_path:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"1af94dfe_0b109b00","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":33},"in_reply_to":"1af94dfe_c4f35909","updated":"2016-03-16 15:52:32.000000000","message":"any external modules that want to do stuff like, run the execs as a different user or run them in a venv or docker container need a way to collect these up. For other modules like heat we only have 1 exec so its pretty easy but keystone has a lot. This is cleaner than renaming everything.","commit_id":"a5da52ec522110ce5ec390a2fef0e15a8ef44531"}],"manifests/ldap_backend.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"d2e0b47c77783c2fe774e6c2943d4ed19f9d79a3","unresolved":false,"context_lines":[{"line_number":478,"context_line":"  $ldap_packages \u003d [\u0027python-ldap\u0027, \u0027python-ldappool\u0027]"},{"line_number":479,"context_line":"  ensure_resource(\u0027package\u0027, $ldap_packages, {"},{"line_number":480,"context_line":"    ensure  \u003d\u003e $package_ensure,"},{"line_number":481,"context_line":"    tag \u003d\u003e \u0027keystone-package\u0027,"},{"line_number":482,"context_line":"  })"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"  if ($tls_cacertdir !\u003d undef) {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5aef4532_3f857506","line":481,"updated":"2016-03-09 20:31:21.000000000","message":"This should probably be [\u0027openstack\u0027, \u0027keystone-package\u0027] to be consistent with other resources.","commit_id":"5cdf5defacd9ffdb03a531b10745940318ebe92f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"596a2ed73d9430fb5dcf5c75b4cf1692f9e4b997","unresolved":false,"context_lines":[{"line_number":453,"context_line":") {"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"  include ::keystone::deps"},{"line_number":456,"context_line":"  include ::keystone::params"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"  $domain_enabled \u003d getparam(Keystone_config[\u0027identity/domain_specific_drivers_enabled\u0027], \u0027value\u0027)"},{"line_number":459,"context_line":"  $domain_dir_enabled \u003d getparam(Keystone_config[\u0027identity/domain_config_dir\u0027], \u0027value\u0027)"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3afc51ec_695ad22b","line":456,"updated":"2016-03-15 10:31:33.000000000","message":"we don\u0027t use any vars from params class here.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"}],"manifests/logging.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"d2e0b47c77783c2fe774e6c2943d4ed19f9d79a3","unresolved":false,"context_lines":[{"line_number":119,"context_line":") {"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  include ::keystone::deps"},{"line_number":122,"context_line":"  include ::keystone::params"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":125,"context_line":"  # to use keystone::\u003cmyparam\u003e first then keystone::logging::\u003cmyparam\u003e."}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5aef4532_7f7b7d28","line":122,"updated":"2016-03-09 20:31:21.000000000","message":"Is this needed?","commit_id":"5cdf5defacd9ffdb03a531b10745940318ebe92f"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"d2e0b47c77783c2fe774e6c2943d4ed19f9d79a3","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"  # This will force the package to be installed before all domains,"},{"line_number":195,"context_line":"  # endpoints, etc. are setup."},{"line_number":196,"context_line":"  Package[\u0027httpd\u0027] ~\u003e Anchor[\u0027keystone::service::end\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  ## Sanitize parameters"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5aef4532_9fcc896b","line":196,"updated":"2016-03-09 20:31:21.000000000","message":"Isn\u0027t this implied by it being boxed by install::begin and install:end above?","commit_id":"5cdf5defacd9ffdb03a531b10745940318ebe92f"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"e17c021855774b2f2116f8c9e75ec5b87a3d2706","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  Package[\u0027keystone\u0027] -\u003e Package[\u0027httpd\u0027]"},{"line_number":183,"context_line":"  Package[\u0027keystone\u0027] ~\u003e Service[\u0027httpd\u0027]"},{"line_number":184,"context_line":"  Keystone_config \u003c| |\u003e ~\u003e Service[\u0027httpd\u0027]"},{"line_number":185,"context_line":"  Service[\u0027httpd\u0027] -\u003e Keystone_endpoint \u003c| |\u003e"},{"line_number":186,"context_line":"  Service[\u0027httpd\u0027] -\u003e Keystone_role \u003c| |\u003e"},{"line_number":187,"context_line":"  Service[\u0027httpd\u0027] -\u003e Keystone_service \u003c| |\u003e"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3afc51ec_e9fefe36","side":"PARENT","line":184,"updated":"2016-03-14 18:47:51.000000000","message":"You\u0027re missing this service restart.\n\nNow when changing a configuration in keystone.conf using keystone_config, the httpd service isn\u0027t restarted anymore.\n\nSee this log for detail: http://logs.openstack.org/98/283898/21/check/gate-puppet-keystone-puppet-beaker-rspec-dsvm-centos7/f49b098/console.html#_2016-03-13_04_34_51_929\n\nNo httpd restart while the keystone.conf file has been changed.\n\nThen all v2 test fails as they are in the my_default_domain and not the \"default\" domain:\n\nhttp://logs.openstack.org/98/283898/21/check/gate-puppet-keystone-puppet-beaker-rspec-dsvm-centos7/f49b098/console.html#_2016-03-13_04_37_14_298\n\nv3 resources are unaffected:\n\nhttp://logs.openstack.org/98/283898/21/check/gate-puppet-keystone-puppet-beaker-rspec-dsvm-centos7/f49b098/console.html#_2016-03-13_04_37_24_202\n\nldap isn\u0027t a concerned with those problems as its manifest is applied *last*, well after all those v2 tests have failed.\n\nFor reference, the beaker tests are applied in the ascii order (ls -lv) so :\n\n 0. default_domain_spec.rb\n 1. keystone_federation_identity_provider_spec.rb\n 2. keystone_federation_shibboleth_spec.rb\n 3. keystone_wsgi_apache_spec.rb\n\nand the ldap tests are at the end of the keystone_wsgi_apache_spec.rp file.\n\nAs another reference see this properly working test, where the service is restarted:\n\nhttp://logs.openstack.org/52/292452/2/check/gate-puppet-keystone-puppet-beaker-rspec-dsvm-centos7/55918dd/console.html#_2016-03-14_15_46_25_369","commit_id":"950b430e814498e5e3dded3066ec00396a28e320"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"274d10c051c177008f9931b17dcfd6550709082e","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"  # Notify the service when config changes"},{"line_number":200,"context_line":"  Anchor[\u0027keystone::config::end\u0027]"},{"line_number":201,"context_line":"  -\u003e Service[\u0027httpd\u0027]"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  ## Sanitize parameters"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3afc51ec_ca221101","line":201,"updated":"2016-03-14 19:22:40.000000000","message":"This should be \"~\u003e\" no ?","commit_id":"7c0e152b39a39475b57ce40f2be60df542957657"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"596a2ed73d9430fb5dcf5c75b4cf1692f9e4b997","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    \u0027group\u0027   \u003d\u003e \u0027keystone\u0027,"},{"line_number":234,"context_line":"    \u0027mode\u0027    \u003d\u003e \u00270644\u0027,"},{"line_number":235,"context_line":"    \u0027require\u0027 \u003d\u003e [File[$::keystone::params::keystone_wsgi_script_path],"},{"line_number":236,"context_line":"      Anchor[\u0027keystone::install::end\u0027]],"},{"line_number":237,"context_line":"  }"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  $wsgi_script_source_real \u003d $wsgi_script_source ? {"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3afc51ec_890d9eea","line":236,"range":{"start_line":236,"start_character":6,"end_line":236,"end_character":38},"updated":"2016-03-15 10:31:33.000000000","message":"i think it is not needed here, because file[$::keystone::params::keystone_wsgi_script_path] already has this dependency.","commit_id":"bfc8043ec0fac602de1c4332ca7c7bc60b93f43e"}]}