)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e093f81e7295302328d001661ba33e98a2b7935b","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    $catalog_driver_real \u003d $catalog_driver"},{"line_number":763,"context_line":"  }"},{"line_number":764,"context_line":"  elsif ($catalog_type \u003d\u003d \u0027template\u0027) {"},{"line_number":765,"context_line":"    $catalog_driver_real \u003d \u0027templated\u0027"},{"line_number":766,"context_line":"  }"},{"line_number":767,"context_line":"  elsif ($catalog_type \u003d\u003d \u0027sql\u0027) {"},{"line_number":768,"context_line":"    $catalog_driver_real \u003d \u0027sql\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aed3d3a_71c0407d","line":765,"updated":"2016-02-26 15:52:02.000000000","message":"I think this thing is deprecated, we might do the deprecated in a separate patch.","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e2e6f1f72ff79f08394a008fff1b460b43d1903","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    $catalog_driver_real \u003d $catalog_driver"},{"line_number":763,"context_line":"  }"},{"line_number":764,"context_line":"  elsif ($catalog_type \u003d\u003d \u0027template\u0027) {"},{"line_number":765,"context_line":"    $catalog_driver_real \u003d \u0027templated\u0027"},{"line_number":766,"context_line":"  }"},{"line_number":767,"context_line":"  elsif ($catalog_type \u003d\u003d \u0027sql\u0027) {"},{"line_number":768,"context_line":"    $catalog_driver_real \u003d \u0027sql\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aed3d3a_994086a7","line":765,"in_reply_to":"9aed3d3a_71c0407d","updated":"2016-02-26 17:14:32.000000000","message":"nope, not deprecated.","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"96c17f10ebfba95e5724d9bd0c3481f8e6d9a429","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    $catalog_driver_real \u003d $catalog_driver"},{"line_number":763,"context_line":"  }"},{"line_number":764,"context_line":"  elsif ($catalog_type \u003d\u003d \u0027template\u0027) {"},{"line_number":765,"context_line":"    $catalog_driver_real \u003d \u0027templated\u0027"},{"line_number":766,"context_line":"  }"},{"line_number":767,"context_line":"  elsif ($catalog_type \u003d\u003d \u0027sql\u0027) {"},{"line_number":768,"context_line":"    $catalog_driver_real \u003d \u0027sql\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aed3d3a_c5f8614c","line":765,"in_reply_to":"9aed3d3a_994086a7","updated":"2016-02-26 18:38:50.000000000","message":"ack","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0c02e80f24099ca82eab8826afae6cf0d4b88c49","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    \u0027revoke/driver\u0027:    value \u003d\u003e $revoke_driver;"},{"line_number":696,"context_line":"  }"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"  if ($policy_driver \u003d~ /^keystone\\.policy\\.backends\\..*Policy$/) {"},{"line_number":699,"context_line":"    warning(\u0027policy driver form \\\u0027keystone.policy.backends.*Policy\\\u0027 is deprecated\u0027)"},{"line_number":700,"context_line":"  }"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9aed3d3a_f9f7c088","line":698,"updated":"2016-02-29 14:20:48.000000000","message":"In the same spirit as the rest of the patch, shouldn\u0027t this stuff been removed ?","commit_id":"fe905317da0b88252520710dcea1b6b58eebddc0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"72faa9d846ce48952d82e253a193e82040acf7bd","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    \u0027revoke/driver\u0027:    value \u003d\u003e $revoke_driver;"},{"line_number":696,"context_line":"  }"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"  if ($policy_driver \u003d~ /^keystone\\.policy\\.backends\\..*Policy$/) {"},{"line_number":699,"context_line":"    warning(\u0027policy driver form \\\u0027keystone.policy.backends.*Policy\\\u0027 is deprecated\u0027)"},{"line_number":700,"context_line":"  }"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9aed3d3a_f4aea7e4","line":698,"in_reply_to":"9aed3d3a_f9f7c088","updated":"2016-02-29 14:26:31.000000000","message":"Done","commit_id":"fe905317da0b88252520710dcea1b6b58eebddc0"}],"spec/acceptance/keystone_wsgi_apache_spec.rb":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e2e6f1f72ff79f08394a008fff1b460b43d1903","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        url  \u003d\u003e \u0027ldap://foo\u0027,"},{"line_number":399,"context_line":"        user \u003d\u003e \u0027cn\u003dfoo,dc\u003dexample,dc\u003dcom\u0027,"},{"line_number":400,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":401,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":402,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":403,"context_line":"      }"},{"line_number":404,"context_line":"      keystone::ldap_backend { \u0027domain_2_ldap_backend\u0027:"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_79fe6239","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":36},"updated":"2016-02-26 17:14:32.000000000","message":"there was never an ldap backend for credentials, just sql.\n\nthe credentials backend has had very little changes since it was created, the entire history can be found here: \n\nhttps://github.com/openstack/keystone/commits/master/keystone/credential/backends","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"96c17f10ebfba95e5724d9bd0c3481f8e6d9a429","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        url  \u003d\u003e \u0027ldap://foo\u0027,"},{"line_number":399,"context_line":"        user \u003d\u003e \u0027cn\u003dfoo,dc\u003dexample,dc\u003dcom\u0027,"},{"line_number":400,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":401,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":402,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":403,"context_line":"      }"},{"line_number":404,"context_line":"      keystone::ldap_backend { \u0027domain_2_ldap_backend\u0027:"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_ac77059e","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":36},"in_reply_to":"9aed3d3a_79fe6239","updated":"2016-02-26 18:38:50.000000000","message":"Done","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"b70903ef0b8dd0abacc2d2895b4113a58642a9d6","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        url  \u003d\u003e \u0027ldap://foo\u0027,"},{"line_number":399,"context_line":"        user \u003d\u003e \u0027cn\u003dfoo,dc\u003dexample,dc\u003dcom\u0027,"},{"line_number":400,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":401,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":402,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":403,"context_line":"      }"},{"line_number":404,"context_line":"      keystone::ldap_backend { \u0027domain_2_ldap_backend\u0027:"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_4c147943","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":36},"in_reply_to":"9aed3d3a_79fe6239","updated":"2016-02-26 18:39:05.000000000","message":"Those are just \"dummy\" checks, the keystone server is restarted but no request is done, as keystone would fail anyway as it doesn\u0027t find the backend.\n\nAs it is, only the correct creation of the associated files are tested, not that the data fed in them is actually correct.\n\nThis card was open at the time to have a more functional test https://trello.com/c/DuNmElKz/70-add-a-ldap-server-to-keystone-acceptance-test-for-testing-ldap-backend\n(require the installation of a ldap server with valid data)\n\nBut you right the credential should be changed to match reality, it would be less confusing.","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e2e6f1f72ff79f08394a008fff1b460b43d1903","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        user \u003d\u003e \u0027cn\u003dfoo,dc\u003dexample,dc\u003dcom\u0027,"},{"line_number":400,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":401,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":402,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":403,"context_line":"      }"},{"line_number":404,"context_line":"      keystone::ldap_backend { \u0027domain_2_ldap_backend\u0027:"},{"line_number":405,"context_line":"        url  \u003d\u003e \u0027ldap://bar\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_b9a62a51","line":402,"range":{"start_line":402,"start_character":8,"end_line":402,"end_character":34},"updated":"2016-02-26 17:14:32.000000000","message":"this has been removed in Mitaka\n\nhttps://github.com/openstack/keystone/commit/e6efbe62b8b7f226aab22e01edecee0e60745897","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"96c17f10ebfba95e5724d9bd0c3481f8e6d9a429","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        user \u003d\u003e \u0027cn\u003dfoo,dc\u003dexample,dc\u003dcom\u0027,"},{"line_number":400,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":401,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":402,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":403,"context_line":"      }"},{"line_number":404,"context_line":"      keystone::ldap_backend { \u0027domain_2_ldap_backend\u0027:"},{"line_number":405,"context_line":"        url  \u003d\u003e \u0027ldap://bar\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_0c6f11c6","line":402,"range":{"start_line":402,"start_character":8,"end_line":402,"end_character":34},"in_reply_to":"9aed3d3a_b9a62a51","updated":"2016-02-26 18:38:50.000000000","message":"Done","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e2e6f1f72ff79f08394a008fff1b460b43d1903","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        url  \u003d\u003e \u0027ldap://bar\u0027,"},{"line_number":406,"context_line":"        user \u003d\u003e \u0027cn\u003dbar,dc\u003dtest,dc\u003dcom\u0027,"},{"line_number":407,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":408,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":409,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":410,"context_line":"      }"},{"line_number":411,"context_line":"      EOM"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_199636f0","line":408,"range":{"start_line":408,"start_character":8,"end_line":408,"end_character":36},"updated":"2016-02-26 17:14:32.000000000","message":"same","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"96c17f10ebfba95e5724d9bd0c3481f8e6d9a429","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        url  \u003d\u003e \u0027ldap://bar\u0027,"},{"line_number":406,"context_line":"        user \u003d\u003e \u0027cn\u003dbar,dc\u003dtest,dc\u003dcom\u0027,"},{"line_number":407,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":408,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":409,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":410,"context_line":"      }"},{"line_number":411,"context_line":"      EOM"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_4c6919be","line":408,"range":{"start_line":408,"start_character":8,"end_line":408,"end_character":36},"in_reply_to":"9aed3d3a_199636f0","updated":"2016-02-26 18:38:50.000000000","message":"Done","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"b70903ef0b8dd0abacc2d2895b4113a58642a9d6","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        url  \u003d\u003e \u0027ldap://bar\u0027,"},{"line_number":406,"context_line":"        user \u003d\u003e \u0027cn\u003dbar,dc\u003dtest,dc\u003dcom\u0027,"},{"line_number":407,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":408,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":409,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":410,"context_line":"      }"},{"line_number":411,"context_line":"      EOM"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_8c35e1db","line":408,"range":{"start_line":408,"start_character":8,"end_line":408,"end_character":36},"in_reply_to":"9aed3d3a_199636f0","updated":"2016-02-26 18:39:05.000000000","message":"same","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e2e6f1f72ff79f08394a008fff1b460b43d1903","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        user \u003d\u003e \u0027cn\u003dbar,dc\u003dtest,dc\u003dcom\u0027,"},{"line_number":407,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":408,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":409,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":410,"context_line":"      }"},{"line_number":411,"context_line":"      EOM"},{"line_number":412,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_596efe01","line":409,"range":{"start_line":409,"start_character":8,"end_line":409,"end_character":34},"updated":"2016-02-26 17:14:32.000000000","message":"same as above","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"96c17f10ebfba95e5724d9bd0c3481f8e6d9a429","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        user \u003d\u003e \u0027cn\u003dbar,dc\u003dtest,dc\u003dcom\u0027,"},{"line_number":407,"context_line":"        identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":408,"context_line":"        credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":409,"context_line":"        assignment_driver \u003d\u003e \u0027ldap\u0027"},{"line_number":410,"context_line":"      }"},{"line_number":411,"context_line":"      EOM"},{"line_number":412,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_8c6321dc","line":409,"range":{"start_line":409,"start_character":8,"end_line":409,"end_character":34},"in_reply_to":"9aed3d3a_596efe01","updated":"2016-02-26 18:38:50.000000000","message":"Done","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"}],"spec/classes/keystone_ldap_spec.rb":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e2e6f1f72ff79f08394a008fff1b460b43d1903","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :tls_cacertdir \u003d\u003e \u0027/etc/ssl/certs/\u0027,"},{"line_number":73,"context_line":"        :tls_cacertfile \u003d\u003e \u0027/etc/ssl/certs/ca-certificates.crt\u0027,"},{"line_number":74,"context_line":"        :tls_req_cert \u003d\u003e \u0027demand\u0027,"},{"line_number":75,"context_line":"        :identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":76,"context_line":"        :credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":77,"context_line":"        :assignment_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":78,"context_line":"        :use_pool \u003d\u003e \u0027True\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_59455e6e","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":35},"updated":"2016-02-26 17:14:32.000000000","message":"only the identity driver supports LDAP in mitaka, assignment support for LDAP has been removed in mitaka, credential support has never existed","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"96c17f10ebfba95e5724d9bd0c3481f8e6d9a429","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :tls_cacertdir \u003d\u003e \u0027/etc/ssl/certs/\u0027,"},{"line_number":73,"context_line":"        :tls_cacertfile \u003d\u003e \u0027/etc/ssl/certs/ca-certificates.crt\u0027,"},{"line_number":74,"context_line":"        :tls_req_cert \u003d\u003e \u0027demand\u0027,"},{"line_number":75,"context_line":"        :identity_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":76,"context_line":"        :credential_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":77,"context_line":"        :assignment_driver \u003d\u003e \u0027ldap\u0027,"},{"line_number":78,"context_line":"        :use_pool \u003d\u003e \u0027True\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aed3d3a_cc824952","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":35},"in_reply_to":"9aed3d3a_59455e6e","updated":"2016-02-26 18:38:50.000000000","message":"Done","commit_id":"dc7f969bd4c53300770a843a2b5d53253d0e7cab"}]}