)]}'
{"manifests/init.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7dccbcdc380efb7e7062ad5a4bdd4769bbaec176","unresolved":false,"context_lines":[{"line_number":996,"context_line":"    # they did something silly, like defining a file rather than a"},{"line_number":997,"context_line":"    # directory.  For the permission it\u0027s their choice."},{"line_number":998,"context_line":"    if (!defined(File[$domain_config_directory])) {"},{"line_number":999,"context_line":"      Package\u003c| tag \u003d\u003d \u0027keystone-package\u0027 |\u003e -\u003e"},{"line_number":1000,"context_line":"      file { $domain_config_directory:"},{"line_number":1001,"context_line":"        ensure \u003d\u003e directory,"},{"line_number":1002,"context_line":"        owner  \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5aef4532_0cc92dac","line":999,"updated":"2016-03-10 22:40:03.000000000","message":"This is convoluted, why not just have a require \u003d\u003e Package[\u0027keystone\u0027] on the file resource? I don\u0027t see a need to use collectors or to refer to it by tag instead of name.","commit_id":"9891ea44f210f42d3489206c776bc136141a43fb"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"cf3823560e8bc666ff01944b84394601cdb1125f","unresolved":false,"context_lines":[{"line_number":996,"context_line":"    # they did something silly, like defining a file rather than a"},{"line_number":997,"context_line":"    # directory.  For the permission it\u0027s their choice."},{"line_number":998,"context_line":"    if (!defined(File[$domain_config_directory])) {"},{"line_number":999,"context_line":"      Package\u003c| tag \u003d\u003d \u0027keystone-package\u0027 |\u003e -\u003e"},{"line_number":1000,"context_line":"      file { $domain_config_directory:"},{"line_number":1001,"context_line":"        ensure \u003d\u003e directory,"},{"line_number":1002,"context_line":"        owner  \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afc51ec_1c0caa93","line":999,"in_reply_to":"5aef4532_0cc92dac","updated":"2016-03-11 14:14:47.000000000","message":"Well, I asked myself the self question with the mere existence of the tag in the keystone package definition, and thought that there was a smart reason for it to be there, like several resources related to keystone package... This kind of indirection looks good.  There is one already in the title vs name definition:\n\n  package { \u0027keystone\u0027:\n    ensure \u003d\u003e $package_ensure,\n    name   \u003d\u003e $::keystone::params::package_name,\n    tag    \u003d\u003e [\u0027openstack\u0027, \u0027keystone-package\u0027],\n  }\n\nBut I said to myself that it existed for a reason.  Now greping through all module there is no other resource tagged keystone-package, so maybe this is useless.\n\nI\u0027m refactoring the idiom to something more common.","commit_id":"9891ea44f210f42d3489206c776bc136141a43fb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c9b96ac218cae764ebb8c445ba7245ba47eeea96","unresolved":false,"context_lines":[{"line_number":997,"context_line":"    # directory.  For the permission it\u0027s their choice."},{"line_number":998,"context_line":"    if (!defined(File[$domain_config_directory])) {"},{"line_number":999,"context_line":"      Package\u003c| tag \u003d\u003d \u0027keystone-package\u0027 |\u003e -\u003e"},{"line_number":1000,"context_line":"      file { $domain_config_directory:"},{"line_number":1001,"context_line":"        ensure \u003d\u003e directory,"},{"line_number":1002,"context_line":"        owner  \u003d\u003e \u0027keystone\u0027,"},{"line_number":1003,"context_line":"        group  \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5aef4532_7c340749","line":1000,"range":{"start_line":1000,"start_character":13,"end_line":1000,"end_character":38},"updated":"2016-03-10 12:05:38.000000000","message":"shouldn\u0027t this directory be provided by package at all?","commit_id":"9891ea44f210f42d3489206c776bc136141a43fb"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"c8d1fadbd339dc5970fbbd6b0b88fc1520c17e5c","unresolved":false,"context_lines":[{"line_number":997,"context_line":"    # directory.  For the permission it\u0027s their choice."},{"line_number":998,"context_line":"    if (!defined(File[$domain_config_directory])) {"},{"line_number":999,"context_line":"      Package\u003c| tag \u003d\u003d \u0027keystone-package\u0027 |\u003e -\u003e"},{"line_number":1000,"context_line":"      file { $domain_config_directory:"},{"line_number":1001,"context_line":"        ensure \u003d\u003e directory,"},{"line_number":1002,"context_line":"        owner  \u003d\u003e \u0027keystone\u0027,"},{"line_number":1003,"context_line":"        group  \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5aef4532_cce47bad","line":1000,"range":{"start_line":1000,"start_character":13,"end_line":1000,"end_character":38},"in_reply_to":"5aef4532_7c340749","updated":"2016-03-10 15:52:39.000000000","message":"Nope.  Multiple domains and domain_config_dir are disabled by default in keystone.conf and it\u0027s up to the operator to activate it and define it.","commit_id":"9891ea44f210f42d3489206c776bc136141a43fb"}]}