)]}'
{"manifests/params.pp":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"5b5dd05a08e660fc411baa805ca6f59fdc5d2f0f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"        default: {"},{"line_number":23,"context_line":"          case $::operatingsystemrelease {"},{"line_number":24,"context_line":"            \u002716.04\u0027: {"},{"line_number":25,"context_line":"              $service_provider \u003d \u0027systemd\u0027"},{"line_number":26,"context_line":"            }"},{"line_number":27,"context_line":"            default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afc51ec_0dbb730f","line":24,"updated":"2016-03-14 19:37:00.000000000","message":"Wouldn\u0027t it be possible to have something more like \"above 15.04\" then \u0027systemd\u0027 else upstart ?","commit_id":"cc99a1955906ddbba0e1e673bd3ec46996fbc910"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"bc9617cf653f525415e5da0372d2c973dd1acc7a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"        default: {"},{"line_number":23,"context_line":"          case $::operatingsystemrelease {"},{"line_number":24,"context_line":"            \u002716.04\u0027: {"},{"line_number":25,"context_line":"              $service_provider \u003d \u0027systemd\u0027"},{"line_number":26,"context_line":"            }"},{"line_number":27,"context_line":"            default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afc51ec_99ffc166","line":24,"in_reply_to":"3afc51ec_0dbb730f","updated":"2016-03-14 21:11:19.000000000","message":"This is probably only possible by using the versioncmp function, https://docs.puppetlabs.com/puppet/latest/reference/function.html#versioncmp to stay compatible across all the versions of puppet we support.\n\nComparing versions as strings in Puppet 4.x works as one would desire but in Puppet 3.x versions with two dots are implicitly cast as strings while versions with only one dot get implicitly cast as floats.","commit_id":"cc99a1955906ddbba0e1e673bd3ec46996fbc910"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"b998db6018a70bb0fc2b0353eff053873338df68","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"        default: {"},{"line_number":23,"context_line":"          case $::operatingsystemrelease {"},{"line_number":24,"context_line":"            \u002716.04\u0027: {"},{"line_number":25,"context_line":"              $service_provider \u003d \u0027systemd\u0027"},{"line_number":26,"context_line":"            }"},{"line_number":27,"context_line":"            default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_d5c5b73c","line":24,"in_reply_to":"3afc51ec_2a51ea0e","updated":"2016-03-16 14:23:11.000000000","message":"seems like versioncmp() is also available in puppet 3, but not mention in doc,\n\nhttps://github.com/puppetlabs/puppet/blob/master/lib/puppet/parser/functions/versioncmp.rb\n\nplus, there\u0027s a related commit back in Feb 2015, seems like versioncmp() is the solution we needed\n\nhttps://bugs.launchpad.net/puppet-nova/+bug/1425300\n\nI\u0027ll commit a new patch set later :)","commit_id":"cc99a1955906ddbba0e1e673bd3ec46996fbc910"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"4569ddc010d2ceccc11a4431b420fc2b212d9638","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"        default: {"},{"line_number":23,"context_line":"          case $::operatingsystemrelease {"},{"line_number":24,"context_line":"            \u002716.04\u0027: {"},{"line_number":25,"context_line":"              $service_provider \u003d \u0027systemd\u0027"},{"line_number":26,"context_line":"            }"},{"line_number":27,"context_line":"            default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afc51ec_2a51ea0e","line":24,"in_reply_to":"3afc51ec_99ffc166","updated":"2016-03-15 00:45:30.000000000","message":"the first question,\nare we going to support non-LTS release?\n\nwith puppet 3,\nunder Ubuntu distribution, facter major version would be dotted \"14.04\".\n\nwith puppet 4,\nseem like versioncmp() is what we want, but I\u0027m not sure if casting \"14.04\" as float to \"14.4\" would work as expect.\n\none possible solution for me, is to split major release version, $version \u003d split($::operatingsystemmajrelease, \u0027\\.\u0027), and compare if $version[0] is greater than \"15\"\n\nis that okay for you?","commit_id":"cc99a1955906ddbba0e1e673bd3ec46996fbc910"}]}