)]}'
{"lib/puppet/provider/keystone_endpoint/openstack.rb":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"d6428a8c7205fe1090107bd2c2857e41335f4ef9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  def set_endpoint(endpoint_id, name, type, url)"},{"line_number":182,"context_line":"    if endpoint_id.to_s \u003d\u003d \u0027\u0027"},{"line_number":183,"context_line":"      id \u003d service_id(name, type)"},{"line_number":184,"context_line":"      endpoint_create(id, @property_hash[:region], \u0027admin\u0027, @property_flush[:admin_url])"},{"line_number":185,"context_line":"    else"},{"line_number":186,"context_line":"      self.class.request(\u0027endpoint\u0027, \u0027set\u0027, [id, \"--url\u003d#{url}\"])"},{"line_number":187,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1af94dfe_e5cc058b","line":184,"updated":"2016-03-18 15:07:33.000000000","message":"This is wrong: endpoint_create options should be name, region, url","commit_id":"3f252fd365bafdad104d8429b0894fad05368923"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"58d3a633414c6fe32026572ff268a5d819355964","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  def set_endpoint(endpoint_id, name, type, url)"},{"line_number":182,"context_line":"    if endpoint_id.to_s \u003d\u003d \u0027\u0027"},{"line_number":183,"context_line":"      id \u003d service_id(name, type)"},{"line_number":184,"context_line":"      endpoint_create(id, @property_hash[:region], type, url)"},{"line_number":185,"context_line":"    else"},{"line_number":186,"context_line":"      self.class.request(\u0027endpoint\u0027, \u0027set\u0027, [endpoint_id, \"--url\u003d#{url}\"])"},{"line_number":187,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa0719c6_30ab52d8","line":184,"updated":"2016-03-22 10:57:55.000000000","message":"endpoint_create take the name of the endpoint not the id of a non-existing entry.  This create an error.","commit_id":"23e3e3d93adc53ae969be6f139532310ad7161e7"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"d008fc13b7cf872901a259c31f298257c37032ac","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        :ensure       \u003d\u003e :present,"},{"line_number":142,"context_line":"        :id           \u003d\u003e ids,"},{"line_number":143,"context_line":"        :region       \u003d\u003e [endpoint[:admin], endpoint[:internal], endpoint[:public]].find {|x| !x.nil?}[:region],"},{"line_number":144,"context_line":"        :admin_url    \u003d\u003e endpoint[:admin] ? endpoint[:admin][:url] : nil,"},{"line_number":145,"context_line":"        :internal_url \u003d\u003e endpoint[:internal] ? endpoint[:internal][:url] : nil,"},{"line_number":146,"context_line":"        :public_url   \u003d\u003e endpoint[:public] ? endpoint[:public][:url] : nil,"},{"line_number":147,"context_line":"      )"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba0121b8_82fee5ab","line":144,"updated":"2016-03-31 16:07:00.000000000","message":"Wont this throw an exception when endpoint[:admin] is undefined?","commit_id":"4f968a9535fd7754c33178cc44eccc75b76cd72d"}]}