)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"60e904e60023ca82743766e033926d72b8a6b642","unresolved":false,"context_lines":[{"line_number":913,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-keystone for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":914,"context_line":"  }"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":917,"context_line":"    exec { \u0027sleep_for_eventlet\u0027:"},{"line_number":918,"context_line":"      command     \u003d\u003e \u0027sleep 35\u0027,"},{"line_number":919,"context_line":"      refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_d739e5f3","line":916,"updated":"2016-04-19 19:46:49.000000000","message":"please move it after line 911 and add an else to have Service[\u0027keystone\u0027] -\u003e Service[$service_name_real]","commit_id":"407e13bbbf8a773c40131f35f9f0c312c5436874"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"5e9aaa0f042d1bd6e53ec92b4cc652bcd8876e23","unresolved":false,"context_lines":[{"line_number":913,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-keystone for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":914,"context_line":"  }"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":917,"context_line":"    exec { \u0027sleep_for_eventlet\u0027:"},{"line_number":918,"context_line":"      command     \u003d\u003e \u0027sleep 35\u0027,"},{"line_number":919,"context_line":"      refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_526163d2","line":916,"in_reply_to":"1a122d0e_d739e5f3","updated":"2016-04-19 19:52:37.000000000","message":"moved it after line 911 but else statement isnt needed.","commit_id":"407e13bbbf8a773c40131f35f9f0c312c5436874"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"60e904e60023ca82743766e033926d72b8a6b642","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":917,"context_line":"    exec { \u0027sleep_for_eventlet\u0027:"},{"line_number":918,"context_line":"      command     \u003d\u003e \u0027sleep 35\u0027,"},{"line_number":919,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":920,"context_line":"    }"},{"line_number":921,"context_line":"    Service[\u0027keystone\u0027] ~\u003e Exec[\u0027sleep_for_eventlet\u0027] -\u003e Service[$service_name_real]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_d7428567","line":918,"updated":"2016-04-19 19:46:49.000000000","message":"put 50, in case of.","commit_id":"407e13bbbf8a773c40131f35f9f0c312c5436874"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c88631fa468af9d9cea16cc019e781af8d8c703e","unresolved":false,"context_lines":[{"line_number":908,"context_line":"    $service_name_real \u003d $::apache::params::service_name"},{"line_number":909,"context_line":"    # leave this here because Ubuntu packages will start Keystone and we need it stopped"},{"line_number":910,"context_line":"    # before apache can run"},{"line_number":911,"context_line":"    Service[\u0027keystone\u0027] -\u003e Service[$service_name_real]"},{"line_number":912,"context_line":"    if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":913,"context_line":"      exec { \u0027sleep_for_eventlet\u0027:"},{"line_number":914,"context_line":"        command     \u003d\u003e \u0027/bin/sleep 35\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_d280d3f9","line":911,"updated":"2016-04-19 20:02:00.000000000","message":"why should we keep that line then?","commit_id":"94768cafe2df6f8ce979e752d19593685ce39811"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c88631fa468af9d9cea16cc019e781af8d8c703e","unresolved":false,"context_lines":[{"line_number":920,"context_line":"    fail(\u0027Invalid service_name. Either keystone/openstack-keystone for running as a standalone service, or httpd for being run by a httpd server\u0027)"},{"line_number":921,"context_line":"  }"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"  if $sync_db {"},{"line_number":925,"context_line":"    include ::keystone::db::sync"},{"line_number":926,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_529e8363","line":923,"updated":"2016-04-19 20:02:00.000000000","message":"drop line","commit_id":"94768cafe2df6f8ce979e752d19593685ce39811"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8b337ea67e2bf828314374992bd0a813476d1a52","unresolved":false,"context_lines":[{"line_number":909,"context_line":"    # leave this here because Ubuntu packages will start Keystone and we need it stopped"},{"line_number":910,"context_line":"    # before apache can run. Delay added to ensure eventlet has enough time to exit."},{"line_number":911,"context_line":"    exec { \u0027sleep_for_eventlet\u0027:"},{"line_number":912,"context_line":"      command     \u003d\u003e \u0027/bin/sleep 35\u0027,"},{"line_number":913,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":914,"context_line":"    }"},{"line_number":915,"context_line":"    Service[\u0027keystone\u0027] ~\u003e Exec[\u0027sleep_for_eventlet\u0027] -\u003e Service[$service_name_real]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_5bdcc072","line":912,"updated":"2016-04-20 10:20:27.000000000","message":"may be we can find more proper to check is service stopped or not?","commit_id":"574e4ec038b91bcaf8293a0b9fcdf788eef4a9da"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ef8e7ca5876df3375b7c4e6d441080e38cd1b3ea","unresolved":false,"context_lines":[{"line_number":924,"context_line":"      # openstacklib::policyrcd only affects debian based systems."},{"line_number":925,"context_line":"      class { \u0027::openstacklib::policyrcd\u0027: services \u003d\u003e [\u0027keystone\u0027] }"},{"line_number":926,"context_line":"      Class[\u0027::openstacklib::policyrcd\u0027] -\u003e Package[\u0027keystone\u0027]"},{"line_number":927,"context_line":"    }"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    class { \u0027::keystone::service\u0027:"},{"line_number":930,"context_line":"      ensure       \u003d\u003e \u0027stopped\u0027,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"1a122d0e_cbf24206","line":927,"updated":"2016-04-22 13:44:03.000000000","message":"just one note, may be we can move this block out of if section?","commit_id":"ecf2b06af5b9dc2fcb0bcfc9046f3380cd6bb302"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7a4781dd811039bd72804abcc22b245b06bd8996","unresolved":false,"context_lines":[{"line_number":924,"context_line":"      # openstacklib::policyrcd only affects debian based systems."},{"line_number":925,"context_line":"      class { \u0027::openstacklib::policyrcd\u0027: services \u003d\u003e [\u0027keystone\u0027] }"},{"line_number":926,"context_line":"      Class[\u0027::openstacklib::policyrcd\u0027] -\u003e Package[\u0027keystone\u0027]"},{"line_number":927,"context_line":"    }"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    class { \u0027::keystone::service\u0027:"},{"line_number":930,"context_line":"      ensure       \u003d\u003e \u0027stopped\u0027,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"1a122d0e_eb91fe53","line":927,"in_reply_to":"1a122d0e_cbf24206","updated":"2016-04-22 13:46:29.000000000","message":"right, +1, some people might run something else than eventlet or httpd.","commit_id":"ecf2b06af5b9dc2fcb0bcfc9046f3380cd6bb302"}]}