)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1d99fd8402471ef5334e0969bc1fcf58042a546c","unresolved":false,"context_lines":[{"line_number":671,"context_line":"  $public_workers                       \u003d max($::processorcount, 2),"},{"line_number":672,"context_line":"  $service_provider                     \u003d undef,"},{"line_number":673,"context_line":"  $verbose                              \u003d undef,"},{"line_number":674,"context_line":"  $signing_certfile                     \u003d undef,"},{"line_number":675,"context_line":"  $signing_keyfile                      \u003d undef,"},{"line_number":676,"context_line":"  $signing_ca_certs                     \u003d undef,"},{"line_number":677,"context_line":"  $signing_ca_key                       \u003d undef,"},{"line_number":678,"context_line":"  $signing_cert_subject                 \u003d undef,"},{"line_number":679,"context_line":"  $signing_key_size                     \u003d undef,"},{"line_number":680,"context_line":") inherits keystone::params {"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"  include ::keystone::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_2df50a83","line":679,"range":{"start_line":674,"start_character":0,"end_line":679,"end_character":48},"updated":"2016-05-18 08:00:24.000000000","message":"i\u0027d prefer to go with $::os_service_default here.\n\nBecause undef value is not suppose to manage this resource at all, while $::os_service_default will have ensure \u003d\u003e absent by default.","commit_id":"bb1099731800d1a5acbf3df80f78d0b056ea3ec9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1d99fd8402471ef5334e0969bc1fcf58042a546c","unresolved":false,"context_lines":[{"line_number":832,"context_line":"  }"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"  # Set the signing key/cert configuration values."},{"line_number":835,"context_line":"  if $signing_certfile {"},{"line_number":836,"context_line":"    warning(\u0027PKI token support has been deprecated in the M release and will be removed in the O release. Fernet or UUID tokens are recommended.\u0027)"},{"line_number":837,"context_line":"  }"},{"line_number":838,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_0d35a645","line":835,"updated":"2016-05-18 08:00:24.000000000","message":"change to: ! is_service_default(..)","commit_id":"bb1099731800d1a5acbf3df80f78d0b056ea3ec9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f076f1a39be686ba569d8a0c638af11d1a2e4322","unresolved":false,"context_lines":[{"line_number":192,"context_line":"#   revocation lists if it doesn\u0027t already exist. This generates a cert and key stored in file"},{"line_number":193,"context_line":"#   locations based on the signing_certfile and signing_keyfile paramters below. If you are"},{"line_number":194,"context_line":"#   providing your own signing cert, make this false."},{"line_number":195,"context_line":"#   Default to false."},{"line_number":196,"context_line":"#"},{"line_number":197,"context_line":"# [*rabbit_host*]"},{"line_number":198,"context_line":"#   (optional) Location of rabbitmq installation."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_f7aedd96","line":195,"updated":"2016-05-19 11:42:40.000000000","message":"you probably should deprecate this parameter as will and set in to undef","commit_id":"97fb0e7fbd3d607f5a9b2bf40815843446e78ec2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f076f1a39be686ba569d8a0c638af11d1a2e4322","unresolved":false,"context_lines":[{"line_number":888,"context_line":"      command     \u003d\u003e \"keystone-manage pki_setup --keystone-user ${keystone_user} --keystone-group ${keystone_group}\","},{"line_number":889,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":890,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":891,"context_line":"      creates     \u003d\u003e $signing_keyfile,"},{"line_number":892,"context_line":"      notify      \u003d\u003e Anchor[\u0027keystone::service::begin\u0027],"},{"line_number":893,"context_line":"      subscribe   \u003d\u003e [Anchor[\u0027keystone::install::end\u0027], Anchor[\u0027keystone::config::end\u0027]],"},{"line_number":894,"context_line":"      tag         \u003d\u003e \u0027keystone-exec\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_f729bd38","line":891,"updated":"2016-05-19 11:42:40.000000000","message":"looks like fuel ci is broken because we have here \u003cSERVICE DEFAULT\u003e\n\nas workaround, i guess we can use here something like:\n\nif is_service_default($signing_keyfile) {\n  fail(\u0027Please specify path to key file\u0027)\n}","commit_id":"97fb0e7fbd3d607f5a9b2bf40815843446e78ec2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3d33211c2b18f5183bd27d340f15f4e5f90cf3b0","unresolved":false,"context_lines":[{"line_number":881,"context_line":"  if $enable_pki_setup \u003d\u003d true {"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    if is_service_default($signing_keyfile) {"},{"line_number":884,"context_line":"      fail(\u0027Please specify path to key file\u0027)"},{"line_number":885,"context_line":"    } else {"},{"line_number":886,"context_line":"    # Create cache directory used for signing."},{"line_number":887,"context_line":"      file { $cache_dir:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_17cfcf29","line":884,"updated":"2016-05-20 18:13:56.000000000","message":"As this is a deprecated option, I don\u0027t think we should should be adding in a new requirement for this. Let\u0027s not add this fail in (it also breaks fuel).","commit_id":"617fa98dcce162fc49bd8c1d88a91a34ed4f6c19"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"08fa7b401074d65708e23d9ee8f4d5f18a5afa11","unresolved":false,"context_lines":[{"line_number":881,"context_line":"  if $enable_pki_setup \u003d\u003d true {"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    if is_service_default($signing_keyfile) {"},{"line_number":884,"context_line":"      fail(\u0027Please specify path to key file\u0027)"},{"line_number":885,"context_line":"    } else {"},{"line_number":886,"context_line":"    # Create cache directory used for signing."},{"line_number":887,"context_line":"      file { $cache_dir:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_6e0da5e7","line":884,"in_reply_to":"bab6814e_17cfcf29","updated":"2016-05-20 18:28:08.000000000","message":"Actually, in looking further it makes sense since we switched it to os_service_default. Still a change in the default behavior, perhaps we should leave this one?  I\u0027m working on fixing it for fuel as i don\u0027t think we use it.","commit_id":"617fa98dcce162fc49bd8c1d88a91a34ed4f6c19"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"13347e567fc6787cc5764c3757c4b77ad206cd06","unresolved":false,"context_lines":[{"line_number":881,"context_line":"  if $enable_pki_setup \u003d\u003d true {"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    if is_service_default($signing_keyfile) {"},{"line_number":884,"context_line":"      fail(\u0027Please specify path to key file\u0027)"},{"line_number":885,"context_line":"    } else {"},{"line_number":886,"context_line":"    # Create cache directory used for signing."},{"line_number":887,"context_line":"      file { $cache_dir:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_5377849f","line":884,"in_reply_to":"bab6814e_6e0da5e7","updated":"2016-05-23 05:48:43.000000000","message":"oh, please tell me if fuel is ok, i will patch it again.","commit_id":"617fa98dcce162fc49bd8c1d88a91a34ed4f6c19"}]}