)]}'
{"manifests/deps.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"053ea09dd95cbb02339e1a978759f6903b4132a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  anchor { \u0027keystone::install::begin\u0027: }"},{"line_number":14,"context_line":"  -\u003e Package\u003c| tag \u003d\u003d \u0027keystone-package\u0027|\u003e"},{"line_number":15,"context_line":"  ~\u003e anchor { \u0027keystone::install::end\u0027: }"},{"line_number":16,"context_line":"  -\u003e Oslo::Cache\u003c||\u003e"},{"line_number":17,"context_line":"  -\u003e anchor { \u0027keystone::config::begin\u0027: }"},{"line_number":18,"context_line":"  -\u003e Keystone_config\u003c||\u003e"},{"line_number":19,"context_line":"  ~\u003e anchor { \u0027keystone::config::end\u0027: }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_fcff9d63","line":16,"updated":"2016-05-26 11:24:20.000000000","message":"that\u0027s not a good example, how we should manage such dependencies.\n\nActually, we already have same situation for db backend package and there no any dependencies and conflicts, why we need it in this case?","commit_id":"8794638c4c69a4f339c2cdb7c66e71c95a646c6f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dd7ee096bd624a379b3f15b1a88831cb78663edc","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # all cache settings should be applied and all packages should be installed"},{"line_number":28,"context_line":"  # before service startup"},{"line_number":29,"context_line":"  Oslo::Cache -\u003e Anchor[\u0027keystone::service::begin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # paste-api.ini config should occur in the config block also."},{"line_number":32,"context_line":"  Anchor[\u0027keystone::config::begin\u0027]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9abb7d3a_c317dfeb","line":29,"updated":"2016-05-27 15:14:53.000000000","message":"I like it better :-)","commit_id":"d8902331e68320255be1a193f076d4e6e22db6ee"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7b40409f9ecda552d629d745cba906ed4a1103be","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # all cache settings should be applied and all packages should be installed"},{"line_number":28,"context_line":"  # before service startup"},{"line_number":29,"context_line":"  Oslo::Cache\u003c||\u003e -\u003e Anchor[\u0027keystone::service::begin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # paste-api.ini config should occur in the config block also."},{"line_number":32,"context_line":"  Anchor[\u0027keystone::config::begin\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_14bf56fc","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":20},"updated":"2016-05-27 17:57:58.000000000","message":"As Oslo::Cache contains keystone_config, in case of changing cache backend option, we probably should restart services.\n\nBut i\u0027m not sure. Can you check it?","commit_id":"b0579205604f305c3753b04941c702481db27612"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"c487230a48a7174a7b283f017fbf59d99d9ace64","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # all cache settings should be applied and all packages should be installed"},{"line_number":28,"context_line":"  # before service startup"},{"line_number":29,"context_line":"  Oslo::Cache\u003c||\u003e -\u003e Anchor[\u0027keystone::service::begin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # paste-api.ini config should occur in the config block also."},{"line_number":32,"context_line":"  Anchor[\u0027keystone::config::begin\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_62dcf1e4","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":20},"in_reply_to":"9abb7d3a_14bf56fc","updated":"2016-05-30 12:43:36.000000000","message":"I see this flow:\n1) \"Keystone_config\u003c||\u003e\" notifies \"keystone::config::end\" (line 18)\n2) \"keystone::config::end\" notifies \"keystone::service::begin\" (line 77)\n3) \u0027keystone::service::begin\u0027 notifies \"Service\u003c| tag \u003d\u003d \u0027keystone-service\u0027 |\u003e\" (line 24)\n\nSo, events are not going to be lost. I made local test with similar structure, it worked.","commit_id":"b0579205604f305c3753b04941c702481db27612"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8a07b819d61600eb93488b858c01815c4fc1e9b7","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # all cache settings should be applied and all packages should be installed"},{"line_number":28,"context_line":"  # before service startup"},{"line_number":29,"context_line":"  Oslo::Cache\u003c||\u003e -\u003e Anchor[\u0027keystone::service::begin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # paste-api.ini config should occur in the config block also."},{"line_number":32,"context_line":"  Anchor[\u0027keystone::config::begin\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_e24aa182","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":20},"in_reply_to":"9abb7d3a_62dcf1e4","updated":"2016-05-30 12:47:45.000000000","message":"Ok, thanks","commit_id":"b0579205604f305c3753b04941c702481db27612"}],"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d4ad6df8f160f281f53722783ed8a14eb3fbc01","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    memcache_pool_maxsize                \u003d\u003e $memcache_pool_maxsize,"},{"line_number":829,"context_line":"    memcache_pool_unused_timeout         \u003d\u003e $memcache_pool_unused_timeout,"},{"line_number":830,"context_line":"    memcache_pool_connection_get_timeout \u003d\u003e $memcache_pool_connection_get_timeout,"},{"line_number":831,"context_line":"  } -\u003e Anchor[\u0027keystone::service::begin\u0027]"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"  # configure based on the catalog backend"},{"line_number":834,"context_line":"  if $catalog_driver {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_2a184084","line":831,"updated":"2016-05-27 14:37:33.000000000","message":"not this this is the right place. We should rather fix it in deps.pp eventually.","commit_id":"5f5e5a5d93ac2ef324602be5fb28bb0029b0fcb2"}]}