)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4e48d2886960e32f6c307cf0170a1678020b5693","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add misssing parameters to keystone_authtoken"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added keystonemiddleware parameters to keystone_authtoken section."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iaac179f2aa32d484dab9296dcb939580aba07c73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_384dd472","line":10,"updated":"2016-06-12 04:17:30.000000000","message":"Please add the Closes-Bug reference","commit_id":"367c455e106fc28611ea41557fb6fc2b48b231d6"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a7b3d761a790e0f7012318bde83722321bf67edb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add misssing parameters to keystone_authtoken"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added keystonemiddleware parameters to keystone_authtoken section."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iaac179f2aa32d484dab9296dcb939580aba07c73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_61d320d6","line":10,"in_reply_to":"7aa08908_384dd472","updated":"2016-06-13 08:58:18.000000000","message":"Ok :)","commit_id":"367c455e106fc28611ea41557fb6fc2b48b231d6"}],"manifests/resource/authtoken.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"166a933ce162b1fa74a391e6c0104123fb412b0c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"  $auth_section                   \u003d undef,"},{"line_number":309,"context_line":"  $auth_type                      \u003d undef,"},{"line_number":310,"context_line":"  $auth_uri                       \u003d undef,"},{"line_number":311,"context_line":"  $auth_version                   \u003d undef,"},{"line_number":312,"context_line":"  $cache                          \u003d undef,"},{"line_number":313,"context_line":"  $cafile                         \u003d undef,"},{"line_number":314,"context_line":"  $certfile                       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_b384f7d2","line":311,"updated":"2016-06-14 10:26:32.000000000","message":"are you sure about $auth_version and $auth_uri  ? afaik, they are deprecated now.","commit_id":"367c455e106fc28611ea41557fb6fc2b48b231d6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4e48d2886960e32f6c307cf0170a1678020b5693","unresolved":false,"context_lines":[{"line_number":333,"context_line":"  $revocation_cache_time          \u003d undef,"},{"line_number":334,"context_line":"  $signing_dir                    \u003d undef,"},{"line_number":335,"context_line":"  $token_cache_time               \u003d undef,"},{"line_number":336,"context_line":") {"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  include ::keystone::deps"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_f834ecde","line":336,"updated":"2016-06-12 04:17:30.000000000","message":"You can use $::os_service_default in most of these parameters, and don\u0027t need to ensure absent.","commit_id":"367c455e106fc28611ea41557fb6fc2b48b231d6"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a7b3d761a790e0f7012318bde83722321bf67edb","unresolved":false,"context_lines":[{"line_number":333,"context_line":"  $revocation_cache_time          \u003d undef,"},{"line_number":334,"context_line":"  $signing_dir                    \u003d undef,"},{"line_number":335,"context_line":"  $token_cache_time               \u003d undef,"},{"line_number":336,"context_line":") {"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  include ::keystone::deps"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_e1df10d4","line":336,"in_reply_to":"7aa08908_f834ecde","updated":"2016-06-13 08:58:18.000000000","message":"ok","commit_id":"367c455e106fc28611ea41557fb6fc2b48b231d6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# \u003d\u003d Parameters:"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*name*]"},{"line_number":47,"context_line":"#   (required) The name of the resource corresponding to the config file."},{"line_number":48,"context_line":"#   For example, keystone::resource::authtoken { \u0027glance_api_config\u0027: ... }"},{"line_number":49,"context_line":"#   Where \u0027glance_api_config\u0027 is the name of the resource used to manage"},{"line_number":50,"context_line":"#   the glance api configuration."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_05d7f6bf","line":47,"updated":"2016-06-22 21:26:23.000000000","message":"Should probably leave this as Required. I think we usually capitalize the first letter","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*auth_plugin*]"},{"line_number":66,"context_line":"#   (deprecated) The plugin to use for authentication."},{"line_number":67,"context_line":"#   Use auth_type instead of auth_plugin."},{"line_number":68,"context_line":"#   Defaults to $::os_service_default"},{"line_number":69,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_65e6bab5","line":66,"updated":"2016-06-22 21:26:23.000000000","message":"Normally for deprecated options we\u0027ll move them down in the list under a deprecated header and leave the optional in place","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"10b8ef8639887f79534364f98168ec70d3ed3c45","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*auth_plugin*]"},{"line_number":66,"context_line":"#   (deprecated) The plugin to use for authentication."},{"line_number":67,"context_line":"#   Use auth_type instead of auth_plugin."},{"line_number":68,"context_line":"#   Defaults to $::os_service_default"},{"line_number":69,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_1050d25d","line":66,"in_reply_to":"3aaa91ec_65e6bab5","updated":"2016-06-22 22:00:27.000000000","message":"Ok","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":137,"context_line":"#   Defaults to $::os_service_default"},{"line_number":138,"context_line":"#"},{"line_number":139,"context_line":"# [*insecure*]"},{"line_number":140,"context_line":"#  (optional)If true, explicitly allow TLS without checking server cert"},{"line_number":141,"context_line":"#  against any certificate authorities.  WARNING: not recommended.  Use with"},{"line_number":142,"context_line":"#  caution."},{"line_number":143,"context_line":"#  Defaults to false (which means be secure)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_45e1fe99","line":140,"updated":"2016-06-22 21:26:23.000000000","message":"Can you add a space after the ) ?","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"#  Defaults to false (which means be secure)"},{"line_number":144,"context_line":"#"},{"line_number":145,"context_line":"# [*auth_section*]"},{"line_number":146,"context_line":"#  (optional)Config Section from which to load plugin specific options"},{"line_number":147,"context_line":"#  Defaults to $::os_service_default."},{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# [*auth_type*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_a5eee288","line":146,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"#  Defaults to $::os_service_default."},{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# [*auth_type*]"},{"line_number":150,"context_line":"#  (optional)Authentication type to load"},{"line_number":151,"context_line":"#  Defaults to \u0027password\u0027"},{"line_number":152,"context_line":"#"},{"line_number":153,"context_line":"# [*auth_uri*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_85f1266d","line":150,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":151,"context_line":"#  Defaults to \u0027password\u0027"},{"line_number":152,"context_line":"#"},{"line_number":153,"context_line":"# [*auth_uri*]"},{"line_number":154,"context_line":"#  (optional)Complete public Identity API endpoint."},{"line_number":155,"context_line":"#  Defaults to $::os_service_default."},{"line_number":156,"context_line":"#"},{"line_number":157,"context_line":"# [*auth_version*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_e5e8ea7e","line":154,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"#  Defaults to $::os_service_default."},{"line_number":156,"context_line":"#"},{"line_number":157,"context_line":"# [*auth_version*]"},{"line_number":158,"context_line":"#  (optional)API version of the admin Identity API endpoint."},{"line_number":159,"context_line":"#  Defaults to $::os_service_default."},{"line_number":160,"context_line":"#"},{"line_number":161,"context_line":"# [*cache*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_c5eb2e77","line":158,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"#  Defaults to $::os_service_default."},{"line_number":160,"context_line":"#"},{"line_number":161,"context_line":"# [*cache*]"},{"line_number":162,"context_line":"#  (optional)Env key for the swift cache."},{"line_number":163,"context_line":"#  Defaults to $::os_service_default."},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# [*cafile*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_25031244","line":162,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"#  Defaults to $::os_service_default."},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# [*cafile*]"},{"line_number":166,"context_line":"#  (optional)A PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":167,"context_line":"#  connections."},{"line_number":168,"context_line":"#  Defaults to $::os_service_default."},{"line_number":169,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_05fed637","line":166,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"#  Defaults to $::os_service_default."},{"line_number":173,"context_line":"#"},{"line_number":174,"context_line":"# [*check_revocations_for_cached*]"},{"line_number":175,"context_line":"#  (optional) If true, the revocation list will be checked for cached tokens."},{"line_number":176,"context_line":"#  This requires that PKI tokens are configured on the identity server."},{"line_number":177,"context_line":"#  Defaults to $::os_service_default."},{"line_number":178,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_65fd1a3a","line":175,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":192,"context_line":"#  Defaults to $::os_service_default."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*hash_algorithms*]"},{"line_number":195,"context_line":"#  (optional)Hash algorithms to use for hashing PKI tokens. This may be a"},{"line_number":196,"context_line":"#  single algorithm or multiple. The algorithms are those supported by Python"},{"line_number":197,"context_line":"#  standard hashlib.new(). The hashes will be tried in the order given, so put"},{"line_number":198,"context_line":"#  the preferred one first for performance. The result of the first hash will"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_45f8de49","line":195,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"#  Defaults to $::os_service_default."},{"line_number":243,"context_line":"#"},{"line_number":244,"context_line":"# [*memcache_pool_unused_timeout*]"},{"line_number":245,"context_line":"#  (optional)Number of seconds a connection to memcached is held unused in the"},{"line_number":246,"context_line":"#  pool before it is closed."},{"line_number":247,"context_line":"#  Defaults to $::os_service_default."},{"line_number":248,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_a59542e5","line":245,"updated":"2016-06-22 21:26:23.000000000","message":"and here","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c198e1a211ef96397ee758d95fb27134337710e0","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  include ::keystone::deps"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"  if $auth_plugin {"},{"line_number":352,"context_line":"    warning(\u0027auth_plugin parameter is deprecated. Use auth_type parameter.\u0027)"},{"line_number":353,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_8598061d","line":350,"updated":"2016-06-22 21:26:23.000000000","message":"Do these options no longer have any effect and there for should be skipped or should we leave them in for backwards compatibility for people who currently use them?","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"10b8ef8639887f79534364f98168ec70d3ed3c45","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  include ::keystone::deps"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"  if $auth_plugin {"},{"line_number":352,"context_line":"    warning(\u0027auth_plugin parameter is deprecated. Use auth_type parameter.\u0027)"},{"line_number":353,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_ab26b3b7","line":350,"in_reply_to":"3aaa91ec_8598061d","updated":"2016-06-22 22:00:27.000000000","message":"In one of my commits (in this patch) some parameters have: pick($new, $old) but I have made it only for few parameters like key -\u003e keyfile, cert -\u003e certfile, etc.\nI can add deprecated parameters to the config file + warning message.\n\nCan it be like this?","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5ba35e2b980b4016d2a03673a5d4141736e4b087","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  include ::keystone::deps"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"  if $auth_plugin {"},{"line_number":352,"context_line":"    warning(\u0027auth_plugin parameter is deprecated. Use auth_type parameter.\u0027)"},{"line_number":353,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_2b21234e","line":350,"in_reply_to":"3aaa91ec_ab26b3b7","updated":"2016-06-22 22:09:05.000000000","message":"Well the problem with pick is that you\u0027ve got $::os_service_default which won\u0027t work with pick. Unless it causes a problem to have both specified it might be better for the ones that you dropped to just continue to set them with a warning","commit_id":"73cdfaacbb56e5d6c28e0cba2c419a3a065c5a13"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2d377c68c0fb743b62351f1b214c60378e2080c1","unresolved":false,"context_lines":[{"line_number":296,"context_line":"#"},{"line_number":297,"context_line":"# \u003d\u003d\u003d Deprecated:"},{"line_number":298,"context_line":"#"},{"line_number":299,"context_line":"# [*user_id*]"},{"line_number":300,"context_line":"# [*user_domain_id*]"},{"line_number":301,"context_line":"# [*project_id*]"},{"line_number":302,"context_line":"# [*project_domain_id*]"},{"line_number":303,"context_line":"# [*domain_id*]"},{"line_number":304,"context_line":"# [*domain_name*]"},{"line_number":305,"context_line":"# [*default_domain_name*]"},{"line_number":306,"context_line":"# [*default_domain_id*]"},{"line_number":307,"context_line":"# [*trust_id*]"},{"line_number":308,"context_line":"# [*auth_plugin*]"},{"line_number":309,"context_line":"# [*cacert*]"},{"line_number":310,"context_line":"# [*cert*]"},{"line_number":311,"context_line":"# [*key*]"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"#"},{"line_number":314,"context_line":"define keystone::resource::authtoken("}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_d7b28405","line":311,"range":{"start_line":299,"start_character":2,"end_line":311,"end_character":9},"updated":"2016-06-23 19:45:05.000000000","message":"i\u0027ll add the description","commit_id":"943bcb79e982f2f3e3113fc0b668f3a0a5ef9750"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e806b03c94e04a6235e85d736cb09db1cc3301af","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  if $key {"},{"line_number":415,"context_line":"    warning(\u0027key parameter is deprecated. Use keyfile parameter.\u0027)"},{"line_number":416,"context_line":"  }"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"  if is_service_default($project_name) and is_service_default($project_id) and"},{"line_number":419,"context_line":"  is_service_default($domain_name) and is_service_default($domain_id) {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_d410c25b","line":416,"updated":"2016-06-23 19:35:13.000000000","message":"this class it not used anywhere, why deprecating the params?","commit_id":"943bcb79e982f2f3e3113fc0b668f3a0a5ef9750"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2d377c68c0fb743b62351f1b214c60378e2080c1","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  if $key {"},{"line_number":415,"context_line":"    warning(\u0027key parameter is deprecated. Use keyfile parameter.\u0027)"},{"line_number":416,"context_line":"  }"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"  if is_service_default($project_name) and is_service_default($project_id) and"},{"line_number":419,"context_line":"  is_service_default($domain_name) and is_service_default($domain_id) {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_b729b839","line":416,"in_reply_to":"3aaa91ec_d410c25b","updated":"2016-06-23 19:45:05.000000000","message":"I\u0027ll update this tonight and also fix tests, next patch i\u0027ll just let all parameters from documentation and what we need","commit_id":"943bcb79e982f2f3e3113fc0b668f3a0a5ef9750"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f44750ec9747c76fcb99a5c0d2a7bf1f555e783e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"#"},{"line_number":245,"context_line":"# \u003d\u003d\u003d Deprecated:"},{"line_number":246,"context_line":"#"},{"line_number":247,"context_line":"# [*domain_name*]"},{"line_number":248,"context_line":"# [*default_domain_name*]"},{"line_number":249,"context_line":"# [*default_domain_id*]"},{"line_number":250,"context_line":"#"},{"line_number":251,"context_line":"define keystone::resource::authtoken("}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_34db9f7d","line":248,"range":{"start_line":247,"start_character":0,"end_line":248,"end_character":25},"updated":"2016-06-27 09:55:46.000000000","message":"deprecated and not deprecated in same time? :)","commit_id":"b929c2de30f83f4005956443caa463f1b9c99c62"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"f5ddcacb4a38273cd91bb049bb911237e9b8db22","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# \u003d\u003d Parameters:"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*name*]"},{"line_number":45,"context_line":"#   (Required) The name of the resource corresponding to the config file."},{"line_number":46,"context_line":"#   For example, keystone::resource::authtoken { \u0027glance_api_config\u0027: ... }"},{"line_number":47,"context_line":"#   Where \u0027glance_api_config\u0027 is the name of the resource used to manage"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_f8a7934d","line":44,"updated":"2016-06-30 09:03:11.000000000","message":"To remove.","commit_id":"2e94eb3a4b32eeb28d7a7653695aa2c8f0e24452"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"75a7221dc7789d03b383eeb2aa108acfaef54e8a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# \u003d\u003d Parameters:"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*name*]"},{"line_number":45,"context_line":"#   (Required) The name of the resource corresponding to the config file."},{"line_number":46,"context_line":"#   For example, keystone::resource::authtoken { \u0027glance_api_config\u0027: ... }"},{"line_number":47,"context_line":"#   Where \u0027glance_api_config\u0027 is the name of the resource used to manage"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_fcd47ce9","line":44,"in_reply_to":"3aaa91ec_3ea8d88b","updated":"2016-06-30 22:13:32.000000000","message":"ok","commit_id":"2e94eb3a4b32eeb28d7a7653695aa2c8f0e24452"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"721228ac01999a14bc46db21c302698e2328abb2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# \u003d\u003d Parameters:"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*name*]"},{"line_number":45,"context_line":"#   (Required) The name of the resource corresponding to the config file."},{"line_number":46,"context_line":"#   For example, keystone::resource::authtoken { \u0027glance_api_config\u0027: ... }"},{"line_number":47,"context_line":"#   Where \u0027glance_api_config\u0027 is the name of the resource used to manage"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_3ea8d88b","line":44,"in_reply_to":"3aaa91ec_f8a7934d","updated":"2016-06-30 13:19:26.000000000","message":"You can\u0027t remove this and please don\u0027t put to os_service_default.","commit_id":"2e94eb3a4b32eeb28d7a7653695aa2c8f0e24452"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"f5ddcacb4a38273cd91bb049bb911237e9b8db22","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  $user_and_domain_array \u003d split($username, \u0027::\u0027)"},{"line_number":274,"context_line":"  $real_username \u003d $user_and_domain_array[0]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  # NOTE(danpawlik) This condition should be changed. I make it so, because I"},{"line_number":277,"context_line":"  # don\u0027t have any idea how to fix unit tests that this condition"},{"line_number":278,"context_line":"  # will be passed."},{"line_number":279,"context_line":"  if !is_service_default($user_domain_name) {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_5846a77b","line":276,"updated":"2016-06-30 09:03:11.000000000","message":"I need some solution for this condition (unit tests need also to be fixed).","commit_id":"2e94eb3a4b32eeb28d7a7653695aa2c8f0e24452"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"75a7221dc7789d03b383eeb2aa108acfaef54e8a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  $user_and_domain_array \u003d split($username, \u0027::\u0027)"},{"line_number":274,"context_line":"  $real_username \u003d $user_and_domain_array[0]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  # NOTE(danpawlik) This condition should be changed. I make it so, because I"},{"line_number":277,"context_line":"  # don\u0027t have any idea how to fix unit tests that this condition"},{"line_number":278,"context_line":"  # will be passed."},{"line_number":279,"context_line":"  if !is_service_default($user_domain_name) {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_7c0d2c8e","line":276,"in_reply_to":"3aaa91ec_5846a77b","updated":"2016-06-30 22:13:32.000000000","message":"This comment should be:  NOTE(danpawlik) This condition should be changed. I make it so, because I don\u0027t have any idea how to pass unit tests.","commit_id":"2e94eb3a4b32eeb28d7a7653695aa2c8f0e24452"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"f5ddcacb4a38273cd91bb049bb911237e9b8db22","unresolved":false,"context_lines":[{"line_number":285,"context_line":"  $project_and_domain_array \u003d split($project_name, \u0027::\u0027)"},{"line_number":286,"context_line":"  $real_project_name \u003d $project_and_domain_array[0]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"  # NOTE(danpawlik) The same situation as above."},{"line_number":289,"context_line":"  if !is_service_default($project_domain_name) {"},{"line_number":290,"context_line":"    $real_project_domain_name \u003d pick($project_domain_name, $project_and_domain_array[1])"},{"line_number":291,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_f855d31d","line":288,"updated":"2016-06-30 09:03:11.000000000","message":"As above","commit_id":"2e94eb3a4b32eeb28d7a7653695aa2c8f0e24452"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"25b9ebf9af9ada77a677425dc076afab99c6685f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*user_domain_name*]"},{"line_number":54,"context_line":"#   (Optional) Name of domain for $username"},{"line_number":55,"context_line":"#   Defaults to $::os_service_default,"},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*project_name*]"},{"line_number":58,"context_line":"#   (Optional) Service project name;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_4a75adf7","line":55,"updated":"2016-07-04 13:27:05.000000000","message":"nit: remove comma","commit_id":"2e0910f53b1c5b9ab1dfd1c5991416d17d52389f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"25b9ebf9af9ada77a677425dc076afab99c6685f","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"  # NOTE(danpawlik) The condition is not needed if we change project_name"},{"line_number":261,"context_line":"  # to required parameter."},{"line_number":262,"context_line":"  if is_service_default($project_name) {"},{"line_number":263,"context_line":"    fail(\u0027Must specify project project_name, for a project scoped token.\u0027)"},{"line_number":264,"context_line":"  }"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_eab61989","line":262,"updated":"2016-07-04 13:27:05.000000000","message":"nit: probably we could make it required","commit_id":"2e0910f53b1c5b9ab1dfd1c5991416d17d52389f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"25b9ebf9af9ada77a677425dc076afab99c6685f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    validate_bool($memcache_use_advanced_pool)"},{"line_number":276,"context_line":"  }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"  if !is_service_default($memcache_security_strategy) and ($memcache_security_strategy !\u003d \u0027MAC\u0027 and $memcache_security_strategy !\u003d \u0027ENCRYPT\u0027) {"},{"line_number":279,"context_line":"    fail(\u0027memcache_security_strategy can be set only to MAC or ENCRYPT\u0027)"},{"line_number":280,"context_line":"  }"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_6a822996","line":278,"updated":"2016-07-04 13:27:05.000000000","message":"if ! ($memcache_security_strategy in [ $::os_service_default, \u0027MAC\u0027, \u0027ENCRYPT\u0027 ]) { fail(...) }","commit_id":"2e0910f53b1c5b9ab1dfd1c5991416d17d52389f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"25b9ebf9af9ada77a677425dc076afab99c6685f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    \u0027keystone_authtoken/auth_type\u0027                      \u003d\u003e {\u0027value\u0027 \u003d\u003e $auth_type},"},{"line_number":294,"context_line":"    \u0027keystone_authtoken/auth_version\u0027                   \u003d\u003e {\u0027value\u0027 \u003d\u003e $auth_version},"},{"line_number":295,"context_line":"    \u0027keystone_authtoken/cache\u0027                          \u003d\u003e {\u0027value\u0027 \u003d\u003e $cache},"},{"line_number":296,"context_line":"# Both are use for pki when i talked to Adam, should we remove this since pki"},{"line_number":297,"context_line":"# is deprecated?"},{"line_number":298,"context_line":"    \u0027keystone_authtoken/cafile\u0027                         \u003d\u003e {\u0027value\u0027 \u003d\u003e $cafile},"},{"line_number":299,"context_line":"    \u0027keystone_authtoken/certfile\u0027                       \u003d\u003e {\u0027value\u0027 \u003d\u003e $certfile},"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_7504ca14","line":296,"updated":"2016-07-04 13:27:05.000000000","message":"used","commit_id":"2e0910f53b1c5b9ab1dfd1c5991416d17d52389f"}]}