)]}'
{"manifests/init.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"440ad5d63337cab55fd721c1f17de63502bbb744","unresolved":false,"context_lines":[{"line_number":711,"context_line":"  if $manage_policyrcd {"},{"line_number":712,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":713,"context_line":"      # Keystone doesn\u0027t have service script in UCA for xenial"},{"line_number":714,"context_line":"      $services \u003d [\u0027apache2\u0027]"},{"line_number":715,"context_line":"    } else {"},{"line_number":716,"context_line":"      $services \u003d [\u0027keystone\u0027, \u0027apache2\u0027]"},{"line_number":717,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_d824e90f","line":714,"updated":"2016-06-15 17:27:33.000000000","message":"probably shouldn\u0027t be hard-codes and used from params class","commit_id":"f7a615a279e2b43e6d97f9d0a7ca463e5edfedea"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"077ca3f1ada915fec9f51aa742d02012a9a858c6","unresolved":false,"context_lines":[{"line_number":687,"context_line":""},{"line_number":688,"context_line":"  include ::keystone::deps"},{"line_number":689,"context_line":"  include ::keystone::logging"},{"line_number":690,"context_line":"  include ::apache::params"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"  if $service_provider {"},{"line_number":693,"context_line":"    warning(\u0027service_provider is deprecated, does nothing and will be removed in a future release, use a Puppet resource collector if you want to modify the service provider.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_efd280d0","line":690,"updated":"2016-06-16 16:40:52.000000000","message":"it would have been great to include is only if httpd is used. So in the conditional.","commit_id":"fb9d04608631bba172db766ab7e156c99dde56dc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"077ca3f1ada915fec9f51aa742d02012a9a858c6","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    warning(\u0027Version string /v2.0/ should not be included in keystone::public_endpoint\u0027)"},{"line_number":710,"context_line":"  }"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"  if $manage_policyrcd {"},{"line_number":713,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":714,"context_line":"      # Keystone doesn\u0027t have service script in UCA for xenial"},{"line_number":715,"context_line":"      $services \u003d [$::apache::params::service_name]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_6fdfb0d6","line":712,"updated":"2016-06-16 16:40:52.000000000","message":"if you apply my previous comment, you\u0027ll have to move it after the conditional.","commit_id":"fb9d04608631bba172db766ab7e156c99dde56dc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"077ca3f1ada915fec9f51aa742d02012a9a858c6","unresolved":false,"context_lines":[{"line_number":965,"context_line":"    warning(\u0027Execution of db_sync does not depend on $enabled anymore. Please use sync_db instead.\u0027)"},{"line_number":966,"context_line":"  }"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"  if !(($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0)) {"},{"line_number":969,"context_line":"    if $service_name \u003d\u003d $::keystone::params::service_name {"},{"line_number":970,"context_line":"      $service_name_real \u003d $::keystone::params::service_name"},{"line_number":971,"context_line":"      if $validate_service {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_8f05bc15","line":968,"updated":"2016-06-16 16:40:52.000000000","message":"so this logic means that if you deploy Keystone on Ubuntu 16.04 LTS without httpd, we\u0027ll use $service_name_real.\n\nWhy not doing this logic for all operatingsystems and in a later patch?","commit_id":"fb9d04608631bba172db766ab7e156c99dde56dc"}]}