)]}'
{"manifests/resource/authtoken.pp":[{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5ec860d156b98c543f6714c763ce64dac2ff448e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  } elsif !is_service_default($default_domain_name) {"},{"line_number":182,"context_line":"    $real_user_domain_name \u003d pick($user_and_domain_array[1], $default_domain_name)"},{"line_number":183,"context_line":"  } else {"},{"line_number":184,"context_line":"    $real_user_domain_name \u003d pick($user_domain_name, $user_and_domain_array[1], $default_domain_name)"},{"line_number":185,"context_line":"  }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  $project_and_domain_array \u003d split($project_name, \u0027::\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_dc3bb99a","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":101},"updated":"2016-06-17 22:37:07.000000000","message":"This line (184) and line 178 are identical.\nPls change this condition.","commit_id":"67997f8893b9993759e01837196216f9f680ae15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e46bd48e66e916dcb9febdc7f605ceca135e898","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  } elsif !is_service_default($default_domain_name) {"},{"line_number":182,"context_line":"    $real_user_domain_name \u003d pick($user_and_domain_array[1], $default_domain_name)"},{"line_number":183,"context_line":"  } else {"},{"line_number":184,"context_line":"    $real_user_domain_name \u003d pick($user_domain_name, $user_and_domain_array[1], $default_domain_name)"},{"line_number":185,"context_line":"  }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  $project_and_domain_array \u003d split($project_name, \u0027::\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a9d85d2_a5c46940","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":101},"in_reply_to":"5a9d85d2_4c4b322c","updated":"2016-06-20 02:50:34.000000000","message":"Done","commit_id":"67997f8893b9993759e01837196216f9f680ae15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2e7ffec507921a198ae3809d723c07464b8c89cf","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  } elsif !is_service_default($default_domain_name) {"},{"line_number":182,"context_line":"    $real_user_domain_name \u003d pick($user_and_domain_array[1], $default_domain_name)"},{"line_number":183,"context_line":"  } else {"},{"line_number":184,"context_line":"    $real_user_domain_name \u003d pick($user_domain_name, $user_and_domain_array[1], $default_domain_name)"},{"line_number":185,"context_line":"  }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  $project_and_domain_array \u003d split($project_name, \u0027::\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_e257e7fe","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":101},"in_reply_to":"7aa08908_dc3bb99a","updated":"2016-06-18 03:56:47.000000000","message":"Hi Daniel, \n\nI don`t see any problem with this condition here,\nbefore we had $user_domain_name and $default_domain_name as undef, since we are using $::os_service_default now they have a value and the pick get the first element that is not undef and this will end up as \u0027\u003cSERVICE DEFAULT\u003e\u0027 and we only want this when the user don\u0027t specify those parameters","commit_id":"67997f8893b9993759e01837196216f9f680ae15"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"65ae1ab95c67071ba2544e6fb15487034b240028","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  } elsif !is_service_default($default_domain_name) {"},{"line_number":182,"context_line":"    $real_user_domain_name \u003d pick($user_and_domain_array[1], $default_domain_name)"},{"line_number":183,"context_line":"  } else {"},{"line_number":184,"context_line":"    $real_user_domain_name \u003d pick($user_domain_name, $user_and_domain_array[1], $default_domain_name)"},{"line_number":185,"context_line":"  }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  $project_and_domain_array \u003d split($project_name, \u0027::\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a9d85d2_4c4b322c","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":101},"in_reply_to":"7aa08908_e257e7fe","updated":"2016-06-19 20:25:59.000000000","message":"I was thinking, that this condition you can improve by removing first \"if\":\ne.g.\n  if !is_service_default($user_domain_name) {\n    $real_user_domain_name \u003d pick($user_domain_name,$user_and_domain_array[1])\n  } elsif !is_service_default($default_domain_name) {\n    $real_user_domain_name \u003d pick($user_and_domain_array[1], $default_domain_name)\n  } else {\n    $real_user_domain_name \u003d pick($user_domain_name, $user_and_domain_array[1], $default_domain_name)\n  }","commit_id":"67997f8893b9993759e01837196216f9f680ae15"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5ec860d156b98c543f6714c763ce64dac2ff448e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  } elsif !is_service_default($default_domain_name) {"},{"line_number":196,"context_line":"    $real_project_domain_name \u003d pick($project_and_domain_array[1], $default_domain_name)"},{"line_number":197,"context_line":"  } else {"},{"line_number":198,"context_line":"    $real_project_domain_name \u003d pick($project_domain_name, $project_and_domain_array[1], $default_domain_name)"},{"line_number":199,"context_line":"  }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  $real_user_domain_id \u003d pick($user_domain_id,$default_domain_id)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_bc686d89","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":110},"updated":"2016-06-17 22:37:07.000000000","message":"198 and 192 - as above.","commit_id":"67997f8893b9993759e01837196216f9f680ae15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e46bd48e66e916dcb9febdc7f605ceca135e898","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  } elsif !is_service_default($default_domain_name) {"},{"line_number":196,"context_line":"    $real_project_domain_name \u003d pick($project_and_domain_array[1], $default_domain_name)"},{"line_number":197,"context_line":"  } else {"},{"line_number":198,"context_line":"    $real_project_domain_name \u003d pick($project_domain_name, $project_and_domain_array[1], $default_domain_name)"},{"line_number":199,"context_line":"  }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  $real_user_domain_id \u003d pick($user_domain_id,$default_domain_id)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a9d85d2_c5e1b5d2","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":110},"in_reply_to":"7aa08908_bc686d89","updated":"2016-06-20 02:50:34.000000000","message":"Done","commit_id":"67997f8893b9993759e01837196216f9f680ae15"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c5dcce7863d2b5f700eae09e5c68fc0b4c18d368","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#   the glance api configuration. string;"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*username*]"},{"line_number":53,"context_line":"#   (Required) The name of the service user;"},{"line_number":54,"context_line":"#   string;"},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*password*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_0fbbd373","line":53,"updated":"2016-06-20 09:06:17.000000000","message":"lines could be merged","commit_id":"086beeac2aff1d551cd97dba5f609b96b46e8978"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c5dcce7863d2b5f700eae09e5c68fc0b4c18d368","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*auth_url*]"},{"line_number":61,"context_line":"#   (Required) The URL to use for authentication."},{"line_number":62,"context_line":"#   string;"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*auth_plugin*]"},{"line_number":65,"context_line":"#   (Optional) The plugin to use for authentication."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_6fb0978c","line":62,"updated":"2016-06-20 09:06:17.000000000","message":"same here","commit_id":"086beeac2aff1d551cd97dba5f609b96b46e8978"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c5dcce7863d2b5f700eae09e5c68fc0b4c18d368","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*auth_plugin*]"},{"line_number":65,"context_line":"#   (Optional) The plugin to use for authentication."},{"line_number":66,"context_line":"#   string; Defaults to \u0027password\u0027"},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*user_id*]"},{"line_number":69,"context_line":"#   (Optional) The ID of the service user;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_8f7ea3ac","line":66,"updated":"2016-06-20 09:06:17.000000000","message":"(Optional) The plugin to use for authentication. string;\nDefaults to \u0027password\u0027","commit_id":"086beeac2aff1d551cd97dba5f609b96b46e8978"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c5dcce7863d2b5f700eae09e5c68fc0b4c18d368","unresolved":false,"context_lines":[{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":"# [*project_name*]"},{"line_number":81,"context_line":"#   (Optional) Service project name;"},{"line_number":82,"context_line":"#   string; Defaults to $::os_service_default"},{"line_number":83,"context_line":"#"},{"line_number":84,"context_line":"# [*project_id*]"},{"line_number":85,"context_line":"#   (Optional) Service project ID;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_4f74bbce","line":82,"updated":"2016-06-20 09:06:17.000000000","message":"(Optional) Service project name; string;\nDefaults to $::os_service_default","commit_id":"086beeac2aff1d551cd97dba5f609b96b46e8978"}],"releasenotes/notes/authtoken-os_service_default-eb8809222b21e05a.yaml":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c5dcce7863d2b5f700eae09e5c68fc0b4c18d368","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - update undef parameters in authtoken.pp to use "},{"line_number":4,"context_line":"    $::os_service_default"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a9d85d2_efbbe773","line":3,"updated":"2016-06-20 09:06:17.000000000","message":"please remove whitespace or merge 3 and 4 lines","commit_id":"086beeac2aff1d551cd97dba5f609b96b46e8978"}]}