)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"156ff7d5dd5a6d1989299f9c8eb289b4b28341d5","unresolved":false,"context_lines":[{"line_number":714,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027apache2\u0027 |\u003e -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      policy_rcd { \u0027apache2\u0027: set_code \u003d\u003e \u0027101\u0027 }"},{"line_number":718,"context_line":"    } else {"},{"line_number":719,"context_line":"      policy_rcd { [\u0027keystone\u0027, \u0027apache2\u0027]: set_code \u003d\u003e \u0027101\u0027 }"},{"line_number":720,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a9d85d2_284ca4c6","line":717,"updated":"2016-06-20 20:59:15.000000000","message":"Does this need to be an ensure resource to allow for apache2 being also defined in like puppet-nova?  Also I know this is kinda off topic now, but seems kinda odd to be adding this exclusion in puppet-keystone init rather than where we actually pull in the apache class?","commit_id":"9987f1184776fc83ec3c1a5536a4126c6db60ca9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"952229d0815051c9a82d44f8d6c70ec6fab9363b","unresolved":false,"context_lines":[{"line_number":714,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027apache2\u0027 |\u003e -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      policy_rcd { \u0027apache2\u0027: set_code \u003d\u003e \u0027101\u0027 }"},{"line_number":718,"context_line":"    } else {"},{"line_number":719,"context_line":"      policy_rcd { [\u0027keystone\u0027, \u0027apache2\u0027]: set_code \u003d\u003e \u0027101\u0027 }"},{"line_number":720,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a9d85d2_98e874e4","line":717,"in_reply_to":"5a9d85d2_284ca4c6","updated":"2016-06-21 08:53:46.000000000","message":"1) \u003e Does this need to be an ensure resource to allow for apache2 being also defined in like puppet-nova?\n\nOk, will do, but not necessary.\n\n2) \u003e seems kinda odd to be adding this exclusion in puppet-keystone init rather than where we actually pull in the apache class\n\nWell, we already have entry point for managing policy_rcd in init.pp class with related flag. Do we need to add it to wsgi/apache.pp class to?\n\nFor now, i can add also check here - if $service_name \u003d\u003d \u0027httpd\u0027 then add policy for apache. But we want to drop eventlet anyway.","commit_id":"9987f1184776fc83ec3c1a5536a4126c6db60ca9"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"dd247c49cee6c04953b88e5964f0fed361901212","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027keystone\u0027 |\u003e -\u003e Package[\u0027keystone\u0027]"},{"line_number":714,"context_line":"    Policy_rcd[\u0027apache2\u0027] -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      policy_rcd { \u0027apache2\u0027:"},{"line_number":718,"context_line":"        ensure   \u003d\u003e present,"},{"line_number":719,"context_line":"        set_code \u003d\u003e \u0027101\u0027,"},{"line_number":720,"context_line":"      }"},{"line_number":721,"context_line":"    } else {"},{"line_number":722,"context_line":"      policy_rcd { [\u0027keystone\u0027, \u0027apache2\u0027]:"},{"line_number":723,"context_line":"        ensure   \u003d\u003e present"},{"line_number":724,"context_line":"        set_code \u003d\u003e \u0027101\u0027"},{"line_number":725,"context_line":"      }"},{"line_number":726,"context_line":"    }"},{"line_number":727,"context_line":"  }"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"  include ::keystone::db"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a9d85d2_73accb35","line":726,"range":{"start_line":716,"start_character":0,"end_line":726,"end_character":5},"updated":"2016-06-21 09:18:16.000000000","message":"$prcd_services \u003d ($::operatingsystem \u003d\u003d ..... ) ? {\n  true \u003d\u003e \u0027apache2\u0027,\n  default \u003d\u003e [\u0027keystone\u0027, \u0027apache2\u0027]\n}\n\npolicy_rcd { $prcd_services:\n  ensure   \u003d\u003e present\n  set_code \u003d\u003e \u0027101\u0027\n}","commit_id":"d8aad74035ccda022b254e14cbb0c07f742003ef"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9aaf4fdee20becf86cea63c86bb6f6d3086ccbcc","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027keystone\u0027 |\u003e -\u003e Package[\u0027keystone\u0027]"},{"line_number":714,"context_line":"    Policy_rcd[\u0027apache2\u0027] -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      policy_rcd { \u0027apache2\u0027:"},{"line_number":718,"context_line":"        ensure   \u003d\u003e present,"},{"line_number":719,"context_line":"        set_code \u003d\u003e \u0027101\u0027,"},{"line_number":720,"context_line":"      }"},{"line_number":721,"context_line":"    } else {"},{"line_number":722,"context_line":"      policy_rcd { [\u0027keystone\u0027, \u0027apache2\u0027]:"},{"line_number":723,"context_line":"        ensure   \u003d\u003e present"},{"line_number":724,"context_line":"        set_code \u003d\u003e \u0027101\u0027"},{"line_number":725,"context_line":"      }"},{"line_number":726,"context_line":"    }"},{"line_number":727,"context_line":"  }"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"  include ::keystone::db"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a9d85d2_9950750c","line":726,"range":{"start_line":716,"start_character":0,"end_line":726,"end_character":5},"in_reply_to":"5a9d85d2_73accb35","updated":"2016-06-21 09:56:07.000000000","message":"Done","commit_id":"d8aad74035ccda022b254e14cbb0c07f742003ef"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5959a8361ed5e611342019edac905384e6b4715e","unresolved":false,"context_lines":[{"line_number":718,"context_line":"    } else {"},{"line_number":719,"context_line":"      $policy_services \u003d [\u0027keystone\u0027, \u0027apache2\u0027]"},{"line_number":720,"context_line":"    }"},{"line_number":721,"context_line":"    policy_rcd { $policy_services:"},{"line_number":722,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":723,"context_line":"      set_code \u003d\u003e \u0027101\u0027,"},{"line_number":724,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a9d85d2_158d537b","line":721,"updated":"2016-06-21 16:01:39.000000000","message":"ensure_resource?","commit_id":"a9fa4d4bfb1178ef1351d8b6c918462002c1b472"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2bcd2d7a6c9773bddeee8c2ecffffbda2b869ea8","unresolved":false,"context_lines":[{"line_number":711,"context_line":"  if $manage_policyrcd {"},{"line_number":712,"context_line":"    # openstacklib policy_rcd only affects debian based systems."},{"line_number":713,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027keystone\u0027 |\u003e -\u003e Package[\u0027keystone\u0027]"},{"line_number":714,"context_line":"    Policy_rcd[\u0027apache2\u0027] -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      $policy_services \u003d \u0027apache2\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_8f93594f","line":714,"updated":"2016-06-21 16:26:31.000000000","message":"It would probably be safer here to use a collector so if apache isn\u0027t defined, we won\u0027t error. For example someone enables manage_policyrcd on centos.","commit_id":"33e051ca75ce2d718f5a334721004d2456506a73"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a2a88948b2c7f6a9edf37613a3299c9baf00da54","unresolved":false,"context_lines":[{"line_number":711,"context_line":"  if $manage_policyrcd {"},{"line_number":712,"context_line":"    # openstacklib policy_rcd only affects debian based systems."},{"line_number":713,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027keystone\u0027 |\u003e -\u003e Package[\u0027keystone\u0027]"},{"line_number":714,"context_line":"    Policy_rcd[\u0027apache2\u0027] -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      $policy_services \u003d \u0027apache2\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_8fe199d3","line":714,"in_reply_to":"3aaa91ec_8f93594f","updated":"2016-06-21 16:28:00.000000000","message":"Well, in our case we always have apache.","commit_id":"33e051ca75ce2d718f5a334721004d2456506a73"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"56fa86d9f071212e7b6372791412126d719c01fb","unresolved":false,"context_lines":[{"line_number":711,"context_line":"  if $manage_policyrcd {"},{"line_number":712,"context_line":"    # openstacklib policy_rcd only affects debian based systems."},{"line_number":713,"context_line":"    Policy_rcd \u003c| title \u003d\u003d \u0027keystone\u0027 |\u003e -\u003e Package[\u0027keystone\u0027]"},{"line_number":714,"context_line":"    Policy_rcd[\u0027apache2\u0027] -\u003e Package[\u0027httpd\u0027]"},{"line_number":715,"context_line":"    # we don\u0027t have keystone service anymore starting from Newton"},{"line_number":716,"context_line":"    if ($::operatingsystem \u003d\u003d \u0027Ubuntu\u0027) and (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":717,"context_line":"      $policy_services \u003d \u0027apache2\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_922a5c7d","line":714,"in_reply_to":"3aaa91ec_8fe199d3","updated":"2016-06-21 16:35:16.000000000","message":"ah true","commit_id":"33e051ca75ce2d718f5a334721004d2456506a73"}]}